69850 2011-10-11 10:44:59 -0700 Enable out-of-thread compositing in WebKit compositor API 2011-10-18 15:36:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 piman webkit-unassigned enne jamesr nduca webkit.review.bot oldest_to_newest 481724 0 piman 2011-10-11 10:44:59 -0700 Enable out-of-thread compositing in WebKit compositor API 481725 1 110536 piman 2011-10-11 10:45:21 -0700 Created attachment 110536 Patch 481727 2 piman 2011-10-11 10:46:25 -0700 It needs https://bugs.webkit.org/show_bug.cgi?id=69048 to work correctly if the client thread is not the main thread. 482628 3 piman 2011-10-12 12:55:30 -0700 Ping ? 482667 4 jamesr 2011-10-12 13:46:36 -0700 I don't understand this patch. Why would users of the WK API want to use the threaded path? 482694 5 nduca 2011-10-12 14:16:10 -0700 (In reply to comment #4) > I don't understand this patch. Why would users of the WK API want to use the threaded path? This makes sense to me. This reduces complexity --- either thread is in use or its not. Rather than "oh, its in use by the renderer compositor but if you're talking about the browser compositor, well thats a different story." Sorry, but ew. 482714 6 piman 2011-10-12 14:28:00 -0700 We're already seeing the browser UI thread limited by painting in certain conditions. We could gain parallelism by moving the rendering to a separate thread. We'll also want to be able to drive animations from the compositor thread. Also, it works. So why not? 482755 7 jamesr 2011-10-12 14:51:32 -0700 All valid points - I just wasn't really sure what the goal was. I agree being able to do animations, etc will be pretty sweet once we get that rolling. 482762 8 110536 jamesr 2011-10-12 14:54:51 -0700 Comment on attachment 110536 Patch R=me but there's still something a bit amiss here. Right now there are 2 ways to indicate threading support via the WK API - you can set the appropriate CCSettings value and call WebCompositor::setThread(). If you do the former but not the latter you hit ASSERT()s and crash today. I think we want to just make the latter be the control - if you pass a thread to WebCompositor::setThread() then the compositor uses it, otherwise it runs single-threaded. Does that sound like a good plan going forward, Nat? To be clear I think this patch is fine to land - we can clean things up later. 483575 9 110536 webkit.review.bot 2011-10-13 15:45:32 -0700 Comment on attachment 110536 Patch Rejecting attachment 110536 from commit-queue. piman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 486274 10 nduca 2011-10-18 13:31:28 -0700 Yeah, I like it. Saying back what I heard, its "do away with the CCSettings field for threaded compositing and derive this entirely from whether CCThread was handed a thread." 486357 11 110536 webkit.review.bot 2011-10-18 15:36:46 -0700 Comment on attachment 110536 Patch Clearing flags on attachment: 110536 Committed r97795: <http://trac.webkit.org/changeset/97795> 486358 12 webkit.review.bot 2011-10-18 15:36:51 -0700 All reviewed patches have been landed. Closing bug. 110536 2011-10-11 10:45:21 -0700 2011-10-18 15:36:46 -0700 Patch bug-69850-20111011104520.patch text/plain 2048 piman U3VidmVyc2lvbiBSZXZpc2lvbjogOTcxMDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ODZlOTdmYzE3ZjE2YWRjNWNkOGYyNTVjNzk2NDhjYTZkNzY4YTQxYS4uMTFlZTFhNDk4M2ViNWU4 NmEyN2JlNjAyOTdiNjFkMTI5MmM5MTk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0xMC0xMSAgQW50b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgRW5hYmxlIG91dC1vZi10aHJlYWQgY29tcG9zaXRpbmcgaW4gV2Vi S2l0IGNvbXBvc2l0b3IgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02OTg1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJMYXllclRyZWVWaWV3OjpTZXR0aW5nczo6b3BlcmF0b3IgQ0NTZXR0aW5ncyk6CisgICAgICAg IChXZWJLaXQ6OldlYkxheWVyVHJlZVZpZXc6OmNvbXBvc2l0ZSk6CisKIDIwMTEtMTAtMTAgIFNl cmdleSBHbGF6dW5vdiAgPHNlcmcuZ2xhenVub3ZAZ21haWwuY29tPgogCiAgICAgICAgIFNjcmlw dENvbnRyb2xsZXI6OmV4ZWN1dGVJZkphdmFTY3JpcHRVUkwgZ2V0cyBjb25mdXNlZCBieSBzeW5j aHJvbm91cyBmcmFtZSBsb2FkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViTGF5ZXJUcmVlVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJM YXllclRyZWVWaWV3LmNwcAppbmRleCAwN2RiMWFlMGI4OTkyMDZiNGJiZDYzNzI4MzNhZTViNjBi NjAwY2FmLi5hM2ZlMzA3YjFhYmUxYjI1ZTk0NjNiNWZmMmQ0MTE2YmRlYjNhMjQ1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNwcApAQCAtMzgs OSArMzgsNyBAQCBXZWJMYXllclRyZWVWaWV3OjpTZXR0aW5nczo6b3BlcmF0b3IgQ0NTZXR0aW5n cygpIGNvbnN0CiAgICAgQ0NTZXR0aW5ncyBzZXR0aW5nczsKICAgICBzZXR0aW5ncy5hY2NlbGVy YXRlUGFpbnRpbmcgPSBhY2NlbGVyYXRlUGFpbnRpbmc7CiAgICAgc2V0dGluZ3MuY29tcG9zaXRl T2Zmc2NyZWVuID0gY29tcG9zaXRlT2Zmc2NyZWVuOwotCi0gICAgLy8gRklYTUU6IGNvbXBvc2l0 b3IgdGhyZWFkIGlzbid0IHN1cHBvcnRlZCBjdXJyZW50bHkuCi0gICAgc2V0dGluZ3MuZW5hYmxl Q29tcG9zaXRvclRocmVhZCA9IGZhbHNlOworICAgIHNldHRpbmdzLmVuYWJsZUNvbXBvc2l0b3JU aHJlYWQgPSBlbmFibGVDb21wb3NpdG9yVGhyZWFkOwogCiAgICAgLy8gRklYTUU6IHNob3dGUFND b3VudGVyIC8gc2hvd1BsYXRmb3JtTGF5ZXJUcmVlIGFyZW4ndCBzdXBwb3J0ZWQgY3VycmVudGx5 LgogICAgIHNldHRpbmdzLnNob3dGUFNDb3VudGVyID0gZmFsc2U7CkBAIC03MCw5ICs2OCwxMCBA QCBib29sIFdlYkxheWVyVHJlZVZpZXc6OmVxdWFscyhjb25zdCBXZWJMYXllclRyZWVWaWV3JiBu KSBjb25zdAogCiB2b2lkIFdlYkxheWVyVHJlZVZpZXc6OmNvbXBvc2l0ZSgpCiB7Ci0jaWYgIVVT RShUSFJFQURFRF9DT01QT1NJVElORykKLSAgICBtX3ByaXZhdGUtPmNvbXBvc2l0ZSgpOwotI2Vu ZGlmCisgICAgaWYgKG1fcHJpdmF0ZS0+c2V0dGluZ3MoKS5lbmFibGVDb21wb3NpdG9yVGhyZWFk KQorICAgICAgICBtX3ByaXZhdGUtPnNldE5lZWRzQ29tbWl0VGhlblJlZHJhdygpOworICAgIGVs c2UKKyAgICAgICAgbV9wcml2YXRlLT5jb21wb3NpdGUoKTsKIH0KIAogdm9pZCBXZWJMYXllclRy ZWVWaWV3OjpzZXRWaWV3cG9ydFNpemUoY29uc3QgV2ViU2l6ZSYgdmlld3BvcnRTaXplKQo=