6985 2006-01-31 16:34:40 -0800 cyclic __proto__ values aren't caught 2007-05-09 04:00:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ PC Linux RESOLVED FIXED data:text/html,%3C%21DOCTYPE%20html%3E%0A%3Cscript%3E%0Avar%20o1%20%3D%20%7B%20p1%3A%201%20%7D%3B%0Avar%20o2%20%3D%20%7B%20p2%3A%202%20%7D%3B%0Ao2.__proto__%20%3D%20o1%3B%0Avar%20o3%20%3D%20%7B%20p3%3A%203%20%7D%3B%0Ao3.__proto__%20%3D%20o2%3B%0Ao1.__proto__%20%3D%20o3%3B%20//%20this%20hangs%0A%3C/script%3E P1 Critical --- 13638 1 ian eric gavin.sharp ian oldest_to_newest 30822 0 ian 2006-01-31 16:34:40 -0800 STEPS TO REPRODUCE Run the following JS: var o1 = { p1: 1 }; var o2 = { p2: 2 }; o2.__proto__ = o1; var o3 = { p3: 3 }; o3.__proto__ = o2; o1.__proto__ = o3; // this hangs ACTUAL RESULTS Hang. EXPECTED RESULTS It should raise an exception "cyclic __proto__ value". 10457 1 14427 eric 2007-05-09 03:27:53 -0700 Created attachment 14427 the fix 10458 2 eric 2007-05-09 03:32:48 -0700 As a reproducible crasher, this should be a P1. 10461 3 eric 2007-05-09 03:59:16 -0700 Fixed in r21332. 10462 4 14427 mjs 2007-05-09 04:00:37 -0700 Comment on attachment 14427 the fix r=me 14427 2007-05-09 03:27:53 -0700 2007-05-09 04:00:37 -0700 the fix foo.patch text/plain 2752 eric SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMzMwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDUtMDkgIEVyaWMgU2Vp ZGVsICA8ZXJpY0Blc2VpZGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY5ODUKKyAgICAgICAgQ3ljbGljIF9fcHJvdG9fXyB2YWx1ZXMgY2F1c2UgV2ViS2l0 IHRvIGhhbmcKKworICAgICAgICAqIGtqcy9vYmplY3QuY3BwOgorICAgICAgICAoS0pTOjpKU09i amVjdDo6cHV0KTogZG8gYSBjeWNsZSBjaGVjayBiZWZvcmUgc2V0dGluZyBfX3Byb3RvX18KKwog MjAwNy0wNS0wOCAgS2ltbW8gS2lubnVuZW4gIDxraW1tb2tAaWtpLmZpPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IGRhcmluLiAgTGFuZGVkIGJ5IGVzZWlkZWwuCkluZGV4OiBKYXZhU2NyaXB0Q29y ZS9ranMvb2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvb2JqZWN0 LmNwcAkocmV2aXNpb24gMjEzMzApCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvb2JqZWN0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjExLDYgKzIxMSwxMyBAQCB2b2lkIEpTT2JqZWN0OjpwdXQoRXhl Y1N0YXRlKiBleGVjLCBjb25zCiAKICAgLy8gbm9uLXN0YW5kYXJkIG5ldHNjYXBlIGV4dGVuc2lv bgogICBpZiAocHJvcGVydHlOYW1lID09IGV4ZWMtPnByb3BlcnR5TmFtZXMoKS51bmRlcnNjb3Jl UHJvdG8pIHsKKyAgICBKU09iamVjdCogcHJvdG8gPSB2YWx1ZS0+Z2V0T2JqZWN0KCk7CisgICAg d2hpbGUgKHByb3RvKSB7CisgICAgICBpZiAocHJvdG8gPT0gdGhpcykKKyAgICAgICAgdGhyb3dF cnJvcihleGVjLCBHZW5lcmFsRXJyb3IsICJjeWNsaWMgX19wcm90b19fIHZhbHVlIik7CisgICAg ICBwcm90byA9IHByb3RvLT5wcm90b3R5cGUoKSA/IHByb3RvLT5wcm90b3R5cGUoKS0+Z2V0T2Jq ZWN0KCkgOiAwOworICAgIH0KKyAgICAKICAgICBzZXRQcm90b3R5cGUodmFsdWUpOwogICAgIHJl dHVybjsKICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjEzMzApCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0wNS0wOSAgRXJpYyBT ZWlkZWwgIDxlcmljQGVzZWlkZWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Njk4NQorICAgICAgICBDeWNsaWMgX19wcm90b19fIHZhbHVlcyBjYXVzZSB3ZWJr aXQgdG8gaGFuZworCisgICAgICAgICogZmFzdC9qcy9jeWNsaWMtcHJvdG90eXBlcy1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvY3ljbGljLXByb3RvdHlwZXMuaHRtbDog QWRkZWQuCisKIDIwMDctMDUtMDggIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvanMvY3ljbGljLXByb3RvdHlwZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvanMvY3ljbGljLXByb3RvdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9jeWNsaWMtcHJvdG90eXBlcy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEwOiBF cnJvcjogY3ljbGljIF9fcHJvdG9fXyB2YWx1ZQorUEFTUyAoZGlkIG5vdCBoYW5nKQpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9qcy9jeWNsaWMtcHJvdG90eXBlcy5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvY3ljbGljLXByb3RvdHlwZXMuaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvanMvY3ljbGljLXByb3RvdHlwZXMuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwxMiBAQAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwordmFyIG8xID0g eyBwMTogMSB9OwordmFyIG8yID0geyBwMjogMiB9OworbzIuX19wcm90b19fID0gbzE7Cit2YXIg bzMgPSB7IHAzOiAzIH07CitvMy5fX3Byb3RvX18gPSBvMjsKK28xLl9fcHJvdG9fXyA9IG8zOyAv LyB0aGlzIGhhbmdzCis8L3NjcmlwdD4KK1BBU1MgKGRpZCBub3QgaGFuZykKXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCg==