69823 2011-10-11 01:51:45 -0700 [GTK] Add can_go_back/forward methods to WebKit2 GTK+ API 2011-10-21 01:16:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 69343 1 cgarcia webkit-unassigned gustavo pnormand xan.lopez oldest_to_newest 481513 0 cgarcia 2011-10-11 01:51:45 -0700 Add webkit_web_view_can_go_back() and webkit_web_view_can_go_forward() 481514 1 110486 cgarcia 2011-10-11 01:53:46 -0700 Created attachment 110486 Patch 481519 2 cgarcia 2011-10-11 02:06:25 -0700 I'll add unit tests for these methods to the backforwardlist test once bug #69343 is fixed. 488171 3 110486 mrobinson 2011-10-20 22:57:47 -0700 Comment on attachment 110486 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110486&action=review This looks good to me! > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:303 > + * Returns: %TRUE if able to move back, %FALSE otherwise. , -> or (based on our previous conversation) > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:333 > + * Returns: %TRUE if able to move forward, %FALSE otherwise. Ditto. 488249 4 cgarcia 2011-10-21 01:16:16 -0700 Committed r98081: <http://trac.webkit.org/changeset/98081> 110486 2011-10-11 01:53:46 -0700 2011-10-20 22:57:47 -0700 Patch wk2-can-go-back-forward.diff text/plain 3317 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmM2JmZmJjLi5jNzhmZThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTAtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCBjYW5fZ29fYmFjay9mb3J3YXJkIG1ldGhvZHMgdG8gV2Vi S2l0MiBHVEsrIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk4MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Vi a2l0X3dlYl92aWV3X2dvX2JhY2spOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2Nhbl9nb19i YWNrKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19nb19mb3J3YXJkKToKKyAgICAgICAgKHdl YmtpdF93ZWJfdmlld19jYW5fZ29fZm9yd2FyZCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlldy5oOgorCiAyMDExLTEwLTEwICBOYXRlIENoYXBpbiAgPGphcGhldEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXNlIGEgQ2FjaGVkSW1hZ2VDbGllbnQgaW5zdGVhZCBv ZiBDYWNoZWRSZXNvdXJjZUNsaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCA1ZmVmNTA4Li5jMmU5ODA0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApA QCAtMjkxLDggKzI5MSwyMiBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19nb19iYWNrKFdlYktpdFdl YlZpZXcqIHdlYlZpZXcpCiB7CiAgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJ RVcod2ViVmlldykpOwogCi0gICAgV2ViUGFnZVByb3h5KiBwYWdlID0gd2Via2l0V2ViVmlld0Jh c2VHZXRQYWdlKFdFQktJVF9XRUJfVklFV19CQVNFKHdlYlZpZXcpKTsKLSAgICBXS1BhZ2VHb0Jh Y2sodG9BUEkocGFnZSkpOworICAgIFdLUGFnZUdvQmFjayh0b0FQSSh3ZWJraXRXZWJWaWV3QmFz ZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2ViVmlldykpKSk7Cit9CisKKy8qKgorICog d2Via2l0X3dlYl92aWV3X2Nhbl9nb19iYWNrOgorICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJW aWV3CisgKgorICogRGV0ZXJtaW5lcyB3aGV0aGVyIEB3ZWJfdmlldyBoYXMgYSBwcmV2aW91cyBo aXN0b3J5IGl0ZW0uCisgKgorICogUmV0dXJuczogJVRSVUUgaWYgYWJsZSB0byBtb3ZlIGJhY2ss ICVGQUxTRSBvdGhlcndpc2UuCisgKi8KK2dib29sZWFuIHdlYmtpdF93ZWJfdmlld19jYW5fZ29f YmFjayhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQoreworICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWls KFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgRkFMU0UpOworCisgICAgcmV0dXJuIFdLUGFn ZUNhbkdvQmFjayh0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVX X0JBU0Uod2ViVmlldykpKSk7CiB9CiAKIC8qKgpAQCAtMzA3LDYgKzMyMSwyMCBAQCB2b2lkIHdl YmtpdF93ZWJfdmlld19nb19mb3J3YXJkKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7CiAgICAg Z19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOwogCi0gICAgV2Vi UGFnZVByb3h5KiBwYWdlID0gd2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdFQktJVF9XRUJfVklF V19CQVNFKHdlYlZpZXcpKTsKLSAgICBXS1BhZ2VHb0ZvcndhcmQodG9BUEkocGFnZSkpOworICAg IFdLUGFnZUdvRm9yd2FyZCh0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dF Ql9WSUVXX0JBU0Uod2ViVmlldykpKSk7Cit9CisKKy8qKgorICogd2Via2l0X3dlYl92aWV3X2Nh bl9nb19mb3J3YXJkOgorICogQHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3CisgKgorICogRGV0 ZXJtaW5lcyB3aGV0aGVyIEB3ZWJfdmlldyBoYXMgYSBuZXh0IGhpc3RvcnkgaXRlbS4KKyAqCisg KiBSZXR1cm5zOiAlVFJVRSBpZiBhYmxlIHRvIG1vdmUgZm9yd2FyZCwgJUZBTFNFIG90aGVyd2lz ZS4KKyAqLworZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2Nhbl9nb19mb3J3YXJkKFdlYktpdFdl YlZpZXcqIHdlYlZpZXcpCit7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dF Ql9WSUVXKHdlYlZpZXcpLCBGQUxTRSk7CisKKyAgICByZXR1cm4gV0tQYWdlQ2FuR29Gb3J3YXJk KHRvQVBJKHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRSh3ZWJW aWV3KSkpKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXcuaAppbmRleCAwMWQ5NzJlLi41OTk3YTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5oCkBAIC0xMDQsOSArMTA0LDE1IEBA IHdlYmtpdF93ZWJfdmlld19yZWxvYWRfYnlwYXNzX2NhY2hlIChXZWJLaXRXZWJWaWV3ICAgICAg ICAgKndlYl92aWV3KTsKIFdFQktJVF9BUEkgdm9pZAogd2Via2l0X3dlYl92aWV3X2dvX2JhY2sg ICAgICAgICAgICAgKFdlYktpdFdlYlZpZXcgICAgICAgICAqd2ViX3ZpZXcpOwogCitXRUJLSVRf QVBJIGdib29sZWFuCit3ZWJraXRfd2ViX3ZpZXdfY2FuX2dvX2JhY2sgICAgICAgICAoV2ViS2l0 V2ViVmlldyAgICAgICAgICp3ZWJfdmlldyk7CisKIFdFQktJVF9BUEkgdm9pZAogd2Via2l0X3dl Yl92aWV3X2dvX2ZvcndhcmQgICAgICAgICAgKFdlYktpdFdlYlZpZXcgICAgICAgICAqd2ViX3Zp ZXcpOwogCitXRUJLSVRfQVBJIGdib29sZWFuCit3ZWJraXRfd2ViX3ZpZXdfY2FuX2dvX2Zvcndh cmQgICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgICp3ZWJfdmlldyk7CisKIEdfRU5EX0RFQ0xT CiAKICNlbmRpZgo=