69817 2011-10-10 22:39:45 -0700 [skia] Implement Path.currentPoint for skia 2011-10-12 16:58:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benwells benwells jamesr kbr reed senorblanco webkit.review.bot oldest_to_newest 481454 0 benwells 2011-10-10 22:39:45 -0700 [skia] Implement Path.currentPoint for skia 481455 1 110476 benwells 2011-10-10 22:43:55 -0700 Created attachment 110476 Patch 481468 2 benwells 2011-10-10 23:22:29 -0700 I implemented this function while working another bug but it wasn't needed. It might come in handy in future for someone else or prevent cross platform problems creeping in if this function is used in future by developers of other ports. It is used in the canvas code to work out if a line, arc etc. will be zero length and therefore whether it should be added or not. The zero length segments get filtered out later so there should be no impact of the change. Tests all pass with the change. 481572 3 reed 2011-10-11 04:57:39 -0700 Looks fine. You could also just call skiaPath.getLastPt(), but you'll still need the check for count==0. The next rev. of getLastPt returns a bool which indicates if the lastPt is valid. This would simplify the impl as well when that lands... 481718 4 110476 kbr 2011-10-11 10:35:22 -0700 Comment on attachment 110476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110476&action=review Looks fine but there's a problem with the ChangeLog that will cause it to be rejected from the commit queue. > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) You'll need to remove this OOPS line. Also ideally there would be a test case. 482190 5 110633 benwells 2011-10-11 21:26:08 -0700 Created attachment 110633 Patch 482191 6 benwells 2011-10-11 21:27:22 -0700 I'm not sure how to test this with a new layout test. Any advice? 482617 7 kbr 2011-10-12 12:41:35 -0700 (In reply to comment #6) > I'm not sure how to test this with a new layout test. Any advice? Did you search the code base for uses of Path.currentPoint() and see if there's any way to get it called from JavaScript, for example via a series of Canvas calls? 482618 8 110633 kbr 2011-10-12 12:41:50 -0700 Comment on attachment 110633 Patch Looks fine. r=me 482788 9 benwells 2011-10-12 15:23:35 -0700 (In reply to comment #7) > (In reply to comment #6) > > I'm not sure how to test this with a new layout test. Any advice? > > Did you search the code base for uses of Path.currentPoint() and see if there's any way to get it called from JavaScript, for example via a series of Canvas calls? Yes I searched for where currentPoint is used when making the change, its not exposed anywhere with easy access like that. 482790 10 110633 webkit.review.bot 2011-10-12 15:25:59 -0700 Comment on attachment 110633 Patch Rejecting attachment 110633 from commit-queue. aboxhall@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 482858 11 110633 webkit.review.bot 2011-10-12 16:58:55 -0700 Comment on attachment 110633 Patch Clearing flags on attachment: 110633 Committed r97319: <http://trac.webkit.org/changeset/97319> 482859 12 webkit.review.bot 2011-10-12 16:58:59 -0700 All reviewed patches have been landed. Closing bug. 110476 2011-10-10 22:43:55 -0700 2011-10-11 21:26:01 -0700 Patch bug-69817-20111011164353.patch text/plain 1610 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTcwNTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1YTZlY2ZkNzY0ZDlhYjU2 OTY0NGU3ZjAyZmRkMWJhMWJmZTBjMjk0Li5kNzBmMjgyZmI1MjI4Y2ZiMjk4MDFhZjNmYmNkMjIx NDUxMzY5YzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMTAgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbc2tpYV0gSW1wbGVtZW50 IFBhdGguY3VycmVudFBvaW50IGZvciBza2lhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTgxNworCisgICAgICAgIFJlcGxhY2UgRklYTUUgd2l0aCBp bXBsZW1lbnRhdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvUGF0aFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6Y3VycmVudFBv aW50KToKKwogMjAxMS0xMC0xMCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc21hbGwgbWVtb3J5IGxlYWsgaW4gc2NyaXB0 cyBwYW5lbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvUGF0aFNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q YXRoU2tpYS5jcHAKaW5kZXggYjAzN2EwZGI3ZmEyZjdkNDUwNWFkN2ExMDE1NjgwNTk1NThjM2Yy NS4uODgzMWYwMjAxMDM5ZTYxMjY2YjUzMjZlOGU2MzNlMTJiOGY2NGRjYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAKQEAgLTc2 LDcgKzc2LDE0IEBAIGJvb2wgUGF0aDo6aGFzQ3VycmVudFBvaW50KCkgY29uc3QKIAogRmxvYXRQ b2ludCBQYXRoOjpjdXJyZW50UG9pbnQoKSBjb25zdCAKIHsKLSAgICAvLyBGSVhNRTogcmV0dXJu IGN1cnJlbnQgcG9pbnQgb2Ygc3VicGF0aC4KKyAgICBpZiAobV9wYXRoLT5jb3VudFBvaW50cygp ID4gMCkgeworICAgICAgICBTa1BvaW50IHNrUmVzdWx0ID0gbV9wYXRoLT5nZXRQb2ludChtX3Bh dGgtPmNvdW50UG9pbnRzKCkgLSAxKTsKKyAgICAgICAgRmxvYXRQb2ludCByZXN1bHQ7CisgICAg ICAgIHJlc3VsdC5zZXRYKFNrU2NhbGFyVG9GbG9hdChza1Jlc3VsdC5mWCkpOworICAgICAgICBy ZXN1bHQuc2V0WShTa1NjYWxhclRvRmxvYXQoc2tSZXN1bHQuZlkpKTsKKyAgICAgICAgcmV0dXJu IHJlc3VsdDsKKyAgICB9CisKICAgICBmbG9hdCBxdWlldE5hTiA9IHN0ZDo6bnVtZXJpY19saW1p dHM8ZmxvYXQ+OjpxdWlldF9OYU4oKTsKICAgICByZXR1cm4gRmxvYXRQb2ludChxdWlldE5hTiwg cXVpZXROYU4pOwogfQo= 110633 2011-10-11 21:26:08 -0700 2011-10-12 16:58:55 -0700 Patch bug-69817-20111012152606.patch text/plain 1570 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTcwNTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1YTZlY2ZkNzY0ZDlhYjU2 OTY0NGU3ZjAyZmRkMWJhMWJmZTBjMjk0Li42MTYxYmU4MTA4YTY5NmFkYTVmYzdjYTU5ZmJiZDc1 MTIxY2EwNjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTAgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbc2tpYV0gSW1wbGVtZW50 IFBhdGguY3VycmVudFBvaW50IGZvciBza2lhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTgxNworCisgICAgICAgIFJlcGxhY2UgRklYTUUgd2l0aCBp bXBsZW1lbnRhdGlvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0aFNraWEuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGF0aDo6Y3VycmVudFBvaW50KToKKwogMjAxMS0xMC0xMCAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc21h bGwgbWVtb3J5IGxlYWsgaW4gc2NyaXB0cyBwYW5lbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGF0aFNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QYXRoU2tpYS5jcHAKaW5kZXggYjAzN2EwZGI3ZmEyZjdk NDUwNWFkN2ExMDE1NjgwNTk1NThjM2YyNS4uN2M4YWVhMDcwNDA5MDU2MjBhYzE0MDcxNWQ3MTMy MjBmOTQzYTQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QYXRoU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QYXRoU2tpYS5jcHAKQEAgLTc2LDcgKzc2LDE1IEBAIGJvb2wgUGF0aDo6aGFzQ3VycmVu dFBvaW50KCkgY29uc3QKIAogRmxvYXRQb2ludCBQYXRoOjpjdXJyZW50UG9pbnQoKSBjb25zdCAK IHsKLSAgICAvLyBGSVhNRTogcmV0dXJuIGN1cnJlbnQgcG9pbnQgb2Ygc3VicGF0aC4KKyAgICBp ZiAobV9wYXRoLT5jb3VudFBvaW50cygpID4gMCkgeworICAgICAgICBTa1BvaW50IHNrUmVzdWx0 OworICAgICAgICBtX3BhdGgtPmdldExhc3RQdCgmc2tSZXN1bHQpOworICAgICAgICBGbG9hdFBv aW50IHJlc3VsdDsKKyAgICAgICAgcmVzdWx0LnNldFgoU2tTY2FsYXJUb0Zsb2F0KHNrUmVzdWx0 LmZYKSk7CisgICAgICAgIHJlc3VsdC5zZXRZKFNrU2NhbGFyVG9GbG9hdChza1Jlc3VsdC5mWSkp OworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0KKwogICAgIGZsb2F0IHF1aWV0TmFOID0g c3RkOjpudW1lcmljX2xpbWl0czxmbG9hdD46OnF1aWV0X05hTigpOwogICAgIHJldHVybiBGbG9h dFBvaW50KHF1aWV0TmFOLCBxdWlldE5hTik7CiB9Cg==