69807 2011-10-10 18:06:33 -0700 Add getOwnPropertySlot to MethodTable 2011-10-25 11:50:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69810 67690 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 481364 0 mhahnenberg 2011-10-10 18:06:33 -0700 We now need to add both versions of getOwnPropertySlot to the MethodTable in ClassInfo in preparation from removing the virtual version of getOwnPropertySlot. 489513 1 112228 mhahnenberg 2011-10-24 12:06:12 -0700 Created attachment 112228 Patch 489776 2 112228 oliver 2011-10-24 16:53:13 -0700 Comment on attachment 112228 Patch r=me 489870 3 112228 webkit.review.bot 2011-10-24 21:18:02 -0700 Comment on attachment 112228 Patch Rejecting attachment 112228 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10210108 490194 4 mhahnenberg 2011-10-25 11:50:58 -0700 Committed r98367: <http://trac.webkit.org/changeset/98367> 112228 2011-10-24 12:06:12 -0700 2011-10-24 21:18:02 -0700 Patch bug-69807-20111024120611.patch text/plain 5950 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyNjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNm ZWE0M2IxMTcyM2FmM2U2ZjE2ZjVkNjFhNmIyYTA2MjM3YTZlZTcuLjEyMWU1NzJiMGUwYzA3MjE2 YTU0NjljOTg1MDI1MTNlYjI3OTNjMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE3IEBACiAyMDExLTEwLTI0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CiAKKyAgICAgICAgQWRkIGdldE93blByb3BlcnR5U2xvdCB0byBNZXRob2RUYWJsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk4MDcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEphdmFTY3Jp cHRDb3JlLmV4cDoKKyAgICAgICAgKiBydW50aW1lL0NsYXNzSW5mby5oOiBBZGRlZCBib3RoIHZl cnNpb25zIG9mIGdldE93blByb3BlcnR5U2xvdCB0byB0aGUgTWV0aG9kVGFibGUuCisgICAgICAg ICogcnVudGltZS9KU0NlbGwuaDogQ2hhbmdlZCBnZXRPd25Qcm9wZXJ0eVNsb3QgdG8gYmUgcHJv dGVjdGVkIHNvIG90aGVyIGNsYXNzZXMgY2FuIAorICAgICAgICByZWZlcmVuY2UgaXQgaW4gdGhl aXIgTWV0aG9kVGFibGVzLgorCisyMDExLTEwLTI0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVu YmVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgUmVuYW1lIHN0YXRpYyBnZXRPd25Qcm9wZXJ0eVNs b3QgdG8gZ2V0T3duUHJvcGVydHlTbG90QnlJbmRleAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyNzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGFmMTRiNWVjOGI5 NGU4YzBhZDY1NDMwYzQ3Y2VkOTM4NWI1YWYyOGYuLmEwNmRhYzMzNDFiZDdiMWZkMzUyOTFmM2E0 OWJiNTJjM2Q0MDU2MGYgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMS0xMC0yNCAg TWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBn ZXRPd25Qcm9wZXJ0eVNsb3QgdG8gTWV0aG9kVGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAg KiBicmlkZ2UvcnVudGltZV9tZXRob2QuaDogQ2hhbmdlZCBnZXRPd25Qcm9wZXJ0eVNsb3QgdG8g YmUgcHJvdGVjdGVkIHNvIAorICAgICAgICBzdWJjbGFzc2VzIGNhbiByZWZlcmVuY2UgaXQgaW4g dGhlaXIgTWV0aG9kVGFibGVzLgorCisyMDExLTEwLTI0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFo bmVuYmVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgUmVuYW1lIHN0YXRpYyBnZXRPd25Qcm9wZXJ0 eVNsb3QgdG8gZ2V0T3duUHJvcGVydHlTbG90QnlJbmRleAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAyNzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS5leHAKaW5kZXggY2UyMTYxNzhhOWEzNjAxZjFhYjdiYTZjMTk2NjMyODNk YmU1NmUzZC4uNjIxZmI5NzUxODgzZWQxNjU3ZGE2MjM0OGFhZjRiY2JkYmYxOWQ2YSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCkBAIC0xMTcsNiArMTE3LDggQEAg X19aTjNKU0MxMHRocm93RXJyb3JFUE5TXzlFeGVjU3RhdGVFTlNfN0pTVmFsdWVFCiBfX1pOM0pT QzEwdGhyb3dFcnJvckVQTlNfOUV4ZWNTdGF0ZUVQTlNfOEpTT2JqZWN0RQogX19aTjNKU0MxMUpT Qnl0ZUFycmF5MTBwdXRCeUluZGV4RVBOU182SlNDZWxsRVBOU185RXhlY1N0YXRlRWpOU183SlNW YWx1ZUUKIF9fWk4zSlNDMTFKU0J5dGVBcnJheTE1Y3JlYXRlU3RydWN0dXJlRVJOU18xMkpTR2xv YmFsRGF0YUVQTlNfMTRKU0dsb2JhbE9iamVjdEVOU183SlNWYWx1ZUVQS05TXzlDbGFzc0luZm9F CitfX1pOM0pTQzExSlNCeXRlQXJyYXkxOGdldE93blByb3BlcnR5U2xvdEVQTlNfNkpTQ2VsbEVQ TlNfOUV4ZWNTdGF0ZUVSS05TXzEwSWRlbnRpZmllckVSTlNfMTJQcm9wZXJ0eVNsb3RFCitfX1pO M0pTQzExSlNCeXRlQXJyYXkyNWdldE93blByb3BlcnR5U2xvdEJ5SW5kZXhFUE5TXzZKU0NlbGxF UE5TXzlFeGVjU3RhdGVFalJOU18xMlByb3BlcnR5U2xvdEUKIF9fWk4zSlNDMTFKU0J5dGVBcnJh eTNwdXRFUE5TXzZKU0NlbGxFUE5TXzlFeGVjU3RhdGVFUktOU18xMElkZW50aWZpZXJFTlNfN0pT VmFsdWVFUk5TXzE1UHV0UHJvcGVydHlTbG90RQogX19aTjNKU0MxMUpTQnl0ZUFycmF5NnNfaW5m b0UKIF9fWk4zSlNDMTFKU0J5dGVBcnJheUMxRVBOU185RXhlY1N0YXRlRVBOU185U3RydWN0dXJl RVBOM1dURjlCeXRlQXJyYXlFCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9DbGFzc0luZm8uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NsYXNzSW5m by5oCmluZGV4IDIzMWUxNzc5MTAxNzk1ZjgxOTQxYTM4MzRjMmM2ZTU5ZWJiNWU3NjUuLmJmZmZk NzhiNTc3OTVjYTM3YTU1NzljOTU3NmVhZjIwZWRjYjFkZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0NsYXNzSW5mby5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NsYXNzSW5mby5oCkBAIC01Miw2ICs1MiwxMiBAQCBuYW1lc3BhY2UgSlND IHsKIAogICAgICAgICB0eXBlZGVmIGJvb2wgKCpEZWxldGVQcm9wZXJ0eUJ5SW5kZXhGdW5jdGlv blB0cikoSlNDZWxsKiwgRXhlY1N0YXRlKiwgdW5zaWduZWQpOwogICAgICAgICBEZWxldGVQcm9w ZXJ0eUJ5SW5kZXhGdW5jdGlvblB0ciBkZWxldGVQcm9wZXJ0eUJ5SW5kZXg7CisKKyAgICAgICAg dHlwZWRlZiBib29sICgqR2V0T3duUHJvcGVydHlTbG90RnVuY3Rpb25QdHIpKEpTQ2VsbCosIEV4 ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBQcm9wZXJ0eVNsb3QmKTsKKyAgICAgICAgR2V0 T3duUHJvcGVydHlTbG90RnVuY3Rpb25QdHIgZ2V0T3duUHJvcGVydHlTbG90OworCisgICAgICAg IHR5cGVkZWYgYm9vbCAoKkdldE93blByb3BlcnR5U2xvdEJ5SW5kZXhGdW5jdGlvblB0cikoSlND ZWxsKiwgRXhlY1N0YXRlKiwgdW5zaWduZWQsIFByb3BlcnR5U2xvdCYpOworICAgICAgICBHZXRP d25Qcm9wZXJ0eVNsb3RCeUluZGV4RnVuY3Rpb25QdHIgZ2V0T3duUHJvcGVydHlTbG90QnlJbmRl eDsKICAgICB9OwogCiAjZGVmaW5lIENSRUFURV9NRVRIT0RfVEFCTEUoQ2xhc3NOYW1lKSB7IFwK QEAgLTYyLDYgKzY4LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICZDbGFzc05hbWU6OnB1 dEJ5SW5kZXgsIFwKICAgICAgICAgJkNsYXNzTmFtZTo6ZGVsZXRlUHJvcGVydHksIFwKICAgICAg ICAgJkNsYXNzTmFtZTo6ZGVsZXRlUHJvcGVydHlCeUluZGV4LCBcCisgICAgICAgICZDbGFzc05h bWU6OmdldE93blByb3BlcnR5U2xvdCwgXAorICAgICAgICAmQ2xhc3NOYW1lOjpnZXRPd25Qcm9w ZXJ0eVNsb3RCeUluZGV4LCBcCiAgICAgfSwgXAogICAgIHNpemVvZihDbGFzc05hbWUpCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgKaW5kZXggZWEwZWRkYzlhYmQyMzAzOGQz MjY0ZDg1NTM3YmU3MGQ4ZTg2ZDA3Mi4uY2UxZDI2OGEyN2NjZDFhM2JhOWE4NWEzOGNlODBhNTk2 MWMwMjY5NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxs LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgKQEAgLTEzMiwx MyArMTMyLDEzIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB2b2lkIGZpbmlzaENyZWF0aW9u KEpTR2xvYmFsRGF0YSYpOwogICAgICAgICB2b2lkIGZpbmlzaENyZWF0aW9uKEpTR2xvYmFsRGF0 YSYsIFN0cnVjdHVyZSosIENyZWF0aW5nRWFybHlDZWxsVGFnKTsKIAotICAgIHByaXZhdGU6CiAg ICAgICAgIC8vIEJhc2UgaW1wbGVtZW50YXRpb247IGZvciBub24tb2JqZWN0IGNsYXNzZXMgaW1w bGVtZW50cyBnZXRQcm9wZXJ0eVNsb3QuCiAgICAgICAgIHZpcnR1YWwgYm9vbCBnZXRPd25Qcm9w ZXJ0eVNsb3RWaXJ0dWFsKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFt ZSwgUHJvcGVydHlTbG90Jik7CiAgICAgICAgIHN0YXRpYyBib29sIGdldE93blByb3BlcnR5U2xv dChKU0NlbGwqLCBFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIFBy b3BlcnR5U2xvdCYpOwogICAgICAgICB2aXJ0dWFsIGJvb2wgZ2V0T3duUHJvcGVydHlTbG90Vmly dHVhbChFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUsIFByb3BlcnR5U2xvdCYpOwog ICAgICAgICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4KEpTQ2VsbCosIEV4 ZWNTdGF0ZSosIHVuc2lnbmVkIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90Jik7CiAgICAgICAg IAorICAgIHByaXZhdGU6CiAgICAgICAgIFdyaXRlQmFycmllcjxTdHJ1Y3R1cmU+IG1fc3RydWN0 dXJlOwogICAgIH07CiAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcnVu dGltZV9tZXRob2QuaCBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9ydW50aW1lX21ldGhvZC5oCmlu ZGV4IDA4ODVkYmU2ZTFkMWRhNjQ3Yjk5M2FiNGNmZTVjZGEyMjMwNTg3YTYuLjI1ZDJmN2U1Mjgx Y2E5M2QwMTIwOThjYTcxNGQ1NDAyMDIyOWI1MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JyaWRnZS9ydW50aW1lX21ldGhvZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9ydW50 aW1lX21ldGhvZC5oCkBAIC02NCwxMCArNjQsMTEgQEAgcHJvdGVjdGVkOgogICAgIHN0YXRpYyBj b25zdCB1bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IE92ZXJyaWRlc0dldE93blByb3BlcnR5U2xv dCB8IEludGVybmFsRnVuY3Rpb246OlN0cnVjdHVyZUZsYWdzOwogICAgIHN0YXRpYyBDYWxsVHlw ZSBnZXRDYWxsRGF0YShKU0NlbGwqLCBDYWxsRGF0YSYpOwogCi1wcml2YXRlOgotICAgIHN0YXRp YyBKU1ZhbHVlIGxlbmd0aEdldHRlcihFeGVjU3RhdGUqLCBKU1ZhbHVlLCBjb25zdCBJZGVudGlm aWVyJik7CiAgICAgdmlydHVhbCBib29sIGdldE93blByb3BlcnR5U2xvdFZpcnR1YWwoRXhlY1N0 YXRlKiwgY29uc3QgSWRlbnRpZmllciYsIFByb3BlcnR5U2xvdCYpOwogICAgIHN0YXRpYyBib29s IGdldE93blByb3BlcnR5U2xvdChKU0NlbGwqLCBFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVy JiwgUHJvcGVydHlTbG90Jik7CisKK3ByaXZhdGU6CisgICAgc3RhdGljIEpTVmFsdWUgbGVuZ3Ro R2V0dGVyKEV4ZWNTdGF0ZSosIEpTVmFsdWUsIGNvbnN0IElkZW50aWZpZXImKTsKICAgICB2aXJ0 dWFsIGJvb2wgZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50 aWZpZXImLCBQcm9wZXJ0eURlc2NyaXB0b3ImKTsKIAogICAgIE93blB0cjxCaW5kaW5nczo6TWV0 aG9kTGlzdD4gX21ldGhvZExpc3Q7Cg==