69806 2011-10-10 17:34:35 -0700 DFG JIT switch dfgConvert methods to use callOperation 2011-10-10 18:03:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned webkit.review.bot oldest_to_newest 481342 0 barraclough 2011-10-10 17:34:35 -0700 This is the last one! 481343 1 110449 barraclough 2011-10-10 17:35:35 -0700 Created attachment 110449 The patch 481346 2 webkit.review.bot 2011-10-10 17:38:43 -0700 Attachment 110449 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:91: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/dfg/DFGOperations.h:92: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 481363 3 barraclough 2011-10-10 18:03:12 -0700 Fixed in r97117 110449 2011-10-10 17:35:35 -0700 2011-10-10 17:38:09 -0700 The patch 69806.patch text/plain 7258 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcxMTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTEtMTAtMTAgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFyYWNsb3VnaEBhcHBsZS5jb20+CisK KyAgICAgICAgREZHIEpJVCBzd2l0Y2ggZGZnQ29udmVydCBtZXRob2RzIHRvIHVzZSBjYWxsT3Bl cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 OTgwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6REZHOjpjYWxsT3BlcmF0 aW9uKToKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0LmNwcDoKKyAgICAg ICAgKEpTQzo6REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpub25TcGVjdWxhdGl2ZVZhbHVlVG9OdW1i ZXIpOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvZGVHZW5lcmF0b3I6Om5vblNwZWN1bGF0aXZl VmFsdWVUb0ludDMyKToKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZUdlbmVyYXRvcjY0LmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpub25TcGVjdWxhdGl2ZVZhbHVl VG9OdW1iZXIpOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvZGVHZW5lcmF0b3I6Om5vblNwZWN1 bGF0aXZlVmFsdWVUb0ludDMyKToKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5oOgorCiAy MDExLTEwLTEwICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBzb21lIHVudXNlZCBtZXRob2RzIGZyb20gdGhlIERGRyBKSVQuCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IzMl82NC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJh dG9yMzJfNjQuY3BwCShyZXZpc2lvbiA5NzEwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ2LDEw ICszNDYsNyBAQCB2b2lkIEpJVENvZGVHZW5lcmF0b3I6Om5vblNwZWN1bGF0aXZlVmFsCiAgICAg Ly8gTmV4dCBoYW5kbGUgY2VsbHMgKCYgb3RoZXIgSlMgaW1tZWRpYXRlcykKICAgICBub25OdW1l cmljLmxpbmsoJm1faml0KTsKICAgICBzaWxlbnRTcGlsbEFsbFJlZ2lzdGVycyhyZXN1bHRUYWdH UFIsIHJlc3VsdFBheWxvYWRHUFIpOwotICAgIG1faml0LnB1c2godGFnR1BSKTsKLSAgICBtX2pp dC5wdXNoKHBheWxvYWRHUFIpOwotICAgIG1faml0LnB1c2goR1BSSW5mbzo6Y2FsbEZyYW1lUmVn aXN0ZXIpOwotICAgIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2soZGZnQ29udmVydEpTVmFs dWVUb051bWJlcik7CisgICAgY2FsbE9wZXJhdGlvbihkZmdDb252ZXJ0SlNWYWx1ZVRvTnVtYmVy LCBGUFJJbmZvOjpyZXR1cm5WYWx1ZUZQUiwgdGFnR1BSLCBwYXlsb2FkR1BSKTsKICAgICBib3hE b3VibGUoRlBSSW5mbzo6cmV0dXJuVmFsdWVGUFIsIHJlc3VsdFRhZ0dQUiwgcmVzdWx0UGF5bG9h ZEdQUiwgYXQobV9jb21waWxlSW5kZXgpLnZpcnR1YWxSZWdpc3RlcigpKTsKICAgICBzaWxlbnRG aWxsQWxsUmVnaXN0ZXJzKHJlc3VsdFRhZ0dQUiwgcmVzdWx0UGF5bG9hZEdQUik7CiAgICAgSklU Q29tcGlsZXI6Okp1bXAgaGFzQ2FsbGVkVG9OdW1iZXIgPSBtX2ppdC5qdW1wKCk7CkBAIC00MTAs MTAgKzQwNyw3IEBAIHZvaWQgSklUQ29kZUdlbmVyYXRvcjo6bm9uU3BlY3VsYXRpdmVWYWwKIAog ICAgIC8vIEZpcnN0IGhhbmRsZSBub24taW50ZWdlcnMKICAgICBzaWxlbnRTcGlsbEFsbFJlZ2lz dGVycyhyZXN1bHRHUFIpOwotICAgIG1faml0LnB1c2godGFnR1BSKTsKLSAgICBtX2ppdC5wdXNo KHBheWxvYWRHUFIpOwotICAgIG1faml0LnB1c2goR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIp OwotICAgIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2soZGZnQ29udmVydEpTVmFsdWVUb0lu dDMyKTsKKyAgICBjYWxsT3BlcmF0aW9uKGRmZ0NvbnZlcnRKU1ZhbHVlVG9JbnQzMiwgR1BSSW5m bzo6cmV0dXJuVmFsdWVHUFIsIHRhZ0dQUiwgcGF5bG9hZEdQUik7CiAgICAgbV9qaXQubW92ZShH UFJJbmZvOjpyZXR1cm5WYWx1ZUdQUiwgcmVzdWx0R1BSKTsKICAgICBzaWxlbnRGaWxsQWxsUmVn aXN0ZXJzKHJlc3VsdEdQUik7CiAgICAgSklUQ29tcGlsZXI6Okp1bXAgaGFzQ2FsbGVkVG9JbnQz MiA9IG1faml0Lmp1bXAoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklU Q29kZUdlbmVyYXRvcjY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0pJVENvZGVHZW5lcmF0b3I2NC5jcHAJKHJldmlzaW9uIDk3MTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yNjQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNTAsOSArMzUwLDcgQEAgdm9pZCBKSVRDb2RlR2VuZXJhdG9yOjpub25TcGVjdWxh dGl2ZVZhbAogICAgIC8vIE5leHQgaGFuZGxlIGNlbGxzICgmIG90aGVyIEpTIGltbWVkaWF0ZXMp CiAgICAgbm9uTnVtZXJpYy5saW5rKCZtX2ppdCk7CiAgICAgc2lsZW50U3BpbGxBbGxSZWdpc3Rl cnMoZ3ByKTsKLSAgICBtX2ppdC5tb3ZlKGpzVmFsdWVHcHIsIEdQUkluZm86OmFyZ3VtZW50R1BS MSk7Ci0gICAgbV9qaXQubW92ZShHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgR1BSSW5mbzo6 YXJndW1lbnRHUFIwKTsKLSAgICBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNrKGRmZ0NvbnZl cnRKU1ZhbHVlVG9OdW1iZXIpOworICAgIGNhbGxPcGVyYXRpb24oZGZnQ29udmVydEpTVmFsdWVU b051bWJlciwgRlBSSW5mbzo6cmV0dXJuVmFsdWVGUFIsIGpzVmFsdWVHcHIpOwogICAgIGJveERv dWJsZShGUFJJbmZvOjpyZXR1cm5WYWx1ZUZQUiwgZ3ByKTsKICAgICBzaWxlbnRGaWxsQWxsUmVn aXN0ZXJzKGdwcik7CiAgICAgSklUQ29tcGlsZXI6Okp1bXAgaGFzQ2FsbGVkVG9OdW1iZXIgPSBt X2ppdC5qdW1wKCk7CkBAIC00MTAsOSArNDA4LDcgQEAgdm9pZCBKSVRDb2RlR2VuZXJhdG9yOjpu b25TcGVjdWxhdGl2ZVZhbAogCiAgICAgLy8gRmlyc3QgaGFuZGxlIG5vbi1pbnRlZ2VycwogICAg IHNpbGVudFNwaWxsQWxsUmVnaXN0ZXJzKHJlc3VsdEdQUik7Ci0gICAgbV9qaXQubW92ZShqc1Zh bHVlR3ByLCBHUFJJbmZvOjphcmd1bWVudEdQUjEpOwotICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6 Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7Ci0gICAgYXBwZW5kQ2Fs bFdpdGhFeGNlcHRpb25DaGVjayhkZmdDb252ZXJ0SlNWYWx1ZVRvSW50MzIpOworICAgIGNhbGxP cGVyYXRpb24oZGZnQ29udmVydEpTVmFsdWVUb0ludDMyLCBHUFJJbmZvOjpyZXR1cm5WYWx1ZUdQ UiwganNWYWx1ZUdwcik7CiAgICAgbV9qaXQuemVyb0V4dGVuZDMyVG9QdHIoR1BSSW5mbzo6cmV0 dXJuVmFsdWVHUFIsIHJlc3VsdEdQUik7CiAgICAgc2lsZW50RmlsbEFsbFJlZ2lzdGVycyhyZXN1 bHRHUFIpOwogICAgIEpJVENvbXBpbGVyOjpKdW1wIGhhc0NhbGxlZFRvSW50MzIgPSBtX2ppdC5q dW1wKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5lcmF0 b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVH ZW5lcmF0b3IuaAkocmV2aXNpb24gOTcxMDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0pJVENvZGVHZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTE3OSw2ICsxMTc5LDIy IEBAIHByb3RlY3RlZDoKIAogICAgICAgICByZXR1cm4gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25D aGVjayhvcGVyYXRpb24pOwogICAgIH0KKyAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsT3BlcmF0 aW9uKFpfREZHT3BlcmF0aW9uX0VKIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFy ZzEpCisgICAgeworICAgICAgICBtX2ppdC5tb3ZlKGFyZzEsIEdQUkluZm86OmFyZ3VtZW50R1BS MSk7CisgICAgICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUklu Zm86OmFyZ3VtZW50R1BSMCk7CisKKyAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0 aW9uQ2hlY2tTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOworICAgIH0KKyAgICBKSVRDb21w aWxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uKERfREZHT3BlcmF0aW9uX0VKIG9wZXJhdGlvbiwgRlBS UmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEpCisgICAgeworICAgICAgICBtX2ppdC5tb3ZlKGFyZzEs IEdQUkluZm86OmFyZ3VtZW50R1BSMSk7CisgICAgICAgIG1faml0Lm1vdmUoR1BSSW5mbzo6Y2Fs bEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisKKyAgICAgICAgSklUQ29t cGlsZXI6OkNhbGwgY2FsbCA9IGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2sob3BlcmF0aW9u KTsKKyAgICAgICAgbV9qaXQubW92ZURvdWJsZShGUFJJbmZvOjpyZXR1cm5WYWx1ZUZQUiwgcmVz dWx0KTsKKyAgICAgICAgcmV0dXJuIGNhbGw7CisgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxs IGNhbGxPcGVyYXRpb24oRF9ERkdPcGVyYXRpb25fREQgb3BlcmF0aW9uLCBGUFJSZWcgcmVzdWx0 LCBGUFJSZWcgYXJnMSwgRlBSUmVnIGFyZzIpCiAgICAgewogICAgICAgICBzZXR1cFR3b1N0dWJB cmdzPEZQUkluZm86OmFyZ3VtZW50RlBSMCwgRlBSSW5mbzo6YXJndW1lbnRGUFIxPihhcmcxLCBh cmcyKTsKQEAgLTE0MDQsNiArMTQyMCwyNSBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIHJldHVybiBj YWxsT3BlcmF0aW9uKChWX0RGR09wZXJhdGlvbl9FUFpKKW9wZXJhdGlvbiwgYXJnMSwgYXJnMiwg YXJnM1RhZywgYXJnM1BheWxvYWQpOwogICAgIH0KIAorICAgIEpJVENvbXBpbGVyOjpDYWxsIGNh bGxPcGVyYXRpb24oWl9ERkdPcGVyYXRpb25fRUogb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0LCBH UFJSZWcgYXJnMVRhZywgR1BSUmVnIGFyZzFQYXlsb2FkKQorICAgIHsKKyAgICAgICAgbV9qaXQu cHVzaChhcmcxVGFnKTsKKyAgICAgICAgbV9qaXQucHVzaChhcmcxUGF5bG9hZCk7CisgICAgICAg IG1faml0LnB1c2goR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIpOworCisgICAgICAgIHJldHVy biBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNrU2V0UmVzdWx0KG9wZXJhdGlvbiwgcmVzdWx0 KTsKKyAgICB9CisgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihEX0RGR09wZXJh dGlvbl9FSiBvcGVyYXRpb24sIEZQUlJlZyByZXN1bHQsIEdQUlJlZyBhcmcxVGFnLCBHUFJSZWcg YXJnMVBheWxvYWQpCisgICAgeworICAgICAgICBtX2ppdC5wdXNoKGFyZzFUYWcpOworICAgICAg ICBtX2ppdC5wdXNoKGFyZzFQYXlsb2FkKTsKKyAgICAgICAgbV9qaXQucHVzaChHUFJJbmZvOjpj YWxsRnJhbWVSZWdpc3Rlcik7CisKKyAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9IGFw cGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2sob3BlcmF0aW9uKTsKKyAgICAgICAgbV9qaXQuYXNz ZW1ibGVyKCkuZnN0cGwoMCwgSklUQ29tcGlsZXI6OnN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKKyAg ICAgICAgbV9qaXQubG9hZERvdWJsZShKSVRDb21waWxlcjo6c3RhY2tQb2ludGVyUmVnaXN0ZXIs IHJlc3VsdCk7CisgICAgICAgIHJldHVybiBjYWxsOworICAgIH0KICAgICBKSVRDb21waWxlcjo6 Q2FsbCBjYWxsT3BlcmF0aW9uKERfREZHT3BlcmF0aW9uX0REIG9wZXJhdGlvbiwgRlBSUmVnIHJl c3VsdCwgRlBSUmVnIGFyZzEsIEZQUlJlZyBhcmcyKQogICAgIHsKICAgICAgICAgbV9qaXQuc3Vi UHRyKFRydXN0ZWRJbW0zMigyICogc2l6ZW9mKGRvdWJsZSkpLCBKSVRDb21waWxlcjo6c3RhY2tQ b2ludGVyUmVnaXN0ZXIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmgJKHJldmlzaW9uIDk3MTA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPcGVyYXRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTg4LDYgKzg4LDggQEAgdHlwZWRlZiB2 b2lkIERGR19PUEVSQVRJT04gKCpWX0RGR09wZXJhdAogdHlwZWRlZiB2b2lkIERGR19PUEVSQVRJ T04gKCpWX0RGR09wZXJhdGlvbl9FUFpKKShFeGVjU3RhdGUqLCB2b2lkKiwgaW50MzJfdCwgRW5j b2RlZEpTVmFsdWUpOwogdHlwZWRlZiB2b2lkIERGR19PUEVSQVRJT04gKCpWX0RGR09wZXJhdGlv bl9FQVpKKShFeGVjU3RhdGUqLCBKU0FycmF5KiwgaW50MzJfdCwgRW5jb2RlZEpTVmFsdWUpOwog dHlwZWRlZiBkb3VibGUgKCpEX0RGR09wZXJhdGlvbl9ERCkoZG91YmxlLCBkb3VibGUpOyAvLyBV c2luZyBkZWZhdWx0IGNhbGxpbmcgY29udmVudGlvbnMhCit0eXBlZGVmIGRvdWJsZSBERkdfT1BF UkFUSU9OICgqRF9ERkdPcGVyYXRpb25fRUopKEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlKTsK K3R5cGVkZWYgaW50MzJfdCBERkdfT1BFUkFUSU9OICgqWl9ERkdPcGVyYXRpb25fRUopKEV4ZWNT dGF0ZSosIEVuY29kZWRKU1ZhbHVlKTsKIHR5cGVkZWYgdm9pZCogREZHX09QRVJBVElPTiAoKlBf REZHT3BlcmF0aW9uX0UpKEV4ZWNTdGF0ZSopOwogCiAvLyBUaGVzZSByb3V0aW5lcyBhcmUgcHJv dmlkZSBjYWxsYmFja3Mgb3V0IHRvIEMrKyBpbXBsZW1lbnRhdGlvbnMgb2Ygb3BlcmF0aW9ucyB0 b28gY29tcGxleCB0byBKSVQuCg==