69788 2011-10-10 14:52:57 -0700 Improve output of run-api-tests to make time-outs more obvious 2011-10-18 16:18:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69942 1 simon.fraser simon.fraser abarth aroben eric simon.fraser oldest_to_newest 481187 0 simon.fraser 2011-10-10 14:52:57 -0700 Right now, some api tests are timing out; see http://build.webkit.org/builders/Lion%20Intel%20Release%20%28WebKit2%20Tests%29/builds/1293 However, unless you know what to look for, it's very hard to determine that this is the cause of the failures. The script output should be improved to make the failures more obvious. 482546 1 110709 simon.fraser 2011-10-12 11:17:20 -0700 Created attachment 110709 Patch 482548 2 110709 aroben 2011-10-12 11:19:16 -0700 Comment on attachment 110709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110709&action=review > Tools/Scripts/run-api-tests:133 > + for my $test (@testsTimedOut) { I think you meant if (@testsTimedOut). > Tools/Scripts/run-api-tests:214 > + if ($result) { > + push @testsFailed, $suite.".".$test; > + } > if ($timedOut) { > + push @testsTimedOut, $suite.".".$test; I think "$suite.$test" would be a little clearer. 486412 3 simon.fraser 2011-10-18 16:18:56 -0700 http://trac.webkit.org/changeset/97277 110709 2011-10-12 11:17:20 -0700 2011-10-12 11:19:16 -0700 Patch bug-69788-20111012111719.patch text/plain 2078 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogOTcyNjYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlYzNjZjg1NzU5NDI3YzhlYWMzZjEyZmMyMDJhOThjNzQ3 ZDczYjEyLi40MDY3MWVjYTFmMzZkYjQ0MDQxMjdkY2VhMzViMGNmOWUyNWQ1OTNhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTAtMTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisK KyAgICAgICAgSW1wcm92ZSBvdXRwdXQgb2YgcnVuLWFwaS10ZXN0cyB0byBtYWtlIHRpbWUtb3V0 cyBtb3JlIG9idmlvdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY5Nzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBMaXN0IHRoZSB0ZXN0cyB0aGF0IGZhaWxlZCBhbmQgdGltZWQgb3V0IGF0 IHRoZSBib3R0b20gb2YgdGhlIG91dHB1dCwKKyAgICAgICAgaWYgcnVuIHdpdGggLS12ZXJib3Nl LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tYXBpLXRlc3RzOgorICAgICAgICAocnVuQWxsVGVz dHMpOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMTEtMTAtMTIgIEtyaXN0w7NmIEtvc3p0ecOz ICA8a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIG5ldy1ydW4td2Via2l0LXRl c3RzIGRvZXMgbm90IHN1cHBvcnQgcXQtNC44IHJlc3VsdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvcnVuLWFwaS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwppbmRleCA1 N2Q3NDE4ZDYwOGU2MWU3MDI3OTJhOWU5NzQxZjk3ZmZiNDcwYmU4Li45OGU5ZmYyNDEwYWU5YTJm ODkxNDQ5MDNkNWE4MmZhNjhhODRiZmRhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1h cGktdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCkBAIC01OCw2ICs1OCw4 IEBAIG15ICR2ZXJib3NlID0gMDsKIG15ICRkdW1wID0gMDsKIG15ICRidWlsZCA9IDE7CiBteSAk YnVpbGREZWZhdWx0ID0gJGJ1aWxkID8gImJ1aWxkIiA6ICJkbyBub3QgYnVpbGQiOworbXkgQHRl c3RzRmFpbGVkOworbXkgQHRlc3RzVGltZWRPdXQ7CiAKIG15ICRwcm9ncmFtTmFtZSA9IGJhc2Vu YW1lKCQwKTsKIG15ICR1c2FnZSA9IDw8RU9GOwpAQCAtMTIwLDYgKzEyMiwyMSBAQCBzdWIgcnVu QWxsVGVzdHMoKQogICAgICAgICAgICAgJGFueUZhaWx1cmVzID0gMTsKICAgICAgICAgfQogICAg IH0KKyAgICAKKyAgICBpZiAoJHZlcmJvc2UpIHsKKyAgICAgICAgaWYgKEB0ZXN0c0ZhaWxlZCkg eworICAgICAgICAgICAgcHJpbnQgIlRlc3RzIHRoYXQgZmFpbGVkOlxuIjsKKyAgICAgICAgICAg IGZvciBteSAkdGVzdCAoQHRlc3RzRmFpbGVkKSB7CisgICAgICAgICAgICAgICAgcHJpbnQgIiAg JHRlc3RcbiI7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgZm9yIG15ICR0ZXN0 IChAdGVzdHNUaW1lZE91dCkgeworICAgICAgICAgICAgcHJpbnQgIlRlc3RzIHRoYXQgdGltZWQg b3V0OlxuIjsKKyAgICAgICAgICAgIGZvciBteSAkdGVzdCAoQHRlc3RzVGltZWRPdXQpIHsKKyAg ICAgICAgICAgICAgICBwcmludCAiICAkdGVzdFxuIjsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorICAgIH0KICAgICByZXR1cm4gJGFueUZhaWx1cmVzOwogfQogCkBAIC0xOTAsNyArMjA3LDEx IEBAIHN1YiBydW5UZXN0KCQkKQogICAgICAgICAkdGltZWRPdXQgPSAxOwogICAgIH0KIAorICAg IGlmICgkcmVzdWx0KSB7CisgICAgICAgIHB1c2ggQHRlc3RzRmFpbGVkLCAkc3VpdGUuIi4iLiR0 ZXN0OworICAgIH0KICAgICBpZiAoJHRpbWVkT3V0KSB7CisgICAgICAgIHB1c2ggQHRlc3RzVGlt ZWRPdXQsICRzdWl0ZS4iLiIuJHRlc3Q7CiAgICAgICAgIHByaW50IHBvc3NpYmx5Q29sb3JlZCgi Ym9sZCB5ZWxsb3ciLCAiVGltZW91dCIpLCAiXG4iOwogICAgIH0gZWxzaWYgKCEkdmVyYm9zZSkg ewogICAgICAgICBpZiAoJHJlc3VsdCkgewo=