69779 2011-10-10 13:36:55 -0700 media/audio-data-url.html test broken on Lion 2012-02-07 15:53:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble eric.carlson oldest_to_newest 481111 0 jer.noble 2011-10-10 13:36:55 -0700 media/audio-data-url.html test broken on Lion 481113 1 110393 jer.noble 2011-10-10 13:40:35 -0700 Created attachment 110393 Patch 481152 2 110393 darin 2011-10-10 14:16:26 -0700 Comment on attachment 110393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > + if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) { We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case. 481174 3 jer.noble 2011-10-10 14:32:30 -0700 (In reply to comment #2) > (From update of attachment 110393 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110393&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > > + if (!willUseProxy && ![[cocoaURL scheme] isEqualTo:@"data"]) { > > We should not do a case-sensitive compare of a URL scheme. So instead of iEqualTo we need something that ignores case. I'll change this to a case insensitive compare. 481230 4 110421 jer.noble 2011-10-10 15:30:36 -0700 Created attachment 110421 Patch 481354 5 110421 eric.carlson 2011-10-10 17:44:32 -0700 Comment on attachment 110421 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > + if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) { Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead? 551487 6 jer.noble 2012-02-07 15:46:45 -0800 (In reply to comment #5) > (From update of attachment 110421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285 > > + if (!willUseProxy && ![[cocoaURL scheme] compare:@"data" options:NSCaseInsensitiveSearch]) { > > Is there any reason to not use WebCore's protocolIs() or KURL's protocolIsData() instead? Nope. Will do. 551499 7 jer.noble 2012-02-07 15:53:24 -0800 Committed r107002: <http://trac.webkit.org/changeset/107002> 110393 2011-10-10 13:40:35 -0700 2011-10-10 15:30:33 -0700 Patch bug-69779-20111010134034.patch text/plain 1792 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3NDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NTVhOGY0ZjZmN2RlMjE4 NzI0ODBjMmY0ZjE2ZDIzY2FiMjY0NmZiLi5iMTI2MTM4MjQyYzcwYzUwOWQ4ZTYwZDExYTlkYTVi ZTYyOTM2MmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTAgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgbWVkaWEvYXVkaW8tZGF0YS11 cmwuaHRtbCB0ZXN0IGJyb2tlbiBvbiBMaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTc3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERvIG5vdCB1c2UgIk9wZW5Gb3JQbGF5YmFjayIgYXR0cmlidXRl IG9uIGRhdGE6Ly8gdXJscywgYXMgQ29yZU1lZGlhL1F1aWNrVGltZSBYIGNhbm5vdAorICAgICAg ICBoYW5kbGUgdGhvc2UgVVJMcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9N ZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZVFUS2l0OjpjcmVhdGVRVE1vdmllKToKKwogMjAxMS0xMC0wNiAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBGb3VyIG1lZGlhIHRlc3RzIGZhaWxpbmcg b24gTGlvbiBkdWUgdG8gaW5jb3JyZWN0IGNhY2hlZCB0aW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZh dGVRVEtpdC5tbQppbmRleCAzNjEzMmNkN2JkNzRmOTgwMWJlNDdmOTZmNjhmMzZlNzQxOGE0MmVh Li43OTk3OGQ0ZmJkY2ZhMGYyNGYxYTk3M2U3NzljNjlkYzJhMTFmOGQ3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRL aXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxh eWVyUHJpdmF0ZVFUS2l0Lm1tCkBAIC0yODIsOSArMjgyLDkgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVRVEtpdDo6Y3JlYXRlUVRNb3ZpZShjb25zdCBTdHJpbmcmIHVybCkKICAgICAgICAgICAg IHdpbGxVc2VQcm94eSA9IE5POwogICAgIH0KIAotICAgIGlmICghd2lsbFVzZVByb3h5KSB7Cisg ICAgaWYgKCF3aWxsVXNlUHJveHkgJiYgIVtbY29jb2FVUkwgc2NoZW1lXSBpc0VxdWFsVG86QCJk YXRhIl0pIHsKICAgICAgICAgLy8gT25seSBwYXNzIHRoZSBRVE1vdmllT3BlbkZvclBsYXliYWNr QXR0cmlidXRlIGZsYWcgaWYgdGhlcmUgYXJlIG5vIHByb3h5IHNlcnZlcnMsIGR1ZQotICAgICAg ICAvLyB0byByZGFyOi8vcHJvYmxlbS83NTMxNzc2LgorICAgICAgICAvLyB0byByZGFyOi8vcHJv YmxlbS83NTMxNzc2LCBvciBpZiBsb2FkaW5nIGEgZGF0YTovLyB1cmwgZHVlIHRvIHJkYXI6Ly9w cm9ibGVtLzgxMDM4MDEuCiAgICAgICAgIFttb3ZpZUF0dHJpYnV0ZXMgc2V0T2JqZWN0OltOU051 bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdIGZvcktleTpAIlFUTW92aWVPcGVuRm9yUGxheWJhY2tB dHRyaWJ1dGUiXTsKICAgICB9CiAgICAgCg== 110421 2011-10-10 15:30:36 -0700 2011-10-10 17:44:31 -0700 Patch bug-69779-20111010153035.patch text/plain 1837 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogOTcwODkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YTdhZjg1NDlkODQ5OGM5 NDcxMzk4OTFmNzJiYTU5NTkzYzUzYzgzLi45OGVkMWM1NmFhYjhjZGNlNzgxOTI0ODY4NjM3MzFi YWM0MDUyN2YxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTAgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgbWVkaWEvYXVkaW8tZGF0YS11 cmwuaHRtbCB0ZXN0IGJyb2tlbiBvbiBMaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02OTc3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERvIG5vdCB1c2UgIk9wZW5Gb3JQbGF5YmFjayIgYXR0cmlidXRl IG9uIGRhdGE6Ly8gdXJscywgYXMgQ29yZU1lZGlhL1F1aWNrVGltZSBYIGNhbm5vdAorICAgICAg ICBoYW5kbGUgdGhvc2UgVVJMcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9N ZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZVFUS2l0OjpjcmVhdGVRVE1vdmllKToKKwogMjAxMS0xMC0wNiAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBtZWRpYS92aWRlby1sb29wLmh0bWwgaXMg ZmFpbGluZyBvbiBMaW9uIGJlY2F1c2Ugb2YgbmVnYXRpdmUgY3VycmVudFRpbWUoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJp dmF0ZVFUS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlh UGxheWVyUHJpdmF0ZVFUS2l0Lm1tCmluZGV4IDM2MTMyY2Q3YmQ3NGY5ODAxYmU0N2Y5NmY2OGYz NmU3NDE4YTQyZWEuLjY1MjdlYWQ3MzQ4YWVmYzkyZGQ0ZWE3OWM2ZDVkMmU4N2ZjMzhhYzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXll clByaXZhdGVRVEtpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KQEAgLTI4Miw5ICsyODIsOSBAQCB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpjcmVhdGVRVE1vdmllKGNvbnN0IFN0cmluZyYgdXJsKQog ICAgICAgICAgICAgd2lsbFVzZVByb3h5ID0gTk87CiAgICAgfQogCi0gICAgaWYgKCF3aWxsVXNl UHJveHkpIHsKKyAgICBpZiAoIXdpbGxVc2VQcm94eSAmJiAhW1tjb2NvYVVSTCBzY2hlbWVdIGNv bXBhcmU6QCJkYXRhIiBvcHRpb25zOk5TQ2FzZUluc2Vuc2l0aXZlU2VhcmNoXSkgewogICAgICAg ICAvLyBPbmx5IHBhc3MgdGhlIFFUTW92aWVPcGVuRm9yUGxheWJhY2tBdHRyaWJ1dGUgZmxhZyBp ZiB0aGVyZSBhcmUgbm8gcHJveHkgc2VydmVycywgZHVlCi0gICAgICAgIC8vIHRvIHJkYXI6Ly9w cm9ibGVtLzc1MzE3NzYuCisgICAgICAgIC8vIHRvIHJkYXI6Ly9wcm9ibGVtLzc1MzE3NzYsIG9y IGlmIG5vdCBsb2FkaW5nIGEgZGF0YTovLyB1cmwgZHVlIHRvIHJkYXI6Ly9wcm9ibGVtLzgxMDM4 MDEuCiAgICAgICAgIFttb3ZpZUF0dHJpYnV0ZXMgc2V0T2JqZWN0OltOU051bWJlciBudW1iZXJX aXRoQm9vbDpZRVNdIGZvcktleTpAIlFUTW92aWVPcGVuRm9yUGxheWJhY2tBdHRyaWJ1dGUiXTsK ICAgICB9CiAgICAgCg==