69751 2011-10-10 03:44:52 -0700 Shrink RenderListItem on 64-bit. 2011-10-10 04:29:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kenneth koivisto oldest_to_newest 480904 0 kling 2011-10-10 03:44:52 -0700 We can pack one int member into the padding at the end of RenderBlock. 480905 1 110345 kling 2011-10-10 03:45:47 -0700 Created attachment 110345 Proposed patch 480912 2 110345 kenneth 2011-10-10 04:15:51 -0700 Comment on attachment 110345 Proposed patch You want to change the initialization order as well: 41 RenderListItem::RenderListItem(Node* node) 42 : RenderBlock(node) 43 , m_marker(0) 44 , m_hasExplicitValue(false) 45 , m_isValueUpToDate(false) 46 , m_notInList(false) 47 { 480913 3 kenneth 2011-10-10 04:16:42 -0700 (In reply to comment #2) > (From update of attachment 110345 [details]) > You want to change the initialization order as well: > > 41 RenderListItem::RenderListItem(Node* node) > 42 : RenderBlock(node) > 43 , m_marker(0) > 44 , m_hasExplicitValue(false) > 45 , m_isValueUpToDate(false) > 46 , m_notInList(false) > 47 { Maybe not... I though I saw m_explicitValue here. 480916 4 110345 kling 2011-10-10 04:28:54 -0700 Comment on attachment 110345 Proposed patch Clearing flags on attachment: 110345 Committed r97054: <http://trac.webkit.org/changeset/97054> 480917 5 kling 2011-10-10 04:29:04 -0700 All reviewed patches have been landed. Closing bug. 110345 2011-10-10 03:45:47 -0700 2011-10-10 04:28:54 -0700 Proposed patch bug-69751.diff text/plain 1174 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNTBmZTYwLi5iMGYxZWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFNocmluayBSZW5kZXJMaXN0SXRlbSBvbiA2NC1iaXQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTc1MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYXJyYW5nZSBtZW1iZXJzIHRvIHV0aWxpemUg dGhlIHBhZGRpbmcgYXQgdGhlIGVuZCBvZiBSZW5kZXJCbG9jay4KKyAgICAgICAgVGhpcyBzaHJp bmtzIFJlbmRlckxpc3RJdGVtIGJ5IDggYnl0ZXMgb24gNjQtYml0LCByZWR1Y2luZyBtZW1vcnkg Y29uc3VtcHRpb24KKyAgICAgICAgYnkgNjAga0Igd2hlbiBsb2FkaW5nIHRoZSBmdWxsIEhUTUw1 IHNwZWMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uaDoKKwogMjAxMS0x MC0wNiAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2hyaW5r IEJvcmRlclZhbHVlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxpc3RJdGVtLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uaApp bmRleCBlNTZlZmZmLi43NmQ5OGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGlzdEl0ZW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGlzdEl0ZW0uaApAQCAtNzUsOCArNzUsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgdXBkYXRlVmFs dWVOb3coKSBjb25zdDsKICAgICB2b2lkIGV4cGxpY2l0VmFsdWVDaGFuZ2VkKCk7CiAKLSAgICBS ZW5kZXJMaXN0TWFya2VyKiBtX21hcmtlcjsKICAgICBpbnQgbV9leHBsaWNpdFZhbHVlOworICAg IFJlbmRlckxpc3RNYXJrZXIqIG1fbWFya2VyOwogICAgIG11dGFibGUgaW50IG1fdmFsdWU7CiAK ICAgICBib29sIG1faGFzRXhwbGljaXRWYWx1ZSA6IDE7Cg==