69749 2011-10-10 03:18:27 -0700 [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable 2011-10-11 10:16:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned webkit.review.bot oldest_to_newest 480901 0 pnormand 2011-10-10 03:18:27 -0700 GtkTable has been deprecated in GTK+3. 481667 1 110521 csaavedra 2011-10-11 09:11:40 -0700 Created attachment 110521 [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 Reviewed by NOBODY (OOPS!). * platform/gtk/GtkAuthenticationDialog.cpp: (WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3 (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Ditto. 481690 2 110521 mrobinson 2011-10-11 09:54:35 -0700 Comment on attachment 110521 [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 Hopefully this will look better once we remove GTK+ support. :) 481705 3 110521 webkit.review.bot 2011-10-11 10:16:03 -0700 Comment on attachment 110521 [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 Clearing flags on attachment: 110521 Committed r97161: <http://trac.webkit.org/changeset/97161> 481706 4 webkit.review.bot 2011-10-11 10:16:07 -0700 All reviewed patches have been landed. Closing bug. 110521 2011-10-11 09:11:40 -0700 2011-10-11 10:16:03 -0700 [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable https://bugs.webkit.org/show_bug.cgi?id=69749 GTK-GtkAuthenticationDialog-use-GtkGrid-instead-of.patch text/plain 5146 csaavedra RnJvbSA1ZGQ2NzE5YjVhYWQ3MTE1NDA0NDViYmIyN2YxODc0ZmFkZDc3MTcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGF1ZGlvIFNhYXZlZHJhIDxjc2FhdmVkcmFAaWdhbGlhLmNv bT4KRGF0ZTogVHVlLCAxMSBPY3QgMjAxMSAxOTowMDozNiArMDMwMApTdWJqZWN0OiBbUEFUQ0hd IFtHVEtdIEd0a0F1dGhlbnRpY2F0aW9uRGlhbG9nOiB1c2UgR3RrR3JpZCBpbnN0ZWFkIG9mCiBH dGtUYWJsZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3NDkKClJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBwbGF0Zm9ybS9ndGsvR3RrQXV0aGVudGljYXRp b25EaWFsb2cuY3BwOgooV2ViQ29yZTo6YWRkRW50cnlUb0dyaWQpOiBNaWdyYXRlIHRvIEd0a0dy aWQgd2hlbiB1c2luZyBHVEsrIDMKKFdlYkNvcmU6Okd0a0F1dGhlbnRpY2F0aW9uRGlhbG9nOjpH dGtBdXRoZW50aWNhdGlvbkRpYWxvZyk6CkRpdHRvLgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysKIC4uLi9wbGF0Zm9y bS9ndGsvR3RrQXV0aGVudGljYXRpb25EaWFsb2cuY3BwICAgICAgIHwgICAzOSArKysrKysrKysr KysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA5Y2IxNmQxLi41OGIwM2E4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTEgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBHdGtBdXRoZW50aWNhdGlvbkRpYWxvZzogdXNlIEd0a0dy aWQgaW5zdGVhZCBvZiBHdGtUYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njk3NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9HdGtBdXRoZW50aWNhdGlvbkRpYWxvZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjphZGRFbnRyeVRvR3JpZCk6IE1pZ3JhdGUgdG8gR3RrR3JpZCB3 aGVuIHVzaW5nIEdUSysgMworICAgICAgICAoV2ViQ29yZTo6R3RrQXV0aGVudGljYXRpb25EaWFs b2c6Okd0a0F1dGhlbnRpY2F0aW9uRGlhbG9nKToKKyAgICAgICAgRGl0dG8uCisKIDIwMTEtMTAt MDUgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogaW1wbGVtZW50IENvbXBpbGVyU291cmNlTWFwcGluZ1Byb3ZpZGVyLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a0F1dGhlbnRpY2F0aW9u RGlhbG9nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtBdXRoZW50aWNhdGlv bkRpYWxvZy5jcHAKaW5kZXggODFmMGRhOC4uZDY1Zjc0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0d0a0F1dGhlbnRpY2F0aW9uRGlhbG9nLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrQXV0aGVudGljYXRpb25EaWFsb2cuY3BwCkBAIC0y Nyw3ICsyNywxMSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZmRlZiBHVEtfQVBJX1ZF UlNJT05fMgogc3RhdGljIEd0a1dpZGdldCogYWRkRW50cnlUb1RhYmxlKEd0a1RhYmxlKiB0YWJs ZSwgaW50IHJvdywgY29uc3QgY2hhciogbGFiZWxUZXh0KQorI2Vsc2UKK3N0YXRpYyBHdGtXaWRn ZXQqIGFkZEVudHJ5VG9HcmlkKEd0a0dyaWQqIGdyaWQsIGludCByb3csIGNvbnN0IGNoYXIqIGxh YmVsVGV4dCkKKyNlbmRpZgogewogICAgIEd0a1dpZGdldCogbGFiZWwgPSBndGtfbGFiZWxfbmV3 KGxhYmVsVGV4dCk7CiAgICAgZ3RrX21pc2Nfc2V0X2FsaWdubWVudChHVEtfTUlTQyhsYWJlbCks IDAuMCwgMC41KTsKQEAgLTM1LDggKzM5LDE3IEBAIHN0YXRpYyBHdGtXaWRnZXQqIGFkZEVudHJ5 VG9UYWJsZShHdGtUYWJsZSogdGFibGUsIGludCByb3csIGNvbnN0IGNoYXIqIGxhYmVsVGV4CiAg ICAgR3RrV2lkZ2V0KiBlbnRyeSA9IGd0a19lbnRyeV9uZXcoKTsKICAgICBndGtfZW50cnlfc2V0 X2FjdGl2YXRlc19kZWZhdWx0KEdUS19FTlRSWShlbnRyeSksIFRSVUUpOwogCisjaWZkZWYgR1RL X0FQSV9WRVJTSU9OXzIKICAgICBndGtfdGFibGVfYXR0YWNoKHRhYmxlLCBsYWJlbCwgMCwgMSwg cm93LCByb3cgKyAxLCBHVEtfRklMTCwgc3RhdGljX2Nhc3Q8R3RrQXR0YWNoT3B0aW9ucz4oR1RL X0VYUEFORCB8IEdUS19GSUxMKSwgMCwgMCk7CiAgICAgZ3RrX3RhYmxlX2F0dGFjaF9kZWZhdWx0 cyh0YWJsZSwgZW50cnksIDEsIDIsIHJvdywgcm93ICsgMSk7CisjZWxzZQorICAgIGd0a19ncmlk X2F0dGFjaChncmlkLCBsYWJlbCwgMCwgcm93LCAxLCAxKTsKKyAgICBndGtfd2lkZ2V0X3NldF9o ZXhwYW5kKGxhYmVsLCBUUlVFKTsKKworICAgIGd0a19ncmlkX2F0dGFjaChncmlkLCBlbnRyeSwg MSwgcm93LCAxLCAxKTsKKyAgICBndGtfd2lkZ2V0X3NldF9oZXhwYW5kKGVudHJ5LCBUUlVFKTsK KyAgICBndGtfd2lkZ2V0X3NldF92ZXhwYW5kKGVudHJ5LCBUUlVFKTsKKyNlbmRpZgogCiAgICAg cmV0dXJuIGVudHJ5OwogfQpAQCAtMTI5LDI1ICsxNDIsNDkgQEAgR3RrQXV0aGVudGljYXRpb25E aWFsb2c6Okd0a0F1dGhlbnRpY2F0aW9uRGlhbG9nKEd0a1dpbmRvdyogcGFyZW50V2luZG93LCBT b3VwU2UKICAgICAvLyBDaGVja2luZyB0aGF0IHJlYWxtIGlzIG5vdCBhbiBlbXB0eSBzdHJpbmcu CiAgICAgYm9vbCBoYXNSZWFsbSA9IChyZWFsbSAmJiByZWFsbVswXSAhPSAnXDAnKTsKIAorI2lm ZGVmIEdUS19BUElfVkVSU0lPTl8yCiAgICAgR3RrV2lkZ2V0KiB0YWJsZSA9IGd0a190YWJsZV9u ZXcoaGFzUmVhbG0gPyAzIDogMiwgMiwgRkFMU0UpOwogICAgIGd0a190YWJsZV9zZXRfY29sX3Nw YWNpbmdzKEdUS19UQUJMRSh0YWJsZSksIDEyKTsKICAgICBndGtfdGFibGVfc2V0X3Jvd19zcGFj aW5ncyhHVEtfVEFCTEUodGFibGUpLCA2KTsKICAgICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09O VEFJTkVSKGVudHJ5Q29udGFpbmVyKSwgdGFibGUpOworI2Vsc2UKKyAgICBHdGtXaWRnZXQqIGdy aWQgPSBndGtfZ3JpZF9uZXcoKTsKKyAgICBndGtfZ3JpZF9zZXRfY29sdW1uX3NwYWNpbmcoR1RL X0dSSUQoZ3JpZCksIDEyKTsKKyAgICBndGtfZ3JpZF9zZXRfcm93X3NwYWNpbmcoR1RLX0dSSUQo Z3JpZCksIDYpOworICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIoZW50cnlDb250 YWluZXIpLCBncmlkKTsKKyNlbmRpZgogCiAgICAgaWYgKGhhc1JlYWxtKSB7CiAgICAgICAgIEd0 a1dpZGdldCogc2VydmVyTWVzc2FnZURlc2NyaXB0aW9uTGFiZWwgPSBndGtfbGFiZWxfbmV3KF8o IlNlcnZlciBtZXNzYWdlOiIpKTsKICAgICAgICAgZ3RrX21pc2Nfc2V0X2FsaWdubWVudChHVEtf TUlTQyhzZXJ2ZXJNZXNzYWdlRGVzY3JpcHRpb25MYWJlbCksIDAuMCwgMC41KTsKICAgICAgICAg Z3RrX2xhYmVsX3NldF9saW5lX3dyYXAoR1RLX0xBQkVMKHNlcnZlck1lc3NhZ2VEZXNjcmlwdGlv bkxhYmVsKSwgVFJVRSk7CisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKICAgICAgICAgZ3RrX3Rh YmxlX2F0dGFjaF9kZWZhdWx0cyhHVEtfVEFCTEUodGFibGUpLCBzZXJ2ZXJNZXNzYWdlRGVzY3Jp cHRpb25MYWJlbCwgMCwgMSwgMCwgMSk7Ci0KKyNlbHNlCisgICAgICAgIGd0a19ncmlkX2F0dGFj aChHVEtfR1JJRChncmlkKSwgc2VydmVyTWVzc2FnZURlc2NyaXB0aW9uTGFiZWwsIDAsIDAsIDEs IDEpOworICAgICAgICBndGtfd2lkZ2V0X3NldF9oZXhwYW5kKHNlcnZlck1lc3NhZ2VEZXNjcmlw dGlvbkxhYmVsLCBUUlVFKTsKKyAgICAgICAgZ3RrX3dpZGdldF9zZXRfdmV4cGFuZChzZXJ2ZXJN ZXNzYWdlRGVzY3JpcHRpb25MYWJlbCwgVFJVRSk7CisjZW5kaWYKICAgICAgICAgR3RrV2lkZ2V0 KiBzZXJ2ZXJNZXNzYWdlTGFiZWwgPSBndGtfbGFiZWxfbmV3KHJlYWxtKTsKICAgICAgICAgZ3Rr X21pc2Nfc2V0X2FsaWdubWVudChHVEtfTUlTQyhzZXJ2ZXJNZXNzYWdlTGFiZWwpLCAwLjAsIDAu NSk7CiAgICAgICAgIGd0a19sYWJlbF9zZXRfbGluZV93cmFwKEdUS19MQUJFTChzZXJ2ZXJNZXNz YWdlTGFiZWwpLCBUUlVFKTsKKyNpZmRlZiBHVEtfQVBJX1ZFUlNJT05fMgogICAgICAgICBndGtf dGFibGVfYXR0YWNoX2RlZmF1bHRzKEdUS19UQUJMRSh0YWJsZSksIHNlcnZlck1lc3NhZ2VMYWJl bCwgMSwgMiwgMCwgMSk7CisjZWxzZQorICAgICAgICBndGtfZ3JpZF9hdHRhY2goR1RLX0dSSUQo Z3JpZCksIHNlcnZlck1lc3NhZ2VMYWJlbCwgMSwgMCwgMSwgMSk7CisgICAgICAgIGd0a193aWRn ZXRfc2V0X2hleHBhbmQoc2VydmVyTWVzc2FnZUxhYmVsLCBUUlVFKTsKKyAgICAgICAgZ3RrX3dp ZGdldF9zZXRfdmV4cGFuZChzZXJ2ZXJNZXNzYWdlTGFiZWwsIFRSVUUpOworI2VuZGlmCiAgICAg fQogCisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKICAgICBtX2xvZ2luRW50cnkgPSBhZGRFbnRy eVRvVGFibGUoR1RLX1RBQkxFKHRhYmxlKSwgaGFzUmVhbG0gPyAxIDogMCwgXygiVXNlcm5hbWU6 IikpOwogICAgIG1fcGFzc3dvcmRFbnRyeSA9IGFkZEVudHJ5VG9UYWJsZShHVEtfVEFCTEUodGFi bGUpLCBoYXNSZWFsbSA/IDIgOiAxLCBfKCJQYXNzd29yZDoiKSk7CisjZWxzZQorICAgIG1fbG9n aW5FbnRyeSA9IGFkZEVudHJ5VG9HcmlkKEdUS19HUklEKGdyaWQpLCBoYXNSZWFsbSA/IDEgOiAw LCBfKCJVc2VybmFtZToiKSk7CisgICAgbV9wYXNzd29yZEVudHJ5ID0gYWRkRW50cnlUb0dyaWQo R1RLX0dSSUQoZ3JpZCksIGhhc1JlYWxtID8gMiA6IDEsIF8oIlBhc3N3b3JkOiIpKTsKKyNlbmRp ZgorCiAgICAgZ3RrX2VudHJ5X3NldF92aXNpYmlsaXR5KEdUS19FTlRSWShtX3Bhc3N3b3JkRW50 cnkpLCBGQUxTRSk7CiAKICAgICBpZiAoc2Vzc2lvbkNhblNhdmVQYXNzd29yZHMobV9zZXNzaW9u KSkgewotLSAKMS43LjYuNA==