69738 2011-10-09 21:37:57 -0700 Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel 2011-11-24 01:37:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 johnjbarton apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 480821 0 johnjbarton 2011-10-09 21:37:57 -0700 1. Open Web Inspector on any site with JS 2. Select Scripts button 3. Click the file list, select one file, the menu closes. 4. Hit page down. Expected: the source pages down Actual: the source changes to a file I did not select. I have to reselect the file I want. The user has selected a source. Now they are ready to work on that view. But keyboard focus remains on the file list. Very frustrating. 508159 1 116364 apavlov 2011-11-23 08:35:51 -0800 Created attachment 116364 Patch 508545 2 116364 timothy 2011-11-23 18:25:33 -0800 Comment on attachment 116364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116364&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:102 > + focusEditor: function() Why not just call this focus()? 508671 3 apavlov 2011-11-24 01:37:44 -0800 Committed r101129: <http://trac.webkit.org/changeset/101129> 116364 2011-11-23 08:35:51 -0800 2011-11-23 18:25:33 -0800 Patch bug-69738-20111123203549.patch text/plain 4224 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQwN2FkNmNjOGJkMjhk YjExNjg4OTExMDBmZjE5MzNlMmFhNjdhMS4uODY4NjMyNjBmNTQ5YjE0NGE1YzZjODM0ZjExMzMy NGFkNzdkODBhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDExLTExLTIzICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3Rvcjogc2hpZnQgZm9jdXMgdG8gdGhlIHNvdXJjZSB2aWV3IHdoZW4gYSByZXNvdXJjZSBpcyBz ZWxlY3RlZCBpbiB0aGUgU2NyaXB0cyBwYW5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgc291cmNlIHZpZXdlciBpcyBmb2N1c2VkIHdoZW5ldmVy IGEgZmlsZSBuYW1lIG9wdGlvbiBpcyBjbGlja2VkLCBhbmQgaXMgTk9UIGZvY3VzZWQgd2hlbiB0 aGUgc2NyaXB0IGxpc3QKKyAgICAgICAgaXMgdHJhdmVyc2VkIHdpdGggdGhlIFVwL0Rvd24ga2V5 cy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX2ZpbGVzU2VsZWN0Q2hh bmdlZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuZm9jdXNFZGl0b3IpOgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZS5mb2N1cyk6CisKKzIwMTEtMTEtMjMgIEFs ZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5z cGVjdG9yOiB3YXJuaW5nIGljb24gZm9yIHVucmVjb2duaXplZCBzdHlsZSBydWxlIHNob3VsZCBo YXZlIHRvb2x0aXAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUwNjM4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvU2NyaXB0c1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T Y3JpcHRzUGFuZWwuanMKaW5kZXggZTg4ODU0NTZhZmQwNTVhMmRmNzJlYjdmZWY2ZWUxYWQ3OWE1 ZWMzNC4uMzc1YjYxNDQyMTAyYjkyZDQzMTJkZWRiMjgzMmZmZWNlNDVhNTg3MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAg LTY5LDggKzY5LDggQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbCA9IGZ1bmN0aW9uKHByZXNl bnRhdGlvbk1vZGVsKQogICAgIHRoaXMuX2ZpbGVzU2VsZWN0RWxlbWVudCA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoInNlbGVjdCIpOwogICAgIHRoaXMuX2ZpbGVzU2VsZWN0RWxlbWVudC5jbGFz c05hbWUgPSAic3RhdHVzLWJhci1pdGVtIjsKICAgICB0aGlzLl9maWxlc1NlbGVjdEVsZW1lbnQu aWQgPSAic2NyaXB0cy1maWxlcyI7Ci0gICAgdGhpcy5fZmlsZXNTZWxlY3RFbGVtZW50LmFkZEV2 ZW50TGlzdGVuZXIoImNoYW5nZSIsIHRoaXMuX2ZpbGVzU2VsZWN0Q2hhbmdlZC5iaW5kKHRoaXMp LCBmYWxzZSk7Ci0gICAgdGhpcy5fZmlsZXNTZWxlY3RFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImtleXVwIiwgdGhpcy5fZmlsZXNTZWxlY3RDaGFuZ2VkLmJpbmQodGhpcyksIGZhbHNlKTsKKyAg ICB0aGlzLl9maWxlc1NlbGVjdEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgdGhp cy5fZmlsZXNTZWxlY3RDaGFuZ2VkLmJpbmQodGhpcywgdHJ1ZSksIGZhbHNlKTsKKyAgICB0aGlz Ll9maWxlc1NlbGVjdEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigia2V5dXAiLCB0aGlzLl9maWxl c1NlbGVjdENoYW5nZWQuYmluZCh0aGlzLCBmYWxzZSksIGZhbHNlKTsKICAgICB0aGlzLnRvcFN0 YXR1c0Jhci5hcHBlbmRDaGlsZCh0aGlzLl9maWxlc1NlbGVjdEVsZW1lbnQpOwogCiAgICAgdGhp cy5mdW5jdGlvbnNTZWxlY3RFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic2VsZWN0 Iik7CkBAIC03NjIsMTMgKzc2MiwxNSBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3Rv dHlwZSA9IHsKICAgICAgICAgdGhpcy5fdXBkYXRlRXhlY3V0aW9uTGluZSh0aGlzLl9wcmVzZW50 YXRpb25Nb2RlbC5leGVjdXRpb25MaW5lTG9jYXRpb24pOwogICAgIH0sCiAKLSAgICBfZmlsZXNT ZWxlY3RDaGFuZ2VkOiBmdW5jdGlvbigpCisgICAgX2ZpbGVzU2VsZWN0Q2hhbmdlZDogZnVuY3Rp b24oZm9jdXNTb3VyY2UpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fZmlsZXNTZWxlY3RFbGVt ZW50LnNlbGVjdGVkSW5kZXggPT09IC0xKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAg IHZhciB1aVNvdXJjZUNvZGUgPSB0aGlzLl9maWxlc1NlbGVjdEVsZW1lbnRbdGhpcy5fZmlsZXNT ZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXhdLl91aVNvdXJjZUNvZGU7Ci0gICAgICAgIHRoaXMu X3Nob3dTb3VyY2VGcmFtZUFuZEFkZFRvSGlzdG9yeSh1aVNvdXJjZUNvZGUpOworICAgICAgICB2 YXIgc291cmNlRnJhbWUgPSB0aGlzLl9zaG93U291cmNlRnJhbWVBbmRBZGRUb0hpc3RvcnkodWlT b3VyY2VDb2RlKTsKKyAgICAgICAgaWYgKHNvdXJjZUZyYW1lICYmIGZvY3VzU291cmNlKQorICAg ICAgICAgICAgc291cmNlRnJhbWUuZm9jdXNFZGl0b3IoKTsKICAgICB9LAogCiAgICAgc2lkZWJh clJlc2l6ZWQ6IGZ1bmN0aW9uKGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMKaW5kZXggNDAxMzkxYjNjYzZiMDIzMzYyYTJkZDE3 ZmM3YWQ1NDU5MjZjZWE2NS4uMWNiMjI3NjdjOTljM2IxNjVlMzJmYjQ5ZWU5MGJmMWE4MjdiN2Zh MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VG cmFtZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZy YW1lLmpzCkBAIC05OSw2ICs5OSwxMSBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90 eXBlID0gewogICAgICAgICB0aGlzLnNldFJlYWRPbmx5KHRydWUpOwogICAgIH0sCiAKKyAgICBm b2N1c0VkaXRvcjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhpcy5fdGV4dFZpZXdlci5m b2N1cygpOworICAgIH0sCisKICAgICBnZXQgc3RhdHVzQmFySXRlbXMoKQogICAgIHsKICAgICAg ICAgcmV0dXJuIFt0aGlzLl9lZGl0QnV0dG9uLmVsZW1lbnRdOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IDAzOThmZWZiZjRlY2Jj YTkwM2YxZDM5ZTVlYzc2ZGJhNTQxNmMyZjMuLmYzMzMxMWY2NzViMWRkMzUyNTc1Mjk3NGJkYWMy NWYzOTBlYmE5ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGV4dFZpZXdlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RleHRWaWV3ZXIuanMKQEAgLTk4LDYgKzk4LDExIEBAIFdlYkluc3BlY3Rvci5UZXh0Vmlld2Vy LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRoaXMuX3RleHRNb2RlbDsKICAgICB9LAog CisgICAgZm9jdXM6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRoaXMuX21haW5QYW5lbC5l bGVtZW50LmZvY3VzKCk7CisgICAgfSwKKwogICAgIHJldmVhbExpbmU6IGZ1bmN0aW9uKGxpbmVO dW1iZXIpCiAgICAgewogICAgICAgICB0aGlzLl9tYWluUGFuZWwucmV2ZWFsTGluZShsaW5lTnVt YmVyKTsK