69735 2011-10-09 20:55:07 -0700 Fix Leopard and Snow Leopard build after changeset 97034 2011-10-28 12:27:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson ap dbates oldest_to_newest 480803 0 macpherson 2011-10-09 20:55:07 -0700 Fix build regressions in 97043 480805 1 110322 macpherson 2011-10-09 20:57:49 -0700 Created attachment 110322 Patch 480807 2 macpherson 2011-10-09 21:00:15 -0700 http://trac.webkit.org/changeset/97034 https://bugs.webkit.org/show_bug.cgi?id=68035 480815 3 110322 dbates 2011-10-09 21:22:27 -0700 Comment on attachment 110322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110322&action=review Will land this by hand and fix commit message. Thanks for the fix! > Source/WebCore/ChangeLog:3 > + Fix build regressions in 97043 97043 => 97034 Also, should mention the builds that this fixes, which includes Leopard and Snow Leopard. 480817 4 dbates 2011-10-09 21:28:31 -0700 Committed r97040: <http://trac.webkit.org/changeset/97040> 482014 5 ap 2011-10-11 16:31:27 -0700 The BuiltInPDFView changes are not quite perfect. The new zoomAnimatorTransformChanged override was added in the midst of Plugin class methods, while there is a separate section for ScrollableArea methods below. 492598 6 ap 2011-10-28 12:27:40 -0700 Fixing that in bug 71133. 110322 2011-10-09 20:57:49 -0700 2011-10-09 21:22:27 -0700 Patch bug-69735-20111010145747.patch text/plain 3311 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MDM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDkgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYnVpbGQg cmVncmVzc2lvbnMgaW4gOTcwNDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY5NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMu Y3BwOgorICAgICAgICBNYXJrIHVudXNlZCBwYXJhbWV0ZXJzIHRvIHByZXZlbnQgY29tcGlsZSBl cnJvcnMgd2hlbiBHRVNUVVJFX0VWRU5UUyBhbmQgU01PT1RIX1NDUk9MTElORyBhcmUgZGlzYWJs ZWQuCisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OnNldEVuYWJsZVNjcm9sbEFuaW1hdG9y KToKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6c2V0Wm9vbUFuaW1hdG9yVHJhbnNmb3Jt KToKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6c2V0Wm9vbVBhcmFtZXRlcnMpOgorCiAy MDExLTEwLTA5ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZW1vdmUgcmVkdW5kYW50IGNvZGUgb2YgSFRNTFNlbGVjdEVsZW1lbnQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCShyZXZpc2lvbiA5NzAzNikKKysrIFNvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU0LDYgKzI1NCw4 IEBAIHZvaWQgSW50ZXJuYWxzOjpzZXRFbmFibGVTY3JvbGxBbmltYXRvcigKIAogI2lmIEVOQUJM RShTTU9PVEhfU0NST0xMSU5HKQogICAgIGRvY3VtZW50LT5zZXR0aW5ncygpLT5zZXRFbmFibGVT Y3JvbGxBbmltYXRvcihlbmFibGVkKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGVuYWJsZWQp OwogI2VuZGlmCiB9CiAKQEAgLTI2Nyw2ICsyNjksMTAgQEAgdm9pZCBJbnRlcm5hbHM6OnNldFpv b21BbmltYXRvclRyYW5zZm9ybQogI2lmIEVOQUJMRShHRVNUVVJFX0VWRU5UUykKICAgICBQbGF0 Zm9ybUdlc3R1cmVFdmVudCBwZ2UoUGxhdGZvcm1HZXN0dXJlRXZlbnQ6OkRvdWJsZVRhcFR5cGUs IEludFBvaW50KHR4LCB0eSksIEludFBvaW50KHR4LCB0eSksIDAsIHNjYWxlLCAwLmYsIDAsIDAs IDAsIDApOwogICAgIGRvY3VtZW50LT52aWV3KCktPmZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5o YW5kbGVHZXN0dXJlRXZlbnQocGdlKTsKKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHNjYWxlKTsK KyAgICBVTlVTRURfUEFSQU0odHgpOworICAgIFVOVVNFRF9QQVJBTSh0eSk7CiAjZW5kaWYKIH0K IApAQCAtMjg5LDYgKzI5NSwxMCBAQCB2b2lkIEludGVybmFsczo6c2V0Wm9vbVBhcmFtZXRlcnMo RG9jdW1lCiAKICNpZiBFTkFCTEUoU01PT1RIX1NDUk9MTElORykKICAgICBkb2N1bWVudC0+dmll dygpLT5zY3JvbGxBbmltYXRvcigpLT5zZXRab29tUGFyYW1ldGVyc0ZvclRlc3Qoc2NhbGUsIHgs IHkpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oc2NhbGUpOworICAgIFVOVVNFRF9QQVJBTSh4 KTsKKyAgICBVTlVTRURfUEFSQU0oeSk7CiAjZW5kaWYKIH0KIApJbmRleDogU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2 aXNpb24gOTcwMzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMC0wOSAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJz b25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBidWlsZCByZWdyZXNzaW9ucyBpbiA5NzA0 MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvUGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuaDoKKyAgICAgICAgQWRkIHN5bWJvbHMg dGhhdCBhcmUgbm93IHJlcXVpcmVkIGJ5IFNjcm9sbGFibGVBcmVhLgorICAgICAgICAoV2ViS2l0 OjpCdWlsdEluUERGVmlldzo6em9vbUFuaW1hdG9yVHJhbnNmb3JtQ2hhbmdlZCk6CisKIDIwMTEt MTAtMDggIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgc3RhdGljIHZlcnNpb24gb2YgSlNDZWxsOjpnZXRDb25zdHJ1Y3REYXRhCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL0J1aWx0SW5QREZWaWV3LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9CdWlsdElu UERGVmlldy5oCShyZXZpc2lvbiA5NzAzNikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QREYvQnVpbHRJblBERlZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUs OCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBtYW51YWxTdHJlYW1EaWRGaW5pc2hMb2Fk aW5nKCk7CiAgICAgdmlydHVhbCB2b2lkIG1hbnVhbFN0cmVhbURpZEZhaWwoYm9vbCB3YXNDYW5j ZWxsZWQpOwogICAgIAorICAgIHZpcnR1YWwgdm9pZCB6b29tQW5pbWF0b3JUcmFuc2Zvcm1DaGFu Z2VkKGRvdWJsZSwgZG91YmxlLCBkb3VibGUsIFpvb21BbmltYXRpb25TdGF0ZSkgeyB9CisKICAg ICB2aXJ0dWFsIGJvb2wgaGFuZGxlTW91c2VFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50Jik7CiAg ICAgdmlydHVhbCBib29sIGhhbmRsZVdoZWVsRXZlbnQoY29uc3QgV2ViV2hlZWxFdmVudCYpOwog ICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVNb3VzZUVudGVyRXZlbnQoY29uc3QgV2ViTW91c2VFdmVu dCYpOwo=