69721 2011-10-09 04:40:52 -0700 JSVALUE32_64 DFG JIT - Bug fix for ConvertThis 2011-10-09 21:37:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 480699 0 yuqiang.xian 2011-10-09 04:40:52 -0700 Patch soon. 480700 1 110298 yuqiang.xian 2011-10-09 04:45:04 -0700 Created attachment 110298 the patch 480727 2 110298 fpizlo 2011-10-09 12:09:58 -0700 Comment on attachment 110298 the patch This doesn't look right. I think you should be catching the case where thisValueTagGPR holds NullTag. I think that's what this code was trying to do (and failing). 480773 3 110314 yuqiang.xian 2011-10-09 18:20:35 -0700 Created attachment 110314 the patch oh... 480785 4 110314 darin 2011-10-09 19:29:08 -0700 Comment on attachment 110314 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=110314&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:1762 > + ASSERT((JSValue::UndefinedTag + 1 == JSValue::NullTag) && (JSValue::NullTag & 0x1)); As I mentioned in the other bug, this assertion should be: COMPILE_ASSERT((JSValue::UndefinedTag | 1) == JSValue::NullTag); 480788 5 110318 yuqiang.xian 2011-10-09 19:38:43 -0700 Created attachment 110318 patch addressing Darin's comments 480796 6 110318 webkit.review.bot 2011-10-09 20:10:17 -0700 Comment on attachment 110318 patch addressing Darin's comments Clearing flags on attachment: 110318 Committed r97037: <http://trac.webkit.org/changeset/97037> 480797 7 webkit.review.bot 2011-10-09 20:10:22 -0700 All reviewed patches have been landed. Closing bug. 110298 2011-10-09 04:45:04 -0700 2011-10-09 18:20:35 -0700 the patch 69721.patch text/plain 1665 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMjYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBCdWcgZml4IGZvciBDb252ZXJ0VGhpcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3MjEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZSk6CisKIDIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRl bC5jb20+CiAKICAgICAgICAgRml4IHZhbHVlIHByb2ZpbGluZyBpbiAzMl82NCBKSVQKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMy XzY0LmNwcAkocmV2aXNpb24gOTcwMjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzI0LDEwICsxNzI0 LDggQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAgICAgICAg ICAgR1BSUmVnIHRoaXNWYWx1ZVRhZ0dQUiA9IHRoaXNWYWx1ZS50YWdHUFIoKTsKICAgICAgICAg ICAgIEdQUlJlZyBzY3JhdGNoR1BSID0gc2NyYXRjaC5ncHIoKTsKICAgICAgICAgICAgIAotICAg ICAgICAgICAgbV9qaXQubW92ZSh0aGlzVmFsdWVUYWdHUFIsIHNjcmF0Y2hHUFIpOwotICAgICAg ICAgICAgbV9qaXQuYW5kMzIoTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW0zMihKU1ZhbHVlOjpV bmRlZmluZWRUYWcpLCBzY3JhdGNoR1BSKTsKLSAgICAgICAgICAgIHNwZWN1bGF0aW9uQ2hlY2so bV9qaXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6Ok5vdEVxdWFsLCBzY3JhdGNoR1BSLCBUcnVz dGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFnKSkpOwotICAgICAgICAgICAgCisgICAgICAg ICAgICBzcGVjdWxhdGlvbkNoZWNrKG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpOb3RF cXVhbCwgdGhpc1ZhbHVlVGFnR1BSLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFn KSkpOworCiAgICAgICAgICAgICBtX2ppdC5tb3ZlKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1t UHRyKG1faml0LmNvZGVCbG9jaygpLT5nbG9iYWxPYmplY3QoKSksIHNjcmF0Y2hHUFIpOwogICAg ICAgICAgICAgY2VsbFJlc3VsdChzY3JhdGNoR1BSLCBtX2NvbXBpbGVJbmRleCk7CiAgICAgICAg ICAgICBicmVhazsK 110314 2011-10-09 18:20:35 -0700 2011-10-09 19:38:43 -0700 the patch 69721.1.patch text/plain 1803 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBCdWcgZml4IGZvciBDb252ZXJ0VGhpcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3MjEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZSk6CisKIDIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRl bC5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBjYWxsT3BlcmF0aW9uIGNvZGUgb2YgREZH IEpJVCBvbiBYODYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gOTcwMzQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNzU5LDkgKzE3NTksMTAgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2Rl JiBub2RlKQogICAgICAgICAgICAgR1BSUmVnIHRoaXNWYWx1ZVRhZ0dQUiA9IHRoaXNWYWx1ZS50 YWdHUFIoKTsKICAgICAgICAgICAgIEdQUlJlZyBzY3JhdGNoR1BSID0gc2NyYXRjaC5ncHIoKTsK ICAgICAgICAgICAgIAorICAgICAgICAgICAgQVNTRVJUKChKU1ZhbHVlOjpVbmRlZmluZWRUYWcg KyAxID09IEpTVmFsdWU6Ok51bGxUYWcpICYmIChKU1ZhbHVlOjpOdWxsVGFnICYgMHgxKSk7CiAg ICAgICAgICAgICBtX2ppdC5tb3ZlKHRoaXNWYWx1ZVRhZ0dQUiwgc2NyYXRjaEdQUik7Ci0gICAg ICAgICAgICBtX2ppdC5hbmQzMihNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6 OlVuZGVmaW5lZFRhZyksIHNjcmF0Y2hHUFIpOwotICAgICAgICAgICAgc3BlY3VsYXRpb25DaGVj ayhtX2ppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIHNjcmF0Y2hHUFIsIFRy dXN0ZWRJbW0zMihKU1ZhbHVlOjpVbmRlZmluZWRUYWcpKSk7CisgICAgICAgICAgICBtX2ppdC5v cjMyKFRydXN0ZWRJbW0zMigxKSwgc2NyYXRjaEdQUik7CisgICAgICAgICAgICBzcGVjdWxhdGlv bkNoZWNrKG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpOb3RFcXVhbCwgc2NyYXRjaEdQ UiwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6Ok51bGxUYWcpKSk7CiAgICAgICAgICAgICAKICAgICAg ICAgICAgIG1faml0Lm1vdmUoTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW1QdHIobV9qaXQuY29k ZUJsb2NrKCktPmdsb2JhbE9iamVjdCgpKSwgc2NyYXRjaEdQUik7CiAgICAgICAgICAgICBjZWxs UmVzdWx0KHNjcmF0Y2hHUFIsIG1fY29tcGlsZUluZGV4KTsK 110318 2011-10-09 19:38:43 -0700 2011-10-09 21:37:23 -0700 patch addressing Darin's comments 69721.2.patch text/plain 1817 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMzUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBCdWcgZml4IGZvciBDb252ZXJ0VGhpcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk3MjEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZSk6CisKIDIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRl bC5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBjYWxsT3BlcmF0aW9uIGNvZGUgb2YgREZH IEpJVCBvbiBYODYKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gOTcwMzQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNzU5LDkgKzE3NTksMTAgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2Rl JiBub2RlKQogICAgICAgICAgICAgR1BSUmVnIHRoaXNWYWx1ZVRhZ0dQUiA9IHRoaXNWYWx1ZS50 YWdHUFIoKTsKICAgICAgICAgICAgIEdQUlJlZyBzY3JhdGNoR1BSID0gc2NyYXRjaC5ncHIoKTsK ICAgICAgICAgICAgIAorICAgICAgICAgICAgQ09NUElMRV9BU1NFUlQoKEpTVmFsdWU6OlVuZGVm aW5lZFRhZyB8IDEpID09IEpTVmFsdWU6Ok51bGxUYWcsIFVuZGVmaW5lZFRhZ19PUl8xX0VRVUFM U19OdWxsVGFnKTsKICAgICAgICAgICAgIG1faml0Lm1vdmUodGhpc1ZhbHVlVGFnR1BSLCBzY3Jh dGNoR1BSKTsKLSAgICAgICAgICAgIG1faml0LmFuZDMyKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVk SW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFnKSwgc2NyYXRjaEdQUik7Ci0gICAgICAgICAgICBz cGVjdWxhdGlvbkNoZWNrKG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpOb3RFcXVhbCwg c2NyYXRjaEdQUiwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6OlVuZGVmaW5lZFRhZykpKTsKKyAgICAg ICAgICAgIG1faml0Lm9yMzIoVHJ1c3RlZEltbTMyKDEpLCBzY3JhdGNoR1BSKTsKKyAgICAgICAg ICAgIHNwZWN1bGF0aW9uQ2hlY2sobV9qaXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6Ok5vdEVx dWFsLCBzY3JhdGNoR1BSLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6TnVsbFRhZykpKTsKICAgICAg ICAgICAgIAogICAgICAgICAgICAgbV9qaXQubW92ZShNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZElt bVB0cihtX2ppdC5jb2RlQmxvY2soKS0+Z2xvYmFsT2JqZWN0KCkpLCBzY3JhdGNoR1BSKTsKICAg ICAgICAgICAgIGNlbGxSZXN1bHQoc2NyYXRjaEdQUiwgbV9jb21waWxlSW5kZXgpOwo=