69720 2011-10-09 04:21:58 -0700 JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble 2011-10-09 13:13:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 480696 0 yuqiang.xian 2011-10-09 04:21:58 -0700 In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by a FPR and will be used for further optimizations, though we currently don't fully utilize it. For now when filling a JS value which was spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat to DataFormatJS to avoid compilation errors. 480697 1 110296 yuqiang.xian 2011-10-09 04:27:45 -0700 Created attachment 110296 the patch 480739 2 110296 webkit.review.bot 2011-10-09 13:13:53 -0700 Comment on attachment 110296 the patch Clearing flags on attachment: 110296 Committed r97031: <http://trac.webkit.org/changeset/97031> 480740 3 webkit.review.bot 2011-10-09 13:13:57 -0700 All reviewed patches have been landed. Closing bug. 110296 2011-10-09 04:27:45 -0700 2011-10-09 13:13:53 -0700 the patch 69720.patch text/plain 1831 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMjYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBmaWxsSlNWYWx1ZSB3aXRoIGEgcGFpciBvZiBH UFJzIHNob3VsZCBub3Qgc2V0IHRoZSByZWdpc3RlckZvcm1hdCB0byBiZSBEYXRhRm9ybWF0SlNE b3VibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5 NzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4g SlNWQUxVRTMyXzY0IERGRywgRGF0YUZvcm1hdEpTRG91YmxlIGlzIGFzc3VtZWQgdG8gYmUgcmVw cmVzZW50ZWQgYnkKKyAgICAgICAgYSBGUFIgYW5kIHdpbGwgYmUgdXNlZCBmb3IgZnVydGhlciBv cHRpbWl6YXRpb25zLCB0aG91Z2ggd2UgY3VycmVudGx5CisgICAgICAgIGRvbid0IGZ1bGx5IHV0 aWxpemUgaXQuIEZvciBub3cgd2hlbiBmaWxsaW5nIGEgSlMgdmFsdWUgd2hpY2ggd2FzCisgICAg ICAgIHNwaWxsZWQgYXMgYSBKU0RvdWJsZSB3aXRoIGEgcGFpciBvZiBHUFJzLCB3ZSdsbCBzZXQg dGhlIHJlZ2lzdGVyRm9ybWF0CisgICAgICAgIHRvIERhdGFGb3JtYXRKUyB0byBhdm9pZCBjb21w aWxhdGlvbiBlcnJvcnMuCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpmaWxsSlNWYWx1ZSk6 CisKIDIwMTEtMTAtMDkgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CiAK ICAgICAgICAgRml4IHZhbHVlIHByb2ZpbGluZyBpbiAzMl82NCBKSVQKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRvcjMyXzY0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IzMl82NC5j cHAJKHJldmlzaW9uIDk3MDI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRD b2RlR2VuZXJhdG9yMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDIsNyArMjQyLDcgQEAg Ym9vbCBKSVRDb2RlR2VuZXJhdG9yOjpmaWxsSlNWYWx1ZShOb2RlSQogICAgICAgICAgICAgbV9q aXQuZW1pdExvYWQobm9kZUluZGV4LCB0YWdHUFIsIHBheWxvYWRHUFIpOwogICAgICAgICAgICAg bV9ncHJzLnJldGFpbih0YWdHUFIsIHZpcnR1YWxSZWdpc3RlciwgU3BpbGxPcmRlclNwaWxsZWQp OwogICAgICAgICAgICAgbV9ncHJzLnJldGFpbihwYXlsb2FkR1BSLCB2aXJ0dWFsUmVnaXN0ZXIs IFNwaWxsT3JkZXJTcGlsbGVkKTsKLSAgICAgICAgICAgIGluZm8uZmlsbEpTVmFsdWUodGFnR1BS LCBwYXlsb2FkR1BSLCBzcGlsbEZvcm1hdCk7CisgICAgICAgICAgICBpbmZvLmZpbGxKU1ZhbHVl KHRhZ0dQUiwgcGF5bG9hZEdQUiwgc3BpbGxGb3JtYXQgPT0gRGF0YUZvcm1hdEpTRG91YmxlID8g RGF0YUZvcm1hdEpTIDogc3BpbGxGb3JtYXQpOwogICAgICAgICB9CiAKICAgICAgICAgcmV0dXJu IHRydWU7Cg==