69715 2011-10-08 22:28:36 -0700 Do not compare the first glyph to itself in Font::drawGlyphBuffer() 2011-10-09 02:59:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin kling webkit.review.bot oldest_to_newest 480657 0 benjamin 2011-10-08 22:28:36 -0700 In Font::drawGlyphBuffer(): 1) the information of the first glyph is extracted 2) it is compared to itself, which never fails 3) then to the following glyphs are handled We can just skip the first iteration which make the code a bit easier to read and hopefully a tiny-little-bit faster :) 480659 1 110290 benjamin 2011-10-08 22:38:13 -0700 Created attachment 110290 Patch 480682 2 110290 kling 2011-10-09 01:55:51 -0700 Comment on attachment 110290 Patch r=me 480687 3 110290 webkit.review.bot 2011-10-09 02:59:17 -0700 Comment on attachment 110290 Patch Clearing flags on attachment: 110290 Committed r97023: <http://trac.webkit.org/changeset/97023> 480688 4 webkit.review.bot 2011-10-09 02:59:21 -0700 All reviewed patches have been landed. Closing bug. 110290 2011-10-08 22:38:13 -0700 2011-10-09 02:59:17 -0700 Patch bug-69715-20111008223812.patch text/plain 1755 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTcwMTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDNkN2U4NjczNTlmZjQ0 NmJkNzMxNGVhODkyMTJkZGVmOGUxYjRjLi5jNTE4MDAzYWE5YmRmOWZlNTUxMmNhYjg2MjYwMDY5 YWJhY2M3Yzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMDggIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIERvIG5vdCBjb21w YXJlIHRoZSBmaXJzdCBnbHlwaCB0byBpdHNlbGYgaW4gRm9udDo6ZHJhd0dseXBoQnVmZmVyKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NzE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBsb29r aW5nIGZvciBnbHlwaHMgd2l0aCBzaW1pbGFyIHByb3BlcnRpZXMsIHdlIHNob3VsZAorICAgICAg ICBza2lwIHRoZSBmaXJzdCBvbmUgc2luY2UgdGhlIGNvbXBhcmlzb24gb2YgZm9udERhdGEgCisg ICAgICAgIGFuZCBvZmZzZXQgd2lsbCBhbHdheXMgZmFpbC4KKworICAgICAgICBUaGlzIGlzIGNv dmVyZWQgYnkgdGhlIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvRm9udEZhc3RQYXRoLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRyYXdHbHlwaEJ1 ZmZlcik6CisKIDIwMTEtMTAtMDggIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgTWFrZSBUaHJlYWRHbG9iYWxEYXRhIG1lbWJlcnMgdXNlIE93blB0cgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQYXRoLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYXN0UGF0aC5jcHAKaW5k ZXggZTUyNjI0MmFmYTNkNmVmNGM2ZTE1YjE2ZDFiY2E3NDZiMDZjYWMxZC4uMDJiNjk1YjFjN2Qz YjQ2NzFkODA2YjI4YjM1ZTc2NzA2ZDE5OGFhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQYXRoLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Gb250RmFzdFBhdGguY3BwCkBAIC0zODMsOSArMzgzLDkgQEAgdm9p ZCBGb250OjpkcmF3R2x5cGhCdWZmZXIoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBU ZXh0UnVuJiBydW4sIGNvbnN0IEcKICAgICBjb25zdCBTaW1wbGVGb250RGF0YSogZm9udERhdGEg PSBnbHlwaEJ1ZmZlci5mb250RGF0YUF0KDApOwogICAgIEZsb2F0U2l6ZSBvZmZzZXQgPSBnbHlw aEJ1ZmZlci5vZmZzZXRBdCgwKTsKICAgICBGbG9hdFBvaW50IHN0YXJ0UG9pbnQocG9pbnQpOwot ICAgIGZsb2F0IG5leHRYID0gc3RhcnRQb2ludC54KCk7CisgICAgZmxvYXQgbmV4dFggPSBzdGFy dFBvaW50LngoKSArIGdseXBoQnVmZmVyLmFkdmFuY2VBdCgwKTsKICAgICBpbnQgbGFzdEZyb20g PSAwOwotICAgIGludCBuZXh0R2x5cGggPSAwOworICAgIGludCBuZXh0R2x5cGggPSAxOwogI2lm IEVOQUJMRShTVkdfRk9OVFMpCiAgICAgVGV4dFJ1bjo6UmVuZGVyaW5nQ29udGV4dCogcmVuZGVy aW5nQ29udGV4dCA9IHJ1bi5yZW5kZXJpbmdDb250ZXh0KCk7CiAjZW5kaWYK