69713 2011-10-08 18:48:42 -0700 run-webkit-tests should accept --child-processes 2011-10-15 17:17:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dpranke eric webkit.review.bot oldest_to_newest 480648 0 ojan 2011-10-08 18:48:42 -0700 It lists --child-processes as a valid commandline argument, but it always creates 1 process. I think this is a regression. It's fine to default to 1, but if you pass the flag, it should respect it. I had noticed recently the run-webkit-tests was taking forever even when I'd run with multiple child processes. I expect I might not be the only one surprised by this. 480714 1 eric 2011-10-09 08:55:38 -0700 That would be an odd regression. I'll look on monday, now that I'm done with the CSS regression stuff. If you run "new-run-webkit-tests" directly does child-processes work as you expect? the "run-webkit-tests" wrapper overrides --child-process to 1. 480777 2 ojan 2011-10-09 19:07:25 -0700 It works correctly if I just new-run-webkit-tests directly. 480861 3 eric 2011-10-10 00:37:03 -0700 OK. Should be easy to teach the wrapper to avoid overriding you. But we could also mark this wontfix. I'm working on NRWT again as of tomorrow. Done with CSS regression distractions. 484658 4 111151 ojan 2011-10-15 15:14:28 -0700 Created attachment 111151 Patch 484659 5 ojan 2011-10-15 15:15:22 -0700 Sorry if this perl is crap. I bet there's a simple one-liner for this. I'm just a perl noob. 484669 6 111151 abarth 2011-10-15 15:56:37 -0700 Comment on attachment 111151 Patch Check out usingWebKit2() and usingLeaks() for some ideas about how to do this more compactly. 484671 7 111153 ojan 2011-10-15 16:09:01 -0700 Created attachment 111153 Patch 484679 8 111153 webkit.review.bot 2011-10-15 17:17:34 -0700 Comment on attachment 111153 Patch Clearing flags on attachment: 111153 Committed r97567: <http://trac.webkit.org/changeset/97567> 484680 9 webkit.review.bot 2011-10-15 17:17:38 -0700 All reviewed patches have been landed. Closing bug. 111151 2011-10-15 15:14:28 -0700 2011-10-15 16:08:58 -0700 Patch bug-69713-20111015151426.patch text/plain 1784 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NjQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NGRkM2RlYjBhZGFhOTdlOTk4ZWFkYTU0ODExNzFhODk5 ZTYwZjI0Li45NGMxNWZmNjU0YWNiNzlmNTI2YTM0NmU1ZWY3ZDYzZTU0OGE4OGMzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg ICBydW4td2Via2l0LXRlc3RzIHNob3VsZCBhY2NlcHQgLS1jaGlsZC1wcm9jZXNzZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NzEzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBzZXQgLS1jaGls ZC1wcm9jZXNzZXM9MSBpZiAtLWNoaWxkLXByb2Nlc3NlcyBpdCBub3QKKyAgICAgICAgcGFzc2Vk IG9uIHRoZSBjb21tYW5kbGluZS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0 czoKKwogMjAxMS0xMC0xNSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgRXh0cmFjdCBjb21tb24gZ2RiIGNvZGUgaW50byBpdHMgb3duIGZ1bmN0aW9uOyBSZW1v dmUgc2NyaXB0IGdkYi1zYWZhcmkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwppbmRleCBkNDQyN2RlOWYw YWY5OTMyYTUyNDcxMTM3NjljNTgyMGNhZDMzNjYyLi4yMzE3MTI3MDI5OTZiNDdlZjcwMzY1ZjY2 N2E1ZmUyMjUzZTI1MTExIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBAIC05Nyw5ICs5NywyMSBA QCBteSAkaGFybmVzc05hbWUgPSAib2xkLXJ1bi13ZWJraXQtdGVzdHMiOwogCiBpZiAodXNlTmV3 UnVuV2ViS2l0VGVzdHMoKSkgewogICAgICRoYXJuZXNzTmFtZSA9ICJuZXctcnVuLXdlYmtpdC10 ZXN0cyI7Ci0gICAgcHVzaChAQVJHViwgIi0tY2hpbGQtcHJvY2Vzc2VzPTEiKTsKLSAgICBwcmlu dCAiUnVubmluZyBuZXctcnVuLXdlYmtpdC10ZXN0cyB3aXRoIG9uZSBjaGlsZCBwcm9jZXNzLlxu IjsKLSAgICBwcmludCAiRm9yIG1vcmUgcGFyYWxsZWxpc20sIHJ1biBuZXctcnVuLXdlYmtpdC10 ZXN0cyBkaXJlY3RseS5cbiI7CisKKyAgICBteSAkaGFzQ2hpbGRQcm9jZXNzZXMgPSAwOworICAg IG15ICRhcmdudW07CisgICAgZm9yZWFjaCAkYXJnbnVtICgwIC4uICQjQVJHVikgeworICAgICAg ICBpZiAoJEFSR1ZbJGFyZ251bV0gPX4gbS9eLS1jaGlsZC1wcm9jZXNzZXMvKSB7CisgICAgICAg ICAgICAkaGFzQ2hpbGRQcm9jZXNzZXMgPSAxOworICAgICAgICB9CisgICAgfQorCisgICAgaWYg KCEkaGFzQ2hpbGRQcm9jZXNzZXMpIHsKKyAgICAgICAgcHVzaChAQVJHViwgIi0tY2hpbGQtcHJv Y2Vzc2VzPTEiKTsKKyAgICAgICAgcHJpbnQgIlJ1bm5pbmcgbmV3LXJ1bi13ZWJraXQtdGVzdHMg d2l0aCBvbmUgY2hpbGQgcHJvY2Vzcy5cbiI7CisgICAgICAgIHByaW50ICJGb3IgbW9yZSBwYXJh bGxlbGlzbSwgcnVuIG5ldy1ydW4td2Via2l0LXRlc3RzIGRpcmVjdGx5LlxuIjsKKyAgICB9CisK ICAgICBpZiAocnVubmluZ09uQnVpbGRCb3QoKSkgewogICAgICAgICBwdXNoKEBBUkdWLCAiLS12 ZXJib3NlIik7CiAgICAgfQo= 111153 2011-10-15 16:09:01 -0700 2011-10-15 17:17:33 -0700 Patch bug-69713-20111015160900.patch text/plain 1599 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTc1NjQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NGRkM2RlYjBhZGFhOTdlOTk4ZWFkYTU0ODExNzFhODk5 ZTYwZjI0Li45NGMxNWZmNjU0YWNiNzlmNTI2YTM0NmU1ZWY3ZDYzZTU0OGE4OGMzIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg ICBydW4td2Via2l0LXRlc3RzIHNob3VsZCBhY2NlcHQgLS1jaGlsZC1wcm9jZXNzZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NzEzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBzZXQgLS1jaGls ZC1wcm9jZXNzZXM9MSBpZiAtLWNoaWxkLXByb2Nlc3NlcyBpdCBub3QKKyAgICAgICAgcGFzc2Vk IG9uIHRoZSBjb21tYW5kbGluZS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0 czoKKwogMjAxMS0xMC0xNSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgRXh0cmFjdCBjb21tb24gZ2RiIGNvZGUgaW50byBpdHMgb3duIGZ1bmN0aW9uOyBSZW1v dmUgc2NyaXB0IGdkYi1zYWZhcmkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwppbmRleCBkNDQyN2RlOWYw YWY5OTMyYTUyNDcxMTM3NjljNTgyMGNhZDMzNjYyLi40ZDAxZTY3MTUwYjRkNjBlMzc4MmNmMmFk OTRiYWVmN2NkNTNiZDFhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBAIC05Nyw5ICs5NywxMyBA QCBteSAkaGFybmVzc05hbWUgPSAib2xkLXJ1bi13ZWJraXQtdGVzdHMiOwogCiBpZiAodXNlTmV3 UnVuV2ViS2l0VGVzdHMoKSkgewogICAgICRoYXJuZXNzTmFtZSA9ICJuZXctcnVuLXdlYmtpdC10 ZXN0cyI7Ci0gICAgcHVzaChAQVJHViwgIi0tY2hpbGQtcHJvY2Vzc2VzPTEiKTsKLSAgICBwcmlu dCAiUnVubmluZyBuZXctcnVuLXdlYmtpdC10ZXN0cyB3aXRoIG9uZSBjaGlsZCBwcm9jZXNzLlxu IjsKLSAgICBwcmludCAiRm9yIG1vcmUgcGFyYWxsZWxpc20sIHJ1biBuZXctcnVuLXdlYmtpdC10 ZXN0cyBkaXJlY3RseS5cbiI7CisKKyAgICBpZiAoIWdyZXAoLy0tY2hpbGQtcHJvY2Vzc2VzLywg QEFSR1YpKSB7CisgICAgICAgIHB1c2goQEFSR1YsICItLWNoaWxkLXByb2Nlc3Nlcz0xIik7Cisg ICAgICAgIHByaW50ICJSdW5uaW5nIG5ldy1ydW4td2Via2l0LXRlc3RzIHdpdGggb25lIGNoaWxk IHByb2Nlc3MuXG4iOworICAgICAgICBwcmludCAiRm9yIG1vcmUgcGFyYWxsZWxpc20sIHJ1biBu ZXctcnVuLXdlYmtpdC10ZXN0cyBkaXJlY3RseS5cbiI7CisgICAgfQorCiAgICAgaWYgKHJ1bm5p bmdPbkJ1aWxkQm90KCkpIHsKICAgICAgICAgcHVzaChAQVJHViwgIi0tdmVyYm9zZSIpOwogICAg IH0K