69702 2011-10-08 07:50:13 -0700 JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot 2011-10-08 13:39:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 480551 0 yuqiang.xian 2011-10-08 07:50:13 -0700 There are some errors in generating code for Branch and LogicalNot, when the operand is predicted as ObjectOrOther. This fix together with another uncommitted bug #69699 make the JSVALUE32_64 DFG JIT pass the JavaScriptCore tests with op_call/op_construct supports turned on (i.e. on Linux ia32 they both have 57/1127 failure rate). 480552 1 110271 yuqiang.xian 2011-10-08 07:54:55 -0700 Created attachment 110271 the patch 480593 2 110271 fpizlo 2011-10-08 12:36:06 -0700 Comment on attachment 110271 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=110271&action=review > Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:560 > speculationCheck(m_jit.branch32(MacroAssembler::NotEqual, valueTagGPR, TrustedImm32(JSValue::UndefinedTag))); It's sad that we need two branches here. :-( But I think that we can optimize this later; more important is that your version is safer and more likely to be correct. 480612 3 110271 webkit.review.bot 2011-10-08 13:39:09 -0700 Comment on attachment 110271 the patch Clearing flags on attachment: 110271 Committed r97013: <http://trac.webkit.org/changeset/97013> 480613 4 webkit.review.bot 2011-10-08 13:39:14 -0700 All reviewed patches have been landed. Closing bug. 110271 2011-10-08 07:54:55 -0700 2011-10-08 13:39:09 -0700 the patch 69702.patch text/plain 2857 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMDkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMTAtMDggIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBCdWcgZml4ZXMgZm9yIEJyYW5jaCBhbmQgTG9n aWNhbE5vdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Njk3MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGVyZSBhcmUgc29tZSBlcnJvcnMgaW4gZ2VuZXJhdGluZyBjb2RlIGZvciBCcmFuY2ggYW5kIExv Z2ljYWxOb3QsCisgICAgICAgIHdoZW4gdGhlIG9wZXJhbmQgaXMgcHJlZGljdGVkIGFzIE9iamVj dE9yT3RoZXIuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6Cisg ICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVPYmplY3RPck90aGVyTG9n aWNhbE5vdCk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRPYmplY3RP ck90aGVyQnJhbmNoKToKKwogMjAxMS0xMC0wOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk2OTk2 LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiA5NzAwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1Miwx NSArNDUyLDE3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVPYmplY3RPck90aGUKICAg ICAKICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBub3RDZWxsID0gbV9qaXQuYnJhbmNoMzIoTWFj cm9Bc3NlbWJsZXI6Ok5vdEVxdWFsLCB2YWx1ZVRhZ0dQUiwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6 OkNlbGxUYWcpKTsKICAgICBzcGVjdWxhdGlvbkNoZWNrKG1faml0LmJyYW5jaFB0cihNYWNyb0Fz c2VtYmxlcjo6Tm90RXF1YWwsIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHZhbHVlUGF5bG9hZEdQ UiksIE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tUHRyKHZwdHIpKSk7Ci0gICAgbV9qaXQubW92 ZShUcnVzdGVkSW1tMzIoMSksIHJlc3VsdFBheWxvYWRHUFIpOworICAgIG1faml0Lm1vdmUoVHJ1 c3RlZEltbTMyKDApLCByZXN1bHRQYXlsb2FkR1BSKTsKICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVt cCBkb25lID0gbV9qaXQuanVtcCgpOwogICAgIAogICAgIG5vdENlbGwubGluaygmbV9qaXQpOwot ICAgIAotICAgIG1faml0Lm1vdmUodmFsdWVUYWdHUFIsIHJlc3VsdFBheWxvYWRHUFIpOwotICAg IG1faml0LmFuZDMyKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZp bmVkVGFnKSwgcmVzdWx0UGF5bG9hZEdQUik7Ci0gICAgc3BlY3VsYXRpb25DaGVjayhtX2ppdC5i cmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIHJlc3VsdFBheWxvYWRHUFIsIFRydXN0 ZWRJbW0zMihKU1ZhbHVlOjpVbmRlZmluZWRUYWcpKSk7Ci0gICAgbV9qaXQubW92ZShUcnVzdGVk SW1tMzIoMCksIHJlc3VsdFBheWxvYWRHUFIpOworIAorICAgIE1hY3JvQXNzZW1ibGVyOjpKdW1w IGlzTnVsbCA9IG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpFcXVhbCwgdmFsdWVUYWdH UFIsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpOdWxsVGFnKSk7CisgICAgc3BlY3VsYXRpb25DaGVj ayhtX2ppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIHZhbHVlVGFnR1BSLCBU cnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFnKSkpOworCisgICAgaXNOdWxsLmxpbmso Jm1faml0KTsKKworICAgIG1faml0Lm1vdmUoVHJ1c3RlZEltbTMyKDEpLCByZXN1bHRQYXlsb2Fk R1BSKTsKICAgICAKICAgICBkb25lLmxpbmsoJm1faml0KTsKICAgICAKQEAgLTU1NCw4ICs1NTYs MTEgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdE9iamVjdE9yT3RoZXJCcgogICAgIAogICAg IG5vdENlbGwubGluaygmbV9qaXQpOwogICAgIAotICAgIG1faml0LmFuZDMyKE1hY3JvQXNzZW1i bGVyOjpUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFnKSwgdmFsdWVUYWdHUFIpOwor ICAgIE1hY3JvQXNzZW1ibGVyOjpKdW1wIGlzTnVsbCA9IG1faml0LmJyYW5jaDMyKE1hY3JvQXNz ZW1ibGVyOjpFcXVhbCwgdmFsdWVUYWdHUFIsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpOdWxsVGFn KSk7CiAgICAgc3BlY3VsYXRpb25DaGVjayhtX2ppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6 Tm90RXF1YWwsIHZhbHVlVGFnR1BSLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6VW5kZWZpbmVkVGFn KSkpOworCisgICAgaXNOdWxsLmxpbmsoJm1faml0KTsKKwogICAgIGlmIChub3RUYWtlbiAhPSAo bV9ibG9jayArIDEpKQogICAgICAgICBhZGRCcmFuY2gobV9qaXQuanVtcCgpLCBub3RUYWtlbik7 CiAgICAgCg==