69699 2011-10-08 05:52:36 -0700 JSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions 2011-10-08 13:41:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 480540 0 yuqiang.xian 2011-10-08 05:52:36 -0700 It should match SetLocal where only payload is stored for array predictions. 480542 1 110269 yuqiang.xian 2011-10-08 05:58:55 -0700 Created attachment 110269 the patch 480594 2 110269 fpizlo 2011-10-08 12:37:28 -0700 Comment on attachment 110269 the patch Looks good! 480614 3 110269 webkit.review.bot 2011-10-08 13:41:19 -0700 Comment on attachment 110269 the patch Clearing flags on attachment: 110269 Committed r97014: <http://trac.webkit.org/changeset/97014> 480615 4 webkit.review.bot 2011-10-08 13:41:23 -0700 All reviewed patches have been landed. Closing bug. 110269 2011-10-08 05:58:55 -0700 2011-10-08 13:41:19 -0700 the patch 69699.patch text/plain 2583 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTcwMDcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMTAtMDggIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgSlNWQUxVRTMyXzY0IERGRyBKSVQgLSBHZXRMb2NhbCBzaG91bGQgcHJvZHVjZSBhIGNl bGwgcmVzdWx0IGZvciBBcnJheSBwcmVkaWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzaG91bGQgbWF0Y2ggU2V0TG9jYWwgd2hlcmUgb25s eSBwYXlsb2FkIGlzIHN0b3JlZCBmb3IgYXJyYXkgcHJlZGljdGlvbnMuCisKKyAgICAgICAgKiBk ZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3Vs YXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDExLTEwLTA4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy OTY5OTYuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklU MzJfNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDk3MDA3KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjU3LDYgKzY1NywxNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUp CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCisgICAgICAgIGlmIChpc0FycmF5UHJl ZGljdGlvbihwcmVkaWN0aW9uKSkgeworICAgICAgICAgICAgbV9qaXQubG9hZDMyKEpJVENvbXBp bGVyOjpwYXlsb2FkRm9yKG5vZGUubG9jYWwoKSksIHJlc3VsdC5ncHIoKSk7CisKKyAgICAgICAg ICAgIC8vIExpa2UgY2VsbFJlc3VsdCwgYnV0IGRvbid0IHVzZUNoaWxkcmVuIC0gb3VyIGNoaWxk cmVuIGFyZSBwaGkgbm9kZXMsCisgICAgICAgICAgICAvLyBhbmQgZG9uJ3QgcmVwcmVzZW50IHZh bHVlcyB3aXRoaW4gdGhpcyBkYXRhZmxvdyB3aXRoIHZpcnR1YWwgcmVnaXN0ZXJzLgorICAgICAg ICAgICAgVmlydHVhbFJlZ2lzdGVyIHZpcnR1YWxSZWdpc3RlciA9IG5vZGUudmlydHVhbFJlZ2lz dGVyKCk7CisgICAgICAgICAgICBtX2dwcnMucmV0YWluKHJlc3VsdC5ncHIoKSwgdmlydHVhbFJl Z2lzdGVyLCBTcGlsbE9yZGVySW50ZWdlcik7CisgICAgICAgICAgICBtX2dlbmVyYXRpb25JbmZv W3ZpcnR1YWxSZWdpc3Rlcl0uaW5pdENlbGwobV9jb21waWxlSW5kZXgsIG5vZGUucmVmQ291bnQo KSwgcmVzdWx0LmdwcigpKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisKICAgICAg ICAgR1BSVGVtcG9yYXJ5IHRhZyh0aGlzKTsKICAgICAgICAgbV9qaXQubG9hZDMyKEpJVENvbXBp bGVyOjpwYXlsb2FkRm9yKG5vZGUubG9jYWwoKSksIHJlc3VsdC5ncHIoKSk7CiAgICAgICAgIG1f aml0LmxvYWQzMihKSVRDb21waWxlcjo6dGFnRm9yKG5vZGUubG9jYWwoKSksIHRhZy5ncHIoKSk7 CkBAIC02NjcsMTQgKzY3OCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYg bm9kZSkKICAgICAgICAgbV9ncHJzLnJldGFpbihyZXN1bHQuZ3ByKCksIHZpcnR1YWxSZWdpc3Rl ciwgU3BpbGxPcmRlckpTKTsKICAgICAgICAgbV9ncHJzLnJldGFpbih0YWcuZ3ByKCksIHZpcnR1 YWxSZWdpc3RlciwgU3BpbGxPcmRlckpTKTsKIAotICAgICAgICBEYXRhRm9ybWF0IGZvcm1hdDsK LSAgICAgICAgaWYgKGlzQXJyYXlQcmVkaWN0aW9uKHByZWRpY3Rpb24pKQotICAgICAgICAgICAg Zm9ybWF0ID0gRGF0YUZvcm1hdEpTQ2VsbDsKLSAgICAgICAgZWxzZSBpZiAoaXNCb29sZWFuUHJl ZGljdGlvbihwcmVkaWN0aW9uKSkKLSAgICAgICAgICAgIGZvcm1hdCA9IERhdGFGb3JtYXRKU0Jv b2xlYW47Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGZvcm1hdCA9IERhdGFGb3JtYXRKUzsK LQorICAgICAgICBEYXRhRm9ybWF0IGZvcm1hdCA9IGlzQm9vbGVhblByZWRpY3Rpb24ocHJlZGlj dGlvbikgPyBEYXRhRm9ybWF0SlNCb29sZWFuIDogRGF0YUZvcm1hdEpTOwogICAgICAgICBtX2dl bmVyYXRpb25JbmZvW3ZpcnR1YWxSZWdpc3Rlcl0uaW5pdEpTVmFsdWUobV9jb21waWxlSW5kZXgs IG5vZGUucmVmQ291bnQoKSwgdGFnLmdwcigpLCByZXN1bHQuZ3ByKCksIGZvcm1hdCk7CiAgICAg ICAgIGJyZWFrOwogICAgIH0K