69692 2011-10-07 21:19:59 -0700 [File API] URL methods required arguments 2023-07-14 15:37:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 pilgrim webkit-unassigned abarth annevk ericu ossy rniwa webkit.review.bot oldest_to_newest 480468 0 pilgrim 2011-10-07 21:19:59 -0700 According to http://dev.w3.org/2006/webapi/FileAPI/#creating-revoking , the URL object has two methods, each of which as a required parameter: createObjectURL(blob) revokeObjectURL(url) This test calls those methods without the required parameter, and logs the results. WebKit passes this test. 480469 1 110252 pilgrim 2011-10-07 21:20:54 -0700 Created attachment 110252 Patch 484507 2 110252 webkit.review.bot 2011-10-15 00:02:50 -0700 Comment on attachment 110252 Patch Clearing flags on attachment: 110252 Committed r97544: <http://trac.webkit.org/changeset/97544> 484508 3 webkit.review.bot 2011-10-15 00:02:54 -0700 All reviewed patches have been landed. Closing bug. 484822 4 ossy 2011-10-16 14:30:53 -0700 This test fails on Qt and on SL bot: --- /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-expected.txt +++ /Volumes/Big/slave/snowleopard-intel-debug-tests/build/layout-test-results/fast/files/url-required-arguments-actual.txt @@ -2,7 +2,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS webkitURL.createObjectURL() threw exception TypeError: Type error. +PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments. PASS webkitURL.revokeObjectURL() threw exception TypeError: Not enough arguments. PASS successfullyParsed is true Is it a JSC vs. V8 difference problem? As far as I remember in this case JSC result should be the platform independent result and the V8 result should platform specific. Reopen to fix expected results. 484823 5 abarth 2011-10-16 14:34:14 -0700 -PASS webkitURL.createObjectURL() threw exception TypeError: Type error. +PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments. Not enough arguments is the correct text of the exception. We should change V8 to match JSC. @Mark: Would you like to take care of this, or should I? 484824 6 ossy 2011-10-16 14:38:01 -0700 I added a Qt specific expected file to make the buildbot green. Please remove it with the proper fix. Thanks in advance. 485251 7 rniwa 2011-10-17 10:25:14 -0700 Moved JSC results to cross-platform dir. and then moved V8 specific results to platform/chromium. http://trac.webkit.org/changeset/97632 1966820 8 annevk 2023-07-14 15:37:15 -0700 Seems this was only applicable to V8. 110252 2011-10-07 21:20:54 -0700 2011-10-15 00:02:50 -0700 Patch bug-69692-20111008002115.patch text/plain 2064 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk3MDAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDcgIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtGaWxlIEFQSV0gVVJMIG1ldGhvZHMgcmVx dWlyZWQgYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02OTY5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9maWxlcy91cmwtcmVxdWlyZWQtYXJndW1lbnRzLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogZmFzdC9maWxlcy91cmwtcmVxdWlyZWQtYXJndW1lbnRzLmh0bWw6 IEFkZGVkLgorCiAyMDExLTEwLTA3ICBKdXN0aW4gU2NodWggIDxqc2NodWhAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIE1ha2UgaXNYTUxNSU1FVHlwZSByZWdleCB1c2UgVExTCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2ZpbGVzL3VybC1yZXF1aXJlZC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZmlsZXMvdXJsLXJlcXVpcmVkLWFyZ3VtZW50 cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3Vy bC1yZXF1aXJlZC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDEwIEBACitUZXN0IHJlcXVpcmVkIGFyZ3VtZW50cyBvZiBVUkwgb2JqZWN0LgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKK1BBU1Mgd2Via2l0VVJMLmNyZWF0ZU9iamVjdFVSTCgpIHRo cmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IFR5cGUgZXJyb3IuCitQQVNTIHdlYmtpdFVSTC5yZXZv a2VPYmplY3RVUkwoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3Vt ZW50cy4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3VybC1yZXF1aXJlZC1hcmd1bWVudHMuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3VybC1yZXF1aXJlZC1hcmd1 bWVudHMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZmlsZXMvdXJsLXJl cXVpcmVkLWFyZ3VtZW50cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIwIEBACis8IURP Q1RZUEUgSFRNTD4KKzxodG1sPgorIDxoZWFkPgorICAgIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIg aHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKyAgICA8c2NyaXB0IHNy Yz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyA8L2hlYWQ+Cisg PGJvZHk+CisgICAgPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorICAgIDxkaXYgaWQ9ImNv bnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0IHJlcXVpcmVkIGFyZ3Vt ZW50cyBvZiBVUkwgb2JqZWN0LiIpOworCitzaG91bGRUaHJvdygid2Via2l0VVJMLmNyZWF0ZU9i amVjdFVSTCgpIik7CitzaG91bGRUaHJvdygid2Via2l0VVJMLnJldm9rZU9iamVjdFVSTCgpIik7 Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+CisgICAgPHNjcmlw dCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorIDwvYm9k eT4KKzwvaHRtbD4K