69671 2011-10-07 14:40:26 -0700 Support string indexing in the DFG 2011-10-07 15:11:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 480319 0 oliver 2011-10-07 14:40:26 -0700 Support string indexing in the DFG 480334 1 110222 oliver 2011-10-07 15:03:24 -0700 Created attachment 110222 Patch 480336 2 110222 barraclough 2011-10-07 15:07:15 -0700 Comment on attachment 110222 Patch You should let msaboff know that this will conflict with his 8/16 bit string changes, he will now also need to fix the DFG JIT. 480340 3 oliver 2011-10-07 15:11:01 -0700 Committed r96983: <http://trac.webkit.org/changeset/96983> 110222 2011-10-07 15:03:24 -0700 2011-10-07 15:07:15 -0700 Patch bug-69671-20111007150323.patch text/plain 6603 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogOTY5ODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDI3 ZTNhYmQxYTY5YTcxZDNhYTM0YTk1MzRjODJlNDY0MzY4MTYyMjEuLjc1NTY3N2ExODA5MmYzNzFj MmVjMzE2OWZlM2ExNjc0YzIzNjI0YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI2IEBACisyMDExLTEwLTA3ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgU3VwcG9ydCBzdHJpbmcgaW5kZXhpbmcgaW4gdGhlIERGRworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2NzEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbWl0IGNvZGUgdG8gc3VwcG9ydCBp bmxpbmUgaW5kZXhpbmcgb2Ygc3RyaW5ncyAKKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVHZXRC eVZhbE9uU3RyaW5nKToKKyAgICAgICAgICAgIFNoYXJlZCBjb2RlIHRvIHBlcmZvcm0gc3RyaW5n IGluZGV4aW5nLgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oOgorICAgICAgICAq IGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKyAgICAg ICAgICAgIFVzZSBjb21waWxlR2V0QnlWYWxPblN0cmluZyBpZiB3ZSBwcmVkaWN0IHRoYXQgdGhl IGJhc2Ugb2JqZWN0CisgICAgICAgICAgICBpcyBhIHN0cmluZyBpbiBHZXRCeVZhbC4KKyAgICAg ICAgKiBydW50aW1lL0pTU3RyaW5nLmg6CisgICAgICAgIChKU0M6OkpTU3RyaW5nOjpvZmZzZXRP ZkZpYmVyQ291bnQpOgorICAgICAgICAoSlNDOjpKU1N0cmluZzo6b2Zmc2V0T2ZWYWx1ZSk6CisK IDIwMTEtMTAtMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBE RkcgQ29udmVydFRoaXMgc3BlY3VsYXRpb24gbG9naWMgaXMgd3JvbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAKaW5kZXggYjNiNWQxNjA2OWVi NTMyMDUwMmJlNjRkMDg0MzMxNDZiMWU5MzAzYS4uYjViN2M3YmJmZDA4N2Y1MWY0MzczZjAxZDUx ZjA0YmNkNzYyZjIyZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVC5jcHAKQEAgLTUyOCw2ICs1MjgsNDIgQEAgVmFsdWVSZWNvdmVyeSBTcGVjdWxh dGl2ZUpJVDo6Y29tcHV0ZVZhbHVlUmVjb3ZlcnlGb3IoY29uc3QgVmFsdWVTb3VyY2UmIHZhbHVl U28KICAgICB9CiB9CiAKK3ZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVHZXRCeVZhbE9uU3Ry aW5nKE5vZGUmIG5vZGUpCit7CisgICAgQVNTRVJUKG5vZGUuY2hpbGQzKCkgPT0gTm9Ob2RlKTsK KyAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBiYXNlKHRoaXMsIG5vZGUuY2hpbGQxKCkpOworICAg IFNwZWN1bGF0ZVN0cmljdEludDMyT3BlcmFuZCBwcm9wZXJ0eSh0aGlzLCBub2RlLmNoaWxkMigp KTsKKyAgICAKKyAgICBHUFJSZWcgYmFzZVJlZyA9IGJhc2UuZ3ByKCk7CisgICAgR1BSUmVnIHBy b3BlcnR5UmVnID0gcHJvcGVydHkuZ3ByKCk7CisKKyAgICBpZiAoIWlzS25vd25TdHJpbmcobm9k ZS5jaGlsZDEoKSkpCisgICAgICAgIHNwZWN1bGF0aW9uQ2hlY2sobV9qaXQuYnJhbmNoUHRyKE1h Y3JvQXNzZW1ibGVyOjpOb3RFcXVhbCwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoYmFzZVJlZyks IE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tUHRyKG1faml0Lmdsb2JhbERhdGEoKS0+anNTdHJp bmdWUHRyKSkpOworCisgICAgLy8gdW5zaWduZWQgY29tcGFyaXNvbiBzbyB3ZSBjYW4gZmlsdGVy IG91dCBuZWdhdGl2ZSBpbmRpY2VzIGFuZCBpbmRpY2VzIHRoYXQgYXJlIHRvbyBsYXJnZQorICAg IHNwZWN1bGF0aW9uQ2hlY2sobV9qaXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6OkFib3ZlT3JF cXVhbCwgcHJvcGVydHlSZWcsIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJhc2VSZWcsIEpTU3Ry aW5nOjpvZmZzZXRPZkxlbmd0aCgpKSkpOworCisgICAgLy8gU3BlY3VsYXRlIHRoYXQgd2UncmUg bm90IGFjY2Vzc2luZyBhIHJvcGUKKyAgICBzcGVjdWxhdGlvbkNoZWNrKG1faml0LmJyYW5jaFRl c3QzMihNYWNyb0Fzc2VtYmxlcjo6Tm9uWmVybywgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoYmFz ZVJlZywgSlNTdHJpbmc6Om9mZnNldE9mRmliZXJDb3VudCgpKSkpOworICAgIAorICAgIEdQUlRl bXBvcmFyeSBzY3JhdGNoKHRoaXMpOworICAgIEdQUlJlZyBzY3JhdGNoUmVnID0gc2NyYXRjaC5n cHIoKTsKKyAgICAKKyAgICAvLyBMb2FkIHRoZSBjaGFyYWN0ZXIgaW50byBzY3JhdGNoUmVnCisg ICAgbV9qaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlUmVnLCBKU1N0cmlu Zzo6b2Zmc2V0T2ZWYWx1ZSgpKSwgc2NyYXRjaFJlZyk7CisgICAgbV9qaXQubG9hZFB0cihNYWNy b0Fzc2VtYmxlcjo6QWRkcmVzcyhzY3JhdGNoUmVnLCBTdHJpbmdJbXBsOjpkYXRhT2Zmc2V0KCkp LCBzY3JhdGNoUmVnKTsKKyAgICBtX2ppdC5sb2FkMTYoTWFjcm9Bc3NlbWJsZXI6OkJhc2VJbmRl eChzY3JhdGNoUmVnLCBwcm9wZXJ0eVJlZywgTWFjcm9Bc3NlbWJsZXI6OlRpbWVzVHdvLCAwKSwg c2NyYXRjaFJlZyk7CisKKyAgICAvLyBXZSBvbmx5IHN1cHBvcnQgYXNjaWkgY2hhcmFjdGVycwor ICAgIHNwZWN1bGF0aW9uQ2hlY2sobV9qaXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6OkFib3Zl T3JFcXVhbCwgc2NyYXRjaFJlZywgVHJ1c3RlZEltbTMyKDB4MTAwKSkpOworICAgIEdQUlRlbXBv cmFyeSBzbWFsbFN0cmluZ3ModGhpcyk7CisgICAgR1BSUmVnIHNtYWxsU3RyaW5nc1JlZyA9IHNt YWxsU3RyaW5ncy5ncHIoKTsKKyAgICBtX2ppdC5tb3ZlKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVk SW1tUHRyKG1faml0Lmdsb2JhbERhdGEoKS0+c21hbGxTdHJpbmdzLnNpbmdsZUNoYXJhY3RlclN0 cmluZ3MoKSksIHNtYWxsU3RyaW5nc1JlZyk7CisgICAgbV9qaXQubG9hZFB0cihNYWNyb0Fzc2Vt Ymxlcjo6QmFzZUluZGV4KHNtYWxsU3RyaW5nc1JlZywgc2NyYXRjaFJlZywgTWFjcm9Bc3NlbWJs ZXI6OlNjYWxlUHRyLCAwKSwgc2NyYXRjaFJlZyk7CisgICAgc3BlY3VsYXRpb25DaGVjayhtX2pp dC5icmFuY2hUZXN0MzIoTWFjcm9Bc3NlbWJsZXI6Olplcm8sIHNjcmF0Y2hSZWcpKTsKKyAgICBj ZWxsUmVzdWx0KHNjcmF0Y2hSZWcsIG1fY29tcGlsZUluZGV4KTsKK30KKwogfSB9IC8vIG5hbWVz cGFjZSBKU0M6OkRGRwogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuaAppbmRleCAzMGZkZmMyZDVkMzBkMzhmNmYxYmYxNjBmN2FhMzkxNGM5 ZDg3ZDRjLi4yNjkwMWIzNDdhZmMyMzhhNWJhMDQzNDJhOWYxNDUzMmIwZjEyN2I1IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCkBAIC00NTYsNiAr NDU2LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIGVtaXRPYmplY3RPck90aGVyQnJhbmNoKE5vZGVJ bmRleCB2YWx1ZSwgQmxvY2tJbmRleCB0YWtlbiwgQmxvY2tJbmRleCBub3RUYWtlbiwgdm9pZCAq dnB0cik7CiAgICAgdm9pZCBlbWl0QnJhbmNoKE5vZGUmKTsKICAgICAKKyAgICB2b2lkIGNvbXBp bGVHZXRCeVZhbE9uU3RyaW5nKE5vZGUmKTsKKyAgICAKICAgICAvLyBJdCBpcyBhY2NlcHRhYmxl IHRvIGhhdmUgc3RydWN0dXJlIGJlIGVxdWFsIHRvIHNjcmF0Y2gsIHNvIGxvbmcgYXMgeW91J3Jl IGZpbmUKICAgICAvLyB3aXRoIHRoZSBzdHJ1Y3R1cmUgR1BSIGJlaW5nIGNsb2JiZXJlZC4KICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKaW5kZXggODZiZjJmZmRmMGE3YTM0ZmNiNDAy NGFiNTAwNjlhNWI5NTMwYTUyZi4uN2NhNDE5ZmI5ZGZmYThiNjA1NDk0MTBiMzNkNGNhNzE2MjZj NzJhMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVDMyXzY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUMzJfNjQuY3BwCkBAIC0xMjYwLDYgKzEyNjAsMTMgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJ VDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgR2V0QnlW YWw6IHsKKyAgICAgICAgaWYgKGF0KG5vZGUuY2hpbGQxKCkpLnByZWRpY3Rpb24oKSA9PSBQcmVk aWN0U3RyaW5nKSB7CisgICAgICAgICAgICBjb21waWxlR2V0QnlWYWxPblN0cmluZyhub2RlKTsK KyAgICAgICAgICAgIGlmICghbV9jb21waWxlT2theSkKKyAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorCiAgICAgICAgIEFTU0VSVChub2RlLmNo aWxkMygpID09IE5vTm9kZSk7CiAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIGJhc2UodGhp cywgbm9kZS5jaGlsZDEoKSk7CiAgICAgICAgIFNwZWN1bGF0ZVN0cmljdEludDMyT3BlcmFuZCBw cm9wZXJ0eSh0aGlzLCBub2RlLmNoaWxkMigpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCmluZGV4IDhkZDcwZDdkNDg1YjA1OTcwZGI1 Y2NlNjIxNmViNGEzNzA5YjRjZmUuLjA4M2ExMTg3YTQxZTE0ZGRkYjlhNmM5ZDlkYjVkZTA0MWVl NTZhZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRp dmVKSVQ2NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVDY0LmNwcApAQCAtMTM3OCw2ICsxMzc4LDEzIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEdldEJ5VmFsOiB7 CisgICAgICAgIGlmIChhdChub2RlLmNoaWxkMSgpKS5wcmVkaWN0aW9uKCkgPT0gUHJlZGljdFN0 cmluZykgeworICAgICAgICAgICAgY29tcGlsZUdldEJ5VmFsT25TdHJpbmcobm9kZSk7CisgICAg ICAgICAgICBpZiAoIW1fY29tcGlsZU9rYXkpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwogICAgICAgICBBU1NFUlQobm9kZS5jaGlsZDMo KSA9PSBOb05vZGUpOwogICAgICAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBiYXNlKHRoaXMsIG5v ZGUuY2hpbGQxKCkpOwogICAgICAgICBTcGVjdWxhdGVTdHJpY3RJbnQzMk9wZXJhbmQgcHJvcGVy dHkodGhpcywgbm9kZS5jaGlsZDIoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU1N0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNT dHJpbmcuaAppbmRleCAxYWM4NGY0OTM0YzA3NWEzMmNlYmJjNDM0YjkxN2E2NzUzMWUwZGNmLi40 MGRmMmVlYzkwNDhkYjQxYWJkY2VmZWZlZWE2ZDkwOWZjNDJjYjNkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgKQEAgLTQ0Nyw2ICs0NDcsOCBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgfQogCiAgICAgICAgIHN0YXRpYyBzaXplX3Qgb2Zmc2V0T2ZMZW5ndGgo KSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoSlNTdHJpbmcsIG1fbGVuZ3RoKTsgfQorICAgICAg ICBzdGF0aWMgc2l6ZV90IG9mZnNldE9mRmliZXJDb3VudCgpIHsgcmV0dXJuIE9CSkVDVF9PRkZT RVRPRihKU1N0cmluZywgbV9maWJlckNvdW50KTsgfQorICAgICAgICBzdGF0aWMgc2l6ZV90IG9m ZnNldE9mVmFsdWUoKSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoSlNTdHJpbmcsIG1fdmFsdWUp OyB9CiAKICAgICAgICAgc3RhdGljIGNvbnN0IENsYXNzSW5mbyBzX2luZm87CiAK