69670 2011-10-07 14:33:48 -0700 [Qt] [WK2] Wrong handling of visibility in QTouchWebPage 2011-10-08 08:36:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned webkit.review.bot oldest_to_newest 480317 0 ostap73 2011-10-07 14:33:48 -0700 Handling of QEvent::Show and QEvent::Hide events doesn't cover all cases of SGItem visibility changes. QSGItem::visibleChanged signal should be used instead. 480321 1 110218 ostap73 2011-10-07 14:42:31 -0700 Created attachment 110218 Fix handling of QTouchWebPage visibility. 480550 2 110218 kling 2011-10-08 07:33:44 -0700 Comment on attachment 110218 Fix handling of QTouchWebPage visibility. r=me 480555 3 110218 webkit.review.bot 2011-10-08 08:36:30 -0700 Comment on attachment 110218 Fix handling of QTouchWebPage visibility. Clearing flags on attachment: 110218 Committed r97010: <http://trac.webkit.org/changeset/97010> 480556 4 webkit.review.bot 2011-10-08 08:36:34 -0700 All reviewed patches have been landed. Closing bug. 110218 2011-10-07 14:42:31 -0700 2011-10-08 08:36:30 -0700 Fix handling of QTouchWebPage visibility. qtouchwebpage_visibility_01.diff text/plain 2784 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NmYxNzQ3Li4yNTQ1ODkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTAtMDcgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBXcm9uZyBoYW5kbGluZyBvZiB2 aXNpYmlsaXR5IGluIFFUb3VjaFdlYlBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY5NjcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVwbGFjZSBRVG91Y2hXZWJQYWdlIHZpc2liaWxpdHkgaGFuZGxp bmcgYnkgU2hvdy9IaWRlIGV2ZW50cyB3aXRoIHVzZSBvZiAKKyAgICAgICAgUVNHSXRlbTo6dmlz aWJsZUNoYW5nZWQgc2lnbmFsLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3 ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFUb3VjaFdlYlBhZ2U6OlFUb3VjaFdlYlBhZ2UpOgorICAg ICAgICAoUVRvdWNoV2ViUGFnZTo6ZXZlbnQpOgorICAgICAgICAoUVRvdWNoV2ViUGFnZTo6b25W aXNpYmxlQ2hhbmdlZCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdl Lmg6CisKIDIwMTEtMTAtMDUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3Nz YS5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdIERlZmF1bHQgZGlyZWN0b3JpZXMgYW5kIHBhdGhz IGFyZSBtaXNzaW5nIGZvciBMb2NhbFN0b3JhZ2UsIERhdGFiYXNlIGFuZCBJY29uRGF0YWJhc2Uu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBh Z2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmNw cAppbmRleCA1MGQyYWU3Li5mNTY0YTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXRvdWNod2VicGFnZS5jcHAKQEAgLTM4LDYgKzM4LDcgQEAgUVRvdWNoV2Vi UGFnZTo6UVRvdWNoV2ViUGFnZShRU0dJdGVtKiBwYXJlbnQpCiAgICAgLy8gV2UgZG8gdGhlIHRy YW5zZm9ybSBmcm9tIHRoZSB0b3AgbGVmdCBzbyB0aGUgdmlld3BvcnQgY2FuIGFzc3VtZSB0aGUg cG9zaXRpb24gMCwgMAogICAgIC8vIGlzIGFsd2F5cyB3aGVyZSByZW5kZXJpbmcgc3RhcnRzLgog ICAgIHNldFRyYW5zZm9ybU9yaWdpbihUb3BMZWZ0KTsKKyAgICBjb25uZWN0KHRoaXMsIFNJR05B TCh2aXNpYmxlQ2hhbmdlZCgpKSwgU0xPVChvblZpc2libGVDaGFuZ2VkKCkpKTsKIH0KIAogUVRv dWNoV2ViUGFnZTo6flFUb3VjaFdlYlBhZ2UoKQpAQCAtOTEsMTcgKzkyLDYgQEAgUVNHTm9kZSog UVRvdWNoV2ViUGFnZTo6dXBkYXRlUGFpbnROb2RlKFFTR05vZGUqIG9sZE5vZGUsIFVwZGF0ZVBh aW50Tm9kZURhdGEqKQogKi8KIGJvb2wgUVRvdWNoV2ViUGFnZTo6ZXZlbnQoUUV2ZW50KiBldikK IHsKLSAgICBzd2l0Y2ggKGV2LT50eXBlKCkpIHsKLSAgICBjYXNlIFFFdmVudDo6U2hvdzoKLSAg ICAgICAgZC0+cGFnZS0+c2V0UGFnZUlzVmlzaWJsZSh0cnVlKTsKLSAgICAgICAgYnJlYWs7Ci0g ICAgY2FzZSBRRXZlbnQ6OkhpZGU6Ci0gICAgICAgIGQtPnBhZ2UtPnNldFBhZ2VJc1Zpc2libGUo ZmFsc2UpOwotICAgICAgICBicmVhazsKLSAgICBkZWZhdWx0OgotICAgICAgICBicmVhazsKLSAg ICB9Ci0KICAgICBpZiAoZC0+cGFnZS0+aGFuZGxlRXZlbnQoZXYpKQogICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICByZXR1cm4gUVNHSXRlbTo6ZXZlbnQoZXYpOwpAQCAtMTY2LDQgKzE1Niw5IEBA IHZvaWQgUVRvdWNoV2ViUGFnZVByaXZhdGU6OnNldFBhZ2UoUVRvdWNoV2ViUGFnZVByb3h5KiBw YWdlKQogICAgIHRoaXMtPnBhZ2UgPSBwYWdlOwogfQogCit2b2lkIFFUb3VjaFdlYlBhZ2U6Om9u VmlzaWJsZUNoYW5nZWQoKQoreworICAgIGQtPnBhZ2UtPnNldFBhZ2VJc1Zpc2libGUoaXNWaXNp YmxlKCkpOworfQorCiAjaW5jbHVkZSAibW9jX3F0b3VjaHdlYnBhZ2UuY3BwIgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmggYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuaAppbmRleCBhN2RhNjE1 Li5mMmVjZjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0 b3VjaHdlYnBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3Vj aHdlYnBhZ2UuaApAQCAtNzIsNiArNzIsOSBAQCBRX1NJR05BTFM6CiAgICAgdm9pZCBsb2FkRmFp bGVkKFFUb3VjaFdlYlBhZ2U6OkVycm9yVHlwZSBlcnJvclR5cGUsIGludCBlcnJvckNvZGUsIGNv bnN0IFFVcmwmIHVybCk7CiAgICAgdm9pZCBsb2FkUHJvZ3Jlc3NDaGFuZ2VkKGludCBwcm9ncmVz cyk7CiAKK3Byb3RlY3RlZCBRX1NMT1RTOgorICAgIHZvaWQgb25WaXNpYmxlQ2hhbmdlZCgpOwor CiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGtleVByZXNzRXZlbnQoUUtleUV2ZW50Kik7 CiAgICAgdmlydHVhbCB2b2lkIGtleVJlbGVhc2VFdmVudChRS2V5RXZlbnQqKTsK