69656 2011-10-07 12:33:20 -0700 [Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true 2011-10-10 06:07:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caryclark caryclark reed senorblanco webkit.review.bot oldest_to_newest 480214 0 caryclark 2011-10-07 12:33:20 -0700 [Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true 480220 1 110197 caryclark 2011-10-07 12:39:32 -0700 Created attachment 110197 Patch 480230 2 110197 senorblanco 2011-10-07 12:46:25 -0700 Comment on attachment 110197 Patch Looks good (up to my limited knowledge). Looping in Mike in case he has any comments. As a side note, I see justify-ideograph-complex is failing on all (chrome) platforms currently. Does it simply require rebaselining, or are there further problems? 480241 3 reed 2011-10-07 12:58:44 -0700 Hmmm, seems fine, but confusing. The result of this function (which is only called once) seems to only mean "can I call isCJKIdeographOrSymbol() or not". But that guy is purely a unicode lookup function, with no platform specificisms afaik. If it makes more pages look better, lets turn it on and see. From a code-review p.o.v. I can't see why this isn't on for all of our platforms (but time will tell). 480258 4 caryclark 2011-10-07 13:17:40 -0700 justify-ideograph-complex should have a fully justified right side. Since canExpandAroundIdeographsInComplexText has never been enabled for Windows and Linux, this test has never succeeded on those platforms. Oddly, there is a non-justified (i.e. wrong) expected image checked in for chromium-cg-mac. 480262 5 caryclark 2011-10-07 13:19:37 -0700 Stephen, is there anything more you'd like me to do with this patch? 480264 6 110197 senorblanco 2011-10-07 13:22:33 -0700 Comment on attachment 110197 Patch I'm going with Mike's OK. r=me 480268 7 senorblanco 2011-10-07 13:23:38 -0700 I've set CQ+ as well, but if you can't be around to watch the canaries when it lands, please clear it until you can. 480270 8 110197 caryclark 2011-10-07 13:27:52 -0700 Comment on attachment 110197 Patch I'll wait 'til Monday morning to commit so I can watch the Canaries. 480927 9 110197 webkit.review.bot 2011-10-10 06:07:00 -0700 Comment on attachment 110197 Patch Clearing flags on attachment: 110197 Committed r97058: <http://trac.webkit.org/changeset/97058> 480928 10 webkit.review.bot 2011-10-10 06:07:05 -0700 All reviewed patches have been landed. Closing bug. 110197 2011-10-07 12:39:32 -0700 2011-10-10 06:07:00 -0700 Patch bug-69656-20111007153930.patch text/plain 1795 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2OTcyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTAtMDcgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBbU2tpYSBvbiBDaHJvbWl1bSBN YWNdIFNldCBjYW5FeHBhbmRBcm91bmRJZGVvZ3JhcGhzSW5Db21wbGV4VGV4dCB0byB0cnVlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTY1NgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI5ODcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyODg5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2tpYSBvbiBMaW51eCBh bmQgV2luZG93cyB1c2VzIGRpZmZlcmVudCBmb250IGVuZ2luZXMgZnJvbQorICAgICAgICBTa2lh IG9uIE1hYy4gQWZ0ZXIgZGV0ZXJtaW5pbmcgdGhhdCB0aGUgdW5kZXJseWluZyBDb3JlVGV4dAor ICAgICAgICBjYW4gaGFuZGxlIGl0LCBlbmFibGluZyB0aGlzIGFsbG93cyBqdXN0aWZpY2F0aW9u IHRvIHdvcmsKKyAgICAgICAgY29ycmVjdGx5LgorCisgICAgICAgIFRlc3RzOiBmYXN0L3RleHQv anVzdGlmeS1pZGVvZ3JhcGgtY29tcGxleC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL0ZvbnRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmNhbkV4cGFu ZEFyb3VuZElkZW9ncmFwaHNJbkNvbXBsZXhUZXh0KToKKwogMjAxMS0xMC0wNyAgQW5kcmVhcyBL bGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGFjayBTdHlsZVJhcmVOb25Jbmhl cml0ZWREYXRhIGV2ZW4gaGFyZGVyIG9uIDY0LWJpdC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwCShyZXZpc2lvbiA5Njk2 MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00OSwxMiArNDksOSBAQCBib29sIEZvbnQ6OmNhblJldHVybkZh bGxiYWNrRm9udHNGb3JDb21wCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLS8vIEZJWE1FOiBEZXRl cm1pbmUgaWYgdGhlIE1hYyBwb3J0IG9mIENocm9taXVtIHVzaW5nIFNraWEgY2FuIGV4cGFuZCBh cm91bmQKLS8vIGlkZW9ncmFwaHMgaW4gY29tcGxleCB0ZXh0LiAoVGhlIFdpbmRvd3MgYW5kIExp bnV4IHBvcnRzIGZvciBDaHJvbWl1bSBjYW4ndC4pCi0vLyBUaGlzIGlzc3VlIGlzIHRyYWNrZWQg aW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyOTg3CiBib29sIEZv bnQ6OmNhbkV4cGFuZEFyb3VuZElkZW9ncmFwaHNJbkNvbXBsZXhUZXh0KCkKIHsKLSAgICByZXR1 cm4gZmFsc2U7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIHN0YXRpYyBib29sIGlzQ2FudmFzTXVs dGlMYXllcmVkKFNrQ2FudmFzKiBjYW52YXMpCg==