69647 2011-10-07 11:24:41 -0700 Remove compile time flag ENABLE_PASSWORD_ECHO 2011-10-07 13:04:44 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cshu cshu ap darin webkit.review.bot oldest_to_newest 480156 0 cshu 2011-10-07 11:24:41 -0700 As we have runtime flag in the page/Settings, we should remove this redundant compile time flag. 480163 1 110183 cshu 2011-10-07 11:35:22 -0700 Created attachment 110183 patch 1 480173 2 110183 kling 2011-10-07 11:44:18 -0700 Comment on attachment 110183 patch 1 Great! r=me 480246 3 110183 webkit.review.bot 2011-10-07 13:04:40 -0700 Comment on attachment 110183 patch 1 Clearing flags on attachment: 110183 Committed r96974: <http://trac.webkit.org/changeset/96974> 480247 4 webkit.review.bot 2011-10-07 13:04:44 -0700 All reviewed patches have been landed. Closing bug. 110183 2011-10-07 11:35:22 -0700 2011-10-07 13:04:40 -0700 patch 1 69647_1.patch text/plain 4664 cshu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2OTYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMDcgIENoYW5nIFNo dSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgY29tcGlsZSB0aW1lIGZsYWcg RU5BQkxFX1BBU1NXT1JEX0VDSE8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY5NjQ3CisKKyAgICAgICAgQXMgd2UgaGF2ZSBydW50aW1lIGZsYWcgaW4g dGhlIHBhZ2UvU2V0dGluZ3MsIHdlIHNob3VsZCByZW1vdmUgdGhpcyByZWR1bmRhbnQgY29tcGls ZSB0aW1lIGZsYWcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisKIDIwMTEtMTAtMDcgIE5hdGUgQ2hhcGlu ICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYWtlIEljb25Mb2FkZXIgYSBDYWNo ZWRSZXNvdXJjZUNsaWVudCBpbnN0ZWFkIG9mIGEgU3VicmVzb3VyY2VMb2FkZXJDbGllbnQuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9jb25maWcuaAkocmV2aXNpb24gOTY5NTgpCisrKyBTb3VyY2UvV2ViQ29yZS9jb25maWcuaAko d29ya2luZyBjb3B5KQpAQCAtMTY2LDcgKzE2Niw2IEBACiAKICNpZiBPUyhTWU1CSUFOKQogI2Rl ZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCi0jZGVmaW5lIEVOQUJMRV9QQVNTV09SRF9FQ0hPIDEK ICNlbmRpZgogCiAjaWYgT1MoVU5JWCkgfHwgT1MoV0lORE9XUykKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvU2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv U2V0dGluZ3MuY3BwCShyZXZpc2lvbiA5Njk1OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTUsNyArMjE1LDExIEBAIFNldHRpbmdzOjpT ZXR0aW5ncyhQYWdlKiBwYWdlKQogI2VuZGlmCiAgICAgLCBtX21lZGlhUGxheWJhY2tSZXF1aXJl c1VzZXJHZXN0dXJlKGZhbHNlKQogICAgICwgbV9tZWRpYVBsYXliYWNrQWxsb3dzSW5saW5lKHRy dWUpCisjaWYgT1MoU1lNQklBTikKKyAgICAsIG1fcGFzc3dvcmRFY2hvRW5hYmxlZCh0cnVlKQor I2Vsc2UKICAgICAsIG1fcGFzc3dvcmRFY2hvRW5hYmxlZChmYWxzZSkKKyNlbmRpZgogICAgICwg bV9zdXBwcmVzc0luY3JlbWVudGFsUmVuZGVyaW5nKGZhbHNlKQogICAgICwgbV9sb2Fkc0ltYWdl c0F1dG9tYXRpY2FsbHlUaW1lcih0aGlzLCAmU2V0dGluZ3M6OmxvYWRzSW1hZ2VzQXV0b21hdGlj YWxseVRpbWVyRmlyZWQpCiAgICAgLCBtX3pvb21BbmltYXRvclNjYWxlKDEpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L3F0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0No YW5nZUxvZwkocmV2aXNpb24gOTY5NjEpCisrKyBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTEwLTA3ICBDaGFuZyBTaHUgIDxj c2h1QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGNvbXBpbGUgdGltZSBmbGFnIEVOQUJM RV9QQVNTV09SRF9FQ0hPCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02OTY0NworCisgICAgICAgIEFzIHdlIGhhdmUgcnVudGltZSBmbGFnIGluIHRoZSBw YWdlL1NldHRpbmdzLCB3ZSBzaG91bGQgcmVtb3ZlIHRoaXMgcmVkdW5kYW50IGNvbXBpbGUgdGlt ZSBmbGFnLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3NQcml2YXRlOjph cHBseSk6CisKIDIwMTEtMTAtMDYgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgQ29kZSBjbGVhbi11cDogTWFrZSBSZW5kZXJPYmplY3Q6OmFic29sdXRlQm91 bmRpbmdCb3hSZWN0IGFuZCBhc3NvY2lhdGVkIG1ldGhvZHMgY29uc3QgYW5kIG1ha2UgaXRzIHBh cmFtZXRlciB1c2VUcmFuc2Zvcm1zIG5vIGxvbmdlciBkZWZhdWx0IHRvIGZhbHNlCkluZGV4OiBT b3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHJldmlzaW9uIDk2OTU4KQorKysgU291 cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg0 LDExICsyODQsNiBAQCB2b2lkIFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KCkKICAgICAgICAg c2V0dGluZ3MtPnNldE5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKHZhbHVlKTsKIAogICAgICAgICBz ZXR0aW5ncy0+c2V0VXNlc1BhZ2VDYWNoZShXZWJDb3JlOjpwYWdlQ2FjaGUoKS0+Y2FwYWNpdHko KSk7Ci0KLSNpZiBFTkFCTEUoUEFTU1dPUkRfRUNITykKLSAgICAgICAgc2V0dGluZ3MtPnNldFBh c3N3b3JkRWNob0VuYWJsZWQodHJ1ZSk7Ci0gICAgICAgIHNldHRpbmdzLT5zZXRQYXNzd29yZEVj aG9EdXJhdGlvbkluU2Vjb25kcygxKTsKLSNlbmRpZgogICAgIH0gZWxzZSB7CiAgICAgICAgIFFM aXN0PFFXZWJTZXR0aW5nc1ByaXZhdGUqPiBzZXR0aW5ncyA9ICo6OmFsbFNldHRpbmdzKCk7CiAg ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgc2V0dGluZ3MuY291bnQoKTsgKytpKQpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gOTY5NjEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMC0wNyAgQ2hhbmcgU2h1ICA8Y3NodUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJlbW92ZSBjb21waWxlIHRpbWUgZmxhZyBFTkFCTEVfUEFTU1dPUkRf RUNITworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2 NDcKKworICAgICAgICBXSzIgdGVzdHMgYXJlIHBhc3NpbmcgYWZ0ZXIgcjk2NzQwIChidWcgNjg5 MjQpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vd2syL1NraXBwZWQ6CisKIDIwMTEtMTAtMDcgIEphbWVzIFNpbW9uc2VuICA8c2lt b25qYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVXBkYXRlIHRlc3RfZXhw ZWN0YXRpb25zIGFmdGVyIFY4IHJvbGwuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIv U2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvU2tpcHBlZAko cmV2aXNpb24gOTY5NTgpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvU2tpcHBlZAkod29y a2luZyBjb3B5KQpAQCAtMTEwMiwxMyArMTEwMiw2IEBAIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxj aGVjay1pbnB1dC1zZWFyY2gKICMgbWlzc2luZyB3aW5kb3cuaW50ZXJuYWxzLmNyZWF0ZVNoYWRv d0NvbnRlbnRFbGVtZW50CiBmYXN0L2RvbS9zaGFkb3cvY3JlYXRlLWNvbnRlbnQtZWxlbWVudC5o dG1sCiAKLSMgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRQ YXNzd29yZEVjaG9FbmFibGVkCi0jIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgbGF5b3V0VGVzdENv bnRyb2xsZXIuc2V0UGFzc3dvcmRFY2hvRHVyYXRpb24KLWVkaXRpbmcvaW5wdXQvcGFzc3dvcmQt ZWNoby1wYXNzbm9kZS5odG1sCi1lZGl0aW5nL2lucHV0L3Bhc3N3b3JkLWVjaG8tcGFzc25vZGUy Lmh0bWwKLWVkaXRpbmcvaW5wdXQvcGFzc3dvcmQtZWNoby1wYXNzbm9kZTMuaHRtbAotZWRpdGlu Zy9pbnB1dC9wYXNzd29yZC1lY2hvLXRleHRub2RlLmh0bWwKLQogIyBXVFIgbmVlZHMgYW4gaW1w bGVtZW50YXRpb24gZm9yIGV2ZW50U2VuZGVyLmNvbnRpbnVvdXNNb3VzZVNjcm9sbEJ5CiAjIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTQxNwogZmFzdC9ldmVudHMv d2hlZWxldmVudC1kaXJlY3Rpb24taW52ZXJ0ZWQtZnJvbS1kZXZpY2UuaHRtbAo=