69644 2011-10-07 11:05:42 -0700 [FileSystem API] DirectoryEntry.removeRecursively successCallback is required 2011-12-01 15:18:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim pilgrim abarth ericu ojan webkit.review.bot oldest_to_newest 480141 0 pilgrim 2011-10-07 11:05:42 -0700 According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#idl-def-DirectoryEntry , the first parameter (successCallback) to the removeRecursively() method is required. This test calls the method without the required parameter and logs the result. Expected behavior: throws TypeError: not enough arguments Actual behavior: no exception thrown 480144 1 110178 pilgrim 2011-10-07 11:06:42 -0700 Created attachment 110178 Patch 484486 2 110178 abarth 2011-10-14 23:03:49 -0700 Comment on attachment 110178 Patch Would you be willing to merge this test with http://trac.webkit.org/browser/trunk/LayoutTests/fast/filesystem/not-enough-arguments.html ? 512984 3 117456 pilgrim 2011-12-01 12:17:16 -0800 Created attachment 117456 Patch 513186 4 117456 webkit.review.bot 2011-12-01 15:18:13 -0800 Comment on attachment 117456 Patch Clearing flags on attachment: 117456 Committed r101718: <http://trac.webkit.org/changeset/101718> 513187 5 webkit.review.bot 2011-12-01 15:18:32 -0800 All reviewed patches have been landed. Closing bug. 110178 2011-10-07 11:06:42 -0700 2011-12-01 12:17:01 -0800 Patch bug-69644-20111007140702.patch text/plain 2671 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk2OTU5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMDcgIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtGaWxlU3lzdGVtIEFQSV0gRGlyZWN0b3J5 RW50cnkucmVtb3ZlUmVjdXJzaXZlbHkgc3VjY2Vzc0NhbGxiYWNrIGlzIHJlcXVpcmVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTY0NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9maWxlc3lz dGVtL3Jlc291cmNlcy9zaW1wbGUtcmVxdWlyZWQtYXJndW1lbnRzLXJlbW92ZXJlY3Vyc2l2ZWx5 LmpzOiBBZGRlZC4KKyAgICAgICAgKGVycm9yQ2FsbGJhY2spOgorICAgICAgICAoc3VjY2Vzc0Nh bGxiYWNrKToKKyAgICAgICAgKiBmYXN0L2ZpbGVzeXN0ZW0vc2ltcGxlLXJlcXVpcmVkLWFyZ3Vt ZW50cy1yZW1vdmVyZWN1cnNpdmVseS5odG1sOiBBZGRlZC4KKwogMjAxMS0xMC0wNyAgVmluZWV0 IENoYXVkYXJ5ICA8dmluZWV0LmNoYXVkaGFyeUBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgYmFj a2dyb3VuZC1jb2xvciBhZmZlY3RzIHRoZSBmb250IGNvbG9yIGluIGRpc2FibGVkIHRleHRhcmVh LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3NpbXBsZS1yZXF1aXJlZC1hcmd1 bWVudHMtcmVtb3ZlcmVjdXJzaXZlbHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2ZpbGVzeXN0ZW0vc2ltcGxlLXJlcXVpcmVkLWFyZ3VtZW50cy1yZW1vdmVyZWN1cnNpdmVs eS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3NpbXBs ZS1yZXF1aXJlZC1hcmd1bWVudHMtcmVtb3ZlcmVjdXJzaXZlbHkuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwxMiBAQAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIg aHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIu Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNj cmlwdCBzcmM9InJlc291cmNlcy9zaW1wbGUtcmVxdWlyZWQtYXJndW1lbnRzLXJlbW92ZXJlY3Vy c2l2ZWx5LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZmlsZXN5c3RlbS9yZXNvdXJjZXMvc2ltcGxlLXJlcXVpcmVkLWFyZ3VtZW50cy1yZW1v dmVyZWN1cnNpdmVseS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0 ZW0vcmVzb3VyY2VzL3NpbXBsZS1yZXF1aXJlZC1hcmd1bWVudHMtcmVtb3ZlcmVjdXJzaXZlbHku anMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vcmVzb3VyY2Vz L3NpbXBsZS1yZXF1aXJlZC1hcmd1bWVudHMtcmVtb3ZlcmVjdXJzaXZlbHkuanMJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMjUgQEAKK2lmICh0aGlzLmltcG9ydFNjcmlwdHMpIHsKKyAgICBpbXBv cnRTY3JpcHRzKCcuLi9yZXNvdXJjZXMvZnMtd29ya2VyLWNvbW1vbi5qcycpOworICAgIGltcG9y dFNjcmlwdHMoJy4uL3Jlc291cmNlcy9mcy10ZXN0LXV0aWwuanMnKTsKK30KKworZGVzY3JpcHRp b24oIkRpcmVjdG9yeUVudHJ5IHJlcXVpcmVkIGFyZ3VtZW50cyB0ZXN0LiIpOworCit2YXIgZmls ZVN5c3RlbSA9IG51bGw7CisKK2Z1bmN0aW9uIGVycm9yQ2FsbGJhY2soZXJyb3IpIHsKKyAgICBk ZWJ1ZygiRXJyb3Igb2NjdXJlZCB3aGlsZSByZXF1ZXN0aW5nIGEgVEVNUE9SQVJZIGZpbGUgc3lz dGVtOiIgKyBlcnJvci5jb2RlKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKworZnVuY3Rpb24g c3VjY2Vzc0NhbGxiYWNrKGZzKSB7CisgICAgZmlsZVN5c3RlbSA9IGZzOworICAgIGRlYnVnKCJT dWNjZXNzZnVsbHkgb2J0YWluZWQgVEVNUE9SQVJZIEZpbGVTeXN0ZW06IiArIGZpbGVTeXN0ZW0u bmFtZSk7CisgICAgcm9vdCA9IGV2YWxBbmRMb2coInJvb3QgPSBmaWxlU3lzdGVtLnJvb3QiKTsK KyAgICBzaG91bGRUaHJvdygicm9vdC5yZW1vdmVSZWN1cnNpdmVseSgpIik7CisgICAgZmluaXNo SlNUZXN0KCk7Cit9CisKK3ZhciBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKK2V2YWxBbmRMb2coIndl YmtpdFJlcXVlc3RGaWxlU3lzdGVtKFRFTVBPUkFSWSwgMTAwLCBzdWNjZXNzQ2FsbGJhY2ssIGVy cm9yQ2FsbGJhY2spOyIpOwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg== 117456 2011-12-01 12:17:16 -0800 2011-12-01 15:18:11 -0800 Patch bug-69644-20111201151735.patch text/plain 3852 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTY5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTEyLTAxICBNYXJrIFBp bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbRmlsZVN5c3RlbSBBUEld IERpcmVjdG9yeUVudHJ5LnJlbW92ZVJlY3Vyc2l2ZWx5IHN1Y2Nlc3NDYWxsYmFjayBpcyByZXF1 aXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2 NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZp bGVhcGkvRGlyZWN0b3J5RW50cnkuaWRsOiByZW1vdmUgW09wdGlvbmFsXSBmbGFnIGZyb20gc3Vj Y2Vzc0NhbGxiYWNrCisKIDIwMTEtMTItMDEgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQu b3JnPgogCiAgICAgICAgIENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uOiBVbm5lY2Vzc2FyeSBk b3VibGUgaGFzaCBsb29rdXAgaW4gY29uc3RydWN0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUv ZmlsZWFwaS9EaXJlY3RvcnlFbnRyeS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZmlsZWFwaS9EaXJlY3RvcnlFbnRyeS5pZGwJKHJldmlzaW9uIDEwMTY2NikKKysrIFNvdXJjZS9X ZWJDb3JlL2ZpbGVhcGkvRGlyZWN0b3J5RW50cnkuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw2 ICszOCw2IEBAIG1vZHVsZSBzdG9yYWdlIHsKICAgICAgICAgRGlyZWN0b3J5UmVhZGVyIGNyZWF0 ZVJlYWRlcigpOwogICAgICAgICBbQ3VzdG9tXSB2b2lkIGdldEZpbGUoaW4gW0NvbnZlcnRVbmRl ZmluZWRPck51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBwYXRoLCBpbiBbT3B0aW9uYWxdIFdl YktpdEZsYWdzIGZsYWdzLCBpbiBbT3B0aW9uYWwsIENhbGxiYWNrXSBFbnRyeUNhbGxiYWNrIHN1 Y2Nlc3NDYWxsYmFjaywgaW4gW09wdGlvbmFsLCBDYWxsYmFja10gRXJyb3JDYWxsYmFjayBlcnJv ckNhbGxiYWNrKTsKICAgICAgICAgW0N1c3RvbV0gdm9pZCBnZXREaXJlY3RvcnkoaW4gW0NvbnZl cnRVbmRlZmluZWRPck51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBwYXRoLCBpbiBbT3B0aW9u YWxdIFdlYktpdEZsYWdzIGZsYWdzLCBpbiBbT3B0aW9uYWwsIENhbGxiYWNrXSBFbnRyeUNhbGxi YWNrIHN1Y2Nlc3NDYWxsYmFjaywgaW4gW09wdGlvbmFsLCBDYWxsYmFja10gRXJyb3JDYWxsYmFj ayBlcnJvckNhbGxiYWNrKTsKLSAgICAgICAgdm9pZCByZW1vdmVSZWN1cnNpdmVseShpbiBbT3B0 aW9uYWwsIENhbGxiYWNrXSBWb2lkQ2FsbGJhY2sgc3VjY2Vzc0NhbGxiYWNrLCBpbiBbT3B0aW9u YWwsIENhbGxiYWNrXSBFcnJvckNhbGxiYWNrIGVycm9yQ2FsbGJhY2spOworICAgICAgICB2b2lk IHJlbW92ZVJlY3Vyc2l2ZWx5KGluIFtDYWxsYmFja10gVm9pZENhbGxiYWNrIHN1Y2Nlc3NDYWxs YmFjaywgaW4gW09wdGlvbmFsLCBDYWxsYmFja10gRXJyb3JDYWxsYmFjayBlcnJvckNhbGxiYWNr KTsKICAgICB9OwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxNjk3KQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTItMDEgIE1h cmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtGaWxlU3lzdGVt IEFQSV0gRGlyZWN0b3J5RW50cnkucmVtb3ZlUmVjdXJzaXZlbHkgc3VjY2Vzc0NhbGxiYWNrIGlz IHJlcXVpcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02OTY0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9maWxlc3lzdGVtL25vdC1lbm91Z2gtYXJndW1lbnRzLWV4cGVjdGVkLnR4dDogYWRk IHJlbW92ZVJlY3Vyc2l2ZWx5IHRlc3QgcmVzdWx0CisgICAgICAgICogZmFzdC9maWxlc3lzdGVt L25vdC1lbm91Z2gtYXJndW1lbnRzLmh0bWw6IGFkZCByZW1vdmVSZWN1cnNpdmVseSB0ZXN0CisK IDIwMTEtMTItMDEgIEplZmYgVGltYW51cyAgPHR3aXpAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IENsZWFuaW5nIHVwIGNvbW1lbnRzIGFuZCB1bnVzZWQgcG9ydGlvbnMgb2YgYSB3ZWJnbCB0ZXN0 LCBhcyBwZXIgcmV2aWV3IGNvbW1lbnRzLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lz dGVtL25vdC1lbm91Z2gtYXJndW1lbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vbm90LWVub3VnaC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAxMDE2NjYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vbm90LWVu b3VnaC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC00LDYgKzQsNyBA QCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBCiAKIAogU3VjY2Vzc2Z1 bGx5IG9idGFpbmVkIFBlcnNpc3RlbnQgRmlsZVN5c3RlbTpmaWxlX18wOlRlbXBvcmFyeQorUEFT UyBmaWxlU3lzdGVtLnJvb3QucmVtb3ZlUmVjdXJzaXZlbHkoKSB0aHJldyBleGNlcHRpb24gVHlw ZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KIFBBU1MgZmlsZVN5c3RlbS5yb290Lm1vdmVU bygpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgogUEFT UyBmaWxlU3lzdGVtLnJvb3QuY29weVRvKCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90 IGVub3VnaCBhcmd1bWVudHMuCiBQQVNTIHJlYWRlci5yZWFkRW50cmllcygpIHRocmV3IGV4Y2Vw dGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9maWxlc3lzdGVtL25vdC1lbm91Z2gtYXJndW1lbnRzLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL25vdC1lbm91Z2gtYXJndW1lbnRzLmh0bWwJKHJl dmlzaW9uIDEwMTY2NikKKysrIExheW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9ub3QtZW5vdWdo LWFyZ3VtZW50cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xOCw2ICsxOCw3IEBAIGZ1bmN0aW9u IHN1Y2Nlc3NDYWxsYmFjayhmcykKICAgICBmaWxlU3lzdGVtID0gZnM7CiAgICAgZGVidWcoIlN1 Y2Nlc3NmdWxseSBvYnRhaW5lZCBQZXJzaXN0ZW50IEZpbGVTeXN0ZW06IiArIGZpbGVTeXN0ZW0u bmFtZSk7CiAKKyAgICBzaG91bGRUaHJvdygiZmlsZVN5c3RlbS5yb290LnJlbW92ZVJlY3Vyc2l2 ZWx5KCkiKTsKICAgICBzaG91bGRUaHJvdygiZmlsZVN5c3RlbS5yb290Lm1vdmVUbygpIik7CiAg ICAgc2hvdWxkVGhyb3coImZpbGVTeXN0ZW0ucm9vdC5jb3B5VG8oKSIpOwogICAgIHJlYWRlciA9 IGZpbGVTeXN0ZW0ucm9vdC5jcmVhdGVSZWFkZXIoKTsK