69636 2011-10-07 09:27:08 -0700 Just use malloc/free when ADDRESS_SANITIZER is defined in RenderArena 2011-10-08 07:18:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 mbarbella inferno abarth inferno kcc webkit.review.bot oldest_to_newest 480067 0 110158 mbarbella 2011-10-07 09:27:08 -0700 Created attachment 110158 Patch for address sanitizer in RenderArena A patch is included to use malloc and free without adding debug headers when ADDRESS_SANITIZER is defined in RenderArena.cpp. The address sanitizer would not be able to detect errors if reads or writes took place in the debug header. I'm working with Abhishek on cluster fuzz. Adam, could you please review it? 480082 1 110161 inferno 2011-10-07 09:53:36 -0700 Created attachment 110161 Patch 480407 2 110161 darin 2011-10-07 17:16:41 -0700 Comment on attachment 110161 Patch OK 480544 3 110161 inferno 2011-10-08 06:13:32 -0700 Comment on attachment 110161 Patch Thanks a lot Darin. 480548 4 110161 webkit.review.bot 2011-10-08 07:18:43 -0700 Comment on attachment 110161 Patch Clearing flags on attachment: 110161 Committed r97009: <http://trac.webkit.org/changeset/97009> 480549 5 webkit.review.bot 2011-10-08 07:18:48 -0700 All reviewed patches have been landed. Closing bug. 110158 2011-10-07 09:27:08 -0700 2011-10-07 09:53:30 -0700 Patch for address sanitizer in RenderArena arenaalloc.patch text/plain 861 mbarbella SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJBcmVuYS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckFyZW5hLmNwcAkocmV2aXNpb24g OTE5OTcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQXJlbmEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03OSw3ICs3OSw5IEBACiB7CiAgICAgbV90b3RhbFNpemUgKz0gc2l6ZTsK IAotI2lmbmRlZiBOREVCVUcKKyNpZmRlZiBBRERSRVNTX1NBTklUSVpFUgorICAgIHJldHVybiA6 Om1hbGxvYyhzaXplKTsKKyNlbGlmICFkZWZpbmVkKE5ERUJVRykKICAgICAvLyBVc2Ugc3RhbmRh cmQgbWFsbG9jIHNvIHRoYXQgbWVtb3J5IGRlYnVnZ2luZyB0b29scyB3b3JrLgogICAgIEFTU0VS VCh0aGlzKTsKICAgICB2b2lkKiBibG9jayA9IDo6bWFsbG9jKGRlYnVnSGVhZGVyU2l6ZSArIHNp emUpOwpAQCAtMTE5LDcgKzEyMSw5IEBACiB7CiAgICAgbV90b3RhbFNpemUgLT0gc2l6ZTsKIAot I2lmbmRlZiBOREVCVUcKKyNpZmRlZiBBRERSRVNTX1NBTklUSVpFUgorICAgIDo6ZnJlZShwdHIp OworI2VsaWYgIWRlZmluZWQoTkRFQlVHKQogICAgIC8vIFVzZSBzdGFuZGFyZCBmcmVlIHNvIHRo YXQgbWVtb3J5IGRlYnVnZ2luZyB0b29scyB3b3JrLgogICAgIHZvaWQqIGJsb2NrID0gc3RhdGlj X2Nhc3Q8Y2hhcio+KHB0cikgLSBkZWJ1Z0hlYWRlclNpemU7CiAgICAgUmVuZGVyQXJlbmFEZWJ1 Z0hlYWRlciogaGVhZGVyID0gc3RhdGljX2Nhc3Q8UmVuZGVyQXJlbmFEZWJ1Z0hlYWRlcio+KGJs b2NrKTsK 110161 2011-10-07 09:53:36 -0700 2011-10-08 07:18:43 -0700 Patch bug-69636-20111007095335.patch text/plain 1788 inferno SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2OTQ4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDcgIEFiaGlzaGVr IEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3Ig QUREUkVTU19TQU5JVElaRVIgaW4gUmVuZGVyQXJlbmEKKyAgICAgICAgYWxsb2NhdGUsIGZyZWUg Y2FsbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 OTYzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVz ZSBtYWxsb2MsIGZyZWUgZGlyZWN0bHkgd2l0aG91dCB1c2luZyB0aGUgZGVidWcgaGVhZGVyLiBP dGhlcndpc2UsCisgICAgICAgIHdlIHdvbid0IGJlIGFibGUgdG8gZGV0ZWN0IG91dCBvZiBib3Vu ZHMgYWNjZXNzIGluIGRlYnVnIGhlYWRlci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJB cmVuYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJBcmVuYTo6YWxsb2NhdGUpOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQXJlbmE6OmZyZWUpOgorCiAyMDExLTEwLTA3ICBBbmRyZWFz IEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBGdW5jdGlvbnMgdGhhdCByZXR1 cm4gImNvbnN0IENvbG9yIiBzaG91bGQgc2ltcGx5IHJldHVybiAiQ29sb3IiLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckFyZW5hLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQXJlbmEuY3BwCShyZXZpc2lvbiA5Njk0NikKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJBcmVuYS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc5LDcgKzc5LDkgQEAgdm9pZCogUmVuZGVyQXJlbmE6OmFsbG9jYXRlKHNpemVfdCBzaXpl KQogewogICAgIG1fdG90YWxTaXplICs9IHNpemU7CiAKLSNpZm5kZWYgTkRFQlVHCisjaWZkZWYg QUREUkVTU19TQU5JVElaRVIKKyAgICByZXR1cm4gOjptYWxsb2Moc2l6ZSk7CisjZWxpZiAhZGVm aW5lZChOREVCVUcpCiAgICAgLy8gVXNlIHN0YW5kYXJkIG1hbGxvYyBzbyB0aGF0IG1lbW9yeSBk ZWJ1Z2dpbmcgdG9vbHMgd29yay4KICAgICBBU1NFUlQodGhpcyk7CiAgICAgdm9pZCogYmxvY2sg PSA6Om1hbGxvYyhkZWJ1Z0hlYWRlclNpemUgKyBzaXplKTsKQEAgLTExOSw3ICsxMjEsOSBAQCB2 b2lkIFJlbmRlckFyZW5hOjpmcmVlKHNpemVfdCBzaXplLCB2b2lkCiB7CiAgICAgbV90b3RhbFNp emUgLT0gc2l6ZTsKIAotI2lmbmRlZiBOREVCVUcKKyNpZmRlZiBBRERSRVNTX1NBTklUSVpFUgor ICAgIDo6ZnJlZShwdHIpOworI2VsaWYgIWRlZmluZWQoTkRFQlVHKQogICAgIC8vIFVzZSBzdGFu ZGFyZCBmcmVlIHNvIHRoYXQgbWVtb3J5IGRlYnVnZ2luZyB0b29scyB3b3JrLgogICAgIHZvaWQq IGJsb2NrID0gc3RhdGljX2Nhc3Q8Y2hhcio+KHB0cikgLSBkZWJ1Z0hlYWRlclNpemU7CiAgICAg UmVuZGVyQXJlbmFEZWJ1Z0hlYWRlciogaGVhZGVyID0gc3RhdGljX2Nhc3Q8UmVuZGVyQXJlbmFE ZWJ1Z0hlYWRlcio+KGJsb2NrKTsK