69629 2011-10-07 08:18:07 -0700 [GStreamer] avoid direct access to GstMessage structure field 2011-10-07 08:47:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 480010 0 pnormand 2011-10-07 08:18:07 -0700 In GStreamer 0.11 one has to use gst_message_get_structure() instead. So let's normalize this! 480014 1 110149 pnormand 2011-10-07 08:23:04 -0700 Created attachment 110149 proposed patch 480028 2 pnormand 2011-10-07 08:47:34 -0700 Committed r96940: <http://trac.webkit.org/changeset/96940> 110149 2011-10-07 08:23:04 -0700 2011-10-07 08:40:11 -0700 proposed patch proposed-patch.patch text/plain 4081 pnormand RnJvbSBmOWQ4Y2ZmZTExMmYwYjQ0YzQxMzk0ZWFkZjgxZWQ3NjZmYjIxZjdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDcgT2N0IDIwMTEgMTc6MjE6NTggKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9nc3Ry ZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNwcCAgICAgICAgIHwgICAgNSArKystLQogLi4uL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgIDEwICsrKysrKy0t LS0KIDMgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggZWQwOWZjNy4uMDdmMjA4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDExLTEwLTA3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1N0cmVhbWVyXSBhdm9pZCBkaXJlY3QgYWNjZXNzIHRvIEdzdE1lc3NhZ2Ugc3Ry dWN0dXJlIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02OTYyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVzZSBnc3RfbWVzc2FnZV9nZXRfc3RydWN0dXJlKCkgaW5zdGVhZCBvZiBkaXJlY3QgYWNj ZXNzIHRvIHRoZQorICAgICAgICBzdHJ1Y3R1cmUgZmllbGQuIE5vIGRpcmVjdCBiZW5lZml0IGFw YXJ0IGZyb20gY29tcGF0aWJpbGl0eSB3aXRoCisgICAgICAgIEdTdHJlYW1lciAwLjExLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpnc3RHV29ybGRTeW5jTWVzc2FnZUNhbGxiYWNrKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6 aGFuZGxlTWVzc2FnZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXI6Om1lZGlhTG9jYXRpb25DaGFuZ2VkKToKKwogMjAxMS0xMC0wNyAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2hyaW5rIFN0eWxlSW5oZXJpdGVkRGF0 YS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9HU3RyZWFtZXJHV29ybGQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAKaW5kZXggYzI2YmZkNC4uNWViZGRjZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJl YW1lckdXb3JsZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAKQEAgLTQyLDkgKzQyLDEwIEBAIGdib29sZWFuIGdz dEdXb3JsZFN5bmNNZXNzYWdlQ2FsbGJhY2soR3N0QnVzKiBidXMsIEdzdE1lc3NhZ2UqIG1lc3Nh Z2UsIGdwb2ludGVyCiAgICAgQVNTRVJUKEdTVF9NRVNTQUdFX1RZUEUobWVzc2FnZSkgPT0gR1NU X01FU1NBR0VfRUxFTUVOVCk7CiAKICAgICBHU3RyZWFtZXJHV29ybGQqIGdzdEdXb3JsZCA9IHN0 YXRpY19jYXN0PEdTdHJlYW1lckdXb3JsZCo+KGRhdGEpOworICAgIGNvbnN0IEdzdFN0cnVjdHVy ZSogc3RydWN0dXJlID0gZ3N0X21lc3NhZ2VfZ2V0X3N0cnVjdHVyZShtZXNzYWdlKTsKIAotICAg IGlmIChnc3Rfc3RydWN0dXJlX2hhc19uYW1lKG1lc3NhZ2UtPnN0cnVjdHVyZSwgInByZXBhcmUt eHdpbmRvdy1pZCIpCi0gICAgICAgIHx8IGdzdF9zdHJ1Y3R1cmVfaGFzX25hbWUobWVzc2FnZS0+ c3RydWN0dXJlLCAiaGF2ZS1ucy12aWV3IikpCisgICAgaWYgKGdzdF9zdHJ1Y3R1cmVfaGFzX25h bWUoc3RydWN0dXJlLCAicHJlcGFyZS14d2luZG93LWlkIikKKyAgICAgICAgfHwgZ3N0X3N0cnVj dHVyZV9oYXNfbmFtZShzdHJ1Y3R1cmUsICJoYXZlLW5zLXZpZXciKSkKICAgICAgICAgZ3N0R1dv cmxkLT5zZXRXaW5kb3dPdmVybGF5KG1lc3NhZ2UpOwogICAgIHJldHVybiBUUlVFOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCA5OGM1 NjNhLi4zODA4MDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcApAQCAtNzIzLDkgKzcyMywxMCBAQCBnYm9vbGVhbiBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OmhhbmRsZU1lc3NhZ2UoR3N0TWVzc2FnZSogbWVzc2FnZSkKICAgICBNZWRp YVBsYXllcjo6TmV0d29ya1N0YXRlIGVycm9yOwogICAgIGJvb2wgaXNzdWVFcnJvciA9IHRydWU7 CiAgICAgYm9vbCBhdHRlbXB0TmV4dExvY2F0aW9uID0gZmFsc2U7CisgICAgY29uc3QgR3N0U3Ry dWN0dXJlKiBzdHJ1Y3R1cmUgPSBnc3RfbWVzc2FnZV9nZXRfc3RydWN0dXJlKG1lc3NhZ2UpOwog Ci0gICAgaWYgKG1lc3NhZ2UtPnN0cnVjdHVyZSkgewotICAgICAgICBjb25zdCBnY2hhciogbWVz c2FnZVR5cGVOYW1lID0gZ3N0X3N0cnVjdHVyZV9nZXRfbmFtZShtZXNzYWdlLT5zdHJ1Y3R1cmUp OworICAgIGlmIChzdHJ1Y3R1cmUpIHsKKyAgICAgICAgY29uc3QgZ2NoYXIqIG1lc3NhZ2VUeXBl TmFtZSA9IGdzdF9zdHJ1Y3R1cmVfZ2V0X25hbWUoc3RydWN0dXJlKTsKIAogICAgICAgICAvLyBS ZWRpcmVjdCBtZXNzYWdlcyBhcmUgc2VudCBmcm9tIGVsZW1lbnRzLCBsaWtlIHF0ZGVtdXgsIHRv CiAgICAgICAgIC8vIG5vdGlmeSBvZiB0aGUgbmV3IGxvY2F0aW9uKHMpIG9mIHRoZSBtZWRpYS4K QEAgLTEyMTMsMTEgKzEyMTQsMTIgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 Om1lZGlhTG9jYXRpb25DaGFuZ2VkKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAgICAgaWYgKG1fbWVk aWFMb2NhdGlvbnMpCiAgICAgICAgIGdzdF9zdHJ1Y3R1cmVfZnJlZShtX21lZGlhTG9jYXRpb25z KTsKIAotICAgIGlmIChtZXNzYWdlLT5zdHJ1Y3R1cmUpIHsKKyAgICBjb25zdCBHc3RTdHJ1Y3R1 cmUqIHN0cnVjdHVyZSA9IGdzdF9tZXNzYWdlX2dldF9zdHJ1Y3R1cmUobWVzc2FnZSk7CisgICAg aWYgKHN0cnVjdHVyZSkgewogICAgICAgICAvLyBUaGlzIHN0cnVjdHVyZSBjYW4gY29udGFpbjoK ICAgICAgICAgLy8gLSBib3RoIGEgbmV3LWxvY2F0aW9uIHN0cmluZyBhbmQgZW1iZWRkZWQgbG9j YXRpb25zIHN0cnVjdHVyZQogICAgICAgICAvLyAtIG9yIG9ubHkgYSBuZXctbG9jYXRpb24gc3Ry aW5nLgotICAgICAgICBtX21lZGlhTG9jYXRpb25zID0gZ3N0X3N0cnVjdHVyZV9jb3B5KG1lc3Nh Z2UtPnN0cnVjdHVyZSk7CisgICAgICAgIG1fbWVkaWFMb2NhdGlvbnMgPSBnc3Rfc3RydWN0dXJl X2NvcHkoc3RydWN0dXJlKTsKICAgICAgICAgY29uc3QgR1ZhbHVlKiBsb2NhdGlvbnMgPSBnc3Rf c3RydWN0dXJlX2dldF92YWx1ZShtX21lZGlhTG9jYXRpb25zLCAibG9jYXRpb25zIik7CiAKICAg ICAgICAgaWYgKGxvY2F0aW9ucykKLS0gCjEuNy43LnJjMQ==