69619 2011-10-07 05:09:32 -0700 [Chromium] select box dropdown list backgound colour error 2013-04-12 09:01:07 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 111873 P2 Normal --- 0 info webkit-unassigned code.vineet info schenney tkent xiyuan oldest_to_newest 479940 0 info 2011-10-07 05:09:32 -0700 The background of a select box is black f.e, and the text colour is yellow. When you click on the select box, the dropdown list background will be white but the text colour still yellow and the text will be unreadable. 479941 1 110127 info 2011-10-07 05:11:17 -0700 Created attachment 110127 The bug itself 479950 2 110129 code.vineet 2011-10-07 05:39:50 -0700 Created attachment 110129 test_case Attaching test verified on chrome-linux. If select element has "background-color:black" then is not inherited to option elements. Mozilla works fine with this. I am analyzing this issue more any comments are welcome. 479962 3 code.vineet 2011-10-07 06:20:43 -0700 Old bugzilla reference : https://bugs.webkit.org/show_bug.cgi?id=9846 480038 4 ap 2011-10-07 08:51:33 -0700 Yes, looks like a duplicate of bug 9846. *** This bug has been marked as a duplicate of bug 9846 *** 480041 5 ap 2011-10-07 08:54:03 -0700 Actually, we still need separate bugs for different platforms, so not tracking as duplicate. 480957 6 code.vineet 2011-10-10 07:45:27 -0700 There is inconsistent chromium behavior for this test case as, this issue is not reproducible on chromium-windows. After debugging through code below are few observations: 1) In RenderMenuList::itemBackgroundColor() this function there is if checks as (line 475): // If the item has an opaque background color, return that. if (!backgroundColor.hasAlpha()) return backgroundColor; Whenever background-color is not specified for option element it always returns after above statement because backgroundColor has values like m_color = 4294440951 (looks white color) and alpha() == 255. I think HTMLOptionElement should take/inherit the background-color from the HTMLSelectElement. Please let me know any thoughts on this. 481479 7 tkent 2011-10-11 00:31:46 -0700 (In reply to comment #6) > 1) In RenderMenuList::itemBackgroundColor() this function there is if checks as (line 475): > > // If the item has an opaque background color, return that. > if (!backgroundColor.hasAlpha()) > return backgroundColor; > > Whenever background-color is not specified for option element it always returns after above statement because backgroundColor has values like m_color = 4294440951 (looks white color) and alpha() == 255. > > I think HTMLOptionElement should take/inherit the background-color from the HTMLSelectElement. > Please let me know any thoughts on this. What are the behaviors of other browsers? 481483 8 info 2011-10-11 00:37:12 -0700 Other browsers are working well, even in windows and linux ( Firefox, Opera, IE ). Google Chrome beta was also good, but after changed to Chronium 15 on my Ubuntu 10.04LTS, this feature went wrong. 481487 9 code.vineet 2011-10-11 00:44:03 -0700 (In reply to comment #8) > Other browsers are working well, even in windows and linux ( Firefox, Opera, IE ). Google Chrome beta was also good, but after changed to Chronium 15 on my Ubuntu 10.04LTS, this feature went wrong. More Specifically I tested for Windows IE(7) : Pass Windows Chrome(14.0.835.163) : Pass Windows Safari(5.1) : Pass Windows/Linux Opera : Pass Linux(ubuntu) Chrome(14.0.835.163) : FAILS 481491 10 tkent 2011-10-11 00:51:08 -0700 I see. So, probably popup-menu code for Chromium-Linux has a regression, and RenderMenuList is innocent. 481495 11 tkent 2011-10-11 00:53:50 -0700 (In reply to comment #9) > Windows IE(7) : Pass > Windows Chrome(14.0.835.163) : Pass > Windows Safari(5.1) : Pass > Windows/Linux Opera : Pass > > Linux(ubuntu) Chrome(14.0.835.163) : FAILS What do you mean by "Pass"? Did the popup menu have black background and yellow foreground? Mac Opera, Mac Chrome, Mac Safari showed a popup with white background and black foreground. 481496 12 code.vineet 2011-10-11 01:00:34 -0700 (In reply to comment #11) > (In reply to comment #9) > > Windows IE(7) : Pass > > Windows Chrome(14.0.835.163) : Pass > > Windows Safari(5.1) : Pass > > Windows/Linux Opera : Pass > > > > Linux(ubuntu) Chrome(14.0.835.163) : FAILS > > What do you mean by "Pass"? Did the popup menu have black background and yellow foreground? > > Mac Opera, Mac Chrome, Mac Safari showed a popup with white background and black foreground. I tested for reduction test (attachment (id=110129)). Pass for Black background and white text. Fail as White background and white text. 481566 13 110497 code.vineet 2011-10-11 04:17:17 -0700 Created attachment 110497 proposed patch Proposed patch. Please let me know the review comments on this. I will update the patch with the test_case soon. 481597 14 110507 code.vineet 2011-10-11 06:21:13 -0700 Created attachment 110507 Updated patch Updated patch with test case modified. 481599 15 code.vineet 2011-10-11 06:27:56 -0700 (In reply to comment #10) > I see. So, probably popup-menu code for Chromium-Linux has a regression, and RenderMenuList is innocent. On debugging it is found that option element was getting the default value from themeChromiumLinux.css which has alpha() 255 so it was returning from RenderMenuList::itemBackgroundColor(). Please find the attached patch which fixes this issue now default color is set as rgba(247,247,247,0); Regarding test case I have modified current test case manual-tests/item-background.html. The new behavior now matches with all other ports. Please let me know your review comments. 482320 16 110507 tkent 2011-10-12 02:52:53 -0700 Comment on attachment 110507 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=110507&action=review > Source/WebCore/css/themeChromiumLinux.css:40 > - background-color: #f7f7f7; > + background-color: rgba(247,247,247,0); I don't think this is correct at all. Why is it reasonable to make <option> transparent by default? You have to find a real reason of the regression, and fix it. > Source/WebCore/manual-tests/item-background.html:74 > - <div class="swatch"></div> > + <div class="sblack"></div> I understand this is expected color for other browsers. How about Safari/Windows and Chromium/Windows? 482328 17 code.vineet 2011-10-12 03:18:50 -0700 (In reply to comment #16) > > Source/WebCore/css/themeChromiumLinux.css:40 > > - background-color: #f7f7f7; > > + background-color: rgba(247,247,247,0); > I don't think this is correct at all. > Why is it reasonable to make <option> transparent by default? > You have to find a real reason of the regression, and fix it. I agree having <option> transparent by default is wrong but we set bgColor to #f7f7f7 ie. alpha as 1 then, if (!backgroundColor.hasAlpha()) return backgroundColor; this check will always pass n return and we wont be able set option elements color then. Another approach we can do is in PopupListBox::paintRow(). Check for backColor = m_popupClient->style()->visitedDependentColor(CSSPropertyBackgroundColor).blend(backgroundColor); instead of backColor = style.backgroundColor(); //If you don't mind may I ping you on IRC? > I understand this is expected color for other browsers. How about Safari/Windows and Chromium/Windows? Also for both Safari/Windows and Chromium/Windows expected color is black and blue. 483859 18 code.vineet 2011-10-14 02:07:08 -0700 In bugzilla I found related bug https://bugs.webkit.org/show_bug.cgi?id=54115 In which it is setting default color of option element to #f7f7f7 for linux. So option element would never gets its parent's background-style. 874775 19 xiyuan 2013-04-12 09:01:07 -0700 This is actually fixed in https://bugs.webkit.org/show_bug.cgi?id=111873 *** This bug has been marked as a duplicate of bug 111873 *** 110127 2011-10-07 05:11:17 -0700 2011-10-07 05:11:17 -0700 The bug itself cs_cap.png image/png 0 info 110129 2011-10-07 05:39:50 -0700 2011-10-07 05:39:50 -0700 test_case test.html text/html 274 code.vineet PGh0bWw+Cjxib2R5PgoKPHNlbGVjdCBzdHlsZSA9ICJiYWNrZ3JvdW5kLWNvbG9yOmJsYWNrIj4K ICA8b3B0aW9uIHN0eWxlID0gImNvbG9yOndoaXRlIj5Wb2x2bzwvb3B0aW9uPgogIDxvcHRpb24g c3R5bGUgPSAiY29sb3I6d2hpdGUiPlNhYWI8L29wdGlvbj4KICA8b3B0aW9uIHN0eWxlID0gImNv bG9yOndoaXRlIj5NZXJjZWRlczwvb3B0aW9uPgogIDxvcHRpb24gc3R5bGUgPSAiY29sb3I6d2hp dGUiPkF1ZGk8L29wdGlvbj4KPC9zZWxlY3Q+CiAKPC9ib2R5Pgo8L2h0bWw+Cg== 110497 2011-10-11 04:17:17 -0700 2011-10-11 06:21:13 -0700 proposed patch option_color_001.diff text/plain 1193 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMTEgIFZpbmVldCBD aGF1ZGhhcnkgIDx2aW5lZXQuY2hhdWRoYXJ5QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbQ2hy b21pdW1dIHNlbGVjdCBib3ggZHJvcGRvd24gbGlzdCBiYWNrZ291bmQgY29sb3VyIGVycm9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTYxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlcGxhY2luZyBo ZXggYmFja2dyb3VuZCBjb2xvciB2YWx1ZSB0byByZXNwZWN0aXZlIFJHQkEuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBjc3MvdGhlbWVDaHJvbWl1bUxpbnV4 LmNzczoKKyAgICAgICAgKHNlbGVjdFtzaXplPSIxIl0gb3B0aW9uKToKKwogMjAxMS0xMC0xMSAg VG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAg W1F0XSBSZW1vdmUgYWxsIHJlZmVyZW5jZXMgdG8gUVRESVJfYnVpbGQgYW5kIHN0YW5kYWxvbmVf cGFja2FnZQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21pdW1MaW51eC5jc3MK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21pdW1MaW51eC5jc3MJ KHJldmlzaW9uIDk3MTQxKQorKysgU291cmNlL1dlYkNvcmUvY3NzL3RoZW1lQ2hyb21pdW1MaW51 eC5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTM3LDUgKzM3LDUgQEAgc2VsZWN0IHsKIHNlbGVjdDpu b3QoW3NpemVdKTpub3QoW211bHRpcGxlXSkgb3B0aW9uLAogc2VsZWN0W3NpemU9IjAiXSBvcHRp b24sCiBzZWxlY3Rbc2l6ZT0iMSJdIG9wdGlvbiB7Ci0gICAgYmFja2dyb3VuZC1jb2xvcjogI2Y3 ZjdmNzsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2JhKDI0NywyNDcsMjQ3LDApOwogfQo= 110507 2011-10-11 06:21:13 -0700 2011-10-14 02:07:23 -0700 Updated patch option_color_002.diff text/plain 2783 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTQ4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMTEgIFZpbmVldCBD aGF1ZGhhcnkgIDx2aW5lZXQuY2hhdWRoYXJ5QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbQ2hy b21pdW1dIHNlbGVjdCBib3ggZHJvcGRvd24gbGlzdCBiYWNrZ291bmQgY29sb3VyIGVycm9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTYxOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2luZyBo ZXggYmFja2dyb3VuZCBjb2xvciB2YWx1ZSB0byByZXNwZWN0aXZlIFJHQkEuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGFkZGVkIG1vZGlmaWVkIGl0ZW0tYmFja2dyb3VuZC5odG1sIHRvIG1hdGNo IHRoZQorICAgICAgICBiZWhhdm9yIHdpdGggb3RoZXIgYnJvd3NlcnMuCisKKyAgICAgICAgKiBj c3MvdGhlbWVDaHJvbWl1bUxpbnV4LmNzczoKKyAgICAgICAgKHNlbGVjdFtzaXplPSIxIl0gb3B0 aW9uKToKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvaXRlbS1iYWNrZ3JvdW5kLmh0bWw6CisKIDIw MTEtMTAtMTEgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgog CiAgICAgICAgIFtRdF0gUmVtb3ZlIGFsbCByZWZlcmVuY2VzIHRvIFFURElSX2J1aWxkIGFuZCBz dGFuZGFsb25lX3BhY2thZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy90aGVtZUNocm9taXVt TGludXguY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy90aGVtZUNocm9taXVt TGludXguY3NzCShyZXZpc2lvbiA5NzE0NCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy90aGVtZUNo cm9taXVtTGludXguY3NzCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw1ICszNyw1IEBAIHNlbGVjdCB7 CiBzZWxlY3Q6bm90KFtzaXplXSk6bm90KFttdWx0aXBsZV0pIG9wdGlvbiwKIHNlbGVjdFtzaXpl PSIwIl0gb3B0aW9uLAogc2VsZWN0W3NpemU9IjEiXSBvcHRpb24gewotICAgIGJhY2tncm91bmQt Y29sb3I6ICNmN2Y3Zjc7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSgyNDcsMjQ3LDI0Nyww KTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pdGVtLWJhY2tncm91bmQu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9tYW51YWwtdGVzdHMvaXRlbS1iYWNr Z3JvdW5kLmh0bWwJKHJldmlzaW9uIDk3MTQ0KQorKysgU291cmNlL1dlYkNvcmUvbWFudWFsLXRl c3RzL2l0ZW0tYmFja2dyb3VuZC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsOCBAQAog PHN0eWxlPgogICAgIGRpdi5jb250YWluZXIgeyBmbG9hdDogbGVmdDsgYmFja2dyb3VuZC1jb2xv cjogI2VlZTsgcGFkZGluZzogNHB4OyBtYXJnaW46IDRweDsgfQogICAgIGRpdi5zd2F0Y2ggeyB3 aWR0aDogMTRweDsgaGVpZ2h0OiAxNHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsgcG9zaXRp b246IHJlbGF0aXZlOyB9CisgICAgZGl2LnNibGFjayB7IHdpZHRoOiAxNHB4OyBoZWlnaHQ6IDE0 cHg7IGJhY2tncm91bmQtY29sb3I6IGJsYWNrOyBwb3NpdGlvbjogcmVsYXRpdmU7IH0KKyAgICBk aXYuc2JsdWUgeyB3aWR0aDogMTRweDsgaGVpZ2h0OiAxNHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBy Z2JhKDAsIDAsIDI1NSwgMC41KTsgcG9zaXRpb246IHJlbGF0aXZlOyB9CiAgICAgZGl2LnN3YXRj aCBkaXYgeyBwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMDsgbGVmdDogMDsgd2lkdGg6IDEwMCU7 IGhlaWdodDogMTAwJTsgfQogICAgIHNlbGVjdCB7IGRpc3BsYXk6IGJsb2NrOyBtYXJnaW4tbGVm dDogMTRweDsgbWFyZ2luLWJvdHRvbTogMXB4OyB9CiAKQEAgLTY5LDcgKzcxLDcgQEAKICAgICAg ICAgPG9wdGlvbiBjbGFzcz0ic2VtaWdyZWVuIj41MCUgdHJhbnNwYXJlbnQgZ3JlZW4gb3B0aW9u PC9vcHRpb24+CiAgICAgICAgIDxvcHRpb24gY2xhc3M9ImRhcmtlbiI+MzMlIHRyYW5zcGFyZW50 IGJsYWNrIG9wdGlvbjwvb3B0aW9uPgogICAgIDwvc2VsZWN0PgotICAgIDxkaXYgY2xhc3M9InN3 YXRjaCI+PC9kaXY+CisgICAgPGRpdiBjbGFzcz0ic2JsYWNrIj48L2Rpdj4KICAgICA8ZGl2IGNs YXNzPSJzd2F0Y2giPgogICAgICAgICA8ZGl2PgogICAgICAgICAgICAgPGRpdiBjbGFzcz0ic29s aWQiPjwvZGl2PgpAQCAtMTMxLDcgKzEzMyw3IEBACiAgICAgICAgIDxvcHRpb24gY2xhc3M9InNl bWlncmVlbiI+NTAlIHRyYW5zcGFyZW50IGdyZWVuIG9wdGlvbjwvb3B0aW9uPgogICAgICAgICA8 b3B0aW9uIGNsYXNzPSJkYXJrZW4iPjMzJSB0cmFuc3BhcmVudCBibGFjayBvcHRpb248L29wdGlv bj4KICAgICA8L3NlbGVjdD4KLSAgICA8ZGl2IGNsYXNzPSJzd2F0Y2giPjwvZGl2PgorICAgIDxk aXYgY2xhc3M9InNibHVlIj48L2Rpdj4KICAgICA8ZGl2IGNsYXNzPSJzd2F0Y2giPgogICAgICAg ICA8ZGl2PgogICAgICAgICAgICAgPGRpdiBjbGFzcz0ic29saWQiPjwvZGl2Pgo=