69611 2011-10-07 02:34:09 -0700 [Qt] WebProcess using proxy settings for localhost as well 2011-10-11 09:12:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned gopal.1.raghavan kenneth kling laszlo.gombos webkit.review.bot oldest_to_newest 479896 0 laszlo.gombos 2011-10-07 02:34:09 -0700 http://localhost should not go trough proxy even if http_proxy environment variable is set. It seems that the current solution does not take localhost/127.0.0.1 into account; see http://trac.webkit.org/changeset/72080/trunk/WebKit2/WebProcess/qt/WebProcessMainQt.cpp. 480996 1 110366 gopal.1.raghavan 2011-10-10 10:34:13 -0700 Created attachment 110366 proxy fix for localhost Implemented checks in queryProxy to return QNetworkProxy::NoProxy for localhost and 127.0.0.1. Not sure where the test cases are for proxy settings. If you have any suggestion, I can add a test case. 481001 2 110366 cshu 2011-10-10 10:56:54 -0700 Comment on attachment 110366 proxy fix for localhost Excellent patch! For perfection, you can possibly explore the option of replacing the "localhost" and "127.0.0.1" with some redefined Qt variables and whether we should go "CaseSensitive". But the patch is good to go. 481620 3 gopal.1.raghavan 2011-10-11 07:28:47 -0700 I grepped through qt5 refactored. I couldn't find a predefined for localhost. There are many occurrences of string. There is an enum under QHostAddress, but that might not be useful in this case. Chrome, firefox etc., accept localhost and LOCALHOST. So, I think CaseInSensitive should be ok. Ofcourse the numbers dont need it. Thanks 481668 4 110366 webkit.review.bot 2011-10-11 09:12:17 -0700 Comment on attachment 110366 proxy fix for localhost Clearing flags on attachment: 110366 Committed r97154: <http://trac.webkit.org/changeset/97154> 481669 5 webkit.review.bot 2011-10-11 09:12:22 -0700 All reviewed patches have been landed. Closing bug. 110366 2011-10-10 10:34:13 -0700 2011-10-11 09:12:17 -0700 proxy fix for localhost 69611.patch text/plain 1770 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MDY4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTAgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBXZWJQ cm9jZXNzIHVzaW5nIHByb3h5IHNldHRpbmdzIGZvciBsb2NhbGhvc3QgYXMgd2VsbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk2MTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRlZCBjaGVj a3MgaW4gcXVlcnlQcm94eSB0byByZXR1cm4gUU5ldHdvcmtQcm94eTo6Tm9Qcm94eSBmb3IgbG9j YWxob3N0IGFuZCAxMjcuMC4wLjEKKworICAgICAgICAqIFdlYlByb2Nlc3MvcXQvV2ViUHJvY2Vz c01haW5RdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkVudkh0dHBQcm94eUZhY3Rvcnk6OnF1ZXJ5 UHJveHkpOgorCiAyMDExLTEwLTEwICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5v a2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBidWlsZCB3aXRoIHFyZWFsID09IGZsb2F0IG9u IE1lZUdvIDEuMiBIYXJtYXR0YW4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQv V2ViUHJvY2Vzc01haW5RdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcAkocmV2aXNpb24gOTcwMTIpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMDQsOSArMTA0LDEzIEBAIGJvb2wgRW52SHR0cFByb3h5RmFjdG9yeTo6aW5pdGlhbGl6 ZUZyb20KIFFMaXN0PFFOZXR3b3JrUHJveHk+IEVudkh0dHBQcm94eUZhY3Rvcnk6OnF1ZXJ5UHJv eHkoY29uc3QgUU5ldHdvcmtQcm94eVF1ZXJ5JiBxdWVyeSkKIHsKICAgICBRU3RyaW5nIHByb3Rv Y29sID0gcXVlcnkucHJvdG9jb2xUYWcoKS50b0xvd2VyKCk7Ci0gICAgaWYgKHByb3RvY29sID09 IFFMYXRpbjFTdHJpbmcoImh0dHAiKSkKKyAgICBib29sIGxvY2FsSG9zdCA9IGZhbHNlOworCisg ICAgaWYgKCFxdWVyeS5wZWVySG9zdE5hbWUoKS5jb21wYXJlKFFMYXRpbjFTdHJpbmcoImxvY2Fs aG9zdCIpLCBRdDo6Q2FzZUluc2Vuc2l0aXZlKSB8fCAhcXVlcnkucGVlckhvc3ROYW1lKCkuY29t cGFyZShRTGF0aW4xU3RyaW5nKCIxMjcuMC4wLjEiKSwgUXQ6OkNhc2VJbnNlbnNpdGl2ZSkpCisg ICAgICAgIGxvY2FsSG9zdCA9IHRydWU7CisgICAgaWYgKHByb3RvY29sID09IFFMYXRpbjFTdHJp bmcoImh0dHAiKSAmJiAhbG9jYWxIb3N0KQogICAgICAgICByZXR1cm4gbV9odHRwUHJveHk7Ci0g ICAgZWxzZSBpZiAocHJvdG9jb2wgPT0gUUxhdGluMVN0cmluZygiaHR0cHMiKSkKKyAgICBpZiAo cHJvdG9jb2wgPT0gUUxhdGluMVN0cmluZygiaHR0cHMiKSAmJiAhbG9jYWxIb3N0KQogICAgICAg ICByZXR1cm4gbV9odHRwc1Byb3h5OwogCiAgICAgUUxpc3Q8UU5ldHdvcmtQcm94eT4gcHJveGll czsK