69600 2011-10-06 21:09:36 -0700 [WinCairo] Correct improper identification of QuartzCore Extensions on Windows 2011-10-15 00:10:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham aroben oldest_to_newest 479774 0 bfulgham 2011-10-06 21:09:36 -0700 A change to support hardware accelerated rendering under the Apple Windows build had the unintended effect of fooling Cairo builds into trying to build with Apple-specific extensions. http://trac.webkit.org/changeset/82960/trunk/Source/WebKit2/DerivedSources.make This patch attempts to recognize the Cairo build case and avoid switching to the new extensions. This was not noticed previously because it is only triggered when the build environment is updated to include the most recent Apple build headers (as you might do if you build both ways to confirm compatibility). 479778 1 110088 bfulgham 2011-10-06 21:14:41 -0700 Created attachment 110088 Patch 479789 2 bfulgham 2011-10-06 22:15:07 -0700 Committed r96904: <http://trac.webkit.org/changeset/96904> 479791 3 bfulgham 2011-10-06 22:19:56 -0700 The EWS showed the standard Apple Windows build succeeding, so I'm landing it to try to get my build bot green. Please roll-out if it causes any problem. 479948 4 aroben 2011-10-07 05:26:14 -0700 Sorry for the trouble here! I think there's probably a slightly better way to fix this. HAVE(WKQCA) being true shouldn't be enough to cause the WinCairo build to start trying to use WebKitQuartzCoreAdditions; USE(ACCELERATED_COMPOSITING) also has to be true. Is that symbol defined for your port? If it is, that seems like a bug. If it is not, then I think we just need to change some "HAVE(WKQCA)" checks into "HAVE(WKQCA) && USE(ACCELERATED_COMPOSITING)". 484521 5 110088 abarth 2011-10-15 00:10:50 -0700 Comment on attachment 110088 Patch Cleared review? from attachment 110088 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 110088 2011-10-06 21:14:41 -0700 2011-10-15 00:10:50 -0700 Patch bug-69600-20111006211440.patch text/plain 1362 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2ODk5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTEtMTAtMDYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29ycmVj dCBpbXByb3BlciBpZGVudGlmaWNhdGlvbiBvZiBXS1FDIGV4dGVuc2lvbnMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTYwMAorCisgICAgICAgICog RGVyaXZlZFNvdXJjZXMubWFrZTogTWFrZSBzdXJlIHdlIGFyZSBub3QgYnVpbGRpbmcgdGhlCisg ICAgICAgIFdpbkNhaXJvIHZhcmlhbnQuCisKIDIwMTEtMTAtMDYgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBXaGVuIGJ1aWxkaW5nIHdpdGggY2xhbmcs IGVuYWJsZSAtV2dsb2JhbC1jb25zdHJ1Y3RvcnMgYW5kIC1XZXhpdC10aW1lLWRlc3RydWN0b3Jz CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5tYWtlCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLm1ha2UJKHJldmlzaW9uIDk2ODk2KQorKysg U291cmNlL1dlYktpdDIvRGVyaXZlZFNvdXJjZXMubWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTE0 LDYgKzExNCw2IEBAIGlmZXEgKCQoT1MpLFdpbmRvd3NfTlQpCiBhbGwgOiBIZWFkZXJEZXRlY3Rp b24uaAogCiBIZWFkZXJEZXRlY3Rpb24uaCA6IERlcml2ZWRTb3VyY2VzLm1ha2UKLQlpZiBbIC1m ICIkKFdFQktJVExJQlJBUklFU0RJUikvaW5jbHVkZS9XZWJLaXRRdWFydHpDb3JlQWRkaXRpb25z L1dlYktpdFF1YXJ0ekNvcmVBZGRpdGlvbnNCYXNlLmgiIF07IHRoZW4gZWNobyAiI2RlZmluZSBI QVZFX1dLUUNBIDEiID4gJEA7IGVsc2UgZWNobyA+ICRAOyBmaQorCWlmIFsgLWYgIiQoV0VCS0lU TElCUkFSSUVTRElSKS9pbmNsdWRlL1dlYktpdFF1YXJ0ekNvcmVBZGRpdGlvbnMvV2ViS2l0UXVh cnR6Q29yZUFkZGl0aW9uc0Jhc2UuaCIgXSAmJiBbICEgLWYgIiQoV0VCS0lUTElCUkFSSUVTRElS KS9pbmNsdWRlL2NhaXJvL2NhaXJvLmgiIF07IHRoZW4gZWNobyAiI2RlZmluZSBIQVZFX1dLUUNB IDEiID4gJEA7IGVsc2UgZWNobyA+ICRAOyBmaQogCiBlbmRpZiAjIFdpbmRvd3NfTlQK