69561 2011-10-06 13:53:19 -0700 [GTK] Don't expose objects with unknown role on GTK 2011-10-07 02:51:00 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario mario cfleizach mrobinson oldest_to_newest 479445 0 mario 2011-10-06 13:53:19 -0700 WebKitGTK is currently exposing objects with role unknown, which is wrong and, besides this, is preventing us to enable the new a11y layout test accessibility/deleting-iframe-destroys-axcache.html by providing a new expectations file. Of course, when it comes to enabling that new test we could of course generate the expected file now, but then one of the assertions would failing due to this bug, since this is how the a11y hierarchy for test looks right now: AXRole: scroll pane AXRole: document frame AXRole: paragraph AXRole: panel AXRole: unknown AXRole: scroll pane AXRole: document frame AXRole: panel AXRole: push button ...and this is how it should look: AXRole: scroll pane AXRole: document frame AXRole: paragraph AXRole: panel AXRole: scroll pane AXRole: document frame AXRole: panel AXRole: push button 479466 1 110015 mario 2011-10-06 14:06:05 -0700 Created attachment 110015 Patch 479471 2 mario 2011-10-06 14:10:21 -0700 Adding Chris to CC, as this patch basically mimics something they are already doing on the Mac. 479473 3 110015 cfleizach 2011-10-06 14:13:22 -0700 Comment on attachment 110015 Patch r=me 479903 4 mario 2011-10-07 02:51:00 -0700 Committed r96922: <http://trac.webkit.org/changeset/96922> 110015 2011-10-06 14:06:05 -0700 2011-10-06 14:13:22 -0700 Patch bug-69561-20111006230602.patch text/plain 6931 mario U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3MDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5NzQyNTI2MTM3MmM5ZDAyMjAyNWU3 NDQ1YzRhNWRjODFhYzIxOWY3Li42Y2Q4NTY1YWZkYTk1NDlhNTdjZDFlNDEyZTNhNDc5OWE4ZDc1 OTIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDYgIE1hcmlvIFNhbmNoZXogUHJh ZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIERvbid0IGV4cG9zZSBv YmplY3RzIHdpdGggdW5rbm93biByb2xlIG9uIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk1NjEKKworICAgICAgICBOZXcgdGVzdCB0byBjaGVj ayB0aGF0IHVua25vd24gb2JqZWN0cyBhcmUgbm90IGV4cG9zZWQgaW4gR1RLLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvdW5rbm93bi1yb2xlcy1ub3QtZXhwb3NlZC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5 L3Vua25vd24tcm9sZXMtbm90LWV4cG9zZWQuaHRtbDogQWRkZWQuCisKKyAgICAgICAgQWRkZWQg bmV3IGV4cGVjdGF0aW9uIGZvciBuZXcgYWNjZXNzaWJpbGl0eSBsYXlvdXQgdGVzdCBpbnRyb2R1 Y2VkCisgICAgICAgIGluIHI5NjEyNyB0aGF0IHdhcyBub3QgcG9zc2libGUgdG8gYWRkIGJlZm9y ZSBiZWNhdXNlIG9mIHRoaXMgYnVnLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2li aWxpdHkvZGVsZXRpbmctaWZyYW1lLWRlc3Ryb3lzLWF4Y2FjaGUtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKwogMjAxMS0xMC0wNSAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW1F0XVtXSzJdIEZpcnN0IHRlc3QgYWx3YXlzIGZhaWxzIGJlY2F1c2Ugb2YgdXNl bGVzcyB4Y2IgZHVtcApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvZGVsZXRpbmctaWZyYW1lLWRlc3Ryb3lzLWF4Y2FjaGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvZGVsZXRpbmctaWZyYW1lLWRl c3Ryb3lzLWF4Y2FjaGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZkMWNkZDcxY2VlODU1NThj OTU1MWVkZWVlNzcyN2Y3ZDE2M2NiNjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9kZWxldGluZy1pZnJhbWUtZGVzdHJveXMtYXhjYWNo ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0OCBAQAorQmVmb3JlCisKK0FmdGVyCisKK0VuZCBv ZiB0ZXN0CisKK1RoaXMgdGVzdHMgdGhhdCBkZWxldGluZyBhbiBpZnJhbWUgZG9lc24ndCBjYXVz ZSB0aGUgYWNjZXNzaWJpbGl0eSBjYWNoZSB0byBiZSBkZXN0cm95ZWQgYW5kIHJlY3JlYXRlZC4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKKworQmVmb3JlOgorQVhSb2xlOiBzY3Jv bGwgcGFuZSAKKyAgICBBWFJvbGU6IGRvY3VtZW50IGZyYW1lIAorICAgICAgICBBWFJvbGU6IHBh cmFncmFwaCAKKyAgICAgICAgQVhSb2xlOiBwYW5lbCAKKyAgICAgICAgICAgIEFYUm9sZTogc2Ny b2xsIHBhbmUgCisgICAgICAgICAgICAgICAgQVhSb2xlOiBkb2N1bWVudCBmcmFtZSAKKyAgICAg ICAgICAgICAgICAgICAgQVhSb2xlOiBwYW5lbCAKKyAgICAgICAgICAgICAgICAgICAgICAgIEFY Um9sZTogcHVzaCBidXR0b24gCisgICAgICAgIEFYUm9sZTogcGFyYWdyYXBoIAorICAgICAgICBB WFJvbGU6IHBhcmFncmFwaCAKKyAgICAgICAgQVhSb2xlOiBwYXJhZ3JhcGggCisgICAgICAgIEFY Um9sZTogcGFyYWdyYXBoIAorICAgICAgICBBWFJvbGU6IHNlY3Rpb24gCisKK0FmdGVyOgorQVhS b2xlOiBzY3JvbGwgcGFuZSAKKyAgICBBWFJvbGU6IGRvY3VtZW50IGZyYW1lIAorICAgICAgICBB WFJvbGU6IHBhcmFncmFwaCAKKyAgICAgICAgQVhSb2xlOiBwYW5lbCAKKyAgICAgICAgQVhSb2xl OiBwYXJhZ3JhcGggCisgICAgICAgIEFYUm9sZTogcGFyYWdyYXBoIAorICAgICAgICBBWFJvbGU6 IHBhcmFncmFwaCAKKyAgICAgICAgQVhSb2xlOiBwYXJhZ3JhcGggCisgICAgICAgIEFYUm9sZTog c2VjdGlvbiAKKworUEFTUyBmcmFtZUJvZHlSb2xlID09IGZyYW1lQm9keS5yb2xlIGlzIGZhbHNl CitQQVNTIGZyYW1lR3JvdXBSb2xlID09IGZyYW1lR3JvdXAucm9sZSBpcyBmYWxzZQorUEFTUyBm cmFtZUJ1dHRvblJvbGUgPT0gZnJhbWVCdXR0b24ucm9sZSBpcyBmYWxzZQorUEFTUyByb290Lmlz RXF1YWwobmV3Um9vdCkgaXMgdHJ1ZQorUEFTUyBib2R5LmlzRXF1YWwobmV3Qm9keSkgaXMgdHJ1 ZQorUEFTUyBiZWZvcmUuaXNFcXVhbChuZXdCZWZvcmUpIGlzIHRydWUKK1BBU1MgYWZ0ZXIuaXNF cXVhbChuZXdBZnRlcikgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Vua25vd24tcm9sZXMtbm90LWV4 cG9zZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvdW5rbm93bi1yb2xlcy1ub3QtZXhwb3NlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNWMw MjUwNDNjZWU0ZGVkMDEyOWY5ODNmNDdlZmU4NTc2NWY3YjBlYgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Vua25vd24tcm9sZXMtbm90 LWV4cG9zZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUgQEAKKworVGhpcyB0ZXN0cyBhY2Nl c3NpYmlsaXR5IG9iamVjdHMgd2l0aCByb2xlICd1bmtub3duJyBhcmUgbm90IGJlaW5nIGV4cG9z ZWQgaW4gdGhlIEdUSyBwb3J0LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitQQVNTIHJvb3Qu cm9sZSBpcyAnQVhSb2xlOiBzY3JvbGwgcGFuZScKK1BBU1Mgd2ViQXJlYS5yb2xlIGlzICdBWFJv bGU6IGRvY3VtZW50IGZyYW1lJworUEFTUyBpZnJhbWUucm9sZSBpcyAnQVhSb2xlOiBzY3JvbGwg cGFuZScKK1BBU1MgaWZyYW1lX2JvZHkucm9sZSBpcyAnQVhSb2xlOiBkb2N1bWVudCBmcmFtZScK K1BBU1MgaWZyYW1lX2J1dHRvbi5yb2xlIGlzICdBWFJvbGU6IHB1c2ggYnV0dG9uJworCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS91bmtub3duLXJv bGVzLW5vdC1leHBvc2VkLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS91bmtub3duLXJvbGVzLW5vdC1leHBvc2VkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2E0YmE1Nzkx ZjY1ZTg5Yzg2MzYyMjJlZDU2YjQxMjc5ZjU5Njk2ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Vua25vd24tcm9sZXMtbm90LWV4cG9z ZWQuaHRtbApAQCAtMCwwICsxLDQ0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYv L0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBo cmVmPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PHNjcmlwdD4KK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsKKworaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgp OworCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29u dHJvbGxlcikgeworCisgICAgd2luZG93LnJvb3QgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5y b290RWxlbWVudDsKKyAgICB3aW5kb3cud2ViQXJlYSA9IHJvb3QuY2hpbGRBdEluZGV4KDApOwor ICAgIHdpbmRvdy5pZnJhbWUgPSB3ZWJBcmVhLmNoaWxkQXRJbmRleCgwKTsKKyAgICB3aW5kb3cu aWZyYW1lX2JvZHkgPSBpZnJhbWUuY2hpbGRBdEluZGV4KDApOworICAgIHdpbmRvdy5pZnJhbWVf YnV0dG9uID0gaWZyYW1lX2JvZHkuY2hpbGRBdEluZGV4KDApOworCisgICAgc2hvdWxkQmUoInJv b3Qucm9sZSIsICInQVhSb2xlOiBzY3JvbGwgcGFuZSciKTsKKyAgICBzaG91bGRCZSgid2ViQXJl YS5yb2xlIiwgIidBWFJvbGU6IGRvY3VtZW50IGZyYW1lJyIpOworICAgIHNob3VsZEJlKCJpZnJh bWUucm9sZSIsICInQVhSb2xlOiBzY3JvbGwgcGFuZSciKTsKKyAgICBzaG91bGRCZSgiaWZyYW1l X2JvZHkucm9sZSIsICInQVhSb2xlOiBkb2N1bWVudCBmcmFtZSciKTsKKyAgICBzaG91bGRCZSgi aWZyYW1lX2J1dHRvbi5yb2xlIiwgIidBWFJvbGU6IHB1c2ggYnV0dG9uJyIpOworICB9Cit9Cis8 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5IiBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8 aWZyYW1lIHNyYz0iZGF0YTp0ZXh0L2h0bWwsPGJvZHk+PGJ1dHRvbj5DbGljayBtZTwvYnV0dG9u PjwvYm9keT4iPjwvaWZyYW1lPgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9 ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgYWNj ZXNzaWJpbGl0eSBvYmplY3RzIHdpdGggcm9sZSAndW5rbm93bicgYXJlIG5vdCBiZWluZyBleHBv c2VkIGluIHRoZSBHVEsgcG9ydC4iKTsKKworc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwv c2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3MDdl MmEzNmVmMWI1YWE2ZjZkZDhkYmY0OWE5ODY5OTRiNmNhMy4uNjQ5ZmI0MzY1YTI3MzA5YzUyNzhh MDUyMzAxNmViYjkxZTM3NDU0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEw LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBEb24ndCBleHBvc2Ugb2JqZWN0cyB3aXRoIHVua25vd24gcm9sZSBvbiBHVEsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NTYxCisKKyAg ICAgICAgSWdub3JlIGFjY2Vzc2liaWxpdHkgb2JqZWN0cyBpbiBhY2Nlc3NpYmlsaXR5UGxhdGZv cm1JbmNsdWRlc09iamVjdC4KKworICAgICAgICBUZXN0OiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS91bmtub3duLXJvbGVzLW5vdC1leHBvc2VkLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2li aWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eVBsYXRmb3JtSW5jbHVkZXNPYmplY3Qp OgorICAgICAgICBGb3IgdW5rbm93biBhY2Nlc3NpYmlsaXR5IG9iamVjdHMsIHJldHVybiBJZ25v cmVPYmplY3QuCisKIDIwMTEtMTAtMDUgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIHN1cHBvcnQgZm9yIHNlYXJjaCBp biBzY3JpcHQgY29udGVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKaW5kZXggMWI3ZmY3MmI4N2I4 OWEzNjUxM2ZiODE0YjFhNDUxMDY4MGU5ZjAxNi4uZTJiYTZiNDU1NTgzYjRlZGE2N2M3MTUxOTRj NWMzZDk4NGMyYzM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9n dGsvQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKQEAgLTczLDYgKzczLDExIEBA IEFjY2Vzc2liaWxpdHlPYmplY3RJbmNsdXNpb24gQWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNz aWJpbGl0eVBsYXRmb3JtSW5jbHVkZXNPCiAgICAgaWYgKHJvbGUgPT0gTGlzdE1hcmtlclJvbGUp CiAgICAgICAgIHJldHVybiBJZ25vcmVPYmplY3Q7CiAKKyAgICAvLyBOZXZlciBleHBvc2UgYW4g dW5rbm93biBvYmplY3QsIHNpbmNlIEFUJ3Mgd29uJ3Qga25vdyB3aGF0IHRvCisgICAgLy8gZG8g d2l0aCB0aGVtLiBUaGlzIGlzIHdoYXQgaXMgZG9uZSBvbiB0aGUgTWFjIGFzIHdlbGwuCisgICAg aWYgKHJvbGUgPT0gVW5rbm93blJvbGUpCisgICAgICAgIHJldHVybiBJZ25vcmVPYmplY3Q7CisK ICAgICByZXR1cm4gRGVmYXVsdEJlaGF2aW9yOwogfQogCg==