69556 2011-10-06 13:43:24 -0700 REGRESSION (r96595): First frame in assertion backtraces is no longer labeled "1" 2011-10-06 16:01:17 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED P2 Normal --- 1 aroben gavinp darin gavinp mitz webkit.review.bot oldest_to_newest 479428 0 aroben 2011-10-06 13:43:24 -0700 Here's an assertion backtrace I got today: ASSERTION FAILED: !structure->m_previous Source/JavaScriptCore/runtime/Structure.cpp(236) : void JSC::Structure::materializePropertyMap(JSC::JSGlobalData &) 2 0x10203207c JSC::Structure::materializePropertyMap(JSC::JSGlobalData&) 3 0x101e0903c JSC::Structure::materializePropertyMapIfNecessary(JSC::JSGlobalData&) 4 0x101e08e93 JSC::Structure::get(JSC::JSGlobalData&, JSC::Identifier const&) 5 0x101e8a984 JSC::DFG::ByteCodeParser::parseBlock(unsigned int) 6 0x101e8d70d JSC::DFG::ByteCodeParser::parse() 7 0x101e8d913 JSC::DFG::parse(JSC::DFG::Graph&, JSC::JSGlobalData*, JSC::CodeBlock*) 8 0x101df4d9f JSC::DFG::compile(JSC::DFG::CompileMode, JSC::ExecState*, JSC::ExecState*, JSC::CodeBlock*, JSC::JITCode&, JSC::MacroAssemblerCodePtr*) 9 0x101df4d3c JSC::DFG::tryCompileFunction(JSC::ExecState*, JSC::ExecState*, JSC::CodeBlock*, JSC::JITCode&, JSC::MacroAssemblerCodePtr&) 10 0x101ecf743 JSC::FunctionExecutable::compileForCallInternal(JSC::ExecState*, JSC::ScopeChainNode*, JSC::ExecState*, JSC::JITCode::JITType) 11 0x101ecee9b JSC::FunctionExecutable::compileOptimizedForCall(JSC::ExecState*, JSC::ScopeChainNode*, JSC::ExecState*) 12 0x101e650fb JSC::FunctionExecutable::compileOptimizedFor(JSC::ExecState*, JSC::ScopeChainNode*, JSC::CodeSpecializationKind) 13 0x101e624b4 JSC::FunctionCodeBlock::compileOptimized(JSC::ExecState*, JSC::ScopeChainNode*) 14 0x101f1c4fb cti_optimize_from_ret 15 0x101f25f20 jscGeneratedNativeCode 16 0x101eeb509 JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) 17 0x101ee78b0 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) 18 0x101e70fba JSC::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 19 0x10326106d WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 20 0x10387c51c WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) 21 0x10387c644 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 22 0x103890372 WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) 23 0x10388f49f WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) 24 0x102ed1c34 WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) 25 0x102ed1a07 WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) 26 0x102e63320 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() 27 0x102e6340b WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) 28 0x102e62d48 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 29 0x102e629b0 WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 30 0x102e63d44 WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() 31 0x102e64387 WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets() 32 0x102afbb62 WebCore::Document::removePendingSheet() Note that the first frame is labeled "2". It used to be labeled "1". 479520 1 110033 gavinp 2011-10-06 14:55:28 -0700 Created attachment 110033 Patch 479524 2 110033 gavinp 2011-10-06 14:57:53 -0700 Comment on attachment 110033 Patch I discussed this with gbarra, and we think also that there's some formatting changes that would benefit here. I'll add those in a separate CL so they can be debated without fixing these regressions. This fix was tested by adding some superfluous dump to some html elements, and running DumpRenderTree, and it is working for me. 479531 3 mitz 2011-10-06 15:01:08 -0700 I think it would be better to fix the long-standing bug (which I’d introduced) where the numbering starts at 1. It really ought to start at 0. 479532 4 mitz 2011-10-06 15:01:38 -0700 (The reason to start at 0 is that it would match other backtrace formats). 479545 5 gavinp 2011-10-06 15:19:59 -0700 mitz, I'll CC you on the upcoming bigger-changes-to-formatting CL. You will be interested. 479588 6 110033 webkit.review.bot 2011-10-06 16:01:13 -0700 Comment on attachment 110033 Patch Clearing flags on attachment: 110033 Committed r96869: <http://trac.webkit.org/changeset/96869> 479589 7 webkit.review.bot 2011-10-06 16:01:17 -0700 All reviewed patches have been landed. Closing bug. 110033 2011-10-06 14:55:28 -0700 2011-10-06 16:01:13 -0700 Patch bug-69556-20111006175527.patch text/plain 1649 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY4MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGYy NDU3NzUxMmU4ODJiNjZlZTdiOWFmNjZkNjlmN2FhMThkMmFlN2EuLmQyMThhNjkxZjkwMjVjOThi MmM5MzI4ZmIwOGU5YWYwZGEzMzdjMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE0IEBACiAyMDExLTEwLTA2ICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3Jn PgogCisgICAgICAgIFJFR1JFU1NJT04gKHI5NjU5NSk6IEZpcnN0IGZyYW1lIGluIGFzc2VydGlv biBiYWNrdHJhY2VzIGlzIG5vIGxvbmdlciBsYWJlbGVkICIxIgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk1NTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKworMjAx MS0xMC0wNiAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKwogICAgICAgICBl eHBvcnQgbmV3IHN0YWNrIGR1bXBpbmcgbWV0aG9kCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTAxOAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9B c3NlcnRpb25zLmNwcAppbmRleCAwNGEwOTBhZGI5ZWJhMjRlNGZjNDVkYzllZjMwMzJhODAwYmJh NGY4Li5lMjE2ZGNlOTkwYTI0YWRiYzEyZTc2N2FlOWQ2MjQzZTIwMDNkYmQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTIxMSwxMCArMjExLDExIEBAIHZv aWQgV1RGUmVwb3J0QmFja3RyYWNlKCkKICAgICAgICAgaWYgKG1hbmdsZWROYW1lKQogICAgICAg ICAgICAgY3hhRGVtYW5nbGVkID0gYWJpOjpfX2N4YV9kZW1hbmdsZShtYW5nbGVkTmFtZSwgMCwg MCwgMCk7CiAjZW5kaWYKKyAgICAgICAgY29uc3QgaW50IGZyYW1lTnVtYmVyID0gaSAtIGZyYW1l c1RvU2tpcCArIDE7CiAgICAgICAgIGlmIChtYW5nbGVkTmFtZSB8fCBjeGFEZW1hbmdsZWQpCi0g ICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIiUtM2QgJXAgJXNcbiIsIGksIHNhbXBsZXNbaV0s IGN4YURlbWFuZ2xlZCA/IGN4YURlbWFuZ2xlZCA6IG1hbmdsZWROYW1lKTsKKyAgICAgICAgICAg IGZwcmludGYoc3RkZXJyLCAiJS0zZCAlcCAlc1xuIiwgZnJhbWVOdW1iZXIsIHNhbXBsZXNbaV0s IGN4YURlbWFuZ2xlZCA/IGN4YURlbWFuZ2xlZCA6IG1hbmdsZWROYW1lKTsKICAgICAgICAgZWxz ZQotICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICIlLTNkICVwXG4iLCBpLCBzYW1wbGVzW2ld KTsKKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiJS0zZCAlcFxuIiwgZnJhbWVOdW1iZXIs IHNhbXBsZXNbaV0pOwogICAgICAgICBmcmVlKGN4YURlbWFuZ2xlZCk7CiAgICAgfQogfQo=