69553 2011-10-06 13:06:42 -0700 Add WKPageContextMenuClient callback when context menu is dismissed 2011-10-07 19:45:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jeffm jeffm beidson webkit-bug-importer oldest_to_newest 479406 0 jeffm 2011-10-06 13:06:42 -0700 Currently, WKPageContextMenuClient has a callback that's invoked when a custom context menu item is chosen. It would be nice to have a new callback that's always invoked when a context menu is dismissed (either when no item is selected, a non-custom item is selected, or a custom item is selected). This could allow clients to clean up any persistent state they may keep around during menu navigation to handle custom menu items. 479407 1 webkit-bug-importer 2011-10-06 13:06:59 -0700 <rdar://problem/10245835> 480389 2 110232 jeffm 2011-10-07 16:47:59 -0700 Created attachment 110232 Patch 480446 3 jeffm 2011-10-07 19:45:17 -0700 Committed r97000: <http://trac.webkit.org/changeset/97000> 110232 2011-10-07 16:47:59 -0700 2011-10-07 16:55:29 -0700 Patch bug-69553-20111007164757.patch text/plain 6117 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2OTkwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMTAtMDcgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBXS1BhZ2VDb250ZXh0TWVudUNs aWVudCBjYWxsYmFjayB3aGVuIGNvbnRleHQgbWVudSBpcyBkaXNtaXNzZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NTUzCisKKyAgICAgICAgQWRk IGNvbnRleHRNZW51RGlzbWlzc2VkIGNhbGxiYWNrIHRvIFdLUGFnZUNvbnRleHRNZW51Q2xpZW50 LCBhbmQgYnVtcCB0aGUgQVBJCisgICAgICAgIHZlcnNpb24gb2YgdGhpcyBjbGllbnQgdG8gMSBz byB3ZSBjb250aW51ZSB0byB3b3JrIHdpdGggb2xkIGNsaWVudHMuCisKKyAgICAgICAgKiBTaGFy ZWQvQVBJQ2xpZW50VHJhaXRzLmNwcDogQWRkZWQgYXJyYXkgb2YgaW50ZXJmYWNlIHNpemVzIGZv ciBXS1BhZ2VDb250ZXh0TWVudUNsaWVudC4KKyAgICAgICAgKiBTaGFyZWQvQVBJQ2xpZW50VHJh aXRzLmg6IEFkZGVkIEFQSUNsaWVudFRyYWl0cyBmb3IgV0tQYWdlQ29udGV4dE1lbnVDbGllbnQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmg6IEFkZGVkIGNvbnRleHRNZW51 RGlzbWlzc2VkIGNhbGxiYWNrIHRvIFdLUGFnZUNvbnRleHRNZW51Q2xpZW50IGFuZCBidW1wZWQg a1dLUGFnZUNvbnRleHRNZW51Q2xpZW50Q3VycmVudFZlcnNpb24uCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZUNvbnRleHRNZW51Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZUNvbnRleHRNZW51Q2xpZW50Ojpjb250ZXh0TWVudURpc21pc3NlZCk6IEFkZGVkLgorCisg ICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VDb250ZXh0TWVudUNsaWVudC5oOiBBZGRlZCBXZWJQ YWdlQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRNZW51RGlzbWlzc2VkKCkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5OjppbnRlcm5hbFNob3dDb250ZXh0TWVudSk6IE5vdGlmeSBjbGllbnQgd2hlbiBjb250ZXh0 IG1lbnUgaXMgZGlzbWlzc2VkLgorCiAyMDExLTEwLTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIFNjcm9sbGJhcnMgaW4gZW1iZWRkZWQgUERG cyBzaG91bGQgdXBkYXRlIHdoZW4gc3lzdGVtIHByZWZlcmVuY2VzIGNoYW5nZQpJbmRleDogU291 cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAJKHJldmlzaW9uIDk2OTgwKQor KysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM1LDYgKzM1LDExIEBAIGNvbnN0IHNpemVfdCBBUElDbGllbnRUcmFpdHM8V0tCdW5k bGVQYWcKICAgICBzaXplb2YoV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50KQogfTsKIAorY29uc3Qg c2l6ZV90IEFQSUNsaWVudFRyYWl0czxXS1BhZ2VDb250ZXh0TWVudUNsaWVudD46OmludGVyZmFj ZVNpemVzQnlWZXJzaW9uW10gPSB7CisgICAgb2Zmc2V0b2YoV0tQYWdlQ29udGV4dE1lbnVDbGll bnQsIGNvbnRleHRNZW51RGlzbWlzc2VkKSwKKyAgICBzaXplb2YoV0tQYWdlQ29udGV4dE1lbnVD bGllbnQpCit9OworICAgIAogY29uc3Qgc2l6ZV90IEFQSUNsaWVudFRyYWl0czxXS1BhZ2VVSUNs aWVudD46OmludGVyZmFjZVNpemVzQnlWZXJzaW9uW10gPSB7CiAgICAgb2Zmc2V0b2YoV0tQYWdl VUlDbGllbnQsIGNyZWF0ZU5ld1BhZ2UpLAogICAgIHNpemVvZihXS1BhZ2VVSUNsaWVudCkKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUElDbGllbnRUcmFpdHMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmgJKHJldmlzaW9uIDk2OTgw KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5oCSh3b3JraW5nIGNv cHkpCkBAIC00Miw2ICs0MiwxMCBAQCB0ZW1wbGF0ZTw+IHN0cnVjdCBBUElDbGllbnRUcmFpdHM8 V0tCdW5kCiAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBpbnRlcmZhY2VTaXplc0J5VmVyc2lvblsy XTsKIH07CiAKK3RlbXBsYXRlPD4gc3RydWN0IEFQSUNsaWVudFRyYWl0czxXS1BhZ2VDb250ZXh0 TWVudUNsaWVudD4geworICAgIHN0YXRpYyBjb25zdCBzaXplX3QgaW50ZXJmYWNlU2l6ZXNCeVZl cnNpb25bMl07Cit9OworCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBUElDbGllbnRUcmFpdHM8V0tQYWdl VUlDbGllbnQ+CiB7CiAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBpbnRlcmZhY2VTaXplc0J5VmVy c2lvblsyXTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlQ29udGV4dE1l bnVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlQ29udGV4dE1lbnVDbGllbnQuY3BwCShyZXZpc2lvbiA5Njk4MCkKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlQ29udGV4dE1lbnVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03NCw0ICs3NCwxMiBAQCB2b2lkIFdlYlBhZ2VDb250ZXh0TWVudUNsaWVudDo6Y3VzdG9t Q29uCiAgICAgbV9jbGllbnQuY3VzdG9tQ29udGV4dE1lbnVJdGVtU2VsZWN0ZWQodG9BUEkocGFn ZSksIHRvQVBJKGl0ZW0uZ2V0KCkpLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKIH0KIAordm9pZCBX ZWJQYWdlQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRNZW51RGlzbWlzc2VkKFdlYlBhZ2VQcm94 eSogcGFnZSkKK3sKKyAgICBpZiAoIW1fY2xpZW50LmNvbnRleHRNZW51RGlzbWlzc2VkKQorICAg ICAgICByZXR1cm47CisgICAgCisgICAgbV9jbGllbnQuY29udGV4dE1lbnVEaXNtaXNzZWQodG9B UEkocGFnZSksIG1fY2xpZW50LmNsaWVudEluZm8pOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlQ29udGV4dE1lbnVDbGll bnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZUNvbnRl eHRNZW51Q2xpZW50LmgJKHJldmlzaW9uIDk2OTgwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VDb250ZXh0TWVudUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0 MCw3IEBAIGNsYXNzIFdlYlBhZ2VDb250ZXh0TWVudUNsaWVudCA6IHB1YmxpYyAKIHB1YmxpYzoK ICAgICBib29sIGdldENvbnRleHRNZW51RnJvbVByb3Bvc2VkTWVudShXZWJQYWdlUHJveHkqLCBj b25zdCBWZWN0b3I8V2ViQ29udGV4dE1lbnVJdGVtRGF0YT4mIHByb3Bvc2VkTWVudSwgVmVjdG9y PFdlYkNvbnRleHRNZW51SXRlbURhdGE+JiBjdXN0b21NZW51LCBBUElPYmplY3QqIHVzZXJEYXRh KTsKICAgICB2b2lkIGN1c3RvbUNvbnRleHRNZW51SXRlbVNlbGVjdGVkKFdlYlBhZ2VQcm94eSos IGNvbnN0IFdlYkNvbnRleHRNZW51SXRlbURhdGEmKTsKKyAgICB2b2lkIGNvbnRleHRNZW51RGlz bWlzc2VkKFdlYlBhZ2VQcm94eSopOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gOTY5 ODApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjM5OCw2ICsyMzk4LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OmludGVybmFs U2hvd0NvbnRleHRNZQogICAgICAgICBtX2FjdGl2ZUNvbnRleHRNZW51LT5zaG93Q29udGV4dE1l bnUobWVudUxvY2F0aW9uLCBwcm9wb3NlZEl0ZW1zKTsKICAgICBlbHNlCiAgICAgICAgIG1fYWN0 aXZlQ29udGV4dE1lbnUtPnNob3dDb250ZXh0TWVudShtZW51TG9jYXRpb24sIGl0ZW1zKTsKKyAg ICAKKyAgICBtX2NvbnRleHRNZW51Q2xpZW50LmNvbnRleHRNZW51RGlzbWlzc2VkKHRoaXMpOwog fQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQoY29uc3QgV2Vi Q29udGV4dE1lbnVJdGVtRGF0YSYgaXRlbSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQy9XS1BhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tQYWdlLmgJKHJldmlzaW9uIDk2OTgwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNzQsMTYgKzI3NCwyMiBAQCBl bnVtIHsKIC8vIENvbnRleHRNZW51IGNsaWVudAogdHlwZWRlZiB2b2lkICgqV0tQYWdlR2V0Q29u dGV4dE1lbnVGcm9tUHJvcG9zZWRDb250ZXh0TWVudUNhbGxiYWNrKShXS1BhZ2VSZWYgcGFnZSwg V0tBcnJheVJlZiBwcm9wb3NlZE1lbnUsIFdLQXJyYXlSZWYqIG5ld01lbnUsIFdLVHlwZVJlZiB1 c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1BhZ2VD dXN0b21Db250ZXh0TWVudUl0ZW1TZWxlY3RlZENhbGxiYWNrKShXS1BhZ2VSZWYgcGFnZSwgV0tD b250ZXh0TWVudUl0ZW1SZWYgY29udGV4dE1lbnVJdGVtLCBjb25zdCB2b2lkKiBjbGllbnRJbmZv KTsKK3R5cGVkZWYgdm9pZCAoKldLUGFnZUNvbnRleHRNZW51RGlzbWlzc2VkQ2FsbGJhY2spKFdL UGFnZVJlZiBwYWdlLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKTsKIAogc3RydWN0IFdLUGFnZUNv bnRleHRNZW51Q2xpZW50IHsKICAgICBpbnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb247CiAgICAgY29uc3Qgdm9p ZCAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjbGllbnRJbmZvOworICAgIAorICAgIC8vIFZlcnNpb24gMAogICAgIFdLUGFnZUdldENvbnRl eHRNZW51RnJvbVByb3Bvc2VkQ29udGV4dE1lbnVDYWxsYmFjayAgICAgICAgICAgICAgICAgZ2V0 Q29udGV4dE1lbnVGcm9tUHJvcG9zZWRNZW51OwogICAgIFdLUGFnZUN1c3RvbUNvbnRleHRNZW51 SXRlbVNlbGVjdGVkQ2FsbGJhY2sgICAgICAgICAgICAgICAgICAgICAgICAgY3VzdG9tQ29udGV4 dE1lbnVJdGVtU2VsZWN0ZWQ7CisgICAgCisgICAgLy8gVmVyc2lvbiAxCisgICAgV0tQYWdlQ29u dGV4dE1lbnVEaXNtaXNzZWRDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb250ZXh0TWVudURpc21pc3NlZDsKIH07CiB0eXBlZGVmIHN0cnVjdCBXS1BhZ2VDb250ZXh0 TWVudUNsaWVudCBXS1BhZ2VDb250ZXh0TWVudUNsaWVudDsKIAotZW51bSB7IGtXS1BhZ2VDb250 ZXh0TWVudUNsaWVudEN1cnJlbnRWZXJzaW9uID0gMCB9OworZW51bSB7IGtXS1BhZ2VDb250ZXh0 TWVudUNsaWVudEN1cnJlbnRWZXJzaW9uID0gMSB9OwogCiBXS19FWFBPUlQgV0tUeXBlSUQgV0tQ YWdlR2V0VHlwZUlEKCk7CiAK