69552 2011-10-06 12:52:22 -0700 DFG implementation of UInt32ToNumber is missing a break statement 2011-10-06 14:45:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned ggaren oldest_to_newest 479402 0 fpizlo 2011-10-06 12:52:22 -0700 This may result in bizarre code generation behavior or crashes when compiling a UInt32ToNumber that must perform a double conversion. 479403 1 109999 fpizlo 2011-10-06 12:54:32 -0700 Created attachment 109999 the patch 479404 2 109999 oliver 2011-10-06 12:55:13 -0700 Comment on attachment 109999 the patch ouch 479488 3 ggaren 2011-10-06 14:30:19 -0700 Can this be regression tested? 479501 4 fpizlo 2011-10-06 14:42:27 -0700 Landed in r96860. 479508 5 fpizlo 2011-10-06 14:45:57 -0700 (In reply to comment #3) > Can this be regression tested? I think we should strive to do this right, in one go: https://bugs.webkit.org/show_bug.cgi?id=69565 The DFG's speculation on arithmetic operations is starting to stabilize to the point where it can be succinctly described and elegantly tested. I think we should take a break at some point from adding new bugs to the DFG and figure out a testing harness that can do this the right way, and uniformly, to minimize the number of redundant tests that we add. 109999 2011-10-06 12:54:32 -0700 2011-10-06 12:55:13 -0700 the patch fixbreak_patch_1.diff text/plain 1800 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTY4NTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMTAtMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgaW1wbGVtZW50YXRpb24gb2YgVUludDMyVG9OdW1iZXIgaXMgbWlzc2luZyBhIGJyZWFrIHN0 YXRlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Njk1NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAx MS0xMC0wNiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAg ICAgICAgREZHIEpJVCAzMl82NCBzaG91bGQgY2hlY2sgdHlwZSBvZiB2YWx1ZXMgYmVpbmcgZmls bGVkIGJ5IGZpbGxTcGVjdWxhdGVJbnQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gOTY3ODYpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC04MDMsNiArODAzLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZShOb2RlJiBub2RlKQogICAgICAgICAgICAgcG9zaXRpdmUubGluaygmbV9qaXQpOwogICAg ICAgICAgICAgCiAgICAgICAgICAgICBkb3VibGVSZXN1bHQob3V0cHV0RlBSLCBtX2NvbXBpbGVJ bmRleCk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCiAgICAgICAgIEludGVnZXJP cGVyYW5kIG9wMSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24gOTY3ODYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05MjQsNiArOTI0LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZShOb2RlJiBub2RlKQogICAgICAgICAgICAgcG9zaXRpdmUubGluaygmbV9qaXQpOwogICAg ICAgICAgICAgCiAgICAgICAgICAgICBkb3VibGVSZXN1bHQob3V0cHV0RlBSLCBtX2NvbXBpbGVJ bmRleCk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCiAgICAgICAgIEludGVnZXJP cGVyYW5kIG9wMSh0aGlzLCBub2RlLmNoaWxkMSgpKTsK