69537 2011-10-06 10:24:59 -0700 conditionalize m_cachedScript stacks to just Chromium port 2011-10-06 12:30:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp japhet mitz oldest_to_newest 479255 0 gavinp 2011-10-06 10:24:59 -0700 conditionalize m_cachedScript stacks to just Chromium port 479257 1 109973 gavinp 2011-10-06 10:27:11 -0700 Created attachment 109973 Patch 479260 2 gavinp 2011-10-06 10:28:11 -0700 This should save non chromium ports from paying the price for this diagnostics. 479261 3 109973 gavinp 2011-10-06 10:29:13 -0700 Comment on attachment 109973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109973&action=review We should wait on bots for this, as #ifdefs are scary. > Source/WebCore/dom/ScriptElement.h:115 > + ZeroedInNotifyFinished, This bad indent was bugging me, so I also fixed it here. 479392 4 gavinp 2011-10-06 12:30:22 -0700 Committed r96849: <http://trac.webkit.org/changeset/96849> 109973 2011-10-06 10:27:11 -0700 2011-10-06 11:39:43 -0700 Patch bug-69537-20111006132710.patch text/plain 4064 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY4MTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MjI2NWYxOWRmNDhiNjM2 NzJkYjQyNDQ1MWMxNTYxZDhmZjBkYzQyLi5lNDc0MzZjZTBlMjMzNDI3MGJhYmEyNDg4ODhhZWYw ZmNjNDgxZDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTEtMTAtMDYgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgY29uZGl0aW9uYWxpemUg bV9jYWNoZWRTY3JpcHQgc3RhY2tzIHRvIGp1c3QgQ2hyb21pdW0gcG9ydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk1MzcKKworICAgICAgICBOZXcg c3RhY2sgc2F2aW5nIHRlbGVtZXRyeSBjb2RlIGluIFNjcmlwdEVsZW1lbnQgc2hvdWxkbid0IGhh dmUKKyAgICAgICAgYmVlbiBwdXQgaW4gYWxsIHBvcnRzOyBqdXN0IG5hcnJvd2luZyBpdCB0byB0 aGUgY2hyb21pdW0gcG9ydCB3aWxsCisgICAgICAgIHNhdmUgb3RoZXIgcG9ydHMgdGhlIG1lbW9y eSBoaXQgb2YgdGhpcyBkaWFnbm9zdGljIGNvZGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogZG9tL1Nj cmlwdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RWxlbWVudDo6U2NyaXB0 RWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRFbGVtZW50OjpyZXF1ZXN0U2NyaXB0 KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OnN0b3BMb2FkUmVxdWVzdCk6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JpcHRFbGVtZW50Ojpub3RpZnlGaW5pc2hlZCk6CisgICAgICAg ICogZG9tL1NjcmlwdEVsZW1lbnQuaDoKKworMjAxMS0xMC0wNiAgR2F2aW4gUGV0ZXJzICA8Z2F2 aW5wQGNocm9taXVtLm9yZz4KKwogICAgICAgICBzYXZlIHJlc291cmNlIHplcm9pbmcgc3RhY2tz IGluIFNjcmlwdEVsZW1lbnQgZm9yIGRlYnVnZ2luZwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0NTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1l bnQuY3BwCmluZGV4IGYzZjgwZjk3ZmM1ZDZhNDAzMTMzNTkyNWQ2YjkzYjkxYzdlYjJhYmIuLmNh NDdkNWY3Y2YxYmI4NGIwOWY4OTYwNTAzMjE3MTMyMWJlMTk2ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v U2NyaXB0RWxlbWVudC5jcHAKQEAgLTY1LDggKzY1LDEwIEBAIFNjcmlwdEVsZW1lbnQ6OlNjcmlw dEVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgYm9vbCBwYXJzZXJJbnNlcnRlZCwgYm9vbCBhbHJl YWR5CiAgICAgLCBtX3dpbGxFeGVjdXRlV2hlbkRvY3VtZW50RmluaXNoZWRQYXJzaW5nKGZhbHNl KQogICAgICwgbV9mb3JjZUFzeW5jKCFwYXJzZXJJbnNlcnRlZCkKICAgICAsIG1fd2lsbEV4ZWN1 dGVJbk9yZGVyKGZhbHNlKQorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgICwgbV9jYWNoZWRT Y3JpcHRTdGF0ZShOZXZlclNldCkKICAgICAsIG1fYmFja3RyYWNlU2l6ZSgwKQorI2VuZGlmCiB7 CiAgICAgQVNTRVJUKG1fZWxlbWVudCk7CiB9CkBAIC0yNjMsOCArMjY1LDEwIEBAIGJvb2wgU2Ny aXB0RWxlbWVudDo6cmVxdWVzdFNjcmlwdChjb25zdCBTdHJpbmcmIHNvdXJjZVVybCkKICAgICB9 CiAKICAgICBpZiAobV9jYWNoZWRTY3JpcHQpIHsKKyNpZiBQTEFURk9STShDSFJPTUlVTSkgICAg ICAKICAgICAgICAgQVNTRVJUKG1fY2FjaGVkU2NyaXB0U3RhdGUgPT0gTmV2ZXJTZXQpOwogICAg ICAgICBtX2NhY2hlZFNjcmlwdFN0YXRlID0gU2V0OworI2VuZGlmCiAgICAgICAgIHJldHVybiB0 cnVlOwogICAgIH0KIApAQCAtMzAyLDExICszMDYsMTIgQEAgdm9pZCBTY3JpcHRFbGVtZW50Ojpz dG9wTG9hZFJlcXVlc3QoKQogICAgIGlmIChtX2NhY2hlZFNjcmlwdCkgewogICAgICAgICBpZiAo IW1fd2lsbEJlUGFyc2VyRXhlY3V0ZWQpCiAgICAgICAgICAgICBtX2NhY2hlZFNjcmlwdC0+cmVt b3ZlQ2xpZW50KHRoaXMpOworI2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgICAgICBBU1NFUlQo bV9jYWNoZWRTY3JpcHRTdGF0ZSA9PSBTZXQpOwotCiAgICAgICAgIG1fY2FjaGVkU2NyaXB0U3Rh dGUgPSBaZXJvZWRJblN0b3BMb2FkUmVxdWVzdDsKICAgICAgICAgbV9iYWNrdHJhY2VTaXplID0g TWF4QmFja3RyYWNlU2l6ZTsKICAgICAgICAgV1RGR2V0QmFja3RyYWNlKG1fYmFja3RyYWNlLCAm bV9iYWNrdHJhY2VTaXplKTsKKyNlbmRpZgogICAgICAgICBtX2NhY2hlZFNjcmlwdCA9IDA7CiAg ICAgfQogfQpAQCAtMzMzLDEwICszMzgsMTIgQEAgdm9pZCBTY3JpcHRFbGVtZW50Ojpub3RpZnlG aW5pc2hlZChDYWNoZWRSZXNvdXJjZSogbykKICAgICBlbHNlCiAgICAgICAgIG1fZWxlbWVudC0+ ZG9jdW1lbnQoKS0+c2NyaXB0UnVubmVyKCktPnF1ZXVlU2NyaXB0Rm9yRXhlY3V0aW9uKHRoaXMs IG1fY2FjaGVkU2NyaXB0LCBTY3JpcHRSdW5uZXI6OkFTWU5DX0VYRUNVVElPTik7CiAKKyNpZiBQ TEFURk9STShDSFJPTUlVTSkKICAgICBBU1NFUlQobV9jYWNoZWRTY3JpcHRTdGF0ZSA9PSBTZXQp OwogICAgIG1fY2FjaGVkU2NyaXB0U3RhdGUgPSBaZXJvZWRJbk5vdGlmeUZpbmlzaGVkOwogICAg IG1fYmFja3RyYWNlU2l6ZSA9IE1heEJhY2t0cmFjZVNpemU7CiAgICAgV1RGR2V0QmFja3RyYWNl KG1fYmFja3RyYWNlLCAmbV9iYWNrdHJhY2VTaXplKTsKKyNlbmRpZgogICAgIG1fY2FjaGVkU2Ny aXB0ID0gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmgKaW5kZXggOWJjOWY4N2Yw M2YxMDk3MTc4ODk5ZjcwMzNkYjM1OWZhMjliMDUyOC4uYmNkNTUxZDVlMzliYmFlYTZjN2RhMDdm ZjM0YzRiYmRmMjRlNTZlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVs ZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5oCkBAIC0xMDUs MTMgKzEwNSwxNCBAQCBwcml2YXRlOgogICAgIFN0cmluZyBtX2NoYXJhY3RlckVuY29kaW5nOwog ICAgIFN0cmluZyBtX2ZhbGxiYWNrQ2hhcmFjdGVyRW5jb2Rpbmc7CiAgICAgCisjaWYgUExBVEZP Uk0oQ0hST01JVU0pCiAgICAgLy8gVGVtcG9yYXJ5OiBpbnRlbmRlZCB0byBoZWxwIGRlYnVnIGhv dyB3ZSBnZXQgbm90aWZ5RmluaXNoZWQoKSBjYWxsZWQgd2hlbiBtX2NhY2hlZFNjcmlwdCBpcyBu dWxsLAogICAgIC8vIHdoaWNoIHNlZW1zIHRvIHNvbWV0aW1lcyBoYXBwZW4gKHNlZSBodHRwOi8v Y29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD03NTYwNCApCiAgICAg ZW51bSB7Ci0gICAgICBOZXZlclNldCwKLSAgICAgIFNldCwKLSAgICAgIFplcm9lZEluU3RvcExv YWRSZXF1ZXN0LAotICAgICAgWmVyb2VkSW5Ob3RpZnlGaW5pc2hlZCwKKyAgICAgICAgTmV2ZXJT ZXQsCisgICAgICAgIFNldCwKKyAgICAgICAgWmVyb2VkSW5TdG9wTG9hZFJlcXVlc3QsCisgICAg ICAgIFplcm9lZEluTm90aWZ5RmluaXNoZWQsCiAgICAgfSBtX2NhY2hlZFNjcmlwdFN0YXRlOwog CiAgICAgLy8gV2UgZ3JhYiBhIGJhY2t0cmFjZSB3aGVuIHdlIHplcm8gbV9jYWNoZWRTY3JpcHQs IHNvIHRoYXQgYXQgbGF0ZXIgY3Jhc2hlcwpAQCAtMTIxLDYgKzEyMiw3IEBAIHByaXZhdGU6CiAg ICAgfTsKICAgICBpbnQgbV9iYWNrdHJhY2VTaXplOwogICAgIHZvaWQqIG1fYmFja3RyYWNlW01h eEJhY2t0cmFjZVNpemVdOworI2VuZGlmCiB9OwogCiBTY3JpcHRFbGVtZW50KiB0b1NjcmlwdEVs ZW1lbnQoRWxlbWVudCopOwo=