69533 2011-10-06 09:41:18 -0700 [EFL] Do not create cairo surfaces with the wrong size for form elements 2011-10-06 12:15:07 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim leandro lucas.de.marchi rniwa tonikitoo webkit.review.bot oldest_to_newest 479217 0 rakuco 2011-10-06 09:41:18 -0700 [EFL] Do not create cairo surfaces with the wrong size for form elements 479219 1 109969 rakuco 2011-10-06 09:43:54 -0700 Created attachment 109969 Patch 479256 2 rniwa 2011-10-06 10:26:27 -0700 Any informal reviews from EFL contributors? 479274 3 109969 leandro 2011-10-06 10:47:25 -0700 Comment on attachment 109969 Patch Informal r+. 479277 4 109969 rniwa 2011-10-06 10:50:39 -0700 Comment on attachment 109969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review > Source/WebCore/ChangeLog:21 > + No new tests, this is triggered by running running pixel tests for > + running, in this order, fast/forms/button-sizes.html, > + fast/forms/input-appearance-preventDefault.html, > + fast/forms/input-appearance-spinbutton-disabled-readonly.html, > + fast/forms/input-appearance-width.html, > + fast/forms/input-button-sizes.html, > + fast/forms/input-placeholder-text-indent.html and > + fast/forms/input-text-click-inside.html (!). Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL? 479288 5 rakuco 2011-10-06 10:59:33 -0700 (In reply to comment #4) > (From update of attachment 109969 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109969&action=review > > > Source/WebCore/ChangeLog:21 > > + No new tests, this is triggered by running running pixel tests for > > + running, in this order, fast/forms/button-sizes.html, > > + fast/forms/input-appearance-preventDefault.html, > > + fast/forms/input-appearance-spinbutton-disabled-readonly.html, > > + fast/forms/input-appearance-width.html, > > + fast/forms/input-button-sizes.html, > > + fast/forms/input-placeholder-text-indent.html and > > + fast/forms/input-text-click-inside.html (!). > > Should this patch cause a rebaseline? Don't we need to rebaseline these tests for EFL? We haven't finished upstreaming our DRT code yet, so we still don't have any baselines upstream. 479291 6 109969 rniwa 2011-10-06 11:01:06 -0700 Comment on attachment 109969 Patch Okay. Sane enough to me. 479375 7 109969 webkit.review.bot 2011-10-06 12:15:03 -0700 Comment on attachment 109969 Patch Clearing flags on attachment: 109969 Committed r96844: <http://trac.webkit.org/changeset/96844> 479376 8 webkit.review.bot 2011-10-06 12:15:07 -0700 All reviewed patches have been landed. Closing bug. 109969 2011-10-06 09:43:54 -0700 2011-10-06 12:15:03 -0700 Patch bug-69533-20111006134341.patch text/plain 2447 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTY4MTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMjkxNzEyOThhZmIxOGEz YzU2NGZmMTYyNTM3MDc3N2NlNTRkYjIwLi4zMzQwOWMxYjhmNjczMTcxZjRlOTU3MDVjMWJmOWRm MTc0MTU2ZTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMTAtMDYgIFJhcGhh ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g RG8gbm90IGNyZWF0ZSBjYWlybyBzdXJmYWNlcyB3aXRoIHRoZSB3cm9uZyBzaXplIGZvciBmb3Jt IGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02OTUzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbmRlclRoZW1lRWZsOjpjYWNoZVRoZW1lUGFydFJlc2l6ZUFuZFJlc2V0IHJlc2l6ZXMgdGhl IEVjb3JlX0V2YXMKKyAgICAgICAgYXNzb2NpYXRlZCB3aXRoIGFuIGVudHJ5LCBidXQgZGlkIG5v dCByZXNldCB0aGUgYHNpemVgIGF0dHJpYnV0ZSBvZiB0aGUKKyAgICAgICAgc3RydWN0IC0tIGlu IHByYWN0aWNlLCB0aGlzIG1lYW50IHRoZSBzdWJzZXF1ZW50IGNhbGwgdG8KKyAgICAgICAgdGhl bWVQYXJ0Q2FjaGVFbnRyeVN1cmZhY2VDcmVhdGUgd291bGQgY3JlYXRlIGEgY2Fpcm8gc3VyZmFj ZSB3aXRoIHRoZQorICAgICAgICBwcmV2aW91cyBzaXplLCB0aHVzIHJlbmRlcmluZyBhbiBlbGVt ZW50IHdpdGggdGhlIHdyb25nIHNpemUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlz IHRyaWdnZXJlZCBieSBydW5uaW5nIHJ1bm5pbmcgcGl4ZWwgdGVzdHMgZm9yCisgICAgICAgIHJ1 bm5pbmcsIGluIHRoaXMgb3JkZXIsIGZhc3QvZm9ybXMvYnV0dG9uLXNpemVzLmh0bWwsCisgICAg ICAgIGZhc3QvZm9ybXMvaW5wdXQtYXBwZWFyYW5jZS1wcmV2ZW50RGVmYXVsdC5odG1sLAorICAg ICAgICBmYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2Utc3BpbmJ1dHRvbi1kaXNhYmxlZC1yZWFk b25seS5odG1sLAorICAgICAgICBmYXN0L2Zvcm1zL2lucHV0LWFwcGVhcmFuY2Utd2lkdGguaHRt bCwKKyAgICAgICAgZmFzdC9mb3Jtcy9pbnB1dC1idXR0b24tc2l6ZXMuaHRtbCwKKyAgICAgICAg ZmFzdC9mb3Jtcy9pbnB1dC1wbGFjZWhvbGRlci10ZXh0LWluZGVudC5odG1sIGFuZAorICAgICAg ICBmYXN0L2Zvcm1zL2lucHV0LXRleHQtY2xpY2staW5zaWRlLmh0bWwgKCEpLgorCisgICAgICAg ICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lRWZsOjpjYWNoZVRoZW1lUGFydFJlc2l6ZUFuZFJlc2V0KTogUmVzZXQgdGhlCisg ICAgICAgIHNpemUgYXR0cmlidXRlIHdoZW4gcmVzaXppbmcgdGhlIGNhbnZhcy4KKwogMjAxMS0x MC0wNiAgUsOpbWkgRHVyYWZmb3J0ICA8cmVtaS5kdXJhZmZvcnRAc3QuY29tPgogCiAgICAgICAg IEZpeCBjb21waWxhdGlvbiBieSBhZGRpbmcgc29tZSBtaXNzaW5nIEVOQUJMRShWSURFT3xYU0xU KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5k ZXggZDU1YzY3YzA1YjhiN2ZlODE4Y2Y3MDMxNTU2NzViOTM1NTY3OGMyOS4uN2IxZjgzYmJhNDIy NDlkY2NmMThkYjIwNTFhNTg3YjRjNmJmNTFmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0yMTgsNiArMjE4LDggQEAgc3RydWN0IFJl bmRlclRoZW1lRWZsOjpUaGVtZVBhcnRDYWNoZUVudHJ5KiBSZW5kZXJUaGVtZUVmbDo6Y2FjaGVU aGVtZVBhcnRSZXNldCgKIHN0cnVjdCBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0Q2FjaGVFbnRy eSogUmVuZGVyVGhlbWVFZmw6OmNhY2hlVGhlbWVQYXJ0UmVzaXplQW5kUmVzZXQoRm9ybVR5cGUg dHlwZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgc3RydWN0IFJlbmRlclRoZW1lRWZsOjpUaGVtZVBh cnRDYWNoZUVudHJ5KiBlbnRyeSkKIHsKICAgICBjYWlyb19zdXJmYWNlX2ZpbmlzaChlbnRyeS0+ c3VyZmFjZSk7CisKKyAgICBlbnRyeS0+c2l6ZSA9IHNpemU7CiAgICAgZWNvcmVfZXZhc19yZXNp emUoZW50cnktPmVlLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpOwogICAgIGV2YXNfb2Jq ZWN0X3Jlc2l6ZShlbnRyeS0+bywgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKTsKIAo=