69510 2011-10-06 03:35:21 -0700 ASSERT(!m_transparencyCount) in GraphicsContext::~GraphicsContext 2011-11-15 23:24:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 69523 1 alex svillar hyatt jchaffraix mrobinson pnormand simon.fraser svillar zimmermann oldest_to_newest 479041 0 alex 2011-10-06 03:35:21 -0700 This is the backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007f2e6131b9ca in WebCore::GraphicsContext::~GraphicsContext (this=0x132c5b0, __in_chrg=<value optimized out>) at ../../../Source/WebCore/platform/graphics/GraphicsContext.cpp:91 91 ASSERT(!m_transparencyCount); (gdb) bt #0 0x00007f2e6131b9ca in WebCore::GraphicsContext::~GraphicsContext (this=0x132c5b0, __in_chrg=<value optimized out>) at ../../../Source/WebCore/platform/graphics/GraphicsContext.cpp:91 #1 0x00007f2e60a41960 in WTF::deleteOwnedPtr<WebCore::GraphicsContext> (ptr=0x132c5b0) at ../../../Source/JavaScriptCore/wtf/OwnPtrCommon.h:53 #2 0x00007f2e60a40b19 in WTF::OwnPtr<WebCore::GraphicsContext>::~OwnPtr (this=0x7fff1adfd2f0, __in_chrg=<value optimized out>) at ../../../Source/JavaScriptCore/wtf/OwnPtr.h:54 #3 0x00007f2e60bbf378 in WebKit::DrawingAreaImpl::display (this=0x123fce0, updateInfo=...) at ../../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:655 #4 0x00007f2e60bbea5d in WebKit::DrawingAreaImpl::display (this=0x123fce0) at ../../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:566 #5 0x00007f2e60bbe8f4 in WebKit::DrawingAreaImpl::displayTimerFired (this=0x123fce0) at ../../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:545 #6 0x00007f2e60bc00b2 in Timer<WebKit::DrawingAreaImpl>::fired (this=0x123fd70) at ../../../Source/WebKit2/Platform/RunLoop.h:127 #7 0x00007f2e60a38339 in RunLoop::TimerBase::timerFiredCallback (timer=0x123fd70) at ../../../Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:106 #8 0x00007f2e5c02bc09 in g_timeout_dispatch (source=0x12b4da0, callback=0x7f2e60a382ee <RunLoop::TimerBase::timerFiredCallback(RunLoop::TimerBase*)>, user_data=0x123fd70) at gmain.c:3904 #9 0x00007f2e5c02860c in g_main_dispatch (context=0x11fa0f0) at gmain.c:2439 #10 0x00007f2e5c029b52 in g_main_context_dispatch (context=0x11fa0f0) at gmain.c:3008 #11 0x00007f2e5c02a008 in g_main_context_iterate (context=0x11fa0f0, block=1, dispatch=1, self=0x11bd8b0) at gmain.c:3086 #12 0x00007f2e5c02a766 in g_main_loop_run (loop=0x11fa3a0) at gmain.c:3294 #13 0x00007f2e60a3810d in RunLoop::run () at ../../../Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:56 #14 0x00007f2e60b3f5b1 in WebKit::WebProcessMainGtk (argc=2, argv=0x7fff1adfd878) at ../../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:64 #15 0x0000000000400984 in main (argc=2, argv=0x7fff1adfd878) at ../../../Source/WebKit2/gtk/MainGtk.cpp:31 489324 1 svillar 2011-10-24 07:44:49 -0700 Alex it isn't crashing for me anymore. Could you confirm that? 489464 2 alex 2011-10-24 11:17:40 -0700 It still crashes in my desktop but it does not crash in my laptop, not sure why. Probably I should check this one in my desktop. 499933 3 svillar 2011-11-10 08:27:08 -0800 (In reply to comment #2) > It still crashes in my desktop but it does not crash in my laptop, not sure why. Probably I should check this one in my desktop. I'll take a look since it's consistently asserting for me in debug builds. 500778 4 svillar 2011-11-11 08:08:57 -0800 Julien is this the same crash than the one you observed on mac when adding tests for https://bugs.webkit.org/show_bug.cgi?id=68133 ? 500924 5 jchaffraix 2011-11-11 10:57:23 -0800 (In reply to comment #4) > Julien is this the same crash than the one you observed on mac when adding tests for https://bugs.webkit.org/show_bug.cgi?id=68133 ? It's not exactly the same (see bug 68566): it is ASSERT(m_stack.isEmpty()) that is triggered in ~GraphicsContext. It may related though. 502983 6 115181 svillar 2011-11-15 09:44:40 -0800 Created attachment 115181 Patch 502985 7 mrobinson 2011-11-15 09:48:14 -0800 There are also some tests skipped in WebKit1. I believe Philippe skipped these tests. Your patch should unskip them as well. 502991 8 svillar 2011-11-15 09:49:20 -0800 Adding some reviewers with good knowledge of that code. 503036 9 mrobinson 2011-11-15 10:35:25 -0800 *** Bug 71454 has been marked as a duplicate of this bug. *** 503075 10 115181 simon.fraser 2011-11-15 11:14:40 -0800 Comment on attachment 115181 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115181&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:1286 > + if (pushTransparencyLayer) > + paintInfo.context->endTransparencyLayer(); It would be nice if we had an RAII class for begin/endTransparencyLayer. 503623 11 svillar 2011-11-15 23:24:49 -0800 Committed r100413: <http://trac.webkit.org/changeset/100413> 115181 2011-11-15 09:44:40 -0800 2011-11-15 11:14:39 -0800 Patch bug-69510-20111115184438.patch text/plain 3445 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTlmYzIxNDRkOWYzMDc1 ODkzZjhmNmRjZWUwZWY3YzA2MzNlOWNjNy4uZTMwZDNmZDcyZjIwMmU2ZDM3OWQ1YjljMzI2NmUz MWIwNjQ3OGI2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTE1ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIFtH VEtdIGZhc3QvY3NzL3dlYmtpdC1tYXNrLWNyYXNoLWZpZWxkc2V0LWxlZ2VuZC5odG1sIGFzc2Vy dHMgV2ViS2l0V2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njk1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBFbmQgdGhlIGN1cnJlbnQgdHJhbnNwYXJlbmN5IGxheWVyIGJlZm9yZSBlYXJs eSByZXR1cm5pbmcgZnJvbQorICAgICAgICBwYWludE1hc2soKSB3aGVuIHRoZXJlIGlzIGEgbWFz a0JveEltYWdlIHdoaWNoIGlzIHN0aWxsIGJlaW5nCisgICAgICAgIGxvYWRlZC4gVGhpcyB3aWxs IGJhbGFuY2UgdGhlIHByZXZpb3VzIGNhbGwgdG8KKyAgICAgICAgYmVnaW5UcmFuc3BhcmVuY3lM YXllcigpLgorCisgICAgICAgICogcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SW5saW5lRmxvd0JveDo6cGFpbnRNYXNrKToKKwogMjAxMS0xMS0xNCAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIGFsbCBj dXN0b20gY29uc3RydWN0b3JzIG9mIEV2ZW50cyBpbiBWOApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0lubGluZUZsb3dCb3guY3BwCmluZGV4IDVjNDlkZGRhYjU5OWEyMTEzYTU0MzU0NGJhZmY2 M2RlNWEwMzhiYTkuLjJkZTA4YjZkM2Q2YmRkMGRhNTRlYjJlZmI4NzZiYjMyNzFiZTYyN2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lRmxvd0JveC5jcHAKQEAgLTEyODEsOCAr MTI4MSwxMSBAQCB2b2lkIElubGluZUZsb3dCb3g6OnBhaW50TWFzayhQYWludEluZm8mIHBhaW50 SW5mbywgY29uc3QgTGF5b3V0UG9pbnQmIHBhaW50T2ZmcwogICAgIHBhaW50RmlsbExheWVycyhw YWludEluZm8sIENvbG9yKCksIHJlbmRlcmVyKCktPnN0eWxlKCktPm1hc2tMYXllcnMoKSwgcGFp bnRSZWN0LCBjb21wb3NpdGVPcCk7CiAgICAgCiAgICAgYm9vbCBoYXNCb3hJbWFnZSA9IG1hc2tC b3hJbWFnZSAmJiBtYXNrQm94SW1hZ2UtPmNhblJlbmRlcihyZW5kZXJlcigpLCByZW5kZXJlcigp LT5zdHlsZSgpLT5lZmZlY3RpdmVab29tKCkpOwotICAgIGlmICghaGFzQm94SW1hZ2UgfHwgIW1h c2tCb3hJbWFnZS0+aXNMb2FkZWQoKSkKKyAgICBpZiAoIWhhc0JveEltYWdlIHx8ICFtYXNrQm94 SW1hZ2UtPmlzTG9hZGVkKCkpIHsKKyAgICAgICAgaWYgKHB1c2hUcmFuc3BhcmVuY3lMYXllcikK KyAgICAgICAgICAgIHBhaW50SW5mby5jb250ZXh0LT5lbmRUcmFuc3BhcmVuY3lMYXllcigpOwog ICAgICAgICByZXR1cm47IC8vIERvbid0IHBhaW50IGFueXRoaW5nIHdoaWxlIHdlIHdhaXQgZm9y IHRoZSBpbWFnZSB0byBsb2FkLgorICAgIH0KIAogICAgIC8vIFRoZSBzaW1wbGUgY2FzZSBpcyB3 aGVyZSB3ZSBhcmUgdGhlIG9ubHkgYm94IGZvciB0aGlzIG9iamVjdC4gIEluIHRob3NlCiAgICAg Ly8gY2FzZXMgb25seSBhIHNpbmdsZSBjYWxsIHRvIGRyYXcgaXMgcmVxdWlyZWQuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MmI5NTA1ZDgzMjIyMzVhMDBiNmM3OGNmNjBlYjlhNGQ3MjcwMDBhNC4uMmRjMDk0NzU3N2UxMjgw ZmI1NGRhODI1YjJiMWE0ZjRkYjg3NmYwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTEx LTE1ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAg IFtXSzJdIFtHVEtdIGZhc3QvY3NzL3dlYmtpdC1tYXNrLWNyYXNoLWZpZWxkc2V0LWxlZ2VuZC5o dG1sIGFzc2VydHMgV2ViS2l0V2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay13azIvU2tpcHBlZDogdW5za2lwcGVk IGZhc3QvY3NzL3dlYmtpdC1tYXNrLWNyYXNoLWZpZWxkc2V0LWxlZ2VuZC5odG1sCisKIDIwMTEt MTEtMTQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIEdUSyBiYXNlbGluZXMgZm9yIDIgbmV3IHN2ZyB0ZXN0cy4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay13azIvU2tpcHBlZAppbmRleCA2M2QwYTQ5NjIzYzJjODA3YzgwOWNjNDRhNTZi MmQwYjBhOWNmNTdmLi40OTNjMWQyZTc0YjdhYzg0NmMxNTJkYjhkNDczYjc3ZTUxYzNmZWViIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2syL1NraXBwZWQKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9Ta2lwcGVkCkBAIC03OSwxMCArNzksNiBAQCBlZGl0 aW5nL2lucHV0L2VtYWNzLWN0cmwtby5odG1sCiAjIFRFU1RTIENSQVNISU5HCiAjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjCiAKLSMgW1dLMl0gW0dUS10gZmFzdC9jc3Mvd2Via2l0LW1hc2stY3Jhc2gt ZmllbGRzZXQtbGVnZW5kLmh0bWwgYXNzZXJ0cyBXZWJLaXRXZWJQcm9jZXNzCi0jIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTUxMAotZmFzdC9jc3Mvd2Via2l0LW1h c2stY3Jhc2gtZmllbGRzZXQtbGVnZW5kLmh0bWwKLQogIyBbV0syXSBbR1RLXSBwbHVnaW5zL2Rl c3Ryb3ktZHVyaW5nLW5wcC1uZXcuaHRtbCBzZWdmYXVsdHMgV2ViS2l0V2ViUHJvY2VzcwogIyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk1MTIKIHBsdWdpbnMvZGVz dHJveS1kdXJpbmctbnBwLW5ldy5odG1sCg==