69505 2011-10-06 01:02:06 -0700 [EFL] Change data type of parameter in ewk_view_viewport_attributes_get() 2011-10-06 19:22:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 479013 0 gyuyoung.kim 2011-10-06 01:02:06 -0700 ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport. However, it is better to use *int* data type as parameter data type instead of *float* casting. 479016 1 109931 gyuyoung.kim 2011-10-06 01:05:25 -0700 Created attachment 109931 Patch 479127 2 rakuco 2011-10-06 06:40:16 -0700 LGTM. 479304 3 109931 kling 2011-10-06 11:16:28 -0700 Comment on attachment 109931 Patch r=me 479731 4 109931 webkit.review.bot 2011-10-06 19:22:11 -0700 Comment on attachment 109931 Patch Clearing flags on attachment: 109931 Committed r96890: <http://trac.webkit.org/changeset/96890> 479732 5 webkit.review.bot 2011-10-06 19:22:17 -0700 All reviewed patches have been landed. Closing bug. 109931 2011-10-06 01:05:25 -0700 2011-10-06 19:22:11 -0700 Patch bug-69505-20111006170524.patch text/plain 5038 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3ODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA5OTcwZjYwMWI0 YWQ1NDlkYjVmNjY2OGQ3NDliYmFjMWE2MDY4NjllLi42MzgwMGFkODIzYTZiN2ViMzVmZjNkMGRm NTczOTY1OGJlYzJkYTZhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MTAtMDUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBbRUZMXSBDaGFuZ2UgZGF0YSB0eXBlIG9mIHBhcmFtZXRlciBpbiBld2tfdmlld192aWV3cG9y dF9hdHRyaWJ1dGVzX2dldCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njk1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2dldCgpIGhhcyB1c2VkIGlt cGxpY2l0IGNhc3RpbmcgZm9yIHdpZHRoIGFuZCBoZWlnaHQgb2Ygdmlld3BvcnQuCisgICAgICAg IEhvd2V2ZXIsIGl0IGlzIGJldHRlciB0byB1c2UgKmludCogZGF0YSB0eXBlIGFzIHBhcmFtZXRl ciBkYXRhIHR5cGUgaW5zdGVhZCBvZiAqZmxvYXQqIGNhc3RpbmcuCisKKyAgICAgICAgKiBld2sv ZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19nZXQp OgorICAgICAgICAqIGV3ay9ld2tfdmlldy5oOgorCiAyMDExLTEwLTA0ICBHeXV5b3VuZyBLaW0g IDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gT25seSBzZXQgd2hl biB0aGUgY3VzdG9tIGVuY29kaW5nIGlzIGRpZmZlcmVudCBmcm9tIGV4aXN0aW5nIHZhbHVlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBhY2M3NWE0YTk3NzNkNzY3MWVmOTIyOWNk NGUxMTUxMGNhMDdiN2Y3Li5kZThkOGQzY2MyMDIxMDQ4MmJhN2UxM2E1YjFhYWZmZjU0NGVhODk2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTM0NTYsNyArMzQ1Niw3IEBAIHZv aWQgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19zZXQoRXZhc19PYmplY3QqIG8sIGNvbnN0 IFdlYkNvcmU6OlZpZXdwb3J0QXJnCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfY2Fs bChvLCAidmlld3BvcnQsY2hhbmdlZCIsIDApOwogfQogCi12b2lkIGV3a192aWV3X3ZpZXdwb3J0 X2F0dHJpYnV0ZXNfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBvLCBmbG9hdCogdywgZmxvYXQqIGgs IGZsb2F0KiBpbml0X3NjYWxlLCBmbG9hdCogbWF4X3NjYWxlLCBmbG9hdCogbWluX3NjYWxlLCBm bG9hdCogZGV2aWNlX3BpeGVsX3JhdGlvLCBFaW5hX0Jvb2wqIHVzZXJfc2NhbGFibGUpCit2b2lk IGV3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBvLCBp bnQqIHcsIGludCogaCwgZmxvYXQqIGluaXRfc2NhbGUsIGZsb2F0KiBtYXhfc2NhbGUsIGZsb2F0 KiBtaW5fc2NhbGUsIGZsb2F0KiBkZXZpY2VfcGl4ZWxfcmF0aW8sIEVpbmFfQm9vbCogdXNlcl9z Y2FsYWJsZSkKIHsKICAgICBXZWJDb3JlOjpWaWV3cG9ydEF0dHJpYnV0ZXMgYXR0cmlidXRlcyA9 IF9ld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2NvbXB1dGUobyk7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmgKaW5kZXggMjdkNmE2YmMyNDNmNWU0OWIxOWE2ODhkYTZhOTlkNzc5MmEzZDgz Yy4uYWM1NWRjNjk3MTIxOTFlMjBkMTQ3OTU0NzNkN2MzNjIzYTdjOTJiZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKQEAgLTIwNjIsNyArMjA2Miw3IEBAIEVBUEkgRWluYV9Cb29sIGV3a192 aWV3X3BhaW50X2NvbnRlbnRzKEV3a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdiwgY2Fpcm9fdCAq Y3IsCiAgKiBAcGFyYW0gZGV2aWNlX3BpeGVsX3JhdGlvIHRoZSBwb2ludGVyIHRvIHN0b3JlIHRo ZSBkZXZpY2UgcGl4ZWwgcmF0aW8gdmFsdWUKICAqIEBwYXJhbSB1c2VyX3NjYWxhYmxlIHRoZSBw b2ludGVyIHRvIHN0b3JlIGlmIHVzZXIgY2FuIHNjYWxlIHZpZXdwb3J0CiAgKi8KLUVBUEkgdm9p ZCBld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2dldChjb25zdCBFdmFzX09iamVjdCAqbywg ZmxvYXQgKncsIGZsb2F0ICpoLCBmbG9hdCAqaW5pdF9zY2FsZSwgZmxvYXQgKm1heF9zY2FsZSwg ZmxvYXQgKm1pbl9zY2FsZSwgZmxvYXQgKmRldmljZV9waXhlbF9yYXRpbyAsIEVpbmFfQm9vbCAq dXNlcl9zY2FsYWJsZSk7CitFQVBJIHZvaWQgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19n ZXQoY29uc3QgRXZhc19PYmplY3QgKm8sIGludCAqdywgaW50ICpoLCBmbG9hdCAqaW5pdF9zY2Fs ZSwgZmxvYXQgKm1heF9zY2FsZSwgZmxvYXQgKm1pbl9zY2FsZSwgZmxvYXQgKmRldmljZV9waXhl bF9yYXRpbyAsIEVpbmFfQm9vbCAqdXNlcl9zY2FsYWJsZSk7CiAKIC8qKgogICogU2V0cyB0aGUg em9vbSByYW5nZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCBmN2U0YThlZTc0YjYwNzkzYjJmYzc0MGNiZDg0MzcyOTA0ZjM2ZjFhLi5hYjI3MGM3 ZGNhZTI0YmRhNGZlMzI0NDFiYzJjNDY1ZTljYjRkOGI4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDUg IEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZM XSBDaGFuZ2UgZGF0YSB0eXBlIG9mIHBhcmFtZXRlciBpbiBld2tfdmlld192aWV3cG9ydF9hdHRy aWJ1dGVzX2dldCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEVXZWJMYXVuY2hlci9tYWluLmM6IFVzZSAqaW50KiB2YXJpYWJsZXMgZm9yIHdpZHRo IGFuZCBoZWlnaHQgb2Ygdmlld3BvcnQgbWV0YSB0YWcuCisgICAgICAgIChvbl92aWV3cG9ydF9j aGFuZ2VkKToKKwogMjAxMS0xMC0wNSAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIHdpbmRvdy5sb2NhdGlvbi5ocmVmIGFuZCBvdGhlcnMgbmVlZGxlc3NseSBk ZWNvZGVzIFVSSS1lbmNvZGVkIGNoYXJhY3RlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVu Y2hlci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IDZhZTlmM2QwZTcx NDYzM2YyY2M0YmIxMWFiNzVkN2UzZmRjZDgzM2IuLjQxM2YxNDY1N2EyZDVmYTIyODAyZjg4NWYy ZjM1Y2Q5ZGY1YWE0NWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysr IGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNDQwLDcgKzQ0MCw4IEBAIG9uX3ZpZXdw b3J0X2NoYW5nZWQodm9pZCogdXNlcl9kYXRhLCBFdmFzX09iamVjdCogd2Vidmlldywgdm9pZCog ZXZlbnRfaW5mbykKIHsKICAgICBFTGF1bmNoZXIgKmFwcCA9IChFTGF1bmNoZXIgKil1c2VyX2Rh dGE7CiAKLSAgICBmbG9hdCB3LCBoLCBpbml0U2NhbGUsIG1pblNjYWxlLCBtYXhTY2FsZSwgZGV2 aWNlUGl4ZWxSYXRpbzsKKyAgICBpbnQgdywgaDsKKyAgICBmbG9hdCBpbml0U2NhbGUsIG1pblNj YWxlLCBtYXhTY2FsZSwgZGV2aWNlUGl4ZWxSYXRpbzsKICAgICBFaW5hX0Jvb2wgdXNlclNjYWxh YmxlOwogCiAgICAgZXdrX3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19nZXQod2VidmlldywgJncs ICZoLCAmaW5pdFNjYWxlLCAmbWF4U2NhbGUsICZtaW5TY2FsZSwgJmRldmljZVBpeGVsUmF0aW8s ICZ1c2VyU2NhbGFibGUpOwpAQCAtNDQ4LDkgKzQ0OSw5IEBAIG9uX3ZpZXdwb3J0X2NoYW5nZWQo dm9pZCogdXNlcl9kYXRhLCBFdmFzX09iamVjdCogd2Vidmlldywgdm9pZCogZXZlbnRfaW5mbykK ICAgICAvKioKICAgICAgKiBJZiB0aGVyZSBpcyBubyBhcmd1bWVudCBpbiB2aWV3cG9ydCB0YWcs IGFyZ3VtZW50J3MgdmFsdWUgaXMgLTEuCiAgICAgICovCi0gICAgaWYgKChpbnQpdyA9PSAtMSkK KyAgICBpZiAodyA9PSAtMSkKICAgICAgICAgdyA9IERFRkFVTFRfV0lEVEg7Ci0gICAgaWYgKChp bnQpaCA9PSAtMSkKKyAgICBpZiAoaCA9PSAtMSkKICAgICAgICAgaCA9IERFRkFVTFRfSEVJR0hU OwogICAgIGlmICgoaW50KWluaXRTY2FsZSA9PSAtMSkKICAgICAgICAgaW5pdFNjYWxlID0gREVG QVVMVF9aT09NX0lOSVQ7IC8vIFRoZXJlJ3Mgbm8gc2NhbGUgc2VwYXJhdGVkIGZyb20gem9vbWlu ZyBpbiB3ZWJraXQtZWZsLgpAQCAtNDYzLDggKzQ2NCw4IEBAIG9uX3ZpZXdwb3J0X2NoYW5nZWQo dm9pZCogdXNlcl9kYXRhLCBFdmFzX09iamVjdCogd2Vidmlldywgdm9pZCogZXZlbnRfaW5mbykK ICAgICBpZiAoKGludCl1c2VyU2NhbGFibGUgPT0gLTEpCiAgICAgICAgIHVzZXJTY2FsYWJsZSA9 IEVJTkFfVFJVRTsKIAotICAgIGFwcC0+dmlld3BvcnQudyA9IChpbnQpdzsKLSAgICBhcHAtPnZp ZXdwb3J0LmggPSAoaW50KWg7CisgICAgYXBwLT52aWV3cG9ydC53ID0gdzsKKyAgICBhcHAtPnZp ZXdwb3J0LmggPSBoOwogICAgIGFwcC0+dmlld3BvcnQuaW5pdFNjYWxlID0gaW5pdFNjYWxlOwog ICAgIGFwcC0+dmlld3BvcnQubWluU2NhbGUgPSBtaW5TY2FsZTsKICAgICBhcHAtPnZpZXdwb3J0 Lm1heFNjYWxlID0gbWF4U2NhbGU7Cg==