69491 2011-10-05 17:40:10 -0700 Define a log2f() function for Windows in wtf/MathExtras.h 2011-10-05 19:03:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers aroben darin webkit.review.bot oldest_to_newest 478827 0 crogers 2011-10-05 17:40:10 -0700 Define a log2f() function for Windows in wtf/MathExtras.h 478828 1 109893 crogers 2011-10-05 17:42:11 -0700 Created attachment 109893 Patch 478833 2 109893 darin 2011-10-05 17:50:00 -0700 Comment on attachment 109893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109893&action=review > Source/JavaScriptCore/wtf/MathExtras.h:162 > + return logf(num) / 0.693147180559945309417232121458176568f; Probably don’t need quite this many digits, but since I don’t know how many we do need, guess we should leave it like this. 478871 3 109893 webkit.review.bot 2011-10-05 19:03:27 -0700 Comment on attachment 109893 Patch Clearing flags on attachment: 109893 Committed r96780: <http://trac.webkit.org/changeset/96780> 478872 4 webkit.review.bot 2011-10-05 19:03:31 -0700 All reviewed patches have been landed. Closing bug. 109893 2011-10-05 17:42:11 -0700 2011-10-05 19:03:27 -0700 Patch bug-69491-20111005174210.patch text/plain 3629 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk2 MjJiZTc3ZmYxMGFmOTBiOGY3ZjMyZDI5MjFiYjFkY2IxNjUwNzcuLmQxNjZkNWVhZjI2YWFlMjAx M2VjMTJhZjk4ZThmN2RlYjM2OTFkZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDExLTEwLTA1ICBDaHJpcyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+ CisKKyAgICAgICAgRGVmaW5lIGEgbG9nMmYoKSBmdW5jdGlvbiBmb3IgV2luZG93cyBpbiB3dGYv TWF0aEV4dHJhcy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02OTQ5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogd3RmL01hdGhFeHRyYXMuaDoKKyAgICAgICAgKGxvZzJmKToKKwogMjAxMS0xMC0wNSAg RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEFzc2VydGlvbiBoaXQg aW4gSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlIG9uIFNMIGJvdHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKaW5kZXggZjY1MWRhNWNlZGU1MGIyYmZmZWE3Zjg2 ZGViMTYxNTgxOTY4ZjNjNy4uNWQzN2QzYzg0YmZkODljYmRiZmU2NTc0NWM1MGUzNzE1YmM1Yjk4 OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTE0OSwxMyArMTQ5 LDE5IEBAIGlubGluZSBmbG9hdCBuZXh0YWZ0ZXJmKGZsb2F0IHgsIGZsb2F0IHkpIHsgcmV0dXJu IHggPiB5ID8geCAtIEZMVF9FUFNJTE9OIDogeCArCiBpbmxpbmUgZG91YmxlIGNvcHlzaWduKGRv dWJsZSB4LCBkb3VibGUgeSkgeyByZXR1cm4gX2NvcHlzaWduKHgsIHkpOyB9CiBpbmxpbmUgaW50 IGlzZmluaXRlKGRvdWJsZSB4KSB7IHJldHVybiBfZmluaXRlKHgpOyB9CiAKLS8vIE1TVkMncyBt YXRoLmggZG9lcyBub3QgY3VycmVudGx5IHN1cHBseSBsb2cyLgorLy8gTVNWQydzIG1hdGguaCBk b2VzIG5vdCBjdXJyZW50bHkgc3VwcGx5IGxvZzIgb3IgbG9nMmYuCiBpbmxpbmUgZG91YmxlIGxv ZzIoZG91YmxlIG51bSkKIHsKICAgICAvLyBUaGlzIGNvbnN0YW50IGlzIHJvdWdobHkgTV9MTjIs IHdoaWNoIGlzIG5vdCBwcm92aWRlZCBieSBkZWZhdWx0IG9uIFdpbmRvd3MuCiAgICAgcmV0dXJu IGxvZyhudW0pIC8gMC42OTMxNDcxODA1NTk5NDUzMDk0MTcyMzIxMjE0NTgxNzY1Njg7CiB9CiAK K2lubGluZSBmbG9hdCBsb2cyZihmbG9hdCBudW0pCit7CisgICAgLy8gVGhpcyBjb25zdGFudCBp cyByb3VnaGx5IE1fTE4yLCB3aGljaCBpcyBub3QgcHJvdmlkZWQgYnkgZGVmYXVsdCBvbiBXaW5k b3dzLgorICAgIHJldHVybiBsb2dmKG51bSkgLyAwLjY5MzE0NzE4MDU1OTk0NTMwOTQxNzIzMjEy MTQ1ODE3NjU2OGY7Cit9CisKIC8vIFdvcmsgYXJvdW5kIGEgYnVnIGluIFdpbiwgd2hlcmUgYXRh bjIoKy1pbmZpbml0eSwgKy1pbmZpbml0eSkgeWllbGRzIE5hTiBpbnN0ZWFkIG9mIHNwZWNpZmlj IHZhbHVlcy4KIGlubGluZSBkb3VibGUgd3RmX2F0YW4yKGRvdWJsZSB4LCBkb3VibGUgeSkKIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMTZmZDBlZGI3Mzg0NDE2OWRjYjY3MGI3Y2UxMmFhYjYxMzI5ZmY0Li42 MmJmOWI3OWViZTA3OWFlNmUzN2JkYjAyMjM0NGVmNzAzYzc4NGVkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTcgQEAKIDIwMTEtMTAtMDUgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNv bT4KIAorICAgICAgICBEZWZpbmUgYSBsb2cyZigpIGZ1bmN0aW9uIGZvciBXaW5kb3dzIGluIHd0 Zi9NYXRoRXh0cmFzLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY5NDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGNoYW5nZSBpcyB0ZXN0ZWQgaW4gZXhpc3RpbmcgbGF5 b3V0IHRlc3RzLgorCisgICAgICAgICogd2ViYXVkaW8vQXVkaW9QYXJhbVRpbWVsaW5lLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvUGFyYW1UaW1lbGluZTo6dmFsdWVzRm9yVGltZVJhbmdl SW1wbCk6CisKKzIwMTEtMTAtMDUgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4K KwogICAgICAgICBGaXggV2luZG93cyBidWlsZCAtIGl0IGRvZXNuJ3QgaGF2ZSBhIGxvZzJmKCkg ZnVuY3Rpb24uLi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY5NDczCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFy YW1UaW1lbGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb1BhcmFtVGltZWxp bmUuY3BwCmluZGV4IGMwMTU3YmRiOWEzMzMwMTg0ZWU4NWFjNzMzNmMyNDJjZDRjNGM3MWQuLjJl ZTEzNGFlMzdhMjIxMDI4OTZkOTZlOGVhYzMwYTNhNDgzZjNiY2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvUGFyYW1UaW1lbGluZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvd2ViYXVkaW8vQXVkaW9QYXJhbVRpbWVsaW5lLmNwcApAQCAtMjQ2LDkgKzI0Niw4IEBA IGZsb2F0IEF1ZGlvUGFyYW1UaW1lbGluZTo6dmFsdWVzRm9yVGltZVJhbmdlSW1wbChmbG9hdCBz dGFydFRpbWUsCiAgICAgICAgICAgICAgICAgICAgIHZhbHVlc1t3cml0ZUluZGV4XSA9IHZhbHVl OwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAvLyBJbnRlcnBvbGF0ZSBp biBsb2cgc3BhY2UuCi0gICAgICAgICAgICAgICAgLy8gRklYTUU6IHdlIHNob3VsZCBqdXN0IHVz ZSBsb2cyZigpLCBidXQgV2luZG93cyBkb2Vzbid0IGhhdmUgdGhpcyBmdW5jdGlvbi4KLSAgICAg ICAgICAgICAgICB2YWx1ZTEgPSBuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGxvZzIodmFsdWUxKSk7 Ci0gICAgICAgICAgICAgICAgdmFsdWUyID0gbmFycm93UHJlY2lzaW9uVG9GbG9hdChsb2cyKHZh bHVlMikpOworICAgICAgICAgICAgICAgIHZhbHVlMSA9IGxvZzJmKHZhbHVlMSk7CisgICAgICAg ICAgICAgICAgdmFsdWUyID0gbG9nMmYodmFsdWUyKTsKIAogICAgICAgICAgICAgICAgIC8vIEZJ WE1FOiBvcHRpbWl6ZSB0byBub3QgdXNlIHBvdygpIGluIGlubmVyIGxvb3AsIHRoaXMgaXMganVz dCBhIHNpbXBsZSBleHBvbmVudGlhbCByYW1wLgogICAgICAgICAgICAgICAgIGZvciAoOyB3cml0 ZUluZGV4IDwgZmlsbFRvRnJhbWU7ICsrd3JpdGVJbmRleCkgewo=