69482 2011-10-05 17:11:08 -0700 Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown 2011-10-06 08:35:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 478799 0 mnaganov 2011-10-05 17:11:08 -0700 Open DevTools, go to Profiles, take a heap snapshot, open it. Now try to show color legends popup by pressing the '?' button on the status bar of a snapshot view. Expected: a popup is shown. Actual: button disappears, "Uncaught TypeError: Cannot call method 'offsetRelativeToWindow' of undefined", source: chrome-devtools://devtools/Popover.js (116) in the console. 478800 1 109884 mnaganov 2011-10-05 17:13:22 -0700 Created attachment 109884 Patch 479174 2 mnaganov 2011-10-06 08:35:13 -0700 Manually committed http://trac.webkit.org/changeset/96812: Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown. https://bugs.webkit.org/show_bug.cgi?id=69482 Reviewed by Yury Semikhatsky. * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._helpClicked): 109884 2011-10-05 17:13:22 -0700 2011-10-06 06:31:32 -0700 Patch patch-69482 text/plain 2261 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MmY4MTc2Li5hZDYwOWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMTAtMDUgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIEhlYXAgU25hcHNob3QgY29sb3Jz IGxlZ2VuZCBoZWxwIHBvcHVwIGlzIG5vdCBzaG93bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVh cHNob3RWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3 LnByb3RvdHlwZS5faGVscENsaWNrZWQpOgorCiAyMDExLTEwLTA0ICBNaWtoYWlsIE5hZ2Fub3Yg IDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRmFjdG9y IG91dCBvYmplY3QgcHJvcGVydGllcyBwb3B1cC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVkSGVhcHNob3RWaWV3LmpzCmluZGV4IDAw OTY2NTEuLjNiZmFhM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qcwpAQCAtMTA4Myw3ICsxMDgzLDcg QEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3LnByb3RvdHlwZSA9IHsKIAogICAg IF9oZWxwQ2xpY2tlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewotICAgICAgICBpZiAoIXRoaXMu aGVscFBvcG92ZXIpIHsKKyAgICAgICAgaWYgKCF0aGlzLl9oZWxwUG9wb3ZlckNvbnRlbnRFbGVt ZW50KSB7CiAgICAgICAgICAgICB2YXIgcmVmVHlwZXMgPSBbImE6IiwgImNvbnNvbGUtZm9ybWF0 dGVkLW5hbWUiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoInByb3BlcnR5IiksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIjA6IiwgImNvbnNvbGUtZm9ybWF0dGVkLW5hbWUiLCBXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoImVsZW1lbnQiKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi YToiLCAiY29uc29sZS1mb3JtYXR0ZWQtbnVtYmVyIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJj b250ZXh0IHZhciIpLApAQCAtMTExOSw3ICsxMTE5LDggQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVk SGVhcHNob3RWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICByb3cuYXBwZW5kQ2hp bGQob2JqQ2VsbCk7CiAgICAgICAgICAgICAgICAgY29udGVudEVsZW1lbnQuYXBwZW5kQ2hpbGQo cm93KTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHRoaXMuaGVscFBvcG92ZXIgPSBuZXcg V2ViSW5zcGVjdG9yLlBvcG92ZXIoY29udGVudEVsZW1lbnQpOworICAgICAgICAgICAgdGhpcy5f aGVscFBvcG92ZXJDb250ZW50RWxlbWVudCA9IGNvbnRlbnRFbGVtZW50OworICAgICAgICAgICAg dGhpcy5oZWxwUG9wb3ZlciA9IG5ldyBXZWJJbnNwZWN0b3IuUG9wb3ZlcigpOwogCiAgICAgICAg ICAgICBmdW5jdGlvbiBhcHBlbmRIZWxwKGhlbHAsIGluZGV4LCBjZWxsKQogICAgICAgICAgICAg ewpAQCAtMTEzOCw3ICsxMTM5LDcgQEAgV2ViSW5zcGVjdG9yLkRldGFpbGVkSGVhcHNob3RWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRoaXMuaGVscFBvcG92ZXIudmlzaWJsZSkKICAg ICAgICAgICAgIHRoaXMuaGVscFBvcG92ZXIuaGlkZSgpOwogICAgICAgICBlbHNlCi0gICAgICAg ICAgICB0aGlzLmhlbHBQb3BvdmVyLnNob3codGhpcy5oZWxwQnV0dG9uLmVsZW1lbnQpOworICAg ICAgICAgICAgdGhpcy5oZWxwUG9wb3Zlci5zaG93KHRoaXMuX2hlbHBQb3BvdmVyQ29udGVudEVs ZW1lbnQsIHRoaXMuaGVscEJ1dHRvbi5lbGVtZW50KTsKICAgICB9LAogCiAgICAgX3N0YXJ0UmV0 YWluZXJzSGVhZGVyRHJhZ2dpbmc6IGZ1bmN0aW9uKGV2ZW50KQo=