<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>69473</bug_id>
          
          <creation_ts>2011-10-05 15:40:18 -0700</creation_ts>
          <short_desc>Fix Windows build - it doesn&apos;t have a log2f() function...</short_desc>
          <delta_ts>2011-10-05 16:40:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Rogers">crogers</reporter>
          <assigned_to name="Chris Rogers">crogers</assigned_to>
          <cc>aroben</cc>
    
    <cc>darin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>478747</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2011-10-05 15:40:18 -0700</bug_when>
    <thetext>Fix Windows build - it doesn&apos;t have a log2f() function...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478753</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2011-10-05 15:48:06 -0700</bug_when>
    <thetext>Committed r96761: &lt;http://trac.webkit.org/changeset/96761&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478756</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-10-05 15:50:18 -0700</bug_when>
    <thetext>Another option is to add a log2f function to wtf/MathExtras.h for Windows to use.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478761</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-10-05 16:03:02 -0700</bug_when>
    <thetext>In the past we have fixed problems like this by adding functions to MathExtras.h to smooth over differences between what platforms have in their &lt;math.h&gt; headers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478769</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-10-05 16:16:28 -0700</bug_when>
    <thetext>Darin is like my much more eloquent shadow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478775</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-10-05 16:32:09 -0700</bug_when>
    <thetext>Next time I will read before I write, because Adam is sure to get there first ;-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478778</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2011-10-05 16:40:03 -0700</bug_when>
    <thetext>Yes, this was certainly a quick fix.  I wanted to get the chromium win builders happy ASAP.

The real fix for my code is not to use the log2() functions at all since they&apos;re inefficient.  There&apos;s a much better algorithm for what I&apos;m doing there (exponential ramp).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>478779</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Rogers">crogers</who>
    <bug_when>2011-10-05 16:40:52 -0700</bug_when>
    <thetext>In the meantime, I&apos;ll try to fix this as you suggest.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>