69468 2011-10-05 14:57:56 -0700 media/video-loop.html is failing on Lion because of negative currentTime() 2011-10-10 15:00:40 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67509 1 jer.noble jer.noble oldest_to_newest 478708 0 jer.noble 2011-10-05 14:57:56 -0700 Both the following tests fail because the AVFoundation back-end on Lion can report a negative currentTime. media/video-loop.html media/video-pause-immediately.html 479467 1 jer.noble 2011-10-06 14:07:21 -0700 Actually, after digging into this, only video-loop.html is being affected by the negative-time problem. 479470 2 110017 jer.noble 2011-10-06 14:10:19 -0700 Created attachment 110017 Patch 479595 3 110017 darin 2011-10-06 16:07:39 -0700 Comment on attachment 110017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110017&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:435 > + float seconds = narrowPrecisionToFloat(CMTimeGetSeconds(itemTime)); > + return max(seconds, 0.0f); Should not need a local variable for this. Probably reads better without it. 479609 4 jer.noble 2011-10-06 16:37:25 -0700 (In reply to comment #3) > (From update of attachment 110017 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110017&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:435 > > + float seconds = narrowPrecisionToFloat(CMTimeGetSeconds(itemTime)); > > + return max(seconds, 0.0f); > > Should not need a local variable for this. Probably reads better without it. You're right; I was thinking of the MAX macro. I'll change this. Thanks! 481193 5 jer.noble 2011-10-10 15:00:40 -0700 Committed r97093: <http://trac.webkit.org/changeset/97093> 110017 2011-10-06 14:10:19 -0700 2011-10-06 16:07:39 -0700 Patch bug-69468-20111006141018.patch text/plain 1929 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3NDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZTZmYjM1YWU5YmMyNTI5 OTI0YTg0YWI3ZTViNGMyOGNjOWYwNjYxLi5mODJlODY0Njg3NmRiN2I5NTk0YjkwYzNhNWE2MDFm NGI2Y2M5NmRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMDYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgbWVkaWEvdmlkZW8tbG9vcC5o dG1sIGlzIGZhaWxpbmcgb24gTGlvbiBiZWNhdXNlIG9mIG5lZ2F0aXZlIGN1cnJlbnRUaW1lKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDY4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBDb3ZlcmVkIGJ5IG1lZGlhL3ZpZGVvLWxvb3AuaHRtbCB0ZXN0LgorCisgICAgICAgIEFW Rm91bmRhdGlvbiB3aWxsIG9jY2FzaW9uYWxseSByZXR1cm4gc21hbGwsIG5lZ2F0aXZlIGN1cnJl bnQgdGltZXMgZHVyaW5nIGxvb3Agb3BlcmF0aW9ucy4KKyAgICAgICAgQ2xlYW4gdXAgdGhlc2Ug bmVnYXRpdmUgdGltZXMgYmVmb3JlIHJldHVybmluZyB0aGUgY3VycmVudFRpbWUuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uT2JqQzo6Y3VycmVudFRpbWUpOgorCiAyMDExLTA5LTIxICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBXRUJfQVVESU8gYnkg ZGVmYXVsdCBpbiB0aGUgV2ViS2l0L21hYyBwb3J0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KaW5k ZXggMmUxZjU1YTZkYTY5ODNmMDIyMjQ3ZDAzNjQ2YmFhNWM0OTQzYTU5NC4uY2MwOTg0ODc1ZmRh OWU1NWMxNDNhYzZhOTZmMDg3N2E0ZGEwZWFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCkBA IC00MzAsOCArNDMwLDEwIEBAIGZsb2F0IE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akM6OmN1cnJlbnRUaW1lKCkgY29uc3QKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBDTVRpbWUg aXRlbVRpbWUgPSBbbV9hdlBsYXllckl0ZW0uZ2V0KCkgY3VycmVudFRpbWVdOwotICAgIGlmIChD TVRJTUVfSVNfTlVNRVJJQyhpdGVtVGltZSkpCi0gICAgICAgIHJldHVybiBuYXJyb3dQcmVjaXNp b25Ub0Zsb2F0KENNVGltZUdldFNlY29uZHMoaXRlbVRpbWUpKTsKKyAgICBpZiAoQ01USU1FX0lT X05VTUVSSUMoaXRlbVRpbWUpKSB7CisgICAgICAgIGZsb2F0IHNlY29uZHMgPSBuYXJyb3dQcmVj aXNpb25Ub0Zsb2F0KENNVGltZUdldFNlY29uZHMoaXRlbVRpbWUpKTsKKyAgICAgICAgcmV0dXJu IG1heChzZWNvbmRzLCAwLjBmKTsKKyAgICB9CiAKICAgICByZXR1cm4gMDsKIH0K