69463 2011-10-05 13:55:39 -0700 Improve the watchlist for threading entries. 2011-10-14 14:19:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin oldest_to_newest 478658 0 levin 2011-10-05 13:55:39 -0700 Exclude files from the more match and add more files and patterns. 478662 1 109857 levin 2011-10-05 13:58:13 -0700 Created attachment 109857 Patch 478674 2 109857 abarth 2011-10-05 14:12:35 -0700 Comment on attachment 109857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109857&action=review > Tools/Scripts/webkitpy/common/config/watchlist:23 > + "more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific" > + r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy|)(?!\.(h|cpp))", Is the trailing | intentional? 478782 3 levin 2011-10-05 16:44:44 -0700 (In reply to comment #2) > (From update of attachment 109857 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109857&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:23 > > + "more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific" > > + r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy|)(?!\.(h|cpp))", > > Is the trailing | intentional? No, that's not good. :) I'll fix it on check in. 484288 4 levin 2011-10-14 14:19:34 -0700 Committed as http://trac.webkit.org/changeset/96768 109857 2011-10-05 13:58:13 -0700 2011-10-05 14:12:35 -0700 Patch bug-69463-20111005135812.patch text/plain 2563 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3MzcKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMzZmMjc3M2YzMDMyOTAzMTkxNjZmYzBjNTliYzhiYmFh ODQ0MmU4Li4wM2JmZmQ1YTgzMmI5YmQwNmI5Mzg0MjBkZTdhNmI3OWUzZmMxZDljIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMDUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIEltcHJvdmUgdGhlIHdhdGNobGlzdCBmb3IgdGhyZWFkaW5nIGVudHJpZXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTQ2MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL3dhdGNobGlzdDoKKwogMjAxMS0xMC0wNSAgQ2hhbmcgU2h1ICA8Y3No dUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXSzJdIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgTGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcENvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdCBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKaW5kZXggOWUwZjg2Yjg0 MzEwOGU0N2MzNzJlNDk0N2FjY2IzOTJmOTljNzcwNC4uNjM5OWNhNDM1MzhiYmNhNDIwZTBlNDhh OTU2MTE4NTdhYzljNjMzMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL3dhdGNobGlzdAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvd2F0Y2hsaXN0CkBAIC04LDExICs4LDE5IEBACiAgICAgICAgICAgICAiZmlsZW5hbWUi OiByIlNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljLy4qIgogICAgICAgICB9LAogICAgICAg ICAiVGhyZWFkaW5nRmlsZXMiOiB7Ci0gICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWRcLmgiCi0gICAgICAgICAgICAg ICAgICAgICAgICByInxTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1wuaCIsCisg ICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFk U3BlY2lmaWNcLi4qIgorICAgICAgICAgICAgICAgICAgICAgICAgciJ8U291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZFwuLioiCisgICAgICAgICAgICAgICAgICAg ICAgICByInxTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1ByaW1pdGl2ZXNcLi4q IgorICAgICAgICAgICAgICAgICAgICAgICAgciJ8U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9U aHJlYWRpbmdcLi4qIgorICAgICAgICAgICAgICAgICAgICAgICAgciJ8U291cmNlL1dlYkNvcmUv ZG9tL0Nyb3NzVGhyZWFkVGFza1wuLioiCisgICAgICAgICAgICAgICAgICAgICAgICByInxTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9Dcm9zc1RocmVhZENvcGllclwuLioiLAogICAgICAgICB9LAog ICAgICAgICAiVGhyZWFkaW5nVXNhZ2UiOiB7Ci0gICAgICAgICAgICAibW9yZSI6IHIiZGVwcmVj YXRlZFR1cm5PZmZWZXJpZmllcnxjcm9zc1RocmVhZFN0cmluZ3x0aHJlYWRzYWZlQ29weXxUaHJl YWRTYWZlUmVmQ291bnRlZHxDcm9zc1RocmVhZFJlZkNvdW50ZWQiLAorICAgICAgICAgICAgIyBU aGUgaW50ZW50aW9uIG9mIHRoaXMgcmVnZXggaXMgdG8gZGV0ZWN0IHBsYWNlcyB3aGVyZSBwZW9w bGUgYXJlIHVzaW5nIGNvbW1vbiB0aHJlYWRpbmcgbWVjaGFuaXNtcywKKyAgICAgICAgICAgICMg c28gdGhhdCBvbmUgY2FuIGxvb2sgdGhlbSBvdmVyIGZvciBjb21tb24gbWlzdGFrZXMuIFRoaXMg bGlzdCBpcyBsb25nIGFuZCBsaWtlbHkgdG8gZ2V0IGxvbmdlciBvdmVyIHRpbWUuCisgICAgICAg ICAgICAjIE5vdGUgdGhlIG5lZ2F0aXZlIGxvb2stYWhlYWQgdG8gYXZvaWQgbmV3IG1lbnRpb25z IG9mIHRoZSBmaWxlcyAoZm9yIGJ1aWxkcyBvciBpbmNsdWRlcykuCisgICAgICAgICAgICAibW9y ZSI6IHIiKEFsbG93Q3Jvc3NUaHJlYWRBY2Nlc3N8QXRvbWljYWxseUluaXRpYWxpemV8Q3Jvc3NU aHJlYWRDb3BpZXJ8Q3Jvc3NUaHJlYWRSZWZDb3VudGVkfE11dGV4fFJlYWRXcml0ZUxvY2t8VGhy ZWFkQ29uZGl0aW9ufFRocmVhZFNhZmVSZWZDb3VudGVkfFRocmVhZFNwZWNpZmljIgorICAgICAg ICAgICAgICAgICAgICByInxjcmVhdGVDYWxsYmFja1Rhc2t8Y3Jvc3NUaHJlYWRTdHJpbmd8ZGVw cmVjYXRlZFR1cm5PZmZWZXJpZmllcnx0aHJlYWRzYWZlQ29weXwpKD8hXC4oaHxjcHApKSIsCiAg ICAgICAgIH0sCiAgICAgICAgICJXYXRjaExpc3RTY3JpcHQiOiB7CiAgICAgICAgICAgICAiZmls ZW5hbWUiOiByIlRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3dhdGNobGlzdC8uKiIsCg==