69453 2011-10-05 12:26:33 -0700 save resource zeroing stacks in ScriptElement for debugging 2011-10-06 09:40:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69472 1 gavinp gavinp abarth ap aroben japhet webkit.review.bot oldest_to_newest 478577 0 gavinp 2011-10-05 12:26:33 -0700 save resource zeroing stacks in ScriptElement for debugging 478579 1 109837 gavinp 2011-10-05 12:29:21 -0700 Created attachment 109837 Patch 478581 2 gavinp 2011-10-05 12:30:33 -0700 add more data for crashes in ScriptElement::notifyFinished double calls. 478583 3 109837 abarth 2011-10-05 12:33:00 -0700 Comment on attachment 109837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109837&action=review > Source/WebCore/dom/ScriptElement.h:120 > + MaxBacktraceSize = 32 bad indent 478585 4 109838 gavinp 2011-10-05 12:35:18 -0700 Created attachment 109838 Patch 478586 5 109838 gavinp 2011-10-05 12:36:06 -0700 Comment on attachment 109838 Patch Fixed indent. 478598 6 109838 japhet 2011-10-05 12:50:37 -0700 Comment on attachment 109838 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109838&action=review > Source/WebCore/ChangeLog:8 > + two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug > + 75604). This patch will save a stack in the ScriptElement when this happens, so that if Please provide a link to the chromium bug. > Source/WebCore/dom/ScriptElement.h:122 > + > + // We grab a backtrace when we zero m_cachedScript, so that at later crashes > + // we'll have a debuggable stack. > + enum { > + MaxBacktraceSize = 32 > + }; > + int m_backtraceSize; Does this value ever change? Can we just make it a static const in ScriptElement.cpp? 478602 7 109842 gavinp 2011-10-05 12:55:04 -0700 Created attachment 109842 Patch 478603 8 109838 gavinp 2011-10-05 12:57:37 -0700 Comment on attachment 109838 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109838&action=review >> Source/WebCore/ChangeLog:8 >> + 75604). This patch will save a stack in the ScriptElement when this happens, so that if > > Please provide a link to the chromium bug. Done. >> Source/WebCore/dom/ScriptElement.h:122 >> + int m_backtraceSize; > > Does this value ever change? Can we just make it a static const in ScriptElement.cpp? It does change, it contains the actual size of the stack in m_backtrace, it could be anything from 0 to 32. 478605 9 109842 gavinp 2011-10-05 12:58:07 -0700 Comment on attachment 109842 Patch Now with links to the chromium bug database. Boy, isn't the chromium bug database really unbearably slow? 478710 10 109842 webkit.review.bot 2011-10-05 15:02:42 -0700 Comment on attachment 109842 Patch Clearing flags on attachment: 109842 Committed r96756: <http://trac.webkit.org/changeset/96756> 478711 11 webkit.review.bot 2011-10-05 15:02:46 -0700 All reviewed patches have been landed. Closing bug. 478741 12 aroben 2011-10-05 15:35:56 -0700 This broke many builds due to WTFGetBacktrace not being exported from JavaScriptCore. Rolling it out in bug 69472. 479126 13 gavinp 2011-10-06 06:38:13 -0700 I just added a new patch to bug 69018 which exports these functions, after that this patch should be good to go, possibly after rerunning ews. 479131 14 109957 gavinp 2011-10-06 06:50:52 -0700 Created attachment 109957 Patch 479135 15 109957 gavinp 2011-10-06 06:54:01 -0700 Comment on attachment 109957 Patch This patch is unchanged from the version that got a rollout; however I've since updated the exports from JavaScriptCore so it should work now. Let's wait on the windows ews bot in particular, then land it? 479191 16 109957 japhet 2011-10-06 09:05:00 -0700 Comment on attachment 109957 Patch Looks like it's passed the bots this time, so r+ again. 479216 17 gavinp 2011-10-06 09:40:15 -0700 Committed r96819: <http://trac.webkit.org/changeset/96819> 109837 2011-10-05 12:29:21 -0700 2011-10-05 12:35:12 -0700 Patch bug-69453-20111005152919.patch text/plain 3201 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2MDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGFkYjRkNDZkOGRjYTEw NGYxNWI5ZGMxZDBlZDgwNWE3ODUxMmJlLi5lMjU0OTY1NmVjZTYxZjYwMDAwZWQ1MjMxZmZhMGRh NjU4NDIzZjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMDUgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2F2ZSByZXNvdXJjZSB6 ZXJvaW5nIHN0YWNrcyBpbiBTY3JpcHRFbGVtZW50IGZvciBkZWJ1Z2dpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDUzCisKKyAgICAgICAgVGhl IHN0YXRlIG1hY2hpbmUgdHJhY2tpbmcgaG93IG1fY2FjaGVkU2NyaXB0IGdldHMgemVyb2VkIHNo b3dzIHRoYXQgc29tZXRpbWVzIHdlIGdldAorICAgICAgICB0d28gbm90aWZ5RmluaXNoZWQoKSBl dmVudHMgaW4gYSBTY3JpcHRFbGVtZW50LCB3aGljaCBjYW4gY3Jhc2ggY2hyb21lIChzZWUgY2hy b21lIGJ1ZworICAgICAgICA3NTYwNCkuICBUaGlzIHBhdGNoIHdpbGwgc2F2ZSBhIHN0YWNrIGlu IHRoZSBTY3JpcHRFbGVtZW50IHdoZW4gdGhpcyBoYXBwZW5zLCBzbyB0aGF0IGlmCisgICAgICAg IHdlIGRvIGxhdGVyIGNyYXNoLCB3ZSBjYW4gc2VlIGhvdyB3ZSBkaWQgdGhlIGZpcnN0IHplcm9p bmcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCB0aGlzIHNob3VsZG4ndCBhZmZlY3Qgb3V0cHV0IGF0IGFsbCwgYW5kIGlzbid0 IHBhcnRpY3VsYXJseSB0ZXN0YWJsZS4KKworICAgICAgICAqIGRvbS9TY3JpcHRFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1lbnQpOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0RWxlbWVudDo6c3RvcExvYWRSZXF1ZXN0KToKKyAgICAgICAg KFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6Om5vdGlmeUZpbmlzaGVkKToKKyAgICAgICAgKiBkb20v U2NyaXB0RWxlbWVudC5oOgorCiAyMDExLTEwLTA0ICBMZWFuZHJvIFBlcmVpcmEgIDxsZWFuZHJv QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtDTWFrZV0gVW5yZXZpZXdlZDogcGFzcyBmZWF0 dXJlIGRlZmluaXRpb25zIGluIHRoZSByaWdodCBmb3JtYXQgZm9yIHRoZSBDU1Mgc2NyaXB0cy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAppbmRleCBmOTgzY2MxZGEyMWVkMDA2ODkw ODY5MDE2MjJhNjYyYTQ4NjA4ZjE2Li5mM2Y4MGY5N2ZjNWQ2YTQwMzEzMzU5MjVkNmI5M2I5MWM3 ZWIyYWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCkBAIC02Niw2ICs2Niw3 IEBAIFNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgYm9vbCBw YXJzZXJJbnNlcnRlZCwgYm9vbCBhbHJlYWR5CiAgICAgLCBtX2ZvcmNlQXN5bmMoIXBhcnNlcklu c2VydGVkKQogICAgICwgbV93aWxsRXhlY3V0ZUluT3JkZXIoZmFsc2UpCiAgICAgLCBtX2NhY2hl ZFNjcmlwdFN0YXRlKE5ldmVyU2V0KQorICAgICwgbV9iYWNrdHJhY2VTaXplKDApCiB7CiAgICAg QVNTRVJUKG1fZWxlbWVudCk7CiB9CkBAIC0zMDIsNyArMzAzLDEwIEBAIHZvaWQgU2NyaXB0RWxl bWVudDo6c3RvcExvYWRSZXF1ZXN0KCkKICAgICAgICAgaWYgKCFtX3dpbGxCZVBhcnNlckV4ZWN1 dGVkKQogICAgICAgICAgICAgbV9jYWNoZWRTY3JpcHQtPnJlbW92ZUNsaWVudCh0aGlzKTsKICAg ICAgICAgQVNTRVJUKG1fY2FjaGVkU2NyaXB0U3RhdGUgPT0gU2V0KTsKKwogICAgICAgICBtX2Nh Y2hlZFNjcmlwdFN0YXRlID0gWmVyb2VkSW5TdG9wTG9hZFJlcXVlc3Q7CisgICAgICAgIG1fYmFj a3RyYWNlU2l6ZSA9IE1heEJhY2t0cmFjZVNpemU7CisgICAgICAgIFdURkdldEJhY2t0cmFjZSht X2JhY2t0cmFjZSwgJm1fYmFja3RyYWNlU2l6ZSk7CiAgICAgICAgIG1fY2FjaGVkU2NyaXB0ID0g MDsKICAgICB9CiB9CkBAIC0zMzEsNiArMzM1LDggQEAgdm9pZCBTY3JpcHRFbGVtZW50Ojpub3Rp ZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogbykKIAogICAgIEFTU0VSVChtX2NhY2hlZFNjcmlw dFN0YXRlID09IFNldCk7CiAgICAgbV9jYWNoZWRTY3JpcHRTdGF0ZSA9IFplcm9lZEluTm90aWZ5 RmluaXNoZWQ7CisgICAgbV9iYWNrdHJhY2VTaXplID0gTWF4QmFja3RyYWNlU2l6ZTsKKyAgICBX VEZHZXRCYWNrdHJhY2UobV9iYWNrdHJhY2UsICZtX2JhY2t0cmFjZVNpemUpOwogICAgIG1fY2Fj aGVkU2NyaXB0ID0gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1Njcmlw dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmgKaW5kZXggNzg3 MjYwMDM1ZTlkMWZlOWFiZDE3OTllMTdmM2QyMDZkZmFjOGNlYi4uZGY1ODQwYjVlMDc5ZGZkZTc1 ZTA2M2M4Yzg4OWI0YmM2OTg0ZGI4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Nj cmlwdEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5oCkBA IC0xMTMsNiArMTEzLDE0IEBAIHByaXZhdGU6CiAgICAgICBaZXJvZWRJblN0b3BMb2FkUmVxdWVz dCwKICAgICAgIFplcm9lZEluTm90aWZ5RmluaXNoZWQsCiAgICAgfSBtX2NhY2hlZFNjcmlwdFN0 YXRlOworCisgICAgLy8gV2UgZ3JhYiBhIGJhY2t0cmFjZSB3aGVuIHdlIHplcm8gbV9jYWNoZWRT Y3JpcHQsIHNvIHRoYXQgYXQgbGF0ZXIgY3Jhc2hlcworICAgIC8vIHdlJ2xsIGhhdmUgYSBkZWJ1 Z2dhYmxlIHN0YWNrLgorICAgIGVudW0geworICAgICAgTWF4QmFja3RyYWNlU2l6ZSA9IDMyCisg ICAgfTsKKyAgICBpbnQgbV9iYWNrdHJhY2VTaXplOworICAgIHZvaWQqIG1fYmFja3RyYWNlW01h eEJhY2t0cmFjZVNpemVdOwogfTsKIAogU2NyaXB0RWxlbWVudCogdG9TY3JpcHRFbGVtZW50KEVs ZW1lbnQqKTsK 109838 2011-10-05 12:35:18 -0700 2011-10-05 12:57:37 -0700 Patch bug-69453-20111005153516.patch text/plain 3203 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2MDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGFkYjRkNDZkOGRjYTEw NGYxNWI5ZGMxZDBlZDgwNWE3ODUxMmJlLi5lMjU0OTY1NmVjZTYxZjYwMDAwZWQ1MjMxZmZhMGRh NjU4NDIzZjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMDUgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2F2ZSByZXNvdXJjZSB6 ZXJvaW5nIHN0YWNrcyBpbiBTY3JpcHRFbGVtZW50IGZvciBkZWJ1Z2dpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDUzCisKKyAgICAgICAgVGhl IHN0YXRlIG1hY2hpbmUgdHJhY2tpbmcgaG93IG1fY2FjaGVkU2NyaXB0IGdldHMgemVyb2VkIHNo b3dzIHRoYXQgc29tZXRpbWVzIHdlIGdldAorICAgICAgICB0d28gbm90aWZ5RmluaXNoZWQoKSBl dmVudHMgaW4gYSBTY3JpcHRFbGVtZW50LCB3aGljaCBjYW4gY3Jhc2ggY2hyb21lIChzZWUgY2hy b21lIGJ1ZworICAgICAgICA3NTYwNCkuICBUaGlzIHBhdGNoIHdpbGwgc2F2ZSBhIHN0YWNrIGlu IHRoZSBTY3JpcHRFbGVtZW50IHdoZW4gdGhpcyBoYXBwZW5zLCBzbyB0aGF0IGlmCisgICAgICAg IHdlIGRvIGxhdGVyIGNyYXNoLCB3ZSBjYW4gc2VlIGhvdyB3ZSBkaWQgdGhlIGZpcnN0IHplcm9p bmcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCB0aGlzIHNob3VsZG4ndCBhZmZlY3Qgb3V0cHV0IGF0IGFsbCwgYW5kIGlzbid0 IHBhcnRpY3VsYXJseSB0ZXN0YWJsZS4KKworICAgICAgICAqIGRvbS9TY3JpcHRFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1lbnQpOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0RWxlbWVudDo6c3RvcExvYWRSZXF1ZXN0KToKKyAgICAgICAg KFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6Om5vdGlmeUZpbmlzaGVkKToKKyAgICAgICAgKiBkb20v U2NyaXB0RWxlbWVudC5oOgorCiAyMDExLTEwLTA0ICBMZWFuZHJvIFBlcmVpcmEgIDxsZWFuZHJv QHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtDTWFrZV0gVW5yZXZpZXdlZDogcGFzcyBmZWF0 dXJlIGRlZmluaXRpb25zIGluIHRoZSByaWdodCBmb3JtYXQgZm9yIHRoZSBDU1Mgc2NyaXB0cy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAppbmRleCBmOTgzY2MxZGEyMWVkMDA2ODkw ODY5MDE2MjJhNjYyYTQ4NjA4ZjE2Li5mM2Y4MGY5N2ZjNWQ2YTQwMzEzMzU5MjVkNmI5M2I5MWM3 ZWIyYWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCkBAIC02Niw2ICs2Niw3 IEBAIFNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgYm9vbCBw YXJzZXJJbnNlcnRlZCwgYm9vbCBhbHJlYWR5CiAgICAgLCBtX2ZvcmNlQXN5bmMoIXBhcnNlcklu c2VydGVkKQogICAgICwgbV93aWxsRXhlY3V0ZUluT3JkZXIoZmFsc2UpCiAgICAgLCBtX2NhY2hl ZFNjcmlwdFN0YXRlKE5ldmVyU2V0KQorICAgICwgbV9iYWNrdHJhY2VTaXplKDApCiB7CiAgICAg QVNTRVJUKG1fZWxlbWVudCk7CiB9CkBAIC0zMDIsNyArMzAzLDEwIEBAIHZvaWQgU2NyaXB0RWxl bWVudDo6c3RvcExvYWRSZXF1ZXN0KCkKICAgICAgICAgaWYgKCFtX3dpbGxCZVBhcnNlckV4ZWN1 dGVkKQogICAgICAgICAgICAgbV9jYWNoZWRTY3JpcHQtPnJlbW92ZUNsaWVudCh0aGlzKTsKICAg ICAgICAgQVNTRVJUKG1fY2FjaGVkU2NyaXB0U3RhdGUgPT0gU2V0KTsKKwogICAgICAgICBtX2Nh Y2hlZFNjcmlwdFN0YXRlID0gWmVyb2VkSW5TdG9wTG9hZFJlcXVlc3Q7CisgICAgICAgIG1fYmFj a3RyYWNlU2l6ZSA9IE1heEJhY2t0cmFjZVNpemU7CisgICAgICAgIFdURkdldEJhY2t0cmFjZSht X2JhY2t0cmFjZSwgJm1fYmFja3RyYWNlU2l6ZSk7CiAgICAgICAgIG1fY2FjaGVkU2NyaXB0ID0g MDsKICAgICB9CiB9CkBAIC0zMzEsNiArMzM1LDggQEAgdm9pZCBTY3JpcHRFbGVtZW50Ojpub3Rp ZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogbykKIAogICAgIEFTU0VSVChtX2NhY2hlZFNjcmlw dFN0YXRlID09IFNldCk7CiAgICAgbV9jYWNoZWRTY3JpcHRTdGF0ZSA9IFplcm9lZEluTm90aWZ5 RmluaXNoZWQ7CisgICAgbV9iYWNrdHJhY2VTaXplID0gTWF4QmFja3RyYWNlU2l6ZTsKKyAgICBX VEZHZXRCYWNrdHJhY2UobV9iYWNrdHJhY2UsICZtX2JhY2t0cmFjZVNpemUpOwogICAgIG1fY2Fj aGVkU2NyaXB0ID0gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1Njcmlw dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmgKaW5kZXggNzg3 MjYwMDM1ZTlkMWZlOWFiZDE3OTllMTdmM2QyMDZkZmFjOGNlYi4uOWJjOWY4N2YwM2YxMDk3MTc4 ODk5ZjcwMzNkYjM1OWZhMjliMDUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Nj cmlwdEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxlbWVudC5oCkBA IC0xMTMsNiArMTEzLDE0IEBAIHByaXZhdGU6CiAgICAgICBaZXJvZWRJblN0b3BMb2FkUmVxdWVz dCwKICAgICAgIFplcm9lZEluTm90aWZ5RmluaXNoZWQsCiAgICAgfSBtX2NhY2hlZFNjcmlwdFN0 YXRlOworCisgICAgLy8gV2UgZ3JhYiBhIGJhY2t0cmFjZSB3aGVuIHdlIHplcm8gbV9jYWNoZWRT Y3JpcHQsIHNvIHRoYXQgYXQgbGF0ZXIgY3Jhc2hlcworICAgIC8vIHdlJ2xsIGhhdmUgYSBkZWJ1 Z2dhYmxlIHN0YWNrLgorICAgIGVudW0geworICAgICAgICBNYXhCYWNrdHJhY2VTaXplID0gMzIK KyAgICB9OworICAgIGludCBtX2JhY2t0cmFjZVNpemU7CisgICAgdm9pZCogbV9iYWNrdHJhY2Vb TWF4QmFja3RyYWNlU2l6ZV07CiB9OwogCiBTY3JpcHRFbGVtZW50KiB0b1NjcmlwdEVsZW1lbnQo RWxlbWVudCopOwo= 109842 2011-10-05 12:55:04 -0700 2011-10-06 06:50:47 -0700 Patch bug-69453-20111005155503.patch text/plain 3344 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2MDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGFkYjRkNDZkOGRjYTEw NGYxNWI5ZGMxZDBlZDgwNWE3ODUxMmJlLi4zZmY3N2NhZWY5MjZiYmNkYjQzMzY4MmZlYTM4OTcw YmVjODI1ZmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMTAtMDUgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2F2ZSByZXNvdXJjZSB6 ZXJvaW5nIHN0YWNrcyBpbiBTY3JpcHRFbGVtZW50IGZvciBkZWJ1Z2dpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDUzCisKKyAgICAgICAgVGhl IHN0YXRlIG1hY2hpbmUgdHJhY2tpbmcgaG93IG1fY2FjaGVkU2NyaXB0IGdldHMgemVyb2VkIHNo b3dzIHRoYXQgc29tZXRpbWVzIHdlIGdldAorICAgICAgICB0d28gbm90aWZ5RmluaXNoZWQoKSBl dmVudHMgaW4gYSBTY3JpcHRFbGVtZW50LCB3aGljaCBjYW4gY3Jhc2ggY2hyb21lIChzZWUgY2hy b21lIGJ1ZworICAgICAgICA3NTYwNCkuICBUaGlzIHBhdGNoIHdpbGwgc2F2ZSBhIHN0YWNrIGlu IHRoZSBTY3JpcHRFbGVtZW50IHdoZW4gdGhpcyBoYXBwZW5zLCBzbyB0aGF0IGlmCisgICAgICAg IHdlIGRvIGxhdGVyIGNyYXNoLCB3ZSBjYW4gc2VlIGhvdyB3ZSBkaWQgdGhlIGZpcnN0IHplcm9p bmcuCisKKyAgICAgICAgU2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1 ZXMvZGV0YWlsP2lkPTc1NjA0IGZvciB0aGUgY2hyb21pdW0gYnVnIHRoYXQKKyAgICAgICAgdGhp cyBjaGFuZ2Ugd2lsbCBoZWxwIHRyYWNrIGRvd24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIHNob3VsZG4ndCBhZmZl Y3Qgb3V0cHV0IGF0IGFsbCwgYW5kIGlzbid0IHBhcnRpY3VsYXJseSB0ZXN0YWJsZS4KKworICAg ICAgICAqIGRvbS9TY3JpcHRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVs ZW1lbnQ6OlNjcmlwdEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RWxlbWVudDo6 c3RvcExvYWRSZXF1ZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6Om5vdGlm eUZpbmlzaGVkKToKKyAgICAgICAgKiBkb20vU2NyaXB0RWxlbWVudC5oOgorCiAyMDExLTEwLTA0 ICBMZWFuZHJvIFBlcmVpcmEgIDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtD TWFrZV0gVW5yZXZpZXdlZDogcGFzcyBmZWF0dXJlIGRlZmluaXRpb25zIGluIHRoZSByaWdodCBm b3JtYXQgZm9yIHRoZSBDU1Mgc2NyaXB0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9TY3JpcHRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNw cAppbmRleCBmOTgzY2MxZGEyMWVkMDA2ODkwODY5MDE2MjJhNjYyYTQ4NjA4ZjE2Li5mM2Y4MGY5 N2ZjNWQ2YTQwMzEzMzU5MjVkNmI5M2I5MWM3ZWIyYWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njcmlw dEVsZW1lbnQuY3BwCkBAIC02Niw2ICs2Niw3IEBAIFNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1l bnQoRWxlbWVudCogZWxlbWVudCwgYm9vbCBwYXJzZXJJbnNlcnRlZCwgYm9vbCBhbHJlYWR5CiAg ICAgLCBtX2ZvcmNlQXN5bmMoIXBhcnNlckluc2VydGVkKQogICAgICwgbV93aWxsRXhlY3V0ZUlu T3JkZXIoZmFsc2UpCiAgICAgLCBtX2NhY2hlZFNjcmlwdFN0YXRlKE5ldmVyU2V0KQorICAgICwg bV9iYWNrdHJhY2VTaXplKDApCiB7CiAgICAgQVNTRVJUKG1fZWxlbWVudCk7CiB9CkBAIC0zMDIs NyArMzAzLDEwIEBAIHZvaWQgU2NyaXB0RWxlbWVudDo6c3RvcExvYWRSZXF1ZXN0KCkKICAgICAg ICAgaWYgKCFtX3dpbGxCZVBhcnNlckV4ZWN1dGVkKQogICAgICAgICAgICAgbV9jYWNoZWRTY3Jp cHQtPnJlbW92ZUNsaWVudCh0aGlzKTsKICAgICAgICAgQVNTRVJUKG1fY2FjaGVkU2NyaXB0U3Rh dGUgPT0gU2V0KTsKKwogICAgICAgICBtX2NhY2hlZFNjcmlwdFN0YXRlID0gWmVyb2VkSW5TdG9w TG9hZFJlcXVlc3Q7CisgICAgICAgIG1fYmFja3RyYWNlU2l6ZSA9IE1heEJhY2t0cmFjZVNpemU7 CisgICAgICAgIFdURkdldEJhY2t0cmFjZShtX2JhY2t0cmFjZSwgJm1fYmFja3RyYWNlU2l6ZSk7 CiAgICAgICAgIG1fY2FjaGVkU2NyaXB0ID0gMDsKICAgICB9CiB9CkBAIC0zMzEsNiArMzM1LDgg QEAgdm9pZCBTY3JpcHRFbGVtZW50Ojpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogbykK IAogICAgIEFTU0VSVChtX2NhY2hlZFNjcmlwdFN0YXRlID09IFNldCk7CiAgICAgbV9jYWNoZWRT Y3JpcHRTdGF0ZSA9IFplcm9lZEluTm90aWZ5RmluaXNoZWQ7CisgICAgbV9iYWNrdHJhY2VTaXpl ID0gTWF4QmFja3RyYWNlU2l6ZTsKKyAgICBXVEZHZXRCYWNrdHJhY2UobV9iYWNrdHJhY2UsICZt X2JhY2t0cmFjZVNpemUpOwogICAgIG1fY2FjaGVkU2NyaXB0ID0gMDsKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9TY3JpcHRFbGVtZW50LmgKaW5kZXggNzg3MjYwMDM1ZTlkMWZlOWFiZDE3OTllMTdmM2QyMDZk ZmFjOGNlYi4uOWJjOWY4N2YwM2YxMDk3MTc4ODk5ZjcwMzNkYjM1OWZhMjliMDUyOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vU2NyaXB0RWxlbWVudC5oCkBAIC0xMTMsNiArMTEzLDE0IEBAIHByaXZhdGU6CiAg ICAgICBaZXJvZWRJblN0b3BMb2FkUmVxdWVzdCwKICAgICAgIFplcm9lZEluTm90aWZ5RmluaXNo ZWQsCiAgICAgfSBtX2NhY2hlZFNjcmlwdFN0YXRlOworCisgICAgLy8gV2UgZ3JhYiBhIGJhY2t0 cmFjZSB3aGVuIHdlIHplcm8gbV9jYWNoZWRTY3JpcHQsIHNvIHRoYXQgYXQgbGF0ZXIgY3Jhc2hl cworICAgIC8vIHdlJ2xsIGhhdmUgYSBkZWJ1Z2dhYmxlIHN0YWNrLgorICAgIGVudW0geworICAg ICAgICBNYXhCYWNrdHJhY2VTaXplID0gMzIKKyAgICB9OworICAgIGludCBtX2JhY2t0cmFjZVNp emU7CisgICAgdm9pZCogbV9iYWNrdHJhY2VbTWF4QmFja3RyYWNlU2l6ZV07CiB9OwogCiBTY3Jp cHRFbGVtZW50KiB0b1NjcmlwdEVsZW1lbnQoRWxlbWVudCopOwo= 109957 2011-10-06 06:50:52 -0700 2011-10-06 09:05:00 -0700 Patch bug-69453-20111006095051.patch text/plain 3326 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogOTY4MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYWJhZDViNDY3OGQzN2Mw YzQ3ZDI0YjJhODU1ZTdiZWRkNjBhZDI2Li5hNTk0MTI0ZmM2NDM4NWJiOGU1OWVlODk4Yjg4ODFi OWM2Mzk3ZmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMTAtMDYgIEdhdmlu IFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2F2ZSByZXNvdXJjZSB6 ZXJvaW5nIHN0YWNrcyBpbiBTY3JpcHRFbGVtZW50IGZvciBkZWJ1Z2dpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDUzCisKKyAgICAgICAgVGhl IHN0YXRlIG1hY2hpbmUgdHJhY2tpbmcgaG93IG1fY2FjaGVkU2NyaXB0IGdldHMgemVyb2VkIHNo b3dzIHRoYXQgc29tZXRpbWVzIHdlIGdldAorICAgICAgICB0d28gbm90aWZ5RmluaXNoZWQoKSBl dmVudHMgaW4gYSBTY3JpcHRFbGVtZW50LCB3aGljaCBjYW4gY3Jhc2ggY2hyb21lIChzZWUgY2hy b21lIGJ1ZworICAgICAgICA3NTYwNCkuICBUaGlzIHBhdGNoIHdpbGwgc2F2ZSBhIHN0YWNrIGlu IHRoZSBTY3JpcHRFbGVtZW50IHdoZW4gdGhpcyBoYXBwZW5zLCBzbyB0aGF0IGlmCisgICAgICAg IHdlIGRvIGxhdGVyIGNyYXNoLCB3ZSBjYW4gc2VlIGhvdyB3ZSBkaWQgdGhlIGZpcnN0IHplcm9p bmcuCisKKyAgICAgICAgU2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1 ZXMvZGV0YWlsP2lkPTc1NjA0IGZvciB0aGUgY2hyb21pdW0gYnVnIHRoYXQKKyAgICAgICAgdGhp cyBjaGFuZ2Ugd2lsbCBoZWxwIHRyYWNrIGRvd24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIHNob3VsZG4ndCBhZmZl Y3Qgb3V0cHV0IGF0IGFsbCwgYW5kIGlzbid0IHBhcnRpY3VsYXJseSB0ZXN0YWJsZS4KKworICAg ICAgICAqIGRvbS9TY3JpcHRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVs ZW1lbnQ6OlNjcmlwdEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RWxlbWVudDo6 c3RvcExvYWRSZXF1ZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6Om5vdGlm eUZpbmlzaGVkKToKKyAgICAgICAgKiBkb20vU2NyaXB0RWxlbWVudC5oOgorCiAyMDExLTEwLTA1 ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBhZGQgMTAgbW9yZSBmcm9udC1lbmQgY2xhc3NlcyB0byB0aGUgY29tcGlsYXRpb24g cHJvY2Vzcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNwcAppbmRleCBmOTgzY2MxZGEy MWVkMDA2ODkwODY5MDE2MjJhNjYyYTQ4NjA4ZjE2Li5mM2Y4MGY5N2ZjNWQ2YTQwMzEzMzU5MjVk NmI5M2I5MWM3ZWIyYWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCkBAIC02 Niw2ICs2Niw3IEBAIFNjcmlwdEVsZW1lbnQ6OlNjcmlwdEVsZW1lbnQoRWxlbWVudCogZWxlbWVu dCwgYm9vbCBwYXJzZXJJbnNlcnRlZCwgYm9vbCBhbHJlYWR5CiAgICAgLCBtX2ZvcmNlQXN5bmMo IXBhcnNlckluc2VydGVkKQogICAgICwgbV93aWxsRXhlY3V0ZUluT3JkZXIoZmFsc2UpCiAgICAg LCBtX2NhY2hlZFNjcmlwdFN0YXRlKE5ldmVyU2V0KQorICAgICwgbV9iYWNrdHJhY2VTaXplKDAp CiB7CiAgICAgQVNTRVJUKG1fZWxlbWVudCk7CiB9CkBAIC0zMDIsNyArMzAzLDEwIEBAIHZvaWQg U2NyaXB0RWxlbWVudDo6c3RvcExvYWRSZXF1ZXN0KCkKICAgICAgICAgaWYgKCFtX3dpbGxCZVBh cnNlckV4ZWN1dGVkKQogICAgICAgICAgICAgbV9jYWNoZWRTY3JpcHQtPnJlbW92ZUNsaWVudCh0 aGlzKTsKICAgICAgICAgQVNTRVJUKG1fY2FjaGVkU2NyaXB0U3RhdGUgPT0gU2V0KTsKKwogICAg ICAgICBtX2NhY2hlZFNjcmlwdFN0YXRlID0gWmVyb2VkSW5TdG9wTG9hZFJlcXVlc3Q7CisgICAg ICAgIG1fYmFja3RyYWNlU2l6ZSA9IE1heEJhY2t0cmFjZVNpemU7CisgICAgICAgIFdURkdldEJh Y2t0cmFjZShtX2JhY2t0cmFjZSwgJm1fYmFja3RyYWNlU2l6ZSk7CiAgICAgICAgIG1fY2FjaGVk U2NyaXB0ID0gMDsKICAgICB9CiB9CkBAIC0zMzEsNiArMzM1LDggQEAgdm9pZCBTY3JpcHRFbGVt ZW50Ojpub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSogbykKIAogICAgIEFTU0VSVChtX2Nh Y2hlZFNjcmlwdFN0YXRlID09IFNldCk7CiAgICAgbV9jYWNoZWRTY3JpcHRTdGF0ZSA9IFplcm9l ZEluTm90aWZ5RmluaXNoZWQ7CisgICAgbV9iYWNrdHJhY2VTaXplID0gTWF4QmFja3RyYWNlU2l6 ZTsKKyAgICBXVEZHZXRCYWNrdHJhY2UobV9iYWNrdHJhY2UsICZtX2JhY2t0cmFjZVNpemUpOwog ICAgIG1fY2FjaGVkU2NyaXB0ID0gMDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL1NjcmlwdEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmgK aW5kZXggNzg3MjYwMDM1ZTlkMWZlOWFiZDE3OTllMTdmM2QyMDZkZmFjOGNlYi4uOWJjOWY4N2Yw M2YxMDk3MTc4ODk5ZjcwMzNkYjM1OWZhMjliMDUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL1NjcmlwdEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxl bWVudC5oCkBAIC0xMTMsNiArMTEzLDE0IEBAIHByaXZhdGU6CiAgICAgICBaZXJvZWRJblN0b3BM b2FkUmVxdWVzdCwKICAgICAgIFplcm9lZEluTm90aWZ5RmluaXNoZWQsCiAgICAgfSBtX2NhY2hl ZFNjcmlwdFN0YXRlOworCisgICAgLy8gV2UgZ3JhYiBhIGJhY2t0cmFjZSB3aGVuIHdlIHplcm8g bV9jYWNoZWRTY3JpcHQsIHNvIHRoYXQgYXQgbGF0ZXIgY3Jhc2hlcworICAgIC8vIHdlJ2xsIGhh dmUgYSBkZWJ1Z2dhYmxlIHN0YWNrLgorICAgIGVudW0geworICAgICAgICBNYXhCYWNrdHJhY2VT aXplID0gMzIKKyAgICB9OworICAgIGludCBtX2JhY2t0cmFjZVNpemU7CisgICAgdm9pZCogbV9i YWNrdHJhY2VbTWF4QmFja3RyYWNlU2l6ZV07CiB9OwogCiBTY3JpcHRFbGVtZW50KiB0b1Njcmlw dEVsZW1lbnQoRWxlbWVudCopOwo=