69440 2011-10-05 10:19:50 -0700 AccessibilityMenuList does not fire change notification when popup is not open. 2011-10-11 13:45:38 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dmazzoni dmazzoni aboxhall cfleizach dtseng webkit.review.bot oldest_to_newest 478471 0 dmazzoni 2011-10-05 10:19:50 -0700 On Mac OS X, an AccessibilityMenuList only changes when the popup is visible. On other platforms, it can be changed when focused by pressing the arrow key, but no platform accessibility notification is being sent. 478609 1 109843 dmazzoni 2011-10-05 13:00:41 -0700 Created attachment 109843 Patch 478734 2 109843 cfleizach 2011-10-05 15:27:34 -0700 Comment on attachment 109843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109843&action=review layout test needed. otherwise seems ok > Source/WebCore/accessibility/AccessibilityMenuList.cpp:96 > + popup->didUpdateActiveOption(optionIndex); i think we should take this patch to verify (outside of ASSERT) that childObjects[0].get() actually is a AccessibilityMenuListPopup, by doing something like if (childObjects[0]->isMenuListPopup()) 478757 3 dmazzoni 2011-10-05 15:53:29 -0700 Sure, happy to add that additional check. As for the layout test, tests that check for notifications have to be platform-specific currently. Would it be okay to check for this notification on Mac OS X even though it isn't strictly needed there? It'd be more trouble to develop the test as Win or GTK specific. I'm also planning to add a Chromium AccessibilityController soon. 478758 4 cfleizach 2011-10-05 15:57:03 -0700 (In reply to comment #3) > Sure, happy to add that additional check. > > As for the layout test, tests that check for notifications have to be platform-specific currently. Would it be okay to check for this notification on Mac OS X even though it isn't strictly needed there? It'd be more trouble to develop the test as Win or GTK specific. Yes I think that's acceptable. With this fix we mainly want to check that a notification is received (not that it's received by a specific platform) > > I'm also planning to add a Chromium AccessibilityController soon. Great! 481521 5 dmazzoni 2011-10-11 02:10:30 -0700 Turns out that this notification doesn't even exist on Mac OS X, so I decided I'm adding a generic test and a Chromium expectations file, and then if we want we can add expectations for any other platform that passes. 481522 6 110487 dmazzoni 2011-10-11 02:12:31 -0700 Created attachment 110487 Patch 481635 7 110487 cfleizach 2011-10-11 07:58:24 -0700 Comment on attachment 110487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110487&action=review r=me with minor layout changes > LayoutTests/accessibility/menu-list-sends-change-notification.html:20 > + layoutTestController.notifyDone(); you should also remove the notification listener when done with this layout test 481860 8 110564 dmazzoni 2011-10-11 13:27:08 -0700 Created attachment 110564 Patch for landing 481876 9 110564 webkit.review.bot 2011-10-11 13:45:33 -0700 Comment on attachment 110564 Patch for landing Clearing flags on attachment: 110564 Committed r97177: <http://trac.webkit.org/changeset/97177> 481877 10 webkit.review.bot 2011-10-11 13:45:38 -0700 All reviewed patches have been landed. Closing bug. 109843 2011-10-05 13:00:41 -0700 2011-10-11 02:12:26 -0700 Patch bug-69440-20111005130039.patch text/plain 2092 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk2NzMwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDUgIERvbWluaWMg TWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDQwCisgICAgICAgIEFjY2Vzc2liaWxpdHlNZW51 TGlzdCBkb2VzIG5vdCBmaXJlIGNoYW5nZSBub3RpZmljYXRpb24gd2hlbiBwb3B1cCBpcyBub3Qg b3Blbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKToKKwogMjAx MS0xMC0wNSAgQW5uYSBDYXZlbmRlciAgPGFubmFjY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg RnVuY3Rpb25zIHRvIG1ha2UgPHRyYWNrPiBlbmFibGVkIGF0IHJ1bnRpbWUsIGluY2x1ZGluZyBj aGFuZ2VzIHRvCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlNZW51TGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3QuY3BwCShyZXZpc2lvbiA5NjczMCkKKysrIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtODQsMTggKzg0LDE3IEBAIGJvb2wgQWNjZXNzaWJpbGl0eU1lbnVMaXN0Ojppc0Nv bGxhcHNlZCgKIAogdm9pZCBBY2Nlc3NpYmlsaXR5TWVudUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9w dGlvbihpbnQgb3B0aW9uSW5kZXgpCiB7Ci0gICAgY29uc3QgQWNjZXNzaWJpbGl0eUNoaWxkcmVu VmVjdG9yJiBjaGlsZE9iamVjdHMgPSBjaGlsZHJlbigpOwotICAgIGlmIChjaGlsZE9iamVjdHMu aXNFbXB0eSgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBBU1NFUlQoY2hpbGRPYmplY3RzLnNp emUoKSA9PSAxKTsKLSAgICBBU1NFUlQoY2hpbGRPYmplY3RzWzBdLT5pc01lbnVMaXN0UG9wdXAo KSk7Ci0KICAgICBSZWZQdHI8RG9jdW1lbnQ+IGRvY3VtZW50ID0gbV9yZW5kZXJlci0+ZG9jdW1l bnQoKTsKICAgICBBWE9iamVjdENhY2hlKiBjYWNoZSA9IGRvY3VtZW50LT5heE9iamVjdENhY2hl KCk7CiAKLSAgICBpZiAoQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAqIHBvcHVwID0gc3RhdGlj X2Nhc3Q8QWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAqPihjaGlsZE9iamVjdHNbMF0uZ2V0KCkp KQotICAgICAgICBwb3B1cC0+ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKG9wdGlvbkluZGV4KTsKKyAg ICBjb25zdCBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGNoaWxkT2JqZWN0cyA9IGNoaWxk cmVuKCk7CisgICAgaWYgKCFjaGlsZE9iamVjdHMuaXNFbXB0eSgpKSB7CisgICAgICAgIEFTU0VS VChjaGlsZE9iamVjdHMuc2l6ZSgpID09IDEpOworICAgICAgICBBU1NFUlQoY2hpbGRPYmplY3Rz WzBdLT5pc01lbnVMaXN0UG9wdXAoKSk7CisKKyAgICAgICAgaWYgKEFjY2Vzc2liaWxpdHlNZW51 TGlzdFBvcHVwKiBwb3B1cCA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVw Kj4oY2hpbGRPYmplY3RzWzBdLmdldCgpKSkKKyAgICAgICAgICAgIHBvcHVwLT5kaWRVcGRhdGVB Y3RpdmVPcHRpb24ob3B0aW9uSW5kZXgpOworICAgIH0KIAogICAgIGNhY2hlLT5wb3N0Tm90aWZp Y2F0aW9uKHRoaXMsIGRvY3VtZW50LmdldCgpLCBBWE9iamVjdENhY2hlOjpBWE1lbnVMaXN0VmFs dWVDaGFuZ2VkLCB0cnVlLCBQb3N0U3luY2hyb25vdXNseSk7CiB9Cg== 110487 2011-10-11 02:12:31 -0700 2011-10-11 13:27:05 -0700 Patch bug-69440-20111011021230.patch text/plain 5953 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTEgIERvbWluaWMg TWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWNjZXNzaWJpbGl0eU1l bnVMaXN0IHNob3VsZCBmaXJlIGNoYW5nZSBub3RpZmljYXRpb24gd2hlbiBwb3B1cCBpcyBub3Qg b3Blbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5 NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dDogYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qtc2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1s CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlzdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5TWVudUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9w dGlvbik6CisKIDIwMTEtMTAtMTAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVcGRhdGUgdGVzdCByZXN1bHRzLgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0LmNwcAkocmV2aXNpb24g OTcxMzEpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51 TGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg0LDE4ICs4NCwxOSBAQCBib29sIEFjY2Vzc2li aWxpdHlNZW51TGlzdDo6aXNDb2xsYXBzZWQoCiAKIHZvaWQgQWNjZXNzaWJpbGl0eU1lbnVMaXN0 OjpkaWRVcGRhdGVBY3RpdmVPcHRpb24oaW50IG9wdGlvbkluZGV4KQogewotICAgIGNvbnN0IEFj Y2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgY2hpbGRPYmplY3RzID0gY2hpbGRyZW4oKTsKLSAg ICBpZiAoY2hpbGRPYmplY3RzLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgQVNT RVJUKGNoaWxkT2JqZWN0cy5zaXplKCkgPT0gMSk7Ci0gICAgQVNTRVJUKGNoaWxkT2JqZWN0c1sw XS0+aXNNZW51TGlzdFBvcHVwKCkpOwotCiAgICAgUmVmUHRyPERvY3VtZW50PiBkb2N1bWVudCA9 IG1fcmVuZGVyZXItPmRvY3VtZW50KCk7CiAgICAgQVhPYmplY3RDYWNoZSogY2FjaGUgPSBkb2N1 bWVudC0+YXhPYmplY3RDYWNoZSgpOwogCi0gICAgaWYgKEFjY2Vzc2liaWxpdHlNZW51TGlzdFBv cHVwKiBwb3B1cCA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwKj4oY2hp bGRPYmplY3RzWzBdLmdldCgpKSkKLSAgICAgICAgcG9wdXAtPmRpZFVwZGF0ZUFjdGl2ZU9wdGlv bihvcHRpb25JbmRleCk7CisgICAgY29uc3QgQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yJiBj aGlsZE9iamVjdHMgPSBjaGlsZHJlbigpOworICAgIGlmICghY2hpbGRPYmplY3RzLmlzRW1wdHko KSkgeworICAgICAgICBBU1NFUlQoY2hpbGRPYmplY3RzLnNpemUoKSA9PSAxKTsKKyAgICAgICAg QVNTRVJUKGNoaWxkT2JqZWN0c1swXS0+aXNNZW51TGlzdFBvcHVwKCkpOworCisgICAgICAgIGlm IChjaGlsZE9iamVjdHNbMF0tPmlzTWVudUxpc3RQb3B1cCgpKSB7CisgICAgICAgICAgICBpZiAo QWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAqIHBvcHVwID0gc3RhdGljX2Nhc3Q8QWNjZXNzaWJp bGl0eU1lbnVMaXN0UG9wdXAqPihjaGlsZE9iamVjdHNbMF0uZ2V0KCkpKQorICAgICAgICAgICAg ICAgIHBvcHVwLT5kaWRVcGRhdGVBY3RpdmVPcHRpb24ob3B0aW9uSW5kZXgpOworICAgICAgICB9 CisgICAgfQogCiAgICAgY2FjaGUtPnBvc3ROb3RpZmljYXRpb24odGhpcywgZG9jdW1lbnQuZ2V0 KCksIEFYT2JqZWN0Q2FjaGU6OkFYTWVudUxpc3RWYWx1ZUNoYW5nZWQsIHRydWUsIFBvc3RTeW5j aHJvbm91c2x5KTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTMxKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTEgIERv bWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWNjZXNzaWJp bGl0eU1lbnVMaXN0IHNob3VsZCBmaXJlIGNoYW5nZSBub3RpZmljYXRpb24gd2hlbiBwb3B1cCBp cyBub3Qgb3Blbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY5NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L21lbnUtbGlzdC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0aW9uLmh0 bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2liaWxpdHkvbWVu dS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwog MjAxMS0xMC0xMSAgT2xpdmVyIFZhcmdhICA8dm9saXZlckBpbmYudS1zemVnZWQuaHU+CiAKICAg ICAgICAgW1F0XSBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbiBhZnRlciByOTcxMDkuCkluZGV4OiBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21lbnUtbGlzdC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0 aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tZW51LWxp c3Qtc2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qtc2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUyIEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsg cmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxl LmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi Pjwvc2NyaXB0PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisKKyAgICBm dW5jdGlvbiBydW5UZXN0KCkgeworICAgICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0 IGNoYW5naW5nIHRoZSB2YWx1ZSBvZiBhIG1lbnUgbGlzdCBzZW5kcyBhIG5vdGlmaWNhdGlvbiBl dmVuIHdoZW4gaXQncyBub3QgcG9wcGVkIG9wZW4uIik7CisKKyAgICAgICAgdmFyIG1lbnVsaXN0 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1lbnVsaXN0Iik7CisgICAgICAgIG1lbnVsaXN0 LmZvY3VzKCk7CisgICAgICAgIHZhciBhY2Nlc3NpYmxlTWVudWxpc3QgPSBhY2Nlc3NpYmlsaXR5 Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKworICAgICAgICBhY2Nlc3NpYmxlTWVudWxpc3Qu YWRkTm90aWZpY2F0aW9uTGlzdGVuZXIoZnVuY3Rpb24obm90aWZpY2F0aW9uKSB7CisgICAgICAg ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVyVGV4dCArPSAiR290 IG5vdGlmaWNhdGlvbjogIiArIG5vdGlmaWNhdGlvbiArICJcbiI7CisgICAgICAgICAgICBkZWJ1 ZygnPGJyIC8+PHNwYW4gY2xhc3M9InBhc3MiPlRFU1QgQ09NUExFVEU8L3NwYW4+Jyk7CisgICAg ICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfSk7CisKKyAgICAg ICAgLy8gQ2hhbmdlIHRoZSBzZWxlY3RlZCBpbmRleC4KKyAgICAgICAgbWVudWxpc3Quc2VsZWN0 ZWRJbmRleCA9IDE7CisKKyAgICAgICAgLy8gTWFrZSB0aGUgdGVzdCBmaW5pc2ggcXVpY2tseSB3 aGV0aGVyIHdlIGdldCB0aGUgbm90aWZpY2F0aW9uIG9yIG5vdC4KKyAgICAgICAgd2luZG93LnNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTsKKyAgICAgICAgfSwgMTApOworICAgIH0KKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIgJiYgd2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAg IHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZnVuY3Rpb24oKSB7CisgICAgICAgICAg ICBzZXRUaW1lb3V0KHJ1blRlc3QsIDEwKTsKKyAgICAgICAgfSwgZmFsc2UpOworICAgIH0KKzwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisKKzxzZWxlY3QgaWQ9Im1lbnVsaXN0Ij4KKyAgPG9w dGlvbiBzZWxlY3RlZD5PbmU8L29wdGlvbj4KKyAgPG9wdGlvbj5Ud288L29wdGlvbj4KKyAgPG9w dGlvbj5UaHJlZTwvb3B0aW9uPgorPC9zZWxlY3Q+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5 IGNoYW5nZXMgb246IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWVudS1saXN0LXNlbmRzLWNo YW5nZS1ub3RpZmljYXRpb24uaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAg ICsgTEYKCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9hY2Nlc3NpYmlsaXR5 L21lbnUtbGlzdC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9hY2Nlc3NpYmlsaXR5L21lbnUt bGlzdC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2liaWxpdHkvbWVudS1saXN0 LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDEwIEBACisKK1RoaXMgdGVzdHMgdGhhdCBjaGFuZ2luZyB0aGUgdmFsdWUgb2YgYSBt ZW51IGxpc3Qgc2VuZHMgYSBub3RpZmljYXRpb24gZXZlbiB3aGVuIGl0J3Mgbm90IHBvcHBlZCBv cGVuLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworR290IG5vdGlmaWNhdGlvbjog TWVudUxpc3RWYWx1ZUNoYW5nZWQKKworVEVTVCBDT01QTEVURQorCgpQcm9wZXJ0eSBjaGFuZ2Vz IG9uOiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9hY2Nlc3NpYmlsaXR5L21lbnUtbGlz dC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0aW9uLWV4cGVjdGVkLnR4dApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVk OiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCg== 110564 2011-10-11 13:27:08 -0700 2011-10-11 13:45:33 -0700 Patch for landing bug-69440-20111011132707.patch text/plain 6072 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3MTcwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTEgIERvbWluaWMg TWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWNjZXNzaWJpbGl0eU1l bnVMaXN0IHNob3VsZCBmaXJlIGNoYW5nZSBub3RpZmljYXRpb24gd2hlbiBwb3B1cCBpcyBub3Qg b3Blbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5 NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRmxlaXphY2guCisKKyAgICAgICAgVGVz dDogYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qtc2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1s CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlzdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5TWVudUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9w dGlvbik6CisKIDIwMTEtMTAtMTEgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4K IAogICAgICAgICBJbmRleGVkREI6IGltcGxlbWVudCBJREJGYWN0b3J5LmNtcCBtZXRob2QKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlNZW51TGlzdC5jcHAJKHJldmlzaW9uIDk3MTcwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NCwx OCArODQsMTkgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5TWVudUxpc3Q6OmlzQ29sbGFwc2VkKAogCiB2 b2lkIEFjY2Vzc2liaWxpdHlNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKGludCBvcHRp b25JbmRleCkKIHsKLSAgICBjb25zdCBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGNoaWxk T2JqZWN0cyA9IGNoaWxkcmVuKCk7Ci0gICAgaWYgKGNoaWxkT2JqZWN0cy5pc0VtcHR5KCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIEFTU0VSVChjaGlsZE9iamVjdHMuc2l6ZSgpID09IDEpOwot ICAgIEFTU0VSVChjaGlsZE9iamVjdHNbMF0tPmlzTWVudUxpc3RQb3B1cCgpKTsKLQogICAgIFJl ZlB0cjxEb2N1bWVudD4gZG9jdW1lbnQgPSBtX3JlbmRlcmVyLT5kb2N1bWVudCgpOwogICAgIEFY T2JqZWN0Q2FjaGUqIGNhY2hlID0gZG9jdW1lbnQtPmF4T2JqZWN0Q2FjaGUoKTsKIAotICAgIGlm IChBY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cCogcG9wdXAgPSBzdGF0aWNfY2FzdDxBY2Nlc3Np YmlsaXR5TWVudUxpc3RQb3B1cCo+KGNoaWxkT2JqZWN0c1swXS5nZXQoKSkpCi0gICAgICAgIHBv cHVwLT5kaWRVcGRhdGVBY3RpdmVPcHRpb24ob3B0aW9uSW5kZXgpOworICAgIGNvbnN0IEFjY2Vz c2liaWxpdHlDaGlsZHJlblZlY3RvciYgY2hpbGRPYmplY3RzID0gY2hpbGRyZW4oKTsKKyAgICBp ZiAoIWNoaWxkT2JqZWN0cy5pc0VtcHR5KCkpIHsKKyAgICAgICAgQVNTRVJUKGNoaWxkT2JqZWN0 cy5zaXplKCkgPT0gMSk7CisgICAgICAgIEFTU0VSVChjaGlsZE9iamVjdHNbMF0tPmlzTWVudUxp c3RQb3B1cCgpKTsKKworICAgICAgICBpZiAoY2hpbGRPYmplY3RzWzBdLT5pc01lbnVMaXN0UG9w dXAoKSkgeworICAgICAgICAgICAgaWYgKEFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwKiBwb3B1 cCA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwKj4oY2hpbGRPYmplY3Rz WzBdLmdldCgpKSkKKyAgICAgICAgICAgICAgICBwb3B1cC0+ZGlkVXBkYXRlQWN0aXZlT3B0aW9u KG9wdGlvbkluZGV4KTsKKyAgICAgICAgfQorICAgIH0KIAogICAgIGNhY2hlLT5wb3N0Tm90aWZp Y2F0aW9uKHRoaXMsIGRvY3VtZW50LmdldCgpLCBBWE9iamVjdENhY2hlOjpBWE1lbnVMaXN0VmFs dWVDaGFuZ2VkLCB0cnVlLCBQb3N0U3luY2hyb25vdXNseSk7CiB9CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA5NzE3MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTEwLTExICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUu Y29tPgorCisgICAgICAgIEFjY2Vzc2liaWxpdHlNZW51TGlzdCBzaG91bGQgZmlyZSBjaGFuZ2Ug bm90aWZpY2F0aW9uIHdoZW4gcG9wdXAgaXMgbm90IG9wZW4uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTQ0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IENocmlzIEZsZWl6YWNoLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qtc2Vu ZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9hY2Nlc3NpYmlsaXR5L21lbnUtbGlzdC1zZW5kcy1jaGFuZ2Utbm90aWZpY2F0aW9u LWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTEtMTAtMTEgIERpbWl0cmkgR2xhemtvdiAgPGRn bGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIE1hcmsgbW9yZSBmbGFr ZXMgYXMgZmxha2VzLgpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qt c2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvbWVudS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24uaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWVudS1saXN0LXNlbmRz LWNoYW5nZS1ub3RpZmljYXRpb24uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1NCBAQAor PGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2Fp dFVudGlsRG9uZSgpOworCisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgZGVzY3Jp cHRpb24oIlRoaXMgdGVzdHMgdGhhdCBjaGFuZ2luZyB0aGUgdmFsdWUgb2YgYSBtZW51IGxpc3Qg c2VuZHMgYSBub3RpZmljYXRpb24gZXZlbiB3aGVuIGl0J3Mgbm90IHBvcHBlZCBvcGVuLiIpOwor CisgICAgICAgIHZhciBtZW51bGlzdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJtZW51bGlz dCIpOworICAgICAgICBtZW51bGlzdC5mb2N1cygpOworICAgICAgICB2YXIgYWNjZXNzaWJsZU1l bnVsaXN0ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisKKyAgICAg ICAgZnVuY3Rpb24gbGlzdGVuZXIobm90aWZpY2F0aW9uKSB7CisgICAgICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVyVGV4dCArPSAiR290IG5vdGlmaWNhdGlv bjogIiArIG5vdGlmaWNhdGlvbiArICJcbiI7CisgICAgICAgICAgICBhY2Nlc3NpYmxlTWVudWxp c3QucmVtb3ZlTm90aWZpY2F0aW9uTGlzdGVuZXIobGlzdGVuZXIpOworICAgICAgICAgICAgZGVi dWcoJzxiciAvPjxzcGFuIGNsYXNzPSJwYXNzIj5URVNUIENPTVBMRVRFPC9zcGFuPicpOworICAg ICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0KKyAgICAgICAg YWNjZXNzaWJsZU1lbnVsaXN0LmFkZE5vdGlmaWNhdGlvbkxpc3RlbmVyKGxpc3RlbmVyKTsKKwor ICAgICAgICAvLyBDaGFuZ2UgdGhlIHNlbGVjdGVkIGluZGV4LgorICAgICAgICBtZW51bGlzdC5z ZWxlY3RlZEluZGV4ID0gMTsKKworICAgICAgICAvLyBNYWtlIHRoZSB0ZXN0IGZpbmlzaCBxdWlj a2x5IHdoZXRoZXIgd2UgZ2V0IHRoZSBub3RpZmljYXRpb24gb3Igbm90LgorICAgICAgICB3aW5k b3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworICAgICAgICB9LCAxMCk7CisgICAgfQorCisgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlciAmJiB3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAg ICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5jdGlvbigpIHsKKyAgICAg ICAgICAgIHNldFRpbWVvdXQocnVuVGVzdCwgMTApOworICAgICAgICB9LCBmYWxzZSk7CisgICAg fQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPHNlbGVjdCBpZD0ibWVudWxpc3QiPgor ICA8b3B0aW9uIHNlbGVjdGVkPk9uZTwvb3B0aW9uPgorICA8b3B0aW9uPlR3bzwvb3B0aW9uPgor ICA8b3B0aW9uPlRocmVlPC9vcHRpb24+Cis8L3NlbGVjdD4KKworPHAgaWQ9ImRlc2NyaXB0aW9u Ij48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPC9ib2R5PgorPC9odG1sPgoKUHJv cGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tZW51LWxpc3Qtc2Vu ZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5 bGUKICAgKyBMRgoKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2li aWxpdHkvbWVudS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2liaWxpdHkv bWVudS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vYWNjZXNzaWJpbGl0eS9tZW51 LWxpc3Qtc2VuZHMtY2hhbmdlLW5vdGlmaWNhdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTAgQEAKKworVGhpcyB0ZXN0cyB0aGF0IGNoYW5naW5nIHRoZSB2YWx1ZSBv ZiBhIG1lbnUgbGlzdCBzZW5kcyBhIG5vdGlmaWNhdGlvbiBldmVuIHdoZW4gaXQncyBub3QgcG9w cGVkIG9wZW4uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitHb3Qgbm90aWZpY2F0 aW9uOiBNZW51TGlzdFZhbHVlQ2hhbmdlZAorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNo YW5nZXMgb246IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2liaWxpdHkvbWVu dS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24tZXhwZWN0ZWQudHh0Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K QWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK