69432 2011-10-05 08:53:21 -0700 [Qt][WK2][Mac] QtWebProcess should not show up in the Dock. 2011-10-06 04:22:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno webkit.review.bot oldest_to_newest 478400 0 zeno 2011-10-05 08:53:21 -0700 [Qt][WK2][Mac] QtWebProcess should not show up in the Dock. 478402 1 109807 zeno 2011-10-05 08:57:31 -0700 Created attachment 109807 Patch 478408 2 109807 kling 2011-10-05 09:09:23 -0700 Comment on attachment 109807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109807&action=review Very nice! :) > Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:85 > + qputenv("QT_MAC_DISABLE_FOREGROUND_APPLICATION_TRANSFORM", QString("1").toLocal8Bit()); We can avoid invoking the ASCII codec by simply passing QByteArray("1") for the second argument. 478661 3 109856 zeno 2011-10-05 13:57:18 -0700 Created attachment 109856 patch for review. - dropped the toLocal8Bit() thing. 478686 4 109856 kling 2011-10-05 14:30:28 -0700 Comment on attachment 109856 patch for review. - dropped the toLocal8Bit() thing. View in context: https://bugs.webkit.org/attachment.cgi?id=109856&action=review r=me > Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:84 > +#if defined Q_OS_MACX I don't think I've ever seen "#if defined X" in WebKit before, let's stick with "#ifdef X" or "#if defined(X)". Sorry I didn't notice earlier. 479053 5 109941 zeno 2011-10-06 03:56:12 -0700 Created attachment 109941 patch for review - fixed "#if defined(X)" 479062 6 109941 webkit.review.bot 2011-10-06 04:22:19 -0700 Comment on attachment 109941 patch for review - fixed "#if defined(X)" Clearing flags on attachment: 109941 Committed r96800: <http://trac.webkit.org/changeset/96800> 479063 7 webkit.review.bot 2011-10-06 04:22:23 -0700 All reviewed patches have been landed. Closing bug. 109807 2011-10-05 08:57:31 -0700 2011-10-05 13:57:18 -0700 Patch bug-69432-20111005175729.patch text/plain 1534 zeno U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4ZGFhZmZhZTU2YjM3ZWNj MzdkNzlkN2ZmNGY0M2ZkY2Y0MTA1NjBkLi5jZTQ0ZjFlMzZlYzQwNzVlMjdjOWM3YzRkZGRiNjIy ZmQ2YzM4NzQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMDUgIFplbm8g QWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl1b TWFjXSBRdFdlYlByb2Nlc3Mgc2hvdWxkIG5vdCBzaG93IHVwIGluIHRoZSBEb2NrLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MzIKKworICAgICAg ICBXZSBjYW4gc2V0IHRoZSBlbnZpcm9ubWVudCB2YXJpYWJsZSBRVF9NQUNfRElTQUJMRV9GT1JF R1JPVU5EX0FQUExJQ0FUSU9OX1RSQU5TRk9STQorICAgICAgICBpbiB0aGUgV2ViUHJvY2VzcyBz dHViIHRvIGRpc2FibGUgdGhlIGF1dG9tYXRpYyBmb3JlZ3JvdW5kIHRyYW5zZm9ybWF0aW9uLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UXRXZWJQcm9jZXNzOjpzZXR1cENoaWxkUHJvY2Vzcyk6CisKIDIwMTEtMTAtMDUgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSBX S1JldGFpblB0ciBmb3IgV0sgdHlwZXMgaW4gV2ViS2l0MiBHVEsrCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNw cAppbmRleCBjYWU1YmRmZjY3NTM0M2E3ZDdiMGQwMGE4ZTBlMThiOTIxNzlhNWNhLi4zMDcxNWRj NzAwZjA0YzU5OTVlNGE3NjhmZTFiYjcwMTMxNGZlY2UzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1bmNoZXJRdC5jcHAK QEAgLTgxLDYgKzgxLDkgQEAgdm9pZCBRdFdlYlByb2Nlc3M6OnNldHVwQ2hpbGRQcm9jZXNzKCkK ICNlbmRpZgogICAgIHByY3RsKFBSX1NFVF9QREVBVEhTSUcsIFNJR0tJTEwpOwogI2VuZGlmCisj aWYgZGVmaW5lZCBRX09TX01BQ1gKKyAgICBxcHV0ZW52KCJRVF9NQUNfRElTQUJMRV9GT1JFR1JP VU5EX0FQUExJQ0FUSU9OX1RSQU5TRk9STSIsIFFTdHJpbmcoIjEiKS50b0xvY2FsOEJpdCgpKTsK KyNlbmRpZgogfQogCiB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2VzcygpCg== 109856 2011-10-05 13:57:18 -0700 2011-10-06 03:56:12 -0700 patch for review. - dropped the toLocal8Bit() thing. 69432_20111005-225323.patch text/plain 1364 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZGFhZmZhLi5jZTQ0ZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMDUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K KworICAgICAgICBbUXRdW1dLMl1bTWFjXSBRdFdlYlByb2Nlc3Mgc2hvdWxkIG5vdCBzaG93IHVw IGluIHRoZSBEb2NrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk0MzIKKworICAgICAgICBXZSBjYW4gc2V0IHRoZSBlbnZpcm9ubWVudCB2YXJpYWJs ZSBRVF9NQUNfRElTQUJMRV9GT1JFR1JPVU5EX0FQUExJQ0FUSU9OX1RSQU5TRk9STQorICAgICAg ICBpbiB0aGUgV2ViUHJvY2VzcyBzdHViIHRvIGRpc2FibGUgdGhlIGF1dG9tYXRpYyBmb3JlZ3Jv dW5kIHRyYW5zZm9ybWF0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNw cDoKKyAgICAgICAgKFdlYktpdDo6UXRXZWJQcm9jZXNzOjpzZXR1cENoaWxkUHJvY2Vzcyk6CisK IDIwMTEtMTAtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIFVzZSBXS1JldGFpblB0ciBmb3IgV0sgdHlwZXMgaW4gV2ViS2l0MiBH VEsrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJv Y2Vzc0xhdW5jaGVyUXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0 L1Byb2Nlc3NMYXVuY2hlclF0LmNwcAppbmRleCBjYWU1YmRmLi41MDY5NWQ3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1 bmNoZXJRdC5jcHAKQEAgLTgxLDYgKzgxLDkgQEAgdm9pZCBRdFdlYlByb2Nlc3M6OnNldHVwQ2hp bGRQcm9jZXNzKCkKICNlbmRpZgogICAgIHByY3RsKFBSX1NFVF9QREVBVEhTSUcsIFNJR0tJTEwp OwogI2VuZGlmCisjaWYgZGVmaW5lZCBRX09TX01BQ1gKKyAgICBxcHV0ZW52KCJRVF9NQUNfRElT QUJMRV9GT1JFR1JPVU5EX0FQUExJQ0FUSU9OX1RSQU5TRk9STSIsIFFCeXRlQXJyYXkoIjEiKSk7 CisjZW5kaWYKIH0KIAogdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQo= 109941 2011-10-06 03:56:12 -0700 2011-10-06 04:22:19 -0700 patch for review - fixed "#if defined(X)" 69432_20111006-125419.patch text/plain 1741 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNmM1MTA1Li4xMTEzYTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMDUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K KworICAgICAgICBbUXRdW1dLMl1bTWFjXSBRdFdlYlByb2Nlc3Mgc2hvdWxkIG5vdCBzaG93IHVw IGluIHRoZSBEb2NrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk0MzIKKworICAgICAgICBXZSBjYW4gc2V0IHRoZSBlbnZpcm9ubWVudCB2YXJpYWJs ZSBRVF9NQUNfRElTQUJMRV9GT1JFR1JPVU5EX0FQUExJQ0FUSU9OX1RSQU5TRk9STQorICAgICAg ICBpbiB0aGUgV2ViUHJvY2VzcyBzdHViIHRvIGRpc2FibGUgdGhlIGF1dG9tYXRpYyBmb3JlZ3Jv dW5kIHRyYW5zZm9ybWF0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNw cDoKKyAgICAgICAgKFdlYktpdDo6UXRXZWJQcm9jZXNzOjpzZXR1cENoaWxkUHJvY2Vzcyk6CisK IDIwMTEtMTAtMDMgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZCBhbiBvcHRpb24gdG8gc3VwcHJlc3MgcmVuZGVyaW5nIHVudGlsIHRoZSBkb2N1bWVudCdzIGxv YWQgZXZlbnQgZmlyZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1 bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcAppbmRleCBjYWU1YmRmLi5lOWJiOGIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vz c0xhdW5jaGVyUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9x dC9Qcm9jZXNzTGF1bmNoZXJRdC5jcHAKQEAgLTUwLDcgKzUwLDcgQEAKICNpbmNsdWRlIDx3dGYv UGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9XVEZTdHJpbmcuaD4KLSNpZiBkZWZpbmVkIFFfT1NfTElOVVgKKyNpZiBkZWZpbmVkKFFf T1NfTElOVVgpCiAjaW5jbHVkZSA8c3lzL3ByY3RsLmg+CiAjaW5jbHVkZSA8c2lnbmFsLmg+CiAj ZW5kaWYKQEAgLTc0LDEzICs3NCwxNiBAQCBwcm90ZWN0ZWQ6CiAKIHZvaWQgUXRXZWJQcm9jZXNz OjpzZXR1cENoaWxkUHJvY2VzcygpCiB7Ci0jaWYgZGVmaW5lZCBRX09TX0xJTlVYCisjaWYgZGVm aW5lZChRX09TX0xJTlVYKQogI2lmbmRlZiBOREVCVUcKICAgICBpZiAoZ2V0ZW52KCJRVF9XRUJL SVRfS0VFUF9BTElWRV9XRUJfUFJPQ0VTUyIpKQogICAgICAgICByZXR1cm47CiAjZW5kaWYKICAg ICBwcmN0bChQUl9TRVRfUERFQVRIU0lHLCBTSUdLSUxMKTsKICNlbmRpZgorI2lmIGRlZmluZWQo UV9PU19NQUNYKQorICAgIHFwdXRlbnYoIlFUX01BQ19ESVNBQkxFX0ZPUkVHUk9VTkRfQVBQTElD QVRJT05fVFJBTlNGT1JNIiwgUUJ5dGVBcnJheSgiMSIpKTsKKyNlbmRpZgogfQogCiB2b2lkIFBy b2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2VzcygpCg==