69425 2011-10-05 07:46:05 -0700 display: table-cell always uses content-box sizing to calculate height, even when box-sizing: border-box 2022-02-28 03:59:08 -0800 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74397 1 nickshanks dominicc darin dominicc eric hyatt mitz tabatkins oldest_to_newest 478347 0 109791 nickshanks 2011-10-05 07:46:05 -0700 Created attachment 109791 reduced test case The height of a table cell with both a height and vertical padding is calculated incorrectly, adding the two together instead of just using the height (cells are always border-box). Changing the box-sizing property or setting a max-height has no effect. This is unrelated to bug #13339, bug #18565 or bug #37685 all of which relate to widths of cells in fixed layout tables. In Aurora 9 and Opera Next 12, both tables in the attached test case are 100px high. In WebKit Nightlies and Chrome Canary it is 152px high. 478993 1 109927 dominicc 2011-10-05 23:54:49 -0700 Created attachment 109927 Patch 478994 2 109927 dominicc 2011-10-05 23:56:24 -0700 Comment on attachment 109927 Patch Bouncing this off bots. 479005 3 nickshanks 2011-10-06 00:13:41 -0700 Dominic, thanks for the quick patch, but the problem is that Firefox and Opera, in strict mode, still calculate cell sizes using the border-box model, even if box-sizing is set to content-box. 479018 4 dominicc 2011-10-06 01:19:00 -0700 (All of my comments below relate to strict mode. I didn’t investigate quirks mode.) Your comment about Firefox and Opera doesn’t jive with what I see. I noticed Firefox (7.0.1 and Minefield 10.0a1 2011-10-05) seems to ignore -moz-box-sizing/box-sizing for display: table-cell elements. FF uses something like the content-box calculation for cell width, and border-box calculation for cell height. Opera 11.51’s default and box-sizing: content-box behavior matches Firefox’s (invariant) behavior. box-sizing: border-box matches the patch I have posted here. It is possible there are multiple WebKit bugs here: 1. WebKit applies box-sizing: border-box of display: table-cell elements to the width, but not the height, of the element. 2. WebKit’s box-sizing: content-box sizing of display: table-cell elements might be wrong, because it doesn’t match that of Firefox or Opera, that is, WebKit uses something like the border-box calculation for cell width, and content-box calculation for cell height. 479021 5 dominicc 2011-10-06 01:38:55 -0700 Two more data points: IE9 display: table-cell with box-sizing: content-box matches WebKit ToT. IE9 display: table-cell with box-sizing: border-box matches Opera and the patch I have posted here. 479029 6 nickshanks 2011-10-06 02:20:54 -0700 (In reply to comment #4) > FF uses something like the content-box calculation for cell width, and border-box calculation for cell height. > 2. WebKit’s box-sizing: content-box sizing of display: table-cell elements might be wrong, because it doesn’t match that of Firefox or Opera, that is, WebKit uses something like the border-box calculation for cell width, and content-box calculation for cell height. I did not test how width was handled (there are many other bugs for that, as cited earlier). All of my previous comments were related to height only, i.e. when I said: > the problem is that Firefox and Opera, in strict mode, still calculate cell sizes using the border-box model, even if box-sizing is set to content-box. I meant to say: > the problem is that Firefox and Opera, in strict mode, still calculate cell *heights* using the border-box model, even if box-sizing is set to content-box. From your testing, it looks like Firefox is the odd one out with border-box cell width. IE, Opera & WKToT with your patch all now agree on heights. Width differences can be covered in a separate bug. Do you think this patch needs some sort of website impact review before landing? It's pretty fundamental to be changing how table cell sizes are calculated, even if our current state is so clearly wrong. 479033 7 dominicc 2011-10-06 03:07:14 -0700 (In reply to comment #6) > I did not test how width was handled (there are many other bugs for that, as cited earlier). All of my previous comments were related to height only Yes! I see now. > From your testing, it looks like Firefox is the odd one out with border-box cell width. IE, Opera & WKToT with your patch all now agree on heights. Width differences can be covered in a separate bug. The fact that Firefox doesn’t change the size of the box between content-box and border-box looks like a bug on their part. > Do you think this patch needs some sort of website impact review before landing? It's pretty fundamental to be changing how table cell sizes are calculated, even if our current state is so clearly wrong. Actually I think that this is relatively safe from a site compatibility perspective, first because it brings WebKit into line with Firefox, Opera and IE9; second because it only changes the height of display: table-cell box-sizing: border-box elements. Most table cells are box-sizing: content-box. 479095 8 nickshanks 2011-10-06 05:50:49 -0700 (In reply to comment #7) > The fact that Firefox doesn’t change the size of the box between content-box and border-box looks like a bug on their part. I was about to file it, but it looks like they have several serious bugs with border-box (open for 6 years). Seems like Tantek is at least aware of one of them: "table-cell height calculation uses border-box sizing; should use content-box" https://bugzilla.mozilla.org/show_bug.cgi?id=295315 "min-height/max-height does not work for box-sizing:border-box" https://bugzilla.mozilla.org/show_bug.cgi?id=308801 > second because it only changes the height of display: table-cell box-sizing: border-box elements. ... with non-zero vertical padding and a fixed height. Okay, maybe you're right :-) 479101 9 nickshanks 2011-10-06 05:53:56 -0700 Oh, I meant to add: are you intending to address the max-height issue with a second patch on this bug, or would you like me to file another bug? 479113 10 dominicc 2011-10-06 06:18:44 -0700 (In reply to comment #9) > Oh, I meant to add: are you intending to address the max-height issue with a second patch on this bug, or would you like me to file another bug? Usual practice in WebKit is to file separate bugs. Please CC me on that one, although I don’t know table layout well, so I will probably wait and see what a reviewer says about this one first. 494007 11 109927 mitz 2011-11-01 10:39:32 -0700 Comment on attachment 109927 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109927&action=review > Source/WebCore/rendering/RenderTableSection.cpp:373 > + // In strict mode, box-sizing: content-box do the > + // right thing and actually add in the border and > + // padding. This comment can fit on two lines (or maybe even one line). > Source/WebCore/rendering/RenderTableSection.cpp:376 > + ch += (adjustedPaddingBefore + adjustedPaddingAfter + cell->borderBefore() + cell->borderAfter()); The parentheses seem unnecessary. 494116 12 dominicc 2011-11-01 13:56:17 -0700 Committed r98997: <http://trac.webkit.org/changeset/98997> 109791 2011-10-05 07:46:05 -0700 2011-10-05 07:46:05 -0700 reduced test case bug.html text/html 436 nickshanks PCFET0NUWVBFIGh0bWw+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CglzcGFuLCB0ZCB7CgkJaGVp Z2h0OiAxMDBweDsKCQlwYWRkaW5nLXRvcDogNTBweDsKCQlkaXNwbGF5OiB0YWJsZS1jZWxsOwoJ CQoJCS8qIGp1c3QgZm9yIGRlYnVnZ2luZyAqLwoJCWJvcmRlcjogMXB4IHNvbGlkIHJlZDsKCQkK CQkvKiB0aGVzZSBoYXZlIG5vIGVmZmVjdCAqLwoJCW1heC1oZWlnaHQ6IDEwMHB4OwoJCS13ZWJr aXQtYm94LXNpemluZzogYm9yZGVyLWJveDsKCQlib3gtc2l6aW5nOiBib3JkZXItYm94OwoJfQo8 L3N0eWxlPgoKPHNwYW4+RXhwZWN0ZWQgaGVpZ2h0IGlzIDEwMHB4IGluY2x1ZGluZyBwYWRkaW5n IGFuZCBib3JkZXIuPC9zcGFuPgo8dGFibGU+PHRkPkV4cGVjdGVkIGhlaWdodCBpcyAxMDBweCBp bmNsdWRpbmcgcGFkZGluZyBhbmQgYm9yZGVyLjwvdGFibGU+Cg== 109927 2011-10-05 23:54:49 -0700 2022-02-28 03:59:08 -0800 Patch bug-69425-20111006155447.patch text/plain 5727 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3MDcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwZDI2ODg1NTlhNWUyYWRiZjkwNjU2 YjMzMjVhYmU5OWRjNWQ4ZGM1Li5lNDY2MTBhNDAwMTVhMTY0NWJjMjZiNzQ2ZmZkMzA2MjM4ZWY3 MTY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDUgIERvbWluaWMgQ29vbmV5ICA8 ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGRpc3BsYXk6IHRhYmxlLWNlbGwgYW5k IGJveC1zaXppbmc6IGJvcmRlci1ib3ggY2FsY3VsYXRlcyBjb250ZW50LWJveCBoZWlnaHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDI1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2JveC1z aXppbmcvdGFibGUtY2VsbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYm94 LXNpemluZy90YWJsZS1jZWxsLmh0bWw6IEFkZGVkLgorCiAyMDExLTEwLTA1ICBBYmhpc2hlayBB cnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2ggaW4gU1ZHVFJlZkVs ZW1lbnQ6OnVwZGF0ZVJlZmVyZW5jZWRUZXh0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9ib3gtc2l6aW5nL3RhYmxlLWNlbGwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9i b3gtc2l6aW5nL3RhYmxlLWNlbGwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFjNmZkMzM5YTZh OWExYjVjYjU5MjVhNWQzZGMyMmE4NDI4ODRhZjgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2JveC1zaXppbmcvdGFibGUtY2VsbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwx NSBAQAorVGVzdHMgdGhhdCBkaXNwbGF5OiB0YWJsZS1jZWxsIGFuZCBib3gtc2l6aW5nOiBib3Jk ZXItYm94IHdvcmsgd2hlbiB1c2VkIHRvZ2V0aGVyLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworZGl2LWRpc3BsYXktdGFibGUtY2VsbAorUEFTUyBlbGVtZW50Lm9mZnNldFdpZHRo IGlzIDgwCitQQVNTIGVsZW1lbnQub2Zmc2V0SGVpZ2h0IGlzIDMwCit0ZAorUEFTUyBlbGVtZW50 Lm9mZnNldFdpZHRoIGlzIDgwCitQQVNTIGVsZW1lbnQub2Zmc2V0SGVpZ2h0IGlzIDMwCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9ib3gtc2l6aW5nL3RhYmxlLWNlbGwuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvYm94LXNpemluZy90YWJsZS1jZWxsLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmNlNWE2MDRi NGJkZjZmZDE3N2QwMzg5NzNmNDEyYjE3ZjJjOTFjNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvYm94LXNpemluZy90YWJsZS1jZWxsLmh0bWwKQEAgLTAsMCArMSw0NCBAQAor PCFET0NUWVBFIGh0bWw+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+CisKKzxzdHlsZT4KKy5zdHlsZWRGb3JUZXN0IHsKKyAg LW1vei1ib3gtc2l6aW5nOiBib3JkZXItYm94OworICBib3gtc2l6aW5nOiBib3JkZXItYm94Owor ICBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7CisgIGNvbG9yOiB3aGl0ZTsKKyAgYm9yZGVyOiA3 cHggc29saWQgYmxhY2s7CisgIHBhZGRpbmc6IDVweDsKKyAgd2lkdGg6IDgwcHg7CisgIGhlaWdo dDogMzBweDsKKyAgbWFyZ2luOiAycHg7Cit9Cis8L3N0eWxlPgorCis8cCBpZD0iZGVzY3JpcHRp b24iPkFsbCBvZiB0aGUgYm94ZXMgc2hvdWxkIGJlIDgweDMwIGFuZCBsb29rIGlkZW50aWNhbC48 L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPGRpdiBpZD0iZXhwZWN0ZWQiIGNsYXNz PSJzdHlsZWRGb3JUZXN0Ij48L2Rpdj4KKworPGRpdiBpZD0iZGl2LWRpc3BsYXktdGFibGUtY2Vs bCIgY2xhc3M9InN0eWxlZEZvclRlc3QiIHN0eWxlPSJkaXNwbGF5OiB0YWJsZS1jZWxsOyI+PC9k aXY+CisKKzx0YWJsZT4KKzx0cj4KKzx0ZCBpZD0idGQiIGNsYXNzPSJzdHlsZWRGb3JUZXN0Ij48 L3RkPgorPC90cj4KKzwvdGFibGU+CisKKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0cyB0aGF0 IGRpc3BsYXk6IHRhYmxlLWNlbGwgYW5kIGJveC1zaXppbmc6IGJvcmRlci1ib3ggd29yayB3aGVu IHVzZWQgdG9nZXRoZXIuJyk7CisKK1snZGl2LWRpc3BsYXktdGFibGUtY2VsbCcsICd0ZCddLmZv ckVhY2goZnVuY3Rpb24gKGlkKSB7CisgIGRlYnVnKGlkKTsKKyAgZWxlbWVudCA9IGRvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoJyMnICsgaWQpOworICBzaG91bGRCZSgnZWxlbWVudC5vZmZzZXRXaWR0 aCcsICc4MCcpOworICBzaG91bGRCZSgnZWxlbWVudC5vZmZzZXRIZWlnaHQnLCAnMzAnKTsKK30p OworCitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2RlOGFlMjdiZDE3NmY0ZTg0MTVlNzlmMmJiZjVhNWNiYmU0NmM2ZC4uYzBhYWRmNGZhNDAwNzc1 ZDczMDI1M2IzNjdhMjhmMTEzMmE5ZTNjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDExLTEwLTA1ICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAg ICAgICBkaXNwbGF5OiB0YWJsZS1jZWxsIGFuZCBib3gtc2l6aW5nOiBib3JkZXItYm94IGNhbGN1 bGF0ZXMgY29udGVudC1ib3ggaGVpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02OTQyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvYm94LXNpemluZy90YWJsZS1jZWxsLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVGFibGVTZWN0aW9uOjpjYWxjUm93TG9naWNhbEhlaWdodCk6CisKIDIwMTEt MTAtMDUgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBD cmFzaCBpbiBTVkdUUmVmRWxlbWVudDo6dXBkYXRlUmVmZXJlbmNlZFRleHQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCmluZGV4IDc4NTkzZjE4 MjQ3NmUxODY4NGMzYTIxMjNiM2JjMDQ4MDdmMGQ5NWYuLjZlYTI5ZjMwMDgwNDhkOTEyM2YxZDk3 NGNiMzNhMmFkMDllMzkyOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZVNlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZVNlY3Rpb24uY3BwCkBAIC0zNjEsMTUgKzM2MSwyMCBAQCBMYXlvdXRVbml0IFJlbmRl clRhYmxlU2VjdGlvbjo6Y2FsY1Jvd0xvZ2ljYWxIZWlnaHQoKQogICAgICAgICAgICAgICAgIGNl bGwtPmxheW91dElmTmVlZGVkKCk7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIExheW91 dFVuaXQgYWRqdXN0ZWRQYWRkaW5nQmVmb3JlID0gY2VsbC0+cGFkZGluZ0JlZm9yZSgpIC0gY2Vs bC0+aW50cmluc2ljUGFkZGluZ0JlZm9yZSgpOwotICAgICAgICAgICAgTGF5b3V0VW5pdCBhZGp1 c3RlZFBhZGRpbmdBZnRlciA9IGNlbGwtPnBhZGRpbmdBZnRlcigpIC0gY2VsbC0+aW50cmluc2lj UGFkZGluZ0FmdGVyKCk7CiAgICAgICAgICAgICBMYXlvdXRVbml0IGFkanVzdGVkTG9naWNhbEhl aWdodCA9IGNlbGwtPmxvZ2ljYWxIZWlnaHQoKSAtIChjZWxsLT5pbnRyaW5zaWNQYWRkaW5nQmVm b3JlKCkgKyBjZWxsLT5pbnRyaW5zaWNQYWRkaW5nQWZ0ZXIoKSk7CiAKLSAgICAgICAgICAgIC8v IEV4cGxpY2l0IGhlaWdodHMgdXNlIHRoZSBib3JkZXIgYm94IGluIHF1aXJrcyBtb2RlLiAgSW4g c3RyaWN0IG1vZGUgZG8gdGhlIHJpZ2h0Ci0gICAgICAgICAgICAvLyB0aGluZyBhbmQgYWN0dWFs bHkgYWRkIGluIHRoZSBib3JkZXIgYW5kIHBhZGRpbmcuCi0gICAgICAgICAgICBjaCA9IGNlbGwt PnN0eWxlKCktPmxvZ2ljYWxIZWlnaHQoKS5jYWxjVmFsdWUoMCkgKyAKLSAgICAgICAgICAgICAg ICAoZG9jdW1lbnQoKS0+aW5RdWlya3NNb2RlKCkgPyAwIDogKGFkanVzdGVkUGFkZGluZ0JlZm9y ZSArIGFkanVzdGVkUGFkZGluZ0FmdGVyICsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNlbGwtPmJvcmRlckJlZm9yZSgpICsgY2VsbC0+Ym9yZGVy QWZ0ZXIoKSkpOworICAgICAgICAgICAgY2ggPSBjZWxsLT5zdHlsZSgpLT5sb2dpY2FsSGVpZ2h0 KCkuY2FsY1ZhbHVlKDApOworICAgICAgICAgICAgaWYgKGRvY3VtZW50KCktPmluUXVpcmtzTW9k ZSgpIHx8IGNlbGwtPnN0eWxlKCktPmJveFNpemluZygpID09IEJPUkRFUl9CT1gpIHsKKyAgICAg ICAgICAgICAgICAvLyBFeHBsaWNpdCBoZWlnaHRzIHVzZSB0aGUgYm9yZGVyIGJveCBpbiBxdWly a3MgbW9kZS4KKyAgICAgICAgICAgICAgICAvLyBEb24ndCBhZGp1c3QgaGVpZ2h0LgorICAgICAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAvLyBJbiBzdHJpY3QgbW9kZSwgYm94LXNp emluZzogY29udGVudC1ib3ggZG8gdGhlCisgICAgICAgICAgICAgICAgLy8gcmlnaHQgdGhpbmcg YW5kIGFjdHVhbGx5IGFkZCBpbiB0aGUgYm9yZGVyIGFuZAorICAgICAgICAgICAgICAgIC8vIHBh ZGRpbmcuCisgICAgICAgICAgICAgICAgTGF5b3V0VW5pdCBhZGp1c3RlZFBhZGRpbmdCZWZvcmUg PSBjZWxsLT5wYWRkaW5nQmVmb3JlKCkgLSBjZWxsLT5pbnRyaW5zaWNQYWRkaW5nQmVmb3JlKCk7 CisgICAgICAgICAgICAgICAgTGF5b3V0VW5pdCBhZGp1c3RlZFBhZGRpbmdBZnRlciA9IGNlbGwt PnBhZGRpbmdBZnRlcigpIC0gY2VsbC0+aW50cmluc2ljUGFkZGluZ0FmdGVyKCk7CisgICAgICAg ICAgICAgICAgY2ggKz0gKGFkanVzdGVkUGFkZGluZ0JlZm9yZSArIGFkanVzdGVkUGFkZGluZ0Fm dGVyICsgY2VsbC0+Ym9yZGVyQmVmb3JlKCkgKyBjZWxsLT5ib3JkZXJBZnRlcigpKTsKKyAgICAg ICAgICAgIH0KICAgICAgICAgICAgIGNoID0gbWF4KGNoLCBhZGp1c3RlZExvZ2ljYWxIZWlnaHQp OwogCiAgICAgICAgICAgICBwb3MgPSBtX3Jvd1Bvc1tpbmR4XSArIGNoICsgKG1fZ3JpZFtyXS5y b3dSZW5kZXJlciA/IHNwYWNpbmcgOiAwKTsK