6942 2006-01-30 14:13:02 -0800 Assertion failure in HTMLSelectElementImpl::selectedIndex (m_multiple) 2006-01-31 11:00:33 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED http://bugzilla.opendarwin.org/enter_bug.cgi?product=WebKit P2 Normal --- 1 mitz webkit-unassigned adele sullivan oldest_to_newest 30659 0 mitz 2006-01-30 14:13:02 -0800 The assert at the end of HTMLSelectElementImpl::selectedIndex fails when no item is selected. It went unnoticed before because it was a Q_ASSERT, but in r12471 it was changed to an ASSERT. Anyway, it is bogus since -1 is the correct value to return when no option is selected. 30663 1 6119 mitz 2006-01-30 14:36:03 -0800 Created attachment 6119 Remove the assert Not sure the test is necessary 30664 2 6119 adele 2006-01-30 14:36:54 -0800 Comment on attachment 6119 Remove the assert r=me 30720 3 darin 2006-01-30 23:07:04 -0800 Oops, yes, I was wondering which of the Q_ASSERT that I changed to ASSERT were bogus. Sorry, my mistake. 30794 4 sullivan 2006-01-31 11:00:33 -0800 *** Bug 6974 has been marked as a duplicate of this bug. *** 6119 2006-01-30 14:36:03 -0800 2006-01-30 14:36:54 -0800 Remove the assert 6942_r1.patch text/plain 3166 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDgwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICAtIHRlc3QgZm9yIGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MgorICAgICAgICAgIEFzc2VydGlvbiBm YWlsdXJlIGluIEhUTUxTZWxlY3RFbGVtZW50SW1wbDo6c2VsZWN0ZWRJbmRleCAobV9tdWx0aXBs ZSkKKworICAgICAgICAqIGZhc3QvZm9ybXMvc2VsZWN0ZWQtaW5kZXgtYXNzZXJ0LWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWxlY3RlZC1pbmRleC1hc3NlcnQu aHRtbDogQWRkZWQuCisKIDIwMDYtMDEtMzAgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgogCiAgICAgICAgIExheW91dCB0ZXN0IGZvciA8cmRhcjovL3Byb2JsZW0vNDI5ODA1Mj4gQ3Jh c2ggaW4gCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdGVkLWluZGV4LWFzc2Vy dC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0ZWQtaW5k ZXgtYXNzZXJ0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nl bGVjdGVkLWluZGV4LWFzc2VydC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEyIEBACitU aGlzIHRlc3RzIGZvciBhIHJlZ3Jlc3Npb24gYWdhaW5zdAorPGk+PGEgaHJlZj0iaHR0cDovL2J1 Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02OTQyIj5odHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDI8L2E+CitBc3NlcnRpb24gZmFp bHVyZSBpbiBIVE1MU2VsZWN0RWxlbWVudEltcGw6OnNlbGVjdGVkSW5kZXggKG1fbXVsdGlwbGUp PC9pPgorPGhyPgorTm8gYXNzZXJ0aW9uIGZhaWx1cmUgKG9uIGEgZGVidWcgYnVpbGQpIG1lYW5z IHRlc3QgUEFTUy4KKzxzZWxlY3QgaWQ9InQiPgorPC9zZWxlY3Q+Cis8c2NyaXB0IHR5cGU9InRl eHQvamF2YXNjcmlwdCI+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCd0Jykuc2VsZWN0ZWRJbmRleCgpOworPC9zY3JpcHQ+CkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdGVkLWluZGV4LWFzc2VydC1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3RlZC1pbmRleC1hc3NlcnQt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxl Y3RlZC1pbmRleC1hc3NlcnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIg QEAKK1RoaXMgdGVzdHMgZm9yIGEgcmVncmVzc2lvbiBhZ2FpbnN0IGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MiBBc3NlcnRpb24gZmFpbHVyZSBpbiBI VE1MU2VsZWN0RWxlbWVudEltcGw6OnNlbGVjdGVkSW5kZXggKG1fbXVsdGlwbGUpCitObyBhc3Nl cnRpb24gZmFpbHVyZSAob24gYSBkZWJ1ZyBidWlsZCkgbWVhbnMgdGVzdCBQQVNTLiAKSW5kZXg6 IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAxMjQ4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBl dHRlbC5jb20+CisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9zZWxlY3RlZC1pbmRleC1hc3Nl cnQuaHRtbC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg CisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Njk0MgorICAgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIEhUTUxTZWxlY3RFbGVt ZW50SW1wbDo6c2VsZWN0ZWRJbmRleCAobV9tdWx0aXBsZSkKKworICAgICAgICAqIGtodG1sL2h0 bWwvSFRNTFNlbGVjdEVsZW1lbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxl Y3RFbGVtZW50SW1wbDo6c2VsZWN0ZWRJbmRleCk6IFJlbW92ZWQgYm9ndXMgYXNzZXJ0LgorICAg ICAgICAtMSBpcyB0aGUgY29ycmVjdCB2YWx1ZSB0byByZXR1cm4gaWYgbm8gb3B0aW9uIGlzIHNl bGVjdGVkLgorCiAyMDA2LTAxLTMwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIYXJyaXNvbi4KSW5kZXg6IFdlYkNvcmUva2h0 bWwvaHRtbC9IVE1MU2VsZWN0RWxlbWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv a2h0bWwvaHRtbC9IVE1MU2VsZWN0RWxlbWVudEltcGwuY3BwCShyZXZpc2lvbiAxMjQ3NikKKysr IFdlYkNvcmUva2h0bWwvaHRtbC9IVE1MU2VsZWN0RWxlbWVudEltcGwuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05NCw3ICs5NCw2IEBAIGludCBIVE1MU2VsZWN0RWxlbWVudEltcGw6OnNlbGVjdGVk SW5kZXgKICAgICAgICAgICAgIG8rKzsKICAgICAgICAgfQogICAgIH0KLSAgICBBU1NFUlQobV9t dWx0aXBsZSk7CiAgICAgcmV0dXJuIC0xOwogfQogCg==