69418 2011-10-05 07:08:06 -0700 Fails to compile with gtk-2.20.1 2011-10-05 10:38:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 remi.duraffort webkit-unassigned alex mrobinson webkit.review.bot xan.lopez oldest_to_newest 478320 0 remi.duraffort 2011-10-05 07:08:06 -0700 WebKitGtk fails to compile with Gtk-2.20.1 (ubuntu lucid) even when adding --with-gtk=2.0 The failure is the following ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp: In member function 'WTF::PassOwnPtr<WebCore::DragData> WebCore::GtkDragAndDropHelper::handleDragMotion(GdkDragContext*, const WebCore::IntPoint&, unsigned int)': ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp:156: error: 'gdk_drag_context_get_actions' was not declared in this scope ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp: In member function 'WTF::PassOwnPtr<WebCore::DragData> WebCore::GtkDragAndDropHelper::handleDragDataReceived(GdkDragContext*, GtkSelectionData*, guint)': ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp:179: error: 'gdk_drag_context_get_actions' was not declared in this scope ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp: In member function 'WTF::PassOwnPtr<WebCore::DragData> WebCore::GtkDragAndDropHelper::handleDragDrop(GdkDragContext*, const WebCore::IntPoint&)': ../../Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp:193: error: 'gdk_drag_context_get_actions' was not declared in this scope make[1]: *** [Source/WebCore/platform/gtk/libWebCoreGtk_la-GtkDragAndDropHelper.lo] Error 1 478324 1 109786 remi.duraffort 2011-10-05 07:12:46 -0700 Created attachment 109786 Fix compilation with Gtk-2.20.1 Fix the compilation by adding one missing header that does the right defines. 478423 2 109786 alex 2011-10-05 09:26:09 -0700 Comment on attachment 109786 Fix compilation with Gtk-2.20.1 Looks good to me. Your name apparently is not using UTF-8? Build fix patches do not need to be reviewed but now that you have written it and you are waiting for review, I think it is better if you add the Reviewed by. 478485 3 109786 webkit.review.bot 2011-10-05 10:38:07 -0700 Comment on attachment 109786 Fix compilation with Gtk-2.20.1 Clearing flags on attachment: 109786 Committed r96720: <http://trac.webkit.org/changeset/96720> 478486 4 webkit.review.bot 2011-10-05 10:38:11 -0700 All reviewed patches have been landed. Closing bug. 109786 2011-10-05 07:12:46 -0700 2011-10-05 10:38:07 -0700 Fix compilation with Gtk-2.20.1 0001-Gtk-fix-compilation.patch text/plain 1022 remi.duraffort ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyODliYzQ5Li5kYzc3ZjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTAtMDUgIFLDqW1pIER1cmFmZm9ydCAgPHJlbWkuZHVyYWZmb3J0QHN0LmNvbT4K KworICAgICAgICBbR1RLXSBGaXggY29tcGlsYXRpb24gd2l0aCBndGsgdjIuMjAuMQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MTgKKworICAgICAg ICBVbnJldmlld2VkIGJ1aWxkIGZpeAorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0a0RyYWdB bmREcm9wSGVscGVyLmNwcDoKKwogMjAxMS0xMC0wNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgQ1NTIG1vZGVsIGNs YXNzZXMgdG8gdGhlIGNvbXBpbGF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0d0a0RyYWdBbmREcm9wSGVscGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9HdGtEcmFnQW5kRHJvcEhlbHBlci5jcHAKaW5kZXggMGIyNmI2Yy4uNzYzZDEyMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a0RyYWdBbmREcm9wSGVs cGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrRHJhZ0FuZERyb3BI ZWxwZXIuY3BwCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSAiQ2xpcGJvYXJkVXRpbGl0aWVz R3RrLmgiCiAjaW5jbHVkZSAiRHJhZ0RhdGEuaCIKICNpbmNsdWRlICJHdGtVdGlsaXRpZXMuaCIK KyNpbmNsdWRlICJHdGtWZXJzaW9uaW5nLmgiCiAjaW5jbHVkZSAiUGFzdGVib2FyZEhlbHBlci5o IgogI2luY2x1ZGUgPGd0ay9ndGsuaD4KICNpbmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgo=