69413 2011-10-05 05:06:22 -0700 REGRESSION(r96347): Build is broken with MSVC compiler if !PLATFORM(WINDOWS) 2011-10-06 04:56:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All Windows XP RESOLVED FIXED P1 Critical --- 69058 1 ossy ossy barraclough ossy webkit.review.bot yuqiang.xian zarvai oldest_to_newest 478280 0 ossy 2011-10-05 05:06:22 -0700 http://trac.webkit.org/changeset/96347/trunk/Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h broke QtWebKit build on Windows with MSVC2008 Express with the following build error: MacroAssemblerCodeRef.h(112) : error C2059: syntax error : 'function-style cast' ... 478290 1 ossy 2011-10-05 05:32:57 -0700 I got it, defining STDCALL is incorrenct if !PLATFORM(WINDOWS) && COMPILER(MSVC). Fix is coming soon. 478301 2 109782 ossy 2011-10-05 06:30:03 -0700 Created attachment 109782 Patch 478303 3 ossy 2011-10-05 06:32:17 -0700 (In reply to comment #2) > Created an attachment (id=109782) [details] > Patch The root of the problem was that PLATFORM(WINDOWS) == Apple Windows port, but if you build eg QtWebKit on Windows with MSVC, PLATFORM(WINDOWS) == false, OS(WIN) == true, COMPILER(MSVC) == true. 478317 4 109782 gyuyoung.kim 2011-10-05 06:58:43 -0700 Comment on attachment 109782 Patch Attachment 109782 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9954397 478319 5 109782 ossy 2011-10-05 07:01:21 -0700 Comment on attachment 109782 Patch ooops 478343 6 109790 ossy 2011-10-05 07:35:55 -0700 Created attachment 109790 Patch 479070 7 109790 webkit.review.bot 2011-10-06 04:56:51 -0700 Comment on attachment 109790 Patch Clearing flags on attachment: 109790 Committed r96802: <http://trac.webkit.org/changeset/96802> 479071 8 webkit.review.bot 2011-10-06 04:56:55 -0700 All reviewed patches have been landed. Closing bug. 109782 2011-10-05 06:30:03 -0700 2011-10-05 07:01:21 -0700 Patch bug-69413-20111005133001.patch text/plain 1381 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVk OTQzNDMxMTk5NWJiN2ZiOTVkMTFmYzU3ZDBhNWY2NTIwM2VkYmEuLmU3MWNlNjFiNzYxOTczYjZi MGI2ZTViOTQzNzMyOWI0YWFmODdhNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTEwLTA1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTYzNDcpOiBCdWlsZCBpcyBicm9rZW4gd2l0aCBN U1ZDIGNvbXBpbGVyIGlmICFQTEFURk9STShXSU5ET1dTKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVS ZWYuaDogRGVmaW5lIFNURENBTEwgZm9yIE1TVkMgaW4gYSBwcm9wZXIgd2F5LgorCiAyMDExLTEw LTA1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgV2luQ0UgYnVpbGQgZml4IGZvciByOTY1OTUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVSZWYuaAppbmRleCAz YTliZGExYjIzZjE4OWJiMWExNzcxNmUxNzA1YjVkMDBiOTcxYzE2Li42ZjE4MmMzNzQxMWY3MDk2 YTE0MTFkZTdmOTY0MDMwZDQ5ZjA5YjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgKQEAgLTEwNyw5ICsxMDcs MTQgQEAgcHVibGljOgogICAgIH0KIAogI2lmIENBTExJTkdfQ09OVkVOVElPTl9JU19DREVDTAor CiAjaWZuZGVmIFNURENBTEwKKyNpZiBDT01QSUxFUihNU1ZDKQorI2RlZmluZSBTVERDQUxMIF9f c3RkY2FsbAorI2Vsc2UKICNkZWZpbmUgU1REQ0FMTCBfX2F0dHJpYnV0ZV9fICgoc3RkY2FsbCkp CiAjZW5kaWYKKwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIHJldHVyblR5cGU+CiAgICAgRnVuY3Rp b25QdHIocmV0dXJuVHlwZSAoU1REQ0FMTCAqdmFsdWUpKCkpCiAgICAgICAgIDogbV92YWx1ZSgo dm9pZCopdmFsdWUpCg== 109790 2011-10-05 07:35:55 -0700 2011-10-06 04:56:51 -0700 Patch bug-69413-20111005143553.patch text/plain 1417 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogOTY3MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVk OTQzNDMxMTk5NWJiN2ZiOTVkMTFmYzU3ZDBhNWY2NTIwM2VkYmEuLmU3MWNlNjFiNzYxOTczYjZi MGI2ZTViOTQzNzMyOWI0YWFmODdhNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTEwLTA1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTYzNDcpOiBCdWlsZCBpcyBicm9rZW4gd2l0aCBN U1ZDIGNvbXBpbGVyIGlmICFQTEFURk9STShXSU5ET1dTKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVS ZWYuaDogRGVmaW5lIFNURENBTEwgZm9yIE1TVkMgaW4gYSBwcm9wZXIgd2F5LgorCiAyMDExLTEw LTA1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgV2luQ0UgYnVpbGQgZml4IGZvciByOTY1OTUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVSZWYuaAppbmRleCAz YTliZGExYjIzZjE4OWJiMWExNzcxNmUxNzA1YjVkMDBiOTcxYzE2Li5hNGJiMTA5ZGYyYWJlYmM2 N2JiNmEyOWNjOTMzOGE5Nzg1MWFiNDc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgKQEAgLTEwOCw4ICsxMDgs MTMgQEAgcHVibGljOgogCiAjaWYgQ0FMTElOR19DT05WRU5USU9OX0lTX0NERUNMCiAjaWZuZGVm IFNURENBTEwKKyNpZiBDT01QSUxFUihNU1ZDKQorI2RlZmluZSBTVERDQUxMIF9fc3RkY2FsbAor I2Vsc2UKICNkZWZpbmUgU1REQ0FMTCBfX2F0dHJpYnV0ZV9fICgoc3RkY2FsbCkpCi0jZW5kaWYK KyNlbmRpZiAvLyBDT01QSUxFUihNU1ZDKQorI2VuZGlmIC8vIFNURENBTEwKKwogICAgIHRlbXBs YXRlPHR5cGVuYW1lIHJldHVyblR5cGU+CiAgICAgRnVuY3Rpb25QdHIocmV0dXJuVHlwZSAoU1RE Q0FMTCAqdmFsdWUpKCkpCiAgICAgICAgIDogbV92YWx1ZSgodm9pZCopdmFsdWUpCg==