69402 2011-10-05 00:04:54 -0700 Input styles are unexpectedly shared regardless of required status difference. 2011-10-05 02:24:44 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tkent tkent darin dbates eric sam webkit.review.bot oldest_to_newest 478188 0 tkent 2011-10-05 00:04:54 -0700 http://code.google.com/p/chromium/issues/detail?id=98008 478189 1 109751 tkent 2011-10-05 00:06:39 -0700 Created attachment 109751 Patch 478208 2 109751 dbates 2011-10-05 00:59:25 -0700 Comment on attachment 109751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109751&action=review This patch looks straightforward. I have some minor nits. > LayoutTests/fast/css/pseudo-required-shared-expected.html:4 > +<input value=required style="color:red;"> > +<input value=optional> Nit: For consistency with the style attribute, I suggest surrounding all attribute values with quotes: <input value="required" style="color:red"> <input value="optional"> > LayoutTests/fast/css/pseudo-required-shared.html:2 > +<!DOCTYPE html> > + This isn't a valid HTML5 document as per section 8.1.2.4 <http://dev.w3.org/html5/spec/Overview.html#optional-tags> which states that "An html element's start tag may be omitted if the first thing inside the html element is not a comment.". That is, we need an <html> tag here since the first thing is a comment. For you consideration, you may want to make the markup closer resemble the form of a basic HTML document as described in section 1.8 of the HTML5 spec. <http://dev.w3.org/html5/spec/Overview.html#a-quick-introduction-to-html>. > LayoutTests/fast/css/pseudo-required-shared.html:7 > + Nit: Please remove this empty line as it doesn't seem to improve the readability of this markup given that we have exactly one CSS block. > LayoutTests/fast/css/pseudo-required-shared.html:11 > +<input required value=required> > +<input value=optional> Nit: I suggest surrounding attribute values in quotes so as to demarcate them from the rest of the markup. 478215 3 tkent 2011-10-05 01:12:14 -0700 Daniel, thank you! I'll follow your comments and land the patch. 478219 4 109759 tkent 2011-10-05 01:21:03 -0700 Created attachment 109759 Patch for landing 478240 5 109759 webkit.review.bot 2011-10-05 02:24:40 -0700 Comment on attachment 109759 Patch for landing Clearing flags on attachment: 109759 Committed r96686: <http://trac.webkit.org/changeset/96686> 478241 6 webkit.review.bot 2011-10-05 02:24:44 -0700 All reviewed patches have been landed. Closing bug. 109751 2011-10-05 00:06:39 -0700 2011-10-05 01:20:57 -0700 Patch bug-69402-20111005160638.patch text/plain 3256 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2NzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNWNmOTU2M2VmYjc3ZmJiNmIyY2U2 M2IxYmRmYjAwMDU3NzgxOGFmLi42MWM3Y2QyMjk4ZDc5YWZiZmFkOGE5MGQ4YjNjYjdmYTVmMmYy MTNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDUgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIElucHV0IHN0eWxlcyBhcmUgdW5leHBlY3RlZGx5 IHNoYXJlZCByZWdhcmRsZXNzIG9mIHJlcXVpcmVkIHN0YXR1cyBkaWZmZXJlbmNlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL3BzZXVk by1yZXF1aXJlZC1zaGFyZWQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9j c3MvcHNldWRvLXJlcXVpcmVkLXNoYXJlZC5odG1sOiBBZGRlZC4KKwogMjAxMS0xMC0wNCAgU2Fk cnVsIEhhYmliIENob3dkaHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4 IEZyYW1lVmlldzo6c2Nyb2xsRWxlbWVudFRvUmVjdCB0byB0YWtlIGFscmVhZHkgc2Nyb2xsZWQg YW1vdW50IGludG8gY29uc2lkZXJhdGlvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL3BzZXVkby1yZXF1aXJlZC1zaGFyZWQtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL3BzZXVkby1yZXF1aXJlZC1zaGFyZWQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5j NzZhYTVhMWExNGM4MWU3N2RlYzI1ZTkxODBkYmYwNjgzYzRhNDg4Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcHNldWRvLXJlcXVpcmVkLXNoYXJlZC1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8Ym9keT4KKzxpbnB1dCB2YWx1 ZT1yZXF1aXJlZCBzdHlsZT0iY29sb3I6cmVkOyI+Cis8aW5wdXQgdmFsdWU9b3B0aW9uYWw+Cis8 L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8tcmVxdWlyZWQt c2hhcmVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wc2V1ZG8tcmVxdWlyZWQtc2hhcmVk Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uZDgxYzliZjJjNWI1NzMyY2ZkZmYyOWU2MzE2YzgyZmU5Y2U2Nzkz MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby1yZXF1aXJl ZC1zaGFyZWQuaHRtbApAQCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgaHRtbD4KKzwhLS0gVGhl cmUgd2FzIGEgYnVnIHRoYXQgc3R5bGVzIGFyZSB1bmV4cGVjdGVkbHkgc2hhcmVkIHJlZ2FyZGxl c3Mgb2YgcmVxdWlyZWQgc3RhdHVzIGRpZmZlcmVuY2UuIC0tPgorPHN0eWxlPgorOnJlcXVpcmVk OnZhbGlkIHsKKyAgICBjb2xvcjogcmVkOworfQorCis8L3N0eWxlPgorPGJvZHk+Cis8aW5wdXQg cmVxdWlyZWQgdmFsdWU9cmVxdWlyZWQ+Cis8aW5wdXQgdmFsdWU9b3B0aW9uYWw+Cis8L2JvZHk+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggZjQ4Y2UwYzRkMmM5NjBjMjJiZDIxMjZkNjZiZWNhZDkxZjc1MmQ4Ny4u NTQ5NGY4OTNkNmY2ODI0NDlhMTNjMjY4NDA4ODJlMzY2MDg3NGIwMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDExLTEwLTA1ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KKworICAgICAgICBJbnB1dCBzdHlsZXMgYXJlIHVuZXhwZWN0ZWRseSBzaGFyZWQgcmVnYXJk bGVzcyBvZiByZXF1aXJlZCBzdGF0dXMgZGlmZmVyZW5jZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvY3NzL3BzZXVkby1yZXF1aXJl ZC1zaGFyZWQuaHRtbAorCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhDb250cm9s KTogQ2hlY2sgdGhlIGRpZmZlcmVuY2Ugb2YgcmVxdWlyZWQoKS4KKwogMjAxMS0xMC0wNCAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdGF0 aWMgQ2xhc3NJbmZvIHN0cnVjdHMgdG8gY2xhc3NlcyB0aGF0IG92ZXJyaWRlIEpTQ2VsbDo6Z2V0 Q2FsbERhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAppbmRleCBhYjJh MDBjODAwYTI2Y2MyYzFhM2Y2NTk3NGMyNzY3MmE1ZmQyOTc0Li5jYWNiMjM0MzE5NGYxN2FhMmE3 Zjk3MWUyMGM5Njk1OTk4M2FhNWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT U3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0 b3IuY3BwCkBAIC03OTYsNiArNzk2LDkgQEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpjYW5TaGFy ZVN0eWxlV2l0aENvbnRyb2woU3R5bGVkRWxlbWVudCogZWxlbWVudCkgY29uc3QKICAgICAKICAg ICBpZiAoZWxlbWVudC0+aXNEZWZhdWx0QnV0dG9uRm9yRm9ybSgpICE9IG1fZWxlbWVudC0+aXNE ZWZhdWx0QnV0dG9uRm9yRm9ybSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAo dGhpc0lucHV0RWxlbWVudC0+cmVxdWlyZWQoKSAhPSBvdGhlcklucHV0RWxlbWVudC0+cmVxdWly ZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAogICAgIGlmICghbV9lbGVtZW50LT5k b2N1bWVudCgpLT5jb250YWluc1ZhbGlkaXR5U3R5bGVSdWxlcygpKQogICAgICAgICByZXR1cm4g ZmFsc2U7Cg== 109759 2011-10-05 01:21:03 -0700 2011-10-05 02:24:40 -0700 Patch for landing bug-69402-20111005172101.patch text/plain 3557 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTY2NzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNWNmOTU2M2VmYjc3ZmJiNmIyY2U2 M2IxYmRmYjAwMDU3NzgxOGFmLi5mZTg0YzgwNDdkYTg4MWE3NmQwYTE2MmU0ZDMxZGJmODNjOTE3 NDVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMDUgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIElucHV0IHN0eWxlcyBhcmUgdW5leHBlY3RlZGx5 IHNoYXJlZCByZWdhcmRsZXNzIG9mIHJlcXVpcmVkIHN0YXR1cyBkaWZmZXJlbmNlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njk0MDIKKworICAgICAg ICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9wc2V1ZG8t cmVxdWlyZWQtc2hhcmVkLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3Nz L3BzZXVkby1yZXF1aXJlZC1zaGFyZWQuaHRtbDogQWRkZWQuCisKIDIwMTEtMTAtMDQgIFNhZHJ1 bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRydWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBG cmFtZVZpZXc6OnNjcm9sbEVsZW1lbnRUb1JlY3QgdG8gdGFrZSBhbHJlYWR5IHNjcm9sbGVkIGFt b3VudCBpbnRvIGNvbnNpZGVyYXRpb24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9wc2V1ZG8tcmVxdWlyZWQtc2hhcmVkLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9wc2V1ZG8tcmVxdWlyZWQtc2hhcmVkLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDFi MDU0N2UyNzg3MmI5NjM3YjQ1Mzg2ODU2OTA5ZmMzYTExOWI4ZAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY3NzL3BzZXVkby1yZXF1aXJlZC1zaGFyZWQtZXhwZWN0ZWQuaHRt bApAQCAtMCwwICsxLDcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxpbnB1 dCB2YWx1ZT0icmVxdWlyZWQiIHN0eWxlPSJjb2xvcjpyZWQ7Ij4KKzxpbnB1dCB2YWx1ZT0ib3B0 aW9uYWwiPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j c3MvcHNldWRvLXJlcXVpcmVkLXNoYXJlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcHNl dWRvLXJlcXVpcmVkLXNoYXJlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVhYTBmOWRhYjgyYzc5YjJiOTdm Zjk2YTIxZTlmMGVlNDhkYWJjNmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9wc2V1ZG8tcmVxdWlyZWQtc2hhcmVkLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzwhLS0gVGhlcmUgd2FzIGEgYnVnIHRoYXQgc3R5bGVzIGFyZSB1 bmV4cGVjdGVkbHkgc2hhcmVkIHJlZ2FyZGxlc3Mgb2YgcmVxdWlyZWQgc3RhdHVzIGRpZmZlcmVu Y2UuIC0tPgorPGhlYWQ+Cis8c3R5bGU+Cis6cmVxdWlyZWQ6dmFsaWQgeworICAgIGNvbG9yOiBy ZWQ7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8aW5wdXQgcmVxdWlyZWQgdmFsdWU9 InJlcXVpcmVkIj4KKzxpbnB1dCB2YWx1ZT0ib3B0aW9uYWwiPgorPC9ib2R5PgorPC9odG1sPgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IGY0OGNlMGM0ZDJjOTYwYzIyYmQyMTI2ZDY2YmVjYWQ5MWY3NTJkODcuLjEx NDg5ZWFkY2JjZDU2Y2NkYWQzMzYzZWU3OWM2N2U5MTVlZjU3MDUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMS0xMC0wNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgSW5wdXQgc3R5bGVzIGFyZSB1bmV4cGVjdGVkbHkgc2hhcmVkIHJlZ2FyZGxl c3Mgb2YgcmVxdWlyZWQgc3RhdHVzIGRpZmZlcmVuY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02OTQwMgorCisgICAgICAgIFJldmlld2VkIGJ5IERh bmllbCBCYXRlcy4KKworICAgICAgICBUZXN0czogZmFzdC9jc3MvcHNldWRvLXJlcXVpcmVkLXNo YXJlZC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpjYW5TaGFyZVN0eWxlV2l0aENvbnRyb2wpOiBD aGVjayB0aGUgZGlmZmVyZW5jZSBvZiByZXF1aXJlZCgpLgorCiAyMDExLTEwLTA0ICBNYXJrIEhh aG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN0YXRpYyBD bGFzc0luZm8gc3RydWN0cyB0byBjbGFzc2VzIHRoYXQgb3ZlcnJpZGUgSlNDZWxsOjpnZXRDYWxs RGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IGFiMmEwMGM4 MDBhMjZjYzJjMWEzZjY1OTc0YzI3NjcyYTVmZDI5NzQuLjdmMTJiN2JiY2Y0YjZmNzE1MmU4YTZm M2Q5Y2YzMDA3YjUzZTRmMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5j cHAKQEAgLTc5MCwxMyArNzkwLDE1IEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVT dHlsZVdpdGhDb250cm9sKFN0eWxlZEVsZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICBpZiAodGhpc0lucHV0RWxlbWVudC0+aXNJbmRldGVybWluYXRlKCkg IT0gb3RoZXJJbnB1dEVsZW1lbnQtPmlzSW5kZXRlcm1pbmF0ZSgpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgaWYgKHRoaXNJbnB1dEVsZW1lbnQtPnJlcXVpcmVkKCkgIT0gb3RoZXJJbnB1 dEVsZW1lbnQtPnJlcXVpcmVkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICBp ZiAoZWxlbWVudC0+aXNFbmFibGVkRm9ybUNvbnRyb2woKSAhPSBtX2VsZW1lbnQtPmlzRW5hYmxl ZEZvcm1Db250cm9sKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICBpZiAoZWxl bWVudC0+aXNEZWZhdWx0QnV0dG9uRm9yRm9ybSgpICE9IG1fZWxlbWVudC0+aXNEZWZhdWx0QnV0 dG9uRm9yRm9ybSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCisKICAgICBpZiAoIW1f ZWxlbWVudC0+ZG9jdW1lbnQoKS0+Y29udGFpbnNWYWxpZGl0eVN0eWxlUnVsZXMoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIAo=